[v8-dev] Re: Unify runtime-style IC functions with Runtime intrinsics (issue 1248303002 by da...@chromium.org)

2015-07-23 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 7 (id:??) landed as https://crrev.com/bc8041dc2b4c8431c5c2476496acd3b7b8b3f61e Cr-Commit-Position: refs/heads/master@{#29811} https://codereview.chromium.org/1248303002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Unify runtime-style IC functions with Runtime intrinsics (issue 1248303002 by da...@chromium.org)

2015-07-23 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #7 (id:120001) https://codereview.chromium.org/1248303002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: Unify runtime-style IC functions with Runtime intrinsics (issue 1248303002 by da...@chromium.org)

2015-07-23 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1248303002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1248303002/120001 https://codereview.chromium.org/1248303002/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: Unify runtime-style IC functions with Runtime intrinsics (issue 1248303002 by da...@chromium.org)

2015-07-23 Thread yangguo
LGTM with a nit. https://codereview.chromium.org/1248303002/diff/80001/src/arm64/code-stubs-arm64.cc File src/arm64/code-stubs-arm64.cc (right): https://codereview.chromium.org/1248303002/diff/80001/src/arm64/code-stubs-arm64.cc#newcode2059 src/arm64/code-stubs-arm64.cc:2059: __ TailCallExterna

[v8-dev] Re: Unify runtime-style IC functions with Runtime intrinsics (issue 1248303002 by da...@chromium.org)

2015-07-23 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1248303002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1248303002/80001 https://codereview.chromium.org/1248303002/ -- -- v8-dev mailing list v8-dev@googlegroups.com ht

[v8-dev] Re: Unify runtime-style IC functions with Runtime intrinsics (issue 1248303002 by da...@chromium.org)

2015-07-23 Thread danno
Feedback addressed. Landing. https://codereview.chromium.org/1248303002/diff/60001/src/runtime/runtime-debug.cc File src/runtime/runtime-debug.cc (right): https://codereview.chromium.org/1248303002/diff/60001/src/runtime/runtime-debug.cc#newcode19 src/runtime/runtime-debug.cc:19: RUNTIME_FUNCTI

[v8-dev] Re: Unify runtime-style IC functions with Runtime intrinsics (issue 1248303002 by da...@chromium.org)

2015-07-23 Thread mstarzinger
LGTM, just nits. I like it! https://codereview.chromium.org/1248303002/diff/60001/src/runtime/runtime-debug.cc File src/runtime/runtime-debug.cc (right): https://codereview.chromium.org/1248303002/diff/60001/src/runtime/runtime-debug.cc#newcode19 src/runtime/runtime-debug.cc:19: RUNTIME_FUNCTIO