[v8-dev] Re: Use [[DefineOwnProperty]] to put 'constructor' field on the protoype object. (issue6531037)

2011-02-18 Thread antonm
http://codereview.chromium.org/6531037/diff/1/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/6531037/diff/1/src/runtime.cc#newcode6930 src/runtime.cc:6930: RETURN_IF_EMPTY_HANDLE(result); On 2011/02/17 20:55:41, Mads Ager wrote: Shouldn't we be able to create a test

[v8-dev] Re: Use [[DefineOwnProperty]] to put 'constructor' field on the protoype object. (issue6531037)

2011-02-17 Thread ager
LGTM! http://codereview.chromium.org/6531037/diff/1/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/6531037/diff/1/src/runtime.cc#newcode6930 src/runtime.cc:6930: RETURN_IF_EMPTY_HANDLE(result); Shouldn't we be able to create a test case for this. The change looks goo