Committed patchset #22 (id:41)
https://codereview.chromium.org/750813003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/750813003/41
https://codereview.chromium.org/750813003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscri
Try jobs failed on following builders:
v8_linux_chromium_gn_rel on tryserver.v8
(http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/builds/201)
https://codereview.chromium.org/750813003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/750813003/380001
https://codereview.chromium.org/750813003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscri
Try jobs failed on following builders:
v8_linux_chromium_gn_rel on tryserver.v8
(http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/builds/199)
https://codereview.chromium.org/750813003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/750813003/360001
https://codereview.chromium.org/750813003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscri
Try jobs failed on following builders:
v8_linux_chromium_gn_rel on tryserver.v8
(http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/builds/188)
https://codereview.chromium.org/750813003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/750813003/340001
https://codereview.chromium.org/750813003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscri
lgtm.
https://codereview.chromium.org/750813003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/750813003/diff/310001/src/heap/gc-idle-time-handler.cc
File src/heap/gc-idle-time-handler.cc (right):
https://codereview.chromium.org/750813003/diff/310001/src/heap/gc-idle-time-handler.cc#newcode192
src/heap/gc-idle-time-handler.cc:192: GCIdleTimeAction
GCIdleTim
Lgtm with a couple of final comments.
Also - you could link this with crbug.com/417668, which I've just made you
owner
of :).
https://codereview.chromium.org/750813003/diff/310001/src/heap/gc-idle-time-handler.cc
File src/heap/gc-idle-time-handler.cc (right):
https://codereview.chromium.org
https://codereview.chromium.org/750813003/diff/130001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/750813003/diff/130001/include/v8.h#newcode5001
include/v8.h:5001: * done within the time limit.
On 2014/11/25 14:28:06, rmcilroy wrote:
nit - mention that deadline_secon
On 2014/11/25 15:57:24, Hannes Payer wrote:
On 2014/11/25 15:54:52, jochen (slow) wrote:
> i'm worried that somewhere in chrome we actually pass in a float value
that
> currently gets automatically converted to an int but then would be
interpreted
> as a deadline?
I decided to stick to raw
On 2014/11/25 15:54:52, jochen (slow) wrote:
i'm worried that somewhere in chrome we actually pass in a float value
that
currently gets automatically converted to an int but then would be
interpreted
as a deadline?
I decided to stick to raw values. TimeTicks would be nice but there are
st
i'm worried that somewhere in chrome we actually pass in a float value that
currently gets automatically converted to an int but then would be
interpreted
as a deadline?
https://codereview.chromium.org/750813003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group
https://codereview.chromium.org/750813003/diff/130001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/750813003/diff/130001/include/v8.h#newcode5001
include/v8.h:5001: * done within the time limit.
nit - mention that deadline_seconds is compared with
MonotonicallyIncreasi
https://codereview.chromium.org/750813003/diff/120001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/750813003/diff/120001/src/heap/heap.cc#newcode4429
src/heap/heap.cc:4429: deadline -
V8::GetCurrentPlatform()->MonotonicallyIncreasingTime();
On 2014/11/25 10:35:
https://codereview.chromium.org/750813003/diff/120001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/750813003/diff/120001/src/heap/heap.cc#newcode4429
src/heap/heap.cc:4429: deadline -
V8::GetCurrentPlatform()->MonotonicallyIncreasingTime();
Both deadline and Mo
18 matches
Mail list logo
