[v8-dev] Re: When flag --nouse-osr is set, don't allow osr from hidden runtime calls. (issue 310773003)

2014-06-03 Thread mvstanton
Committed patchset #2 manually as r21622 (presubmit successful). https://codereview.chromium.org/310773003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To u

[v8-dev] Re: When flag --nouse-osr is set, don't allow osr from hidden runtime calls. (issue 310773003)

2014-06-03 Thread mvstanton
Thanks, I simplified the test and added the runtime assert. Much appreciated! --Michael https://codereview.chromium.org/310773003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Gro

[v8-dev] Re: When flag --nouse-osr is set, don't allow osr from hidden runtime calls. (issue 310773003)

2014-06-03 Thread yangguo
LGTM, but the test case can be a *lot* simpler. Something like Flags: --nouse-osr function f() { %OptimizeFunctionOnNextCall(f, "osr"); for (var i = 0; i < 1000; i++); } f(); https://codereview.chromium.org/310773003/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chr