[v8-dev] Re: X64: Templating Smi-macros to use both Label and NearLabel. (issue3381005)

2010-09-16 Thread lrn
The functions are moved to the .h file because they are templates. http://codereview.chromium.org/3381005/diff/1/5 File src/x64/macro-assembler-x64.h (right): http://codereview.chromium.org/3381005/diff/1/5#newcode1017 src/x64/macro-assembler-x64.h:1017: ASSERT_EQ(0, kSmiTag); Nor is the functi

[v8-dev] Re: X64: Templating Smi-macros to use both Label and NearLabel. (issue3381005)

2010-09-15 Thread ricow
LGTM, but why are all the method implementations moved from macro-assembler-x64.cc to the header file? http://codereview.chromium.org/3381005/diff/1/5 File src/x64/macro-assembler-x64.h (right): http://codereview.chromium.org/3381005/diff/1/5#newcode1017 src/x64/macro-assembler-x64.h:1017: ASSE