LGTM, but why are all the method implementations moved from macro-assembler-x64.cc to the header file?
http://codereview.chromium.org/3381005/diff/1/5 File src/x64/macro-assembler-x64.h (right): http://codereview.chromium.org/3381005/diff/1/5#newcode1017 src/x64/macro-assembler-x64.h:1017: ASSERT_EQ(0, kSmiTag); on_overflow label not used http://codereview.chromium.org/3381005/show -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev