Committed patchset #4 (id:60001)
https://codereview.chromium.org/978783002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and s
Patchset 4 (id:??) landed as
https://crrev.com/6e189f5ae6af20eb9d27f954bae8c5532749fb1b
Cr-Commit-Position: refs/heads/master@{#27004}
https://codereview.chromium.org/978783002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/978783002/60001
https://codereview.chromium.org/978783002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
If this were Chromium code, I'd be inclined to allow this use (although if
it
was actually chromium code I'd tell you to use the macro, but that's
obviously
not practical to do for this header).
https://codereview.chromium.org/978783002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http
(In case you haven't seen it, the Chromium C++11 guideline is at
http://chromium-cpp.appspot.com)
On Wed, Mar 4, 2015 at 11:40 AM, wrote:
> thanks for looking at this. we try to keep our code as close to the style
> guide
> as possible. i'll discuss this change further with the team
>
>
> http
thanks for looking at this. we try to keep our code as close to the style
guide
as possible. i'll discuss this change further with the team
https://codereview.chromium.org/978783002/diff/40001/build/standalone.gypi
File build/standalone.gypi (right):
https://codereview.chromium.org/97878300
I believe everything in v8.h will work in Chromium, though (modulo the
self-assignment bug)
https://codereview.chromium.org/978783002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google G
https://codereview.chromium.org/978783002/diff/40001/build/standalone.gypi
File build/standalone.gypi (right):
https://codereview.chromium.org/978783002/diff/40001/build/standalone.gypi#newcode527
build/standalone.gypi:527: 'CLANG_CXX_LIBRARY': 'libc++', #
-stdlib=libc++
On 2015/03/04 18:52:37,
The style guide only applies to Chromium proper, not subrepos, but some of
the
toolchain constraints that apply to Chromium also apply to V8 (or at least
the
parts of V8 that need to build in chromium).
+thakis for OS X
https://codereview.chromium.org/978783002/diff/40001/build/standalone.g
Reviewers: Sven Panne, jamesr,
Message:
it turns out this is anyway disallowed by the styleguide without permission
of a
styleguide owner, so I added one.
jamesr@ this is a feature we would really like for a single class:
UniquePersistent, which is effectively a unique_ptr a lot of internal s
Try jobs failed on following builders:
v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/3578)
https://codereview.chromium.org/978783002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You r
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/978783002/40001
https://codereview.chromium.org/978783002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
12 matches
Mail list logo
