Re: [v8-users] bazel build v8 version 11.0.226.16 failed with error: 'src/heap/base/stack.h' file

2023-02-23 Thread 'Clemens Backes' via v8-users
That include indeed seems broken. It should use double quotes instead of angled brackets. This file was added in https://crrev.com/c/3989143 (v10.9) and removed in https://crrev.com/c/4171639 (v11.1), that's why tip of tree works for you. As the problem was already introduced in v10.9, I am not sur

Re: [v8-users] Issues with preserve_most?

2023-02-21 Thread 'Clemens Backes' via v8-users
On Wed, Feb 8, 2023 at 6:05 PM ClearScript Developers < clearscript...@gmail.com> wrote: > Hi Clemens, > > >Which toolchain do you use where you see crashes? > > Our hack to retain compatibility with old distros is probably bogus and > unsupported, so if you know of a better way, please share it :

Re: [v8-users] Issues with preserve_most?

2023-02-08 Thread &#x27;Clemens Backes&#x27; via v8-users
Thanks for reaching out! Indeed, preserve_most support turned out to be a bit incomplete, so we tried to restrict it to the most important platforms and toolchains used for Chromium. It's restricted to clang anyway, and I didn't find any relevant fixes since the introduction in 2016. Which toolchai

Re: [v8-users] Unable to compile wasm bytes in a isolate associated with v8::SnapshotCreator

2022-10-27 Thread &#x27;Clemens Backes&#x27; via v8-users
Wasm support in snapshots was never added (see issue 8176 ). Supporting it would be a non-trivial amount of work, as we have to make sure to serialize the compiled Wasm code (living outside the JS heap) on snapshot creation, and properly reconstruct all involved functions

Re: [v8-users] v8::Platform::PostJob and v8::platform::NewDefaultJobHandle

2020-09-23 Thread &#x27;Clemens Backes&#x27; via v8-users
That is supposed to work, yes. All the DefaultJobHandle does is posting tasks to the platform. On Wed, Sep 23, 2020 at 4:37 PM ClearScript Developers < clearscript...@gmail.com> wrote: > Greetings! > > We're updating our embedder for V8 8.6, and apparently our v8::Platform > implementation now ha

Re: [v8-users] Re: Inspecting Wasm Memory in ChromeDevTools

2020-09-22 Thread &#x27;Clemens Backes&#x27; via v8-users
Hi Immanuel, the problem is probably related to your manipulation of the raw memory pointer . For debugging, we are not using this pointer, but the WasmMemoryObject

Re: [v8-users] Re: Compile Error with `use_custom_libcxx=false`

2020-06-17 Thread &#x27;Clemens Backes&#x27; via v8-users
On Wed, Jun 17, 2020 at 10:47 AM Immanuel Haffner < haffner.imman...@gmail.com> wrote: > > Out of curiosity: wouldn't it make sense to add a CI job for > `use_custom_libcxx=false`? I guess we wouldn't need one bot for that, but as many as there are combinations of compilers and standard library

Re: [v8-users] Re: Compile Error with `use_custom_libcxx=false`

2020-06-17 Thread &#x27;Clemens Backes&#x27; via v8-users
On Wed, Jun 17, 2020 at 10:41 AM Immanuel Haffner < haffner.imman...@gmail.com> wrote: > Hi Clemens, > > the patch is working. Thanks a lot for the quick response :) When will > this be available upstream? > The patch was merged to ToT about half an hour ago, so it should be available to you now.

Re: [v8-users] Re: Compile Error with `use_custom_libcxx=false`

2020-06-17 Thread &#x27;Clemens Backes&#x27; via v8-users
Thanks for reporting this, Immanuel! I uploaded a fix to include : https://crrev.com/c/2248196 Can you check whether this also fixes the issue in your configuration? Thanks, Clemens On Wed, Jun 17, 2020 at 9:38 AM Immanuel Haffner wrote: > Oh, i forgot to mention the version. I am trying to co

Re: [v8-users] Re: WebAssembly.instantiate didn't call then nor catch in v8 embedded

2020-02-21 Thread &#x27;Clemens Backes&#x27; via v8-users
Also note this other discussion: https://groups.google.com/g/v8-users/c/lRe7WrCkHCE/m/NmMfpDZ-DAAJ On Fri, Feb 21, 2020 at 12:01 PM Darin Dimitrov wrote: > I had the same problem in my Android project and used a workaround. I > replaced the global.WebAssembly object with a Proxy and intercept th