Re: Fresh patch for Solaris

2008-08-11 Thread Poul-Henning Kamp
In message [EMAIL PROTECTED], Theo Schlossnagle writes: http://lethargy.org/~jesus/misc/varnish-solaris-trunk-3071.diff OK, I've picked the obvious stuff out. Various questions about the rest: Doesn't Solaris have fcntl(F_SETLK) as mandated by POSIX ? flock() is not a standardized API, and I

Re: Fresh patch for Solaris

2008-08-11 Thread Theo Schlossnagle
On Aug 11, 2008, at 5:30 AM, Poul-Henning Kamp wrote: In message [EMAIL PROTECTED], Theo Schlossnagle writes: http://lethargy.org/~jesus/misc/varnish-solaris-trunk-3071.diff OK, I've picked the obvious stuff out. Various questions about the rest: Doesn't Solaris have fcntl(F_SETLK)

Re: Fresh patch for Solaris

2008-08-11 Thread Theo Schlossnagle
On Aug 11, 2008, at 5:30 AM, Poul-Henning Kamp wrote: In message [EMAIL PROTECTED], Theo Schlossnagle writes: http://lethargy.org/~jesus/misc/varnish-solaris-trunk-3071.diff OK, I've picked the obvious stuff out. Next pass:

Re: Fresh patch for Solaris

2008-08-11 Thread Poul-Henning Kamp
In message [EMAIL PROTECTED], Theo Schlossnagle writes: Next pass: http://lethargy.org/~jesus/misc/varnish-solaris-trunk-3080.diff You still have the err.h compat stuff, that's not necessary any more, I removed the two uses of err(). Why is the tcp.c patch necessay ? You have not answered

Re: Fresh patch for Solaris

2008-08-11 Thread Poul-Henning Kamp
Sorry for the comment at the end of my prevous email, got your emails in reverse order here :-) Doesn't Solaris have fcntl(F_SETLK) as mandated by POSIX ? Ah, good catch. That wasn't a patch for Solaris. It was for Linux. We've run into some issues with flock being more reliable than

Re: Fresh patch for Solaris

2008-08-11 Thread Theo Schlossnagle
Next pass: http://lethargy.org/~jesus/misc/varnish-solaris-trunk-3080-2.diff On Aug 11, 2008, at 10:47 AM, Poul-Henning Kamp wrote: You still have the err.h compat stuff, that's not necessary any more, I removed the two uses of err(). Didn't catch that. Fixed. Why is the tcp.c patch