Re: commit IDs in changelog messsages (was: Introductory mail)

2008-11-13 Thread Guido Günther
On Wed, Nov 12, 2008 at 01:20:10PM +0100, Stefano Zacchiroli wrote: > Following the (good) path of "Closes", it should probably be something > like "[Commit: fed3f3d]". Also, can't it be put inside the same > parentheses than "Closes", as in "(Closes: #7005180, #7005181; Commit: > fed3f3d)". If we

Re: commit IDs in changelog messsages (was: Introductory mail)

2008-11-13 Thread Guido Günther
On Wed, Nov 12, 2008 at 11:09:45AM -0500, James Westby wrote: > On Wed, 2008-11-12 at 08:39 +0100, martin f krafft wrote: > > also sprach Guido Günther <[EMAIL PROTECTED]> [2008.11.08.1419 +0100]: > > > Does this look like a worthwhile extension to the current changelog > > > format? For me it make

Re: commit IDs in changelog messsages (was: Introductory mail)

2008-11-13 Thread martin f krafft
also sprach Guido Günther <[EMAIL PROTECTED]> [2008.11.13.0903 +0100]: > If we really want a tag in front of the commit identifier we should > specify the VCS: [Git:fed3f3d], [Svn:r1234], [Hg:fed3f3d] this would > help in the case where a package switches VCSs. ... except we wouldn't have the old

Re: commit IDs in changelog messsages (was: Introductory mail)

2008-11-13 Thread Stefano Zacchiroli
On Thu, Nov 13, 2008 at 09:03:32AM +0100, Guido Günther wrote: > If we really want a tag in front of the commit identifier we should > specify the VCS: [Git:fed3f3d], [Svn:r1234], [Hg:fed3f3d] this would > help in the case where a package switches VCSs. > > > Finally, I missed if the aim is findi

Re: commit IDs in changelog messsages (was: Introductory mail)

2008-11-13 Thread Guido Günther
On Thu, Nov 13, 2008 at 10:36:05AM +0100, Stefano Zacchiroli wrote: > On Thu, Nov 13, 2008 at 09:03:32AM +0100, Guido Günther wrote: > > If we really want a tag in front of the commit identifier we should > > specify the VCS: [Git:fed3f3d], [Svn:r1234], [Hg:fed3f3d] this would > > help in the case

Re: commit IDs in changelog messsages (was: Introductory mail)

2008-11-13 Thread Stefano Zacchiroli
On Thu, Nov 13, 2008 at 10:40:15AM +0100, Guido Günther wrote: > I don't have a need for it either - just iff we want to have a > qualifier inside the braces we should at least use the type of VCS > not only "Commit:". OK, but note that there are drawbacks. For example if we go for "(Git:af14e5)"

Re: commit IDs in changelog messsages (was: Introductory mail)

2008-11-13 Thread Stefano Zacchiroli
On Thu, Nov 13, 2008 at 12:54:03PM +0100, Adeodato Simó wrote: > > 2) (Closes: #1234567, Commit: git:fba134) > > Though I agree with your reasoning here, I find (2) a tad too > verbose (mostly because of the colon appearing twice, which requires > two passes from your brain, if you see what I mean

Re: commit IDs in changelog messsages (was: Introductory mail)

2008-11-13 Thread martin f krafft
also sprach Manuel Prinz <[EMAIL PROTECTED]> [2008.11.13.1328 +0100]: > If it should be clear to someone outside of Debian (packaging), the > notation "{Git,SVN,Hg,*}-Commit" might also be reasonable, as it shows > that the entry has something to do with a VCS commit. Except, of course, there is n

Re: commit IDs in changelog messsages (was: Introductory mail)

2008-11-13 Thread Manuel Prinz
Am Donnerstag, den 13.11.2008, 12:54 +0100 schrieb Adeodato Simó: > Though I agree with your reasoning here, I find (2) a tad too verbose > (mostly because of the colon appearing twice, which requires two passes > from your brain, if you see what I mean). May I suggest: > > 3) (Closes: #123456

Re: commit IDs in changelog messsages (was: Introductory mail)

2008-11-13 Thread Adeodato Simó
* Stefano Zacchiroli [Thu, 13 Nov 2008 12:41:33 +0100]: > On Thu, Nov 13, 2008 at 11:22:56AM +0100, martin f krafft wrote: > > But instead of one parser, I'd really rather think of it as a number > > of parsers, each getting a chance. So Closes would be handled by the > > dak-bts parser, and Git:

Re: commit IDs in changelog messsages (was: Introductory mail)

2008-11-13 Thread martin f krafft
also sprach Stefano Zacchiroli <[EMAIL PROTECTED]> [2008.11.13.1109 +0100]: > OK, but note that there are drawbacks. For example if we go for > "(Git:af14e5)" that would be annoying, as parsing will depend on the > number of supported, or "known", VCS. That was a wrong design choice > of Vcs-* whic

Re: commit IDs in changelog messsages (was: Introductory mail)

2008-11-13 Thread Stefano Zacchiroli
On Thu, Nov 13, 2008 at 11:22:56AM +0100, martin f krafft wrote: > But instead of one parser, I'd really rather think of it as a number > of parsers, each getting a chance. So Closes would be handled by the > dak-bts parser, and Git: by a git parser, SVN: by an SVN parser, > etc. Consider the foll

Re: commit IDs in changelog messsages (was: Introductory mail)

2008-11-13 Thread Martin Bähr
On Thu, Nov 13, 2008 at 01:42:44PM +0100, martin f krafft wrote: > Except, of course, there is no such thing as an SVN-Commit. r123 is > a state, a snapshot, the commit if the diff against r-1. I think hg > is like Git well, in git the commit-ids also represent the state of the whole tree like in

Re: commit IDs in changelog messsages (was: Introductory mail)

2008-11-13 Thread Petr Baudis
On Thu, Nov 13, 2008 at 01:28:17PM +0100, Manuel Prinz wrote: > Am Donnerstag, den 13.11.2008, 12:54 +0100 schrieb Adeodato Simó: > > Though I agree with your reasoning here, I find (2) a tad too verbose > > (mostly because of the colon appearing twice, which requires two passes > > from your brain

Re: commit IDs in changelog messsages (was: Introductory mail)

2008-11-13 Thread James Westby
On Thu, 2008-11-13 at 08:00 +0100, martin f krafft wrote: > also sprach James Westby <[EMAIL PROTECTED]> [2008.11.12.1709 +0100]: > > You mean > > > >[fc5473a06be960382582ddbfb40e2a5f824be122] > > > > don't you? > > No, why? Short commit IDs are usually enough in Git. Why not use [f] then?

Re: commit IDs in changelog messsages (was: Introductory mail)

2008-11-13 Thread martin f krafft
also sprach Martin Bähr <[EMAIL PROTECTED]> [2008.11.13.1540 +0100]: > On Thu, Nov 13, 2008 at 01:42:44PM +0100, martin f krafft wrote: > > Except, of course, there is no such thing as an SVN-Commit. r123 > > is a state, a snapshot, the commit if the diff against r-1. > > I think hg is like Git >

Re: commit IDs in changelog messsages (was: Introductory mail)

2008-11-13 Thread martin f krafft
also sprach Petr Baudis <[EMAIL PROTECTED]> [2008.11.13.1540 +0100]: > On Thu, Nov 13, 2008 at 01:28:17PM +0100, Manuel Prinz wrote: > > Am Donnerstag, den 13.11.2008, 12:54 +0100 schrieb Adeodato Simó: > > > Though I agree with your reasoning here, I find (2) a tad too verbose > > > (mostly becaus

Re: commit IDs in changelog messsages (was: Introductory mail)

2008-11-13 Thread martin f krafft
also sprach James Westby <[EMAIL PROTECTED]> [2008.11.13.1611 +0100]: > The short ID may be unambiguous when you create the entry, but > it's not future proof. The chances of a collision increase over > time. You could disambiguate collisions by walking the history > from the root and finding the f

Re: commit IDs in changelog messsages

2008-11-13 Thread Manoj Srivastava
On Wed, Nov 12 2008, martin f krafft wrote: > also sprach Guido Günther <[EMAIL PROTECTED]> [2008.11.08.1419 +0100]: >> Does this look like a worthwhile extension to the current changelog >> format? For me it makes reviewing changes a lot easier. > > I think this is very important to have, but why