also sprach Guido Günther <[EMAIL PROTECTED]> [2008.11.08.1419 +0100]:
> Does this look like a worthwhile extension to the current changelog
> format? For me it makes reviewing changes a lot easier.
I think this is very important to have, but why put them at the
front? Changelogs are for consumpti
On Wed, Nov 12, 2008 at 08:39:05AM +0100, martin f krafft wrote:
> So, similar to how we close bugs, how about
> * fixed segfault during daemon startup (Closes: #7005180) [fed3f3d]
> instead?
Following the (good) path of "Closes", it should probably be something
like "[Commit: fed3f3d]". Also, c
On Wed, 2008-11-12 at 08:39 +0100, martin f krafft wrote:
> also sprach Guido Günther <[EMAIL PROTECTED]> [2008.11.08.1419 +0100]:
> > Does this look like a worthwhile extension to the current changelog
> > format? For me it makes reviewing changes a lot easier.
>
> I think this is very important
On Wed, Nov 12, 2008 at 11:09:45AM -0500, James Westby wrote:
> On Wed, 2008-11-12 at 08:39 +0100, martin f krafft wrote:
> > also sprach Guido Günther <[EMAIL PROTECTED]> [2008.11.08.1419 +0100]:
> > > Does this look like a worthwhile extension to the current changelog
> > > format? For me it make
* James Westby [Wed, 12 Nov 2008 11:09:45 -0500]:
> How would this differ from using annotate on the changelog? Do some
> people write the changelog at the end?
I think that's what git-dch(1) does.
--
Adeodato Simó dato at net.com.org.es
Debian Developer
also sprach Stefano Zacchiroli <[EMAIL PROTECTED]> [2008.11.12.1320 +0100]:
> Following the (good) path of "Closes", it should probably be
> something like "[Commit: fed3f3d]". Also, can't it be put inside
> the same parentheses than "Closes", as in "(Closes: #7005180,
> #7005181; Commit: fed3f3d)"
On Wed, Nov 12, 2008 at 01:20:10PM +0100, Stefano Zacchiroli wrote:
> Following the (good) path of "Closes", it should probably be something
> like "[Commit: fed3f3d]". Also, can't it be put inside the same
> parentheses than "Closes", as in "(Closes: #7005180, #7005181; Commit:
> fed3f3d)".
If we
On Wed, Nov 12, 2008 at 11:09:45AM -0500, James Westby wrote:
> On Wed, 2008-11-12 at 08:39 +0100, martin f krafft wrote:
> > also sprach Guido Günther <[EMAIL PROTECTED]> [2008.11.08.1419 +0100]:
> > > Does this look like a worthwhile extension to the current changelog
> > > format? For me it make
also sprach Guido Günther <[EMAIL PROTECTED]> [2008.11.13.0903 +0100]:
> If we really want a tag in front of the commit identifier we should
> specify the VCS: [Git:fed3f3d], [Svn:r1234], [Hg:fed3f3d] this would
> help in the case where a package switches VCSs.
... except we wouldn't have the old
On Thu, Nov 13, 2008 at 09:03:32AM +0100, Guido Günther wrote:
> If we really want a tag in front of the commit identifier we should
> specify the VCS: [Git:fed3f3d], [Svn:r1234], [Hg:fed3f3d] this would
> help in the case where a package switches VCSs.
>
> > Finally, I missed if the aim is findi
On Thu, Nov 13, 2008 at 10:36:05AM +0100, Stefano Zacchiroli wrote:
> On Thu, Nov 13, 2008 at 09:03:32AM +0100, Guido Günther wrote:
> > If we really want a tag in front of the commit identifier we should
> > specify the VCS: [Git:fed3f3d], [Svn:r1234], [Hg:fed3f3d] this would
> > help in the case
On Thu, Nov 13, 2008 at 10:40:15AM +0100, Guido Günther wrote:
> I don't have a need for it either - just iff we want to have a
> qualifier inside the braces we should at least use the type of VCS
> not only "Commit:".
OK, but note that there are drawbacks. For example if we go for
"(Git:af14e5)"
On Thu, Nov 13, 2008 at 12:54:03PM +0100, Adeodato Simó wrote:
> > 2) (Closes: #1234567, Commit: git:fba134)
>
> Though I agree with your reasoning here, I find (2) a tad too
> verbose (mostly because of the colon appearing twice, which requires
> two passes from your brain, if you see what I mean
also sprach Manuel Prinz <[EMAIL PROTECTED]> [2008.11.13.1328 +0100]:
> If it should be clear to someone outside of Debian (packaging), the
> notation "{Git,SVN,Hg,*}-Commit" might also be reasonable, as it shows
> that the entry has something to do with a VCS commit.
Except, of course, there is n
Am Donnerstag, den 13.11.2008, 12:54 +0100 schrieb Adeodato Simó:
> Though I agree with your reasoning here, I find (2) a tad too verbose
> (mostly because of the colon appearing twice, which requires two passes
> from your brain, if you see what I mean). May I suggest:
>
> 3) (Closes: #123456
* Stefano Zacchiroli [Thu, 13 Nov 2008 12:41:33 +0100]:
> On Thu, Nov 13, 2008 at 11:22:56AM +0100, martin f krafft wrote:
> > But instead of one parser, I'd really rather think of it as a number
> > of parsers, each getting a chance. So Closes would be handled by the
> > dak-bts parser, and Git:
also sprach Stefano Zacchiroli <[EMAIL PROTECTED]> [2008.11.13.1109 +0100]:
> OK, but note that there are drawbacks. For example if we go for
> "(Git:af14e5)" that would be annoying, as parsing will depend on the
> number of supported, or "known", VCS. That was a wrong design choice
> of Vcs-* whic
On Thu, Nov 13, 2008 at 11:22:56AM +0100, martin f krafft wrote:
> But instead of one parser, I'd really rather think of it as a number
> of parsers, each getting a chance. So Closes would be handled by the
> dak-bts parser, and Git: by a git parser, SVN: by an SVN parser,
> etc.
Consider the foll
On Thu, Nov 13, 2008 at 01:42:44PM +0100, martin f krafft wrote:
> Except, of course, there is no such thing as an SVN-Commit. r123 is
> a state, a snapshot, the commit if the diff against r-1. I think hg
> is like Git
well, in git the commit-ids also represent the state of the whole tree
like in
On Thu, Nov 13, 2008 at 01:28:17PM +0100, Manuel Prinz wrote:
> Am Donnerstag, den 13.11.2008, 12:54 +0100 schrieb Adeodato Simó:
> > Though I agree with your reasoning here, I find (2) a tad too verbose
> > (mostly because of the colon appearing twice, which requires two passes
> > from your brain
On Thu, 2008-11-13 at 08:00 +0100, martin f krafft wrote:
> also sprach James Westby <[EMAIL PROTECTED]> [2008.11.12.1709 +0100]:
> > You mean
> >
> >[fc5473a06be960382582ddbfb40e2a5f824be122]
> >
> > don't you?
>
> No, why? Short commit IDs are usually enough in Git.
Why not use [f] then?
also sprach Martin Bähr <[EMAIL PROTECTED]> [2008.11.13.1540 +0100]:
> On Thu, Nov 13, 2008 at 01:42:44PM +0100, martin f krafft wrote:
> > Except, of course, there is no such thing as an SVN-Commit. r123
> > is a state, a snapshot, the commit if the diff against r-1.
> > I think hg is like Git
>
also sprach Petr Baudis <[EMAIL PROTECTED]> [2008.11.13.1540 +0100]:
> On Thu, Nov 13, 2008 at 01:28:17PM +0100, Manuel Prinz wrote:
> > Am Donnerstag, den 13.11.2008, 12:54 +0100 schrieb Adeodato Simó:
> > > Though I agree with your reasoning here, I find (2) a tad too verbose
> > > (mostly becaus
also sprach James Westby <[EMAIL PROTECTED]> [2008.11.13.1611 +0100]:
> The short ID may be unambiguous when you create the entry, but
> it's not future proof. The chances of a collision increase over
> time. You could disambiguate collisions by walking the history
> from the root and finding the f
On Thu, Nov 13, 2008 at 10:11:15AM -0500, James Westby wrote:
> > > You mean [fc5473a06be960382582ddbfb40e2a5f824be122] don't you?
> > No, why? Short commit IDs are usually enough in Git.
> Why not use [f] then?
Well, even thought the likelihood of clashes increase trivially with
time, we are in t
On Fri, Nov 14, 2008 at 07:42:02AM +0100, martin f krafft wrote:
> also sprach Martin Bähr <[EMAIL PROTECTED]> [2008.11.13.1540 +0100]:
> > On Thu, Nov 13, 2008 at 01:42:44PM +0100, martin f krafft wrote:
> > > Except, of course, there is no such thing as an SVN-Commit. r123
> > > is a state, a sna
On Fri, Nov 14, 2008 at 07:47:06AM +0100, martin f krafft wrote:
> In the long run, I really want to supersede "Closes:" anyway.
> Ideally, the bug gets marked 'fix-committed' when a signed-off
> commit closing the bug hits the repo (or a tag like closes-123456
> appears), and an upload would ident
* martin f krafft [Fri, 14 Nov 2008 07:42:02 +0100]:
> Yes, but we are talking about commits, about changes which resolve
> a given bug. It's only SVN's limitation that you cannot do 'svn show
> r123' and get what you want to see.
% svn diff -c 123
HTH,
--
Adeodato Simó
also sprach Petr Baudis <[EMAIL PROTECTED]> [2008.11.14.1301 +0100]:
> > In the long run, I really want to supersede "Closes:" anyway.
> > Ideally, the bug gets marked 'fix-committed' when a signed-off
> > commit closing the bug hits the repo (or a tag like
> > closes-123456 appears), and an upload
On Thu, 2008-11-13 at 10:11 -0500, James Westby wrote:
> > No, why? Short commit IDs are usually enough in Git.
>
> Why not use [f] then?
>
> The short ID may be unambiguous when you create the entry, but it's not
> future proof. The chances of a collision increase over time.
Right, but every d
30 matches
Mail list logo
