Dan Kenigsberg has posted comments on this change.
Change subject: adjust betterPopenTest.py
..
Patch Set 2:
this waits for formal verification.
--
To view, visit http://gerrit.ovirt.org/4585
To unsubscribe, visit http://gerri
Dan Kenigsberg has posted comments on this change.
Change subject: add comment for hard coded version string in vdsmd.init
..
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
the text of the comment i
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: add testcases for configNetwork
..
tests: add testcases for configNetwork
Add testcases for functions nicSort() and
isBridgeNameValid() in confi
Dan Kenigsberg has posted comments on this change.
Change subject: tests: add testcases for configNetwork
..
Patch Set 3: Verified; Looks good to me, approved
Thanks, I've verified your patch by myself.
--
To view, visit http:
Zhou Zheng Sheng has posted comments on this change.
Change subject: Properly parse configurations in function "do_create" in
vdsClient
..
Patch Set 5: Verified
Add the import hacks for vdsClient.py and vdscli.py.
Test the pa
Douglas Schilling Landgraf has posted comments on this change.
Change subject: add comment for hard coded version string in vdsmd.init
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://ger
Douglas Schilling Landgraf has abandoned this change.
Change subject: Allow deploy of hosts with customized kernel
..
Patch Set 1: Abandoned
We are going to ship a complete/improved approach. For now, canceling this
patch vers
Douglas Schilling Landgraf has posted comments on this change.
Change subject: deployUtil: slightly saner kernel version comparison
..
Patch Set 1:
Sure
# python test.py
('kernel', '3.4')
[root@localhost tmp]# uname -a
Linux
Dan Kenigsberg has posted comments on this change.
Change subject: split logrotate configure into two file for coredump and log
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovi
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#784931 - Fixing raise condition from deactivateSD().
..
Patch Set 2: (3 inline comments)
File vdsm/stora
Dan Kenigsberg has posted comments on this change.
Change subject: Adding the status field to getDeviceLit info.
..
Patch Set 2: (1 inline comment)
Commit Message
Line 7: Add
Ayal Baron has posted comments on this change.
Change subject: Adding the status field to getDeviceLit info.
..
Patch Set 2: I would prefer that you didn't submit this
(14 inline comments)
.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: deployUtil: use os.uname instead of /bin/uname
..
deployUtil: use os.uname instead of /bin/uname
simpler, quicker, and less error-prone.
Change-Id: I7
Dan Kenigsberg has posted comments on this change.
Change subject: deployUtil: use os.uname instead of /bin/uname
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5636
To unsubscribe, visit h
Dan Kenigsberg has posted comments on this change.
Change subject: deployUtil: slightly saner kernel version comparison
..
Patch Set 1:
version='kernel-3.4' ??
could you try running deployUtil.getKernelVR() directly on your ho
Douglas Schilling Landgraf has posted comments on this change.
Change subject: deployUtil: slightly saner kernel version comparison
..
Patch Set 1: I would prefer that you didn't submit this
Failed to install a host with kernel
Douglas Schilling Landgraf has posted comments on this change.
Change subject: deployUtil: use os.uname instead of /bin/uname
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit http://ge
Eduardo has posted comments on this change.
Change subject: BZ#784931 - Restore SD.validate() semantics.
..
Patch Set 2: (1 inline comment)
File vdsm/storage/blockSD.py
Line
Eduardo has uploaded a new change for review.
Change subject: BZ#784931 - Fixing raise condition from deactivateSD().
..
BZ#784931 - Fixing raise condition from deactivateSD().
Change-Id: If06f9cc8da81996590c366de9ad9ea2786a5d3e
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Change default key size to 2048 bits
..
Change default key size to 2048 bits
Change-Id: I05512933dce15c9f6c23fd7944277c3d0465ee76
Signed-off-by: Juan H
Dan Kenigsberg has posted comments on this change.
Change subject: Change default key size to 2048 bits
..
Patch Set 1: Looks good to me, approved
2048 is twice as good ;-)
fine by me.
--
To view, visit http://gerrit.ovirt.org
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hooking.py: expose execCmd
..
hooking.py: expose execCmd
vdsm.utils.execCmd is used by multiple hook scripts to execute external
commands. However, hoo
Dan Kenigsberg has posted comments on this change.
Change subject: hooking.py: expose execCmd
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5616
To unsubscribe, visit http://gerrit.ovirt.o
Juan Hernandez has posted comments on this change.
Change subject: Change default key size to 2048 bits
..
Patch Set 1: Verified
I verified that with this change I can add a Fedora 17 host to a 2048 bits
ovirt-engine (didn't t
Juan Hernandez has posted comments on this change.
Change subject: Change default key size to 2048 bits
..
Patch Set 1:
This complements the same change in the default key size applied to
ovirt-engine:
http://gerrit.ovirt.org
Juan Hernandez has uploaded a new change for review.
Change subject: Change default key size to 2048 bits
..
Change default key size to 2048 bits
Change-Id: I05512933dce15c9f6c23fd7944277c3d0465ee76
Signed-off-by: Juan Hernandez
Shahar Havivi has posted comments on this change.
Change subject: hooking.py: expose execCmd
..
Patch Set 2: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5616
To unsubscrib
Barak Azulay has posted comments on this change.
Change subject: Add shutdown based on qemu-ga(qemu guest agent) in vdsm
..
Patch Set 2: I would prefer that you didn't submit this
The creation of the vioserial required for qemu
Eduardo has posted comments on this change.
Change subject: Adding the status field to getDeviceLit info.
..
Patch Set 2:
Should be getDeviceList.
--
To view, visit http://gerrit.ovirt.org/5515
To unsubscribe, visit http://ger
Bing Bu Cao has posted comments on this change.
Change subject: Add shutdown based on qemu-ga(qemu guest agent) in vdsm
..
Patch Set 2: (1 inline comment)
File vdsm/vm.py
Lin
Dan Kenigsberg has uploaded a new change for review.
Change subject: pthread.py: avoid stdout noise on process shutdown
..
pthread.py: avoid stdout noise on process shutdown
For some reason, __del__ is sometimes called after its
Zhou Zheng Sheng has posted comments on this change.
Change subject: add api registeration mechanism
..
Patch Set 1: (5 inline comments)
File tests/apiTests.py
Line 10: @
Dan Kenigsberg has submitted this change and it was merged.
Change subject: add configure variable vdsmcoredumpdir for /var/log/core
..
add configure variable vdsmcoredumpdir for /var/log/core
Change-Id: I94ac220078f8a00fbdd8ab
Xu He Jie has posted comments on this change.
Change subject: add configure variable vdsmcoredumpdir for /var/log/core
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/5150
To unsubscribe, visit http://gerrit.
Dan Kenigsberg has uploaded a new change for review.
Change subject: BZ#770153 Do not set max_cstate on Fedora hosts
..
BZ#770153 Do not set max_cstate on Fedora hosts
Modern hardware with stable/constant tsc can host VMs with a
Gal Hammer has posted comments on this change.
Change subject: Add shutdown based on qemu-ga(qemu guest agent) in vdsm
..
Patch Set 2: (1 inline comment)
File vdsm/vm.py
Line
ShaoHe Feng has posted comments on this change.
Change subject: Fixing typo in the source files besides vdsm.git/vdsm.
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/43
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#833752 - Fix chlist as a volume object list in Image.merge().
..
BZ#833752 - Fix chlist as a volume object list in Image.merge().
Merging a base raw
Bing Bu Cao has posted comments on this change.
Change subject: Add shutdown based on qemu-ga(qemu guest agent) in vdsm
..
Patch Set 2: (1 inline comment)
File vdsm/vm.py
Lin
39 matches
Mail list logo