Change in vdsm[master]: adjust betterPopenTest.py

2012-06-25 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: adjust betterPopenTest.py .. Patch Set 2: this waits for formal verification. -- To view, visit http://gerrit.ovirt.org/4585 To unsubscribe, visit http://gerri

Change in vdsm[master]: add comment for hard coded version string in vdsmd.init

2012-06-25 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: add comment for hard coded version string in vdsmd.init .. Patch Set 3: I would prefer that you didn't submit this (1 inline comment) the text of the comment i

Change in vdsm[master]: tests: add testcases for configNetwork

2012-06-25 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: add testcases for configNetwork .. tests: add testcases for configNetwork Add testcases for functions nicSort() and isBridgeNameValid() in confi

Change in vdsm[master]: tests: add testcases for configNetwork

2012-06-25 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: tests: add testcases for configNetwork .. Patch Set 3: Verified; Looks good to me, approved Thanks, I've verified your patch by myself. -- To view, visit http:

Change in vdsm[master]: Properly parse configurations in function "do_create" in vds...

2012-06-25 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: Properly parse configurations in function "do_create" in vdsClient .. Patch Set 5: Verified Add the import hacks for vdsClient.py and vdscli.py. Test the pa

Change in vdsm[master]: add comment for hard coded version string in vdsmd.init

2012-06-25 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: add comment for hard coded version string in vdsmd.init .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://ger

Change in vdsm[master]: Allow deploy of hosts with customized kernel

2012-06-25 Thread dougsland
Douglas Schilling Landgraf has abandoned this change. Change subject: Allow deploy of hosts with customized kernel .. Patch Set 1: Abandoned We are going to ship a complete/improved approach. For now, canceling this patch vers

Change in vdsm[master]: deployUtil: slightly saner kernel version comparison

2012-06-25 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: deployUtil: slightly saner kernel version comparison .. Patch Set 1: Sure # python test.py ('kernel', '3.4') [root@localhost tmp]# uname -a Linux

Change in vdsm[master]: split logrotate configure into two file for coredump and log

2012-06-25 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: split logrotate configure into two file for coredump and log .. Patch Set 5: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovi

Change in vdsm[master]: BZ#784931 - Fixing raise condition from deactivateSD().

2012-06-25 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ#784931 - Fixing raise condition from deactivateSD(). .. Patch Set 2: (3 inline comments) File vdsm/stora

Change in vdsm[master]: Adding the status field to getDeviceLit info.

2012-06-25 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Adding the status field to getDeviceLit info. .. Patch Set 2: (1 inline comment) Commit Message Line 7: Add

Change in vdsm[master]: Adding the status field to getDeviceLit info.

2012-06-25 Thread abaron
Ayal Baron has posted comments on this change. Change subject: Adding the status field to getDeviceLit info. .. Patch Set 2: I would prefer that you didn't submit this (14 inline comments) .

Change in vdsm[master]: deployUtil: use os.uname instead of /bin/uname

2012-06-25 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: deployUtil: use os.uname instead of /bin/uname .. deployUtil: use os.uname instead of /bin/uname simpler, quicker, and less error-prone. Change-Id: I7

Change in vdsm[master]: deployUtil: use os.uname instead of /bin/uname

2012-06-25 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: deployUtil: use os.uname instead of /bin/uname .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5636 To unsubscribe, visit h

Change in vdsm[master]: deployUtil: slightly saner kernel version comparison

2012-06-25 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: deployUtil: slightly saner kernel version comparison .. Patch Set 1: version='kernel-3.4' ?? could you try running deployUtil.getKernelVR() directly on your ho

Change in vdsm[master]: deployUtil: slightly saner kernel version comparison

2012-06-25 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: deployUtil: slightly saner kernel version comparison .. Patch Set 1: I would prefer that you didn't submit this Failed to install a host with kernel

Change in vdsm[master]: deployUtil: use os.uname instead of /bin/uname

2012-06-25 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: deployUtil: use os.uname instead of /bin/uname .. Patch Set 1: Verified; Looks good to me, but someone else must approve -- To view, visit http://ge

Change in vdsm[master]: BZ#784931 - Restore SD.validate() semantics.

2012-06-25 Thread ewarszaw
Eduardo has posted comments on this change. Change subject: BZ#784931 - Restore SD.validate() semantics. .. Patch Set 2: (1 inline comment) File vdsm/storage/blockSD.py Line

Change in vdsm[master]: BZ#784931 - Fixing raise condition from deactivateSD().

2012-06-25 Thread ewarszaw
Eduardo has uploaded a new change for review. Change subject: BZ#784931 - Fixing raise condition from deactivateSD(). .. BZ#784931 - Fixing raise condition from deactivateSD(). Change-Id: If06f9cc8da81996590c366de9ad9ea2786a5d3e

Change in vdsm[master]: Change default key size to 2048 bits

2012-06-25 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Change default key size to 2048 bits .. Change default key size to 2048 bits Change-Id: I05512933dce15c9f6c23fd7944277c3d0465ee76 Signed-off-by: Juan H

Change in vdsm[master]: Change default key size to 2048 bits

2012-06-25 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Change default key size to 2048 bits .. Patch Set 1: Looks good to me, approved 2048 is twice as good ;-) fine by me. -- To view, visit http://gerrit.ovirt.org

Change in vdsm[master]: hooking.py: expose execCmd

2012-06-25 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: hooking.py: expose execCmd .. hooking.py: expose execCmd vdsm.utils.execCmd is used by multiple hook scripts to execute external commands. However, hoo

Change in vdsm[master]: hooking.py: expose execCmd

2012-06-25 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: hooking.py: expose execCmd .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5616 To unsubscribe, visit http://gerrit.ovirt.o

Change in vdsm[master]: Change default key size to 2048 bits

2012-06-25 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: Change default key size to 2048 bits .. Patch Set 1: Verified I verified that with this change I can add a Fedora 17 host to a 2048 bits ovirt-engine (didn't t

Change in vdsm[master]: Change default key size to 2048 bits

2012-06-25 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: Change default key size to 2048 bits .. Patch Set 1: This complements the same change in the default key size applied to ovirt-engine: http://gerrit.ovirt.org

Change in vdsm[master]: Change default key size to 2048 bits

2012-06-25 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: Change default key size to 2048 bits .. Change default key size to 2048 bits Change-Id: I05512933dce15c9f6c23fd7944277c3d0465ee76 Signed-off-by: Juan Hernandez

Change in vdsm[master]: hooking.py: expose execCmd

2012-06-25 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: hooking.py: expose execCmd .. Patch Set 2: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/5616 To unsubscrib

Change in vdsm[master]: Add shutdown based on qemu-ga(qemu guest agent) in vdsm

2012-06-25 Thread bazulay
Barak Azulay has posted comments on this change. Change subject: Add shutdown based on qemu-ga(qemu guest agent) in vdsm .. Patch Set 2: I would prefer that you didn't submit this The creation of the vioserial required for qemu

Change in vdsm[master]: Adding the status field to getDeviceLit info.

2012-06-25 Thread ewarszaw
Eduardo has posted comments on this change. Change subject: Adding the status field to getDeviceLit info. .. Patch Set 2: Should be getDeviceList. -- To view, visit http://gerrit.ovirt.org/5515 To unsubscribe, visit http://ger

Change in vdsm[master]: Add shutdown based on qemu-ga(qemu guest agent) in vdsm

2012-06-25 Thread mars
Bing Bu Cao has posted comments on this change. Change subject: Add shutdown based on qemu-ga(qemu guest agent) in vdsm .. Patch Set 2: (1 inline comment) File vdsm/vm.py Lin

Change in vdsm[master]: pthread.py: avoid stdout noise on process shutdown

2012-06-25 Thread danken
Dan Kenigsberg has uploaded a new change for review. Change subject: pthread.py: avoid stdout noise on process shutdown .. pthread.py: avoid stdout noise on process shutdown For some reason, __del__ is sometimes called after its

Change in vdsm[master]: add api registeration mechanism

2012-06-25 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: add api registeration mechanism .. Patch Set 1: (5 inline comments) File tests/apiTests.py Line 10: @

Change in vdsm[master]: add configure variable vdsmcoredumpdir for /var/log/core

2012-06-25 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: add configure variable vdsmcoredumpdir for /var/log/core .. add configure variable vdsmcoredumpdir for /var/log/core Change-Id: I94ac220078f8a00fbdd8ab

Change in vdsm[master]: add configure variable vdsmcoredumpdir for /var/log/core

2012-06-25 Thread Xu He Jie
Xu He Jie has posted comments on this change. Change subject: add configure variable vdsmcoredumpdir for /var/log/core .. Patch Set 5: Verified -- To view, visit http://gerrit.ovirt.org/5150 To unsubscribe, visit http://gerrit.

Change in vdsm[master]: BZ#770153 Do not set max_cstate on Fedora hosts

2012-06-25 Thread danken
Dan Kenigsberg has uploaded a new change for review. Change subject: BZ#770153 Do not set max_cstate on Fedora hosts .. BZ#770153 Do not set max_cstate on Fedora hosts Modern hardware with stable/constant tsc can host VMs with a

Change in vdsm[master]: Add shutdown based on qemu-ga(qemu guest agent) in vdsm

2012-06-25 Thread ghammer
Gal Hammer has posted comments on this change. Change subject: Add shutdown based on qemu-ga(qemu guest agent) in vdsm .. Patch Set 2: (1 inline comment) File vdsm/vm.py Line

Change in vdsm[master]: Fixing typo in the source files besides vdsm.git/vdsm.

2012-06-25 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: Fixing typo in the source files besides vdsm.git/vdsm. .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/43

Change in vdsm[master]: BZ#833752 - Fix chlist as a volume object list in Image.merg...

2012-06-25 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: BZ#833752 - Fix chlist as a volume object list in Image.merge(). .. BZ#833752 - Fix chlist as a volume object list in Image.merge(). Merging a base raw

Change in vdsm[master]: Add shutdown based on qemu-ga(qemu guest agent) in vdsm

2012-06-25 Thread mars
Bing Bu Cao has posted comments on this change. Change subject: Add shutdown based on qemu-ga(qemu guest agent) in vdsm .. Patch Set 2: (1 inline comment) File vdsm/vm.py Lin