Dan Kenigsberg has posted comments on this change. Change subject: BZ#784931 - Fixing raise condition from deactivateSD(). ......................................................................
Patch Set 2: (3 inline comments) .................................................... File vdsm/storage/mount.py Line 46: def _runcmd(self, cmd, timeout): it was not really necessary for this patch, right? Line 146: def isMounted(target): I do not really fancy is* functions that does not return a boolean. but if you really want to do it, please update the docstring. .................................................... File vdsm/storage/sp.py Line 1051: masterDir = os.path.join(dom.domaindir, sd.MASTER_FS_DIR) didn't you plan to use your new isMounted() semantics here? if not, I do not understand why you've touched mount.py. -- To view, visit http://gerrit.ovirt.org/5677 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If06f9cc8da81996590c366de9ad9ea2786a5d3ea Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
