Change in vdsm[master]: Specify the ACPI flag when shutting down VMs

2012-08-11 Thread lvroyce
Royce Lv has posted comments on this change. Change subject: Specify the ACPI flag when shutting down VMs .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/6996 To unsubsc

Change in vdsm[master]: Don't report 'imageID' for non-vdsm images in _getDiskStats(...

2012-08-11 Thread lvroyce
Royce Lv has posted comments on this change. Change subject: Don't report 'imageID' for non-vdsm images in _getDiskStats() .. Patch Set 1: Looks good to me, but someone else must approve Is this what you're referring with the '

Change in vdsm[master]: check disk shared flag exist before use it

2012-08-11 Thread lvroyce
Royce Lv has posted comments on this change. Change subject: check disk shared flag exist before use it .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/7051 To unsubscribe, visit http://gerrit.ovirt.org/setti

Change in vdsm[master]: bootstrap: remove dh key generation

2012-08-11 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: bootstrap: remove dh key generation .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/7073 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: bootstrap: remove dh key generation

2012-08-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: bootstrap: remove dh key generation .. Patch Set 2: Build Successful http://jenkins.ovirt.info/job/patch_vdms_manager/16/ : SUCCESS -- To view, visi

Change in vdsm[master]: bootstrap: send complete bootstrap from engine

2012-08-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: bootstrap: send complete bootstrap from engine .. Patch Set 9: Build Successful http://jenkins.ovirt.info/job/patch_vdms_manager/15/ : SUCCESS -- To

Change in vdsm[master]: bootstrap: remove dh key generation

2012-08-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: bootstrap: remove dh key generation .. Patch Set 2: Build Started http://jenkins.ovirt.info/job/patch_vdms_manager/16/ -- To view, visit http://gerrit

Change in vdsm[master]: bootstrap: send complete bootstrap from engine

2012-08-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: bootstrap: send complete bootstrap from engine .. Patch Set 9: Build Started http://jenkins.ovirt.info/job/patch_vdms_manager/15/ -- To view, visit ht

Change in vdsm[master]: bootstrap: send complete bootstrap from engine

2012-08-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: bootstrap: send complete bootstrap from engine .. Patch Set 8: Build Successful http://jenkins.ovirt.info/job/patch_vdms_manager/14/ : SUCCESS -- To

Change in vdsm[master]: bootstrap: send complete bootstrap from engine

2012-08-11 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: bootstrap: send complete bootstrap from engine .. Patch Set 8: Don't clean self directory, so that if someone runs script manually it won't destroy anything. Eng

Change in vdsm[master]: bootstrap: send complete bootstrap from engine

2012-08-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: bootstrap: send complete bootstrap from engine .. Patch Set 8: Build Started http://jenkins.ovirt.info/job/patch_vdms_manager/14/ -- To view, visit ht

Change in vdsm[master]: Add deathSignal options to better peopen

2012-08-11 Thread abaron
Ayal Baron has posted comments on this change. Change subject: Add deathSignal options to better peopen .. Patch Set 9: Looks good to me, but someone else must approve (4 inline comments) ..

Change in vdsm[master]: Enable fake_kvm_support on hosts without hardware VT support...

2012-08-11 Thread iheim
Itamar Heim has posted comments on this change. Change subject: Enable fake_kvm_support on hosts without hardware VT support automatically .. Patch Set 1: vdsm bootstrap already has code for this detection, please look at it f

Change in vdsm[master]: Properly propagate pool timeout in file handler

2012-08-11 Thread abaron
Ayal Baron has posted comments on this change. Change subject: Properly propagate pool timeout in file handler .. Patch Set 6: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6671 To unsubscribe, visit http

Change in vdsm[master]: Report hsm tasks in getAllTasksStatuses and getAllTasksInfo

2012-08-11 Thread abaron
Ayal Baron has posted comments on this change. Change subject: Report hsm tasks in getAllTasksStatuses and getAllTasksInfo .. Patch Set 8: I would prefer that you didn't submit this Doesn't this break engine? 1 scenario that po

Change in vdsm[master]: bootstrap: sync logging between two phases

2012-08-11 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: bootstrap: sync logging between two phases .. Patch Set 1: (1 inline comment) File vds_bootstrap/vds_bootstra

Change in vdsm[master]: bootstrap: cleanup file cleanup function

2012-08-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: bootstrap: cleanup file cleanup function .. Patch Set 2: Build Successful http://jenkins.ovirt.info/job/patch_vdms_manager/13/ : SUCCESS -- To view,

Change in vdsm[master]: bootstrap: cleanup file cleanup function

2012-08-11 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: bootstrap: cleanup file cleanup function .. Patch Set 2: Remove extra (). -- To view, visit http://gerrit.ovirt.org/7090 To unsubscribe, visit http://gerrit.ovir

Change in vdsm[master]: bootstrap: always use /tmp for output files

2012-08-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: bootstrap: always use /tmp for output files .. Patch Set 2: Build Successful http://jenkins.ovirt.info/job/patch_vdms_manager/12/ : SUCCESS -- To vi

Change in vdsm[master]: bootstrap: sync logging between two phases

2012-08-11 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: bootstrap: sync logging between two phases .. Patch Set 2: tempfile.gettempdir() -- To view, visit http://gerrit.ovirt.org/7089 To unsubscribe, visit http://gerr

Change in vdsm[master]: bootstrap: sync logging between two phases

2012-08-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: bootstrap: sync logging between two phases .. Patch Set 2: Build Successful http://jenkins.ovirt.info/job/patch_vdms_manager/11/ : SUCCESS -- To vie

Change in vdsm[master]: bootstrap: send complete bootstrap from engine

2012-08-11 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: bootstrap: send complete bootstrap from engine .. Patch Set 7: Update log default to use tempfile.gettempdir() as default. -- To view, visit http://gerrit.ovirt.

Change in vdsm[master]: bootstrap: introduce bootstrap interface version

2012-08-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: bootstrap: introduce bootstrap interface version .. Patch Set 2: Build Successful http://jenkins.ovirt.info/job/patch_vdms_manager/10/ : SUCCESS --

Change in vdsm[master]: bootstrap: send complete bootstrap from engine

2012-08-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: bootstrap: send complete bootstrap from engine .. Patch Set 7: Build Successful http://jenkins.ovirt.info/job/patch_vdms_manager/9/ : SUCCESS -- To

Change in vdsm[master]: bootstrap: cleanup file cleanup function

2012-08-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: bootstrap: cleanup file cleanup function .. Patch Set 2: Build Started http://jenkins.ovirt.info/job/patch_vdms_manager/13/ -- To view, visit http://g

Change in vdsm[master]: bootstrap: always use /tmp for output files

2012-08-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: bootstrap: always use /tmp for output files .. Patch Set 2: Build Started http://jenkins.ovirt.info/job/patch_vdms_manager/12/ -- To view, visit http:

Change in vdsm[master]: bootstrap: sync logging between two phases

2012-08-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: bootstrap: sync logging between two phases .. Patch Set 2: Build Started http://jenkins.ovirt.info/job/patch_vdms_manager/11/ -- To view, visit http:/

Change in vdsm[master]: bootstrap: send complete bootstrap from engine

2012-08-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: bootstrap: send complete bootstrap from engine .. Patch Set 7: Build Started http://jenkins.ovirt.info/job/patch_vdms_manager/9/ -- To view, visit htt

Change in vdsm[master]: bootstrap: introduce bootstrap interface version

2012-08-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: bootstrap: introduce bootstrap interface version .. Patch Set 2: Build Started http://jenkins.ovirt.info/job/patch_vdms_manager/10/ -- To view, visit

Change in vdsm[master]: bootstrap: send complete bootstrap from engine

2012-08-11 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: bootstrap: send complete bootstrap from engine .. Patch Set 6: (1 inline comment) File vds_bootstrap/setup-2

Change in vdsm[master]: cleanup: bootstrap: cleanup file cleanup function

2012-08-11 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: cleanup: bootstrap: cleanup file cleanup function .. Patch Set 1: (1 inline comment) File vdsm_reg/deployUtil

Change in vdsm[master]: bootstrap: sync logging between two phases

2012-08-11 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: bootstrap: sync logging between two phases .. Patch Set 1: (2 inline comments) File vds_bootstrap/vds_bootstr

Change in vdsm[master]: cleanup: bootstrap: cleanup file cleanup function

2012-08-11 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: cleanup: bootstrap: cleanup file cleanup function .. Patch Set 1: (2 inline comments) Commit Message Line 7

Change in vdsm[master]: vdsm bootstrap changes for kvm on ppc64 support

2012-08-11 Thread bpradip
Pradipta Banerjee has posted comments on this change. Change subject: vdsm bootstrap changes for kvm on ppc64 support .. Patch Set 2: Verified Incorporated feedback from Douglas -- To view, visit http://gerrit.ovirt.org/7072 T

Change in vdsm[master]: bootstrap: sync logging between two phases

2012-08-11 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: bootstrap: sync logging between two phases .. Patch Set 1: I would prefer that you didn't submit this (2 inline comments) .

Change in vdsm[master]: bootstrap: send complete bootstrap from engine

2012-08-11 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: bootstrap: send complete bootstrap from engine .. Patch Set 6: (1 inline comment) File vds_bootstrap/setup-

Change in vdsm[master]: bootstrap: search own ssh key without base64 suffix

2012-08-11 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: bootstrap: search own ssh key without base64 suffix .. Patch Set 1: We can look for both cases... or fix the other application :) -- To view, visit http://gerrit

Change in vdsm[master]: bootstrap: search own ssh key without base64 suffix

2012-08-11 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: bootstrap: search own ssh key without base64 suffix .. Patch Set 1: Looks good to me, approved note that we used to have a problem with (other) applications, le

Change in vdsm[master]: legal: bootstrap: update copyright years

2012-08-11 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: legal: bootstrap: update copyright years .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/7087 To unsubscribe, visit http://gerrit.ovirt.org/s

Change in vdsm[master]: legal: bootstrap: update copyright years

2012-08-11 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: legal: bootstrap: update copyright years .. legal: bootstrap: update copyright years Change-Id: I1d57db3594b786580a5fb31a9dbcf971ce980af8 Signed-off-by

Change in vdsm[master]: legal: bootstrap: update copyright years

2012-08-11 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: legal: bootstrap: update copyright years .. Patch Set 1: Looks good to me, approved I understand this is my punishment for asking to break your patch to pieces

Change in vdsm[master]: Add missing log object to CrabRPCServer

2012-08-11 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Add missing log object to CrabRPCServer .. Patch Set 1: Looks good to me, approved doh, I should have noticed this "little" fact when reviewing http://gerrit.o

Change in vdsm[master]: vdsm bootstrap changes for kvm on ppc64 support

2012-08-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm bootstrap changes for kvm on ppc64 support .. Patch Set 2: Fails Build Failed http://jenkins.ovirt.info/job/patch_vdms_manager/8/ : FAILURE --

Change in vdsm[master]: vdsm bootstrap changes for kvm on ppc64 support

2012-08-11 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm bootstrap changes for kvm on ppc64 support .. Patch Set 2: Build Started http://jenkins.ovirt.info/job/patch_vdms_manager/8/ -- To view, visit ht