Federico Simoncelli has posted comments on this change.
Change subject: misc: handle properly timeout=-1 in NoIntrPoll
..
Patch Set 3: Verified
Verified with the provided test (both positive and negative).
--
To view, visit ht
Antoni Segura Puimedon has abandoned this change.
Change subject: Don't fail silently when ifup fails.
..
Patch Set 1: Abandoned
Can wait till 3.3
--
To view, visit http://gerrit.ovirt.org/11820
To unsubscribe, visit http://ge
Ayal Baron has posted comments on this change.
Change subject: Rename parent volume in blockSD.getAllVolumes.
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8608
To unsubscribe, visit http:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Requires policycoreutils-2.1.13-55 to avoid another break on
selinux disabled.
..
Requires policycoreutils-2.1.13-55 to avoid another break on selinux
Dan Kenigsberg has posted comments on this change.
Change subject: Requires policycoreutils-2.1.13-55 to avoid another break on
selinux disabled.
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://ge
Dan Kenigsberg has posted comments on this change.
Change subject: Probe cpu count from new libvirt capabilities.
..
Patch Set 4: I would prefer that you didn't submit this
My main issue with this patch is that it is based on a
Dan Kenigsberg has posted comments on this change.
Change subject: Add migration network support.
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11795
To unsubscribe, v
Dan Kenigsberg has posted comments on this change.
Change subject: Don't fail silently when ifup fails.
..
Patch Set 1: I would prefer that you didn't submit this
wasn't http://gerrit.ovirt.org/10008 required for this to work?
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Fix broken NFS.
..
Fix broken NFS.
self.sdUUID does not exist when self.validateFileSystemFeatures
is called.
Broken by Icf14d1c4737.
Change-Id: Iabe
Dan Kenigsberg has posted comments on this change.
Change subject: Fix broken NFS.
..
Patch Set 2: Looks good to me, approved
Thanks, Eduardo, for quickly unbreaking master.
--
To view, visit http://gerrit.ovirt.org/11802
To u
Saggi Mizrahi has posted comments on this change.
Change subject: [WIP] Implement python bindings
..
Patch Set 2: I would prefer that you didn't submit this
(9 inline comments)
Some minor comments.
The big problems are:
move e
Adam Litke has posted comments on this change.
Change subject: netinfo: report IPv6 information
..
Patch Set 6: Looks good to me, but someone else must approve
I don't see any problems with the schema changes.
--
To view, visi
Adam Litke has posted comments on this change.
Change subject: jsonrpc: Make jsonrpc an independent package
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/11710
To unsubscribe, visit http://gerrit.ovirt.org/
Adam Litke has posted comments on this change.
Change subject: jsonrpc: Use the AsyncoreClient implementation in tests too
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerri
Adam Litke has posted comments on this change.
Change subject: tests: (OCD) Add space at the end of the sample string
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovi
Adam Litke has posted comments on this change.
Change subject: jsonrpc: Remove unecessary check
..
Patch Set 3: Verified
Please add a reason why the check is not needed to your commit message.
--
To view, visit http://gerrit.o
Adam Litke has posted comments on this change.
Change subject: jsonrpc: Check for credit before popping a message from the
queue
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.o
Adam Litke has posted comments on this change.
Change subject: jsonrpc: Use asyncore instead of custom solution
..
Patch Set 6: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org
Adam Litke has posted comments on this change.
Change subject: jsonrpc: Make reactor clients 1st class objects
..
Patch Set 5: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/
Adam Litke has posted comments on this change.
Change subject: jsonrpc: Change start_listening to createListener
..
Patch Set 5: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.or
Adam Litke has posted comments on this change.
Change subject: jsonrpc: Add support for multiple listeners
..
Patch Set 5: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1140
Adam Litke has posted comments on this change.
Change subject: jsonrpc: Change cxtr to connector to make the code a bit more
understandable
..
Patch Set 10: Verified; Looks good to me, but someone else must approve
Carrying my
Adam Litke has posted comments on this change.
Change subject: jsonrpc: Add multi-threading option to JsonRpcServer
..
Patch Set 11: Verified
--
To view, visit http://gerrit.ovirt.org/10374
To unsubscribe, visit http://gerrit.o
Adam Litke has posted comments on this change.
Change subject: jsonrpc: Federate context and request-response objects
..
Patch Set 11: Verified
--
To view, visit http://gerrit.ovirt.org/10375
To unsubscribe, visit http://gerrit
Adam Litke has posted comments on this change.
Change subject: jsonrpc: Federate context and request-response objects
..
Patch Set 11: Looks good to me, but someone else must approve
Patch is unchanged and my review stands as-i
Antoni Segura Puimedon has posted comments on this change.
Change subject: Don't fail silently when ifup fails.
..
Patch Set 1:
This will make our life supporting users much easier, as setupNetwork errors
will not go unnoticed
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/11820
to review the following change.
Change subject: Don't fail silently when ifup fails.
..
Don't fail silently when ifup fail
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm: create /etc/modules-load.d/vdsm.conf
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/11718
To unsubscribe, visit http://ger
Adam Litke has posted comments on this change.
Change subject: jsonrpc: Add multi-threading option to JsonRpcServer
..
Patch Set 11: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1037
Adam Litke has posted comments on this change.
Change subject: jsonrpc: Fix race in ProtonReactor and add better delivery
semantics
..
Patch Set 11: (1 inline comment)
Commi
Adam Litke has posted comments on this change.
Change subject: jsonrpc: Make jsonrpc an independent package
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11710
To unsu
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: create /etc/modules-load.d/vdsm.conf
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1169/ : SUCCESS
http://jen
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: create /etc/modules-load.d/vdsm.conf
..
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1204/ (2/3)
--
To view, v
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: create /etc/modules-load.d/vdsm.conf
..
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/315/ (3/3)
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: create /etc/modules-load.d/vdsm.conf
..
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1169/ (1/3)
--
To view, visit h
Saggi Mizrahi has posted comments on this change.
Change subject: Fix broken NFS.
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11802
To unsubscribe, visit http://gerr
Mark Wu has posted comments on this change.
Change subject: Remove some cases of netinfo instance creation.
..
Patch Set 9: Looks good to me, but someone else must approve
(1 inline comment)
just a minor suggestion inline
...
Federico Simoncelli has posted comments on this change.
Change subject: If attachSD fails - rescan for new vgs not visible from spm
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
I need some clar
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add migration network support.
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1168/ : SUCCESS
http://jenkins.ovirt.o
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add migration network support.
..
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1203/ (1/3)
--
To view, visit http://
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add migration network support.
..
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1168/ (2/3)
--
To view, visit http://gerrit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add migration network support.
..
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/314/ (3/3)
--
To view, visit http:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Rename parent volume in blockSD.getAllVolumes.
..
Patch Set 4: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1167/ : SUCCESS
http
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#829110 Remove a "Domain not found" error from stats thread.
..
Patch Set 2: Looks good to me, approved
I suppose that these days, libvirt event are dependabl
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#829110 Remove a "Domain not found" error from stats thread.
..
BZ#829110 Remove a "Domain not found" error from stats thread.
Removed redundant code
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Rename parent volume in blockSD.getAllVolumes.
..
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/313/ (3/3)
--
To v
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Rename parent volume in blockSD.getAllVolumes.
..
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1167/ (1/3)
--
To view, vis
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Rename parent volume in blockSD.getAllVolumes.
..
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1202/ (2/3)
--
To vie
Dan Kenigsberg has abandoned this change.
Change subject: [WIP] migration network custom property
..
Patch Set 1: Abandoned
proper implementation should follow the lines of
http://gerrit.ovirt.org/#/c/11795/
--
To view, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Fix broken NFS.
..
Patch Set 2: Verified
works over fedora.
--
To view, visit http://gerrit.ovirt.org/11802
To unsubscribe, visit http://gerrit.ovirt.org/setti
Roy Golan has posted comments on this change.
Change subject: catch libvirt timeout and return an error on setVmTicket
..
Patch Set 3: (2 inline comments)
File vdsm/libvirtvm
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add migration network support.
..
Patch Set 2: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1166/ : SUCCESS
http://jenkins.ovirt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add migration network support.
..
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1166/ (2/3)
--
To view, visit http://gerrit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add migration network support.
..
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/312/ (3/3)
--
To view, visit http:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add migration network support.
..
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1201/ (1/3)
--
To view, visit http://
Igor Lvovsky has posted comments on this change.
Change subject: Add migration network support.
..
Patch Set 1: (2 inline comments)
File vdsm/API.py
Line 452: *ds
Daniel Paikov has posted comments on this change.
Change subject: If attachSD fails - rescan for new vgs not visible from spm
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10495
To unsubscribe, visit http:/
Dan Kenigsberg has posted comments on this change.
Change subject: configNet: allow delete/update of devices with no ifcfg
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11680
To unsubscrib
Dan Kenigsberg has submitted this change and it was merged.
Change subject: configNet: allow delete/update of devices with no ifcfg
..
configNet: allow delete/update of devices with no ifcfg
In Fedora 18, ifcfg files are missin
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix broken NFS.
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1165/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_uni
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix broken NFS.
..
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1200/ (3/3)
--
To view, visit http://gerrit.ovirt.or
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix broken NFS.
..
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1165/ (2/3)
--
To view, visit http://gerrit.ovirt.org/1180
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix broken NFS.
..
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/311/ (1/3)
--
To view, visit http://gerrit.ovirt.
Yeela Kaplan has posted comments on this change.
Change subject: Fix broken NFS.
..
Patch Set 1: (1 inline comment)
Commit Message
Line 3: AuthorDate: 2013-02-06 16:47:44 +02
Vinzenz Feenstra has posted comments on this change.
Change subject: migrateStatus() progress report
..
Patch Set 19: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6824
To unsubscribe
Yeela Kaplan has posted comments on this change.
Change subject: Fix broken NFS.
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
File vdsm/stor
oVirt Jenkins CI Server has posted comments on this change.
Change subject: misc: handle properly timeout=-1 in NoIntrPoll
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1164/ : SUCCESS
http:/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: misc: handle properly timeout=-1 in NoIntrPoll
..
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1164/ (1/3)
--
To view, vis
oVirt Jenkins CI Server has posted comments on this change.
Change subject: misc: handle properly timeout=-1 in NoIntrPoll
..
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1199/ (3/3)
--
To vie
oVirt Jenkins CI Server has posted comments on this change.
Change subject: misc: handle properly timeout=-1 in NoIntrPoll
..
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/310/ (2/3)
--
To v
oVirt Jenkins CI Server has posted comments on this change.
Change subject: misc: handle properly timeout=-1 in NoIntrPoll
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1163/ : SUCCESS
http:/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: misc: handle properly timeout=-1 in NoIntrPoll
..
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/309/ (3/3)
--
To v
oVirt Jenkins CI Server has posted comments on this change.
Change subject: misc: handle properly timeout=-1 in NoIntrPoll
..
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1163/ (1/3)
--
To view, vis
oVirt Jenkins CI Server has posted comments on this change.
Change subject: misc: handle properly timeout=-1 in NoIntrPoll
..
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1198/ (2/3)
--
To vie
Federico Simoncelli has posted comments on this change.
Change subject: misc: handle properly timeout=-1 in NoIntrPoll
..
Patch Set 1: (1 inline comment)
File vdsm/storage/mi
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: Gluster UFO verbs
..
Patch Set 10:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1162/ : SUCCESS
http://jenkins.ovirt.org/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: Gluster UFO verbs
..
Patch Set 10:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1197/ (3/3)
--
To view, visit http://ger
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: Gluster UFO verbs
..
Patch Set 10:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1162/ (1/3)
--
To view, visit http://gerrit.ov
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: Gluster UFO verbs
..
Patch Set 10:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/308/ (2/3)
--
To view, visit http://g
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: Gluster UFO verbs
..
Patch Set 9: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1161/ : SUCCESS
http://jenkins.ovirt.org
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: Gluster UFO verbs
..
Patch Set 9:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/307/ (1/3)
--
To view, visit http://ge
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: Gluster UFO verbs
..
Patch Set 9:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1161/ (3/3)
--
To view, visit http://gerrit.ovi
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: Gluster UFO verbs
..
Patch Set 9:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1196/ (2/3)
--
To view, visit http://gerr
oVirt Jenkins CI Server has posted comments on this change.
Change subject: migrateStatus() progress report
..
Patch Set 19:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1160/ : SUCCESS
http://jenkins.ovirt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: migrateStatus() progress report
..
Patch Set 19:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/306/ (2/3)
--
To view, visit htt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: migrateStatus() progress report
..
Patch Set 19:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1195/ (1/3)
--
To view, visit http:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: migrateStatus() progress report
..
Patch Set 19:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1160/ (3/3)
--
To view, visit http://gerr
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix broken NFS.
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1159/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_uni
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix broken NFS.
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1194/ (3/3)
--
To view, visit http://gerrit.ovirt.or
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix broken NFS.
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1159/ (2/3)
--
To view, visit http://gerrit.ovirt.org/1180
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix broken NFS.
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/305/ (1/3)
--
To view, visit http://gerrit.ovirt.
Eduardo has uploaded a new change for review.
Change subject: Fix broken NFS.
..
Fix broken NFS.
self.sdUUID does not exist when self.validateFileSystemFeatures
is called.
Broken by Icf14d1c4737.
Change-Id: Iabe379eb1c422ee21d
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Probe cpu count from new libvirt capabilities.
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1158/ : SUCCESS
http:/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Probe cpu count from new libvirt capabilities.
..
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1193/ (3/3)
--
To vie
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Probe cpu count from new libvirt capabilities.
..
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1158/ (2/3)
--
To view, vis
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Probe cpu count from new libvirt capabilities.
..
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/304/ (1/3)
--
To v
Bala.FA has posted comments on this change.
Change subject: Caps: Include glusterfs packages
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11138
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: supervdsm: Fix race regarding instance ident
..
Patch Set 1: (1 inline comment)
Commit Message
Line 7: supe
Dan Kenigsberg has posted comments on this change.
Change subject: Add migration network support.
..
Patch Set 1:
Only a minor naming issue.
Please document the suggested API in
http://www.ovirt.org/Features/Migration_Network
Dan Kenigsberg has posted comments on this change.
Change subject: Add migration network support.
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
.
1 - 100 of 118 matches
Mail list logo