Roy Golan has posted comments on this change.
Change subject: catch libvirt timeout and return an error on setVmTicket
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File vdsm/libvirtvm.py
Line 2456: graphics.setAttribute('passwdValidTo', validto)
Line 2457: if graphics.getAttribute('type') == 'spice':
Line 2458: graphics.setAttribute('connected', connAct)
Line 2459: hooks.before_vm_set_ticket(self._lastXMLDesc, self.conf,
params)
Line 2460: self._dom.updateDeviceFlags(graphics.toxml(), 0)
totally right I was a bit blind on this one
Line 2461: hooks.after_vm_set_ticket(self._lastXMLDesc, self.conf,
params)
Line 2462: except TimeoutError as tmo:
Line 2463: err = errCode['internalVdsmTimeout']
Line 2464: err['exception'] = tmo
Line 2460: self._dom.updateDeviceFlags(graphics.toxml(), 0)
Line 2461: hooks.after_vm_set_ticket(self._lastXMLDesc, self.conf,
params)
Line 2462: except TimeoutError as tmo:
Line 2463: err = errCode['internalVdsmTimeout']
Line 2464: err['exception'] = tmo
add a dependency patch and put Adam, right?
Line 2465: return err
Line 2466: return {'status': doneCode}
Line 2467:
Line 2468: def _reviveTicket(self, newlife):
--
To view, visit http://gerrit.ovirt.org/10285
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb48a1baff1e059f48f71f600f4bf5d9f40a7d11
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
