Yaniv Bronhaim has uploaded a new change for review.
Change subject: Changing libvirt configure print
..
Changing libvirt configure print
Change-Id: I081a5f8f13eb035994179174c976b2c2b629b74d
Signed-off-by: Yaniv Bronhaim
Mark Wu has posted comments on this change.
Change subject: netconf: Skip source routing cfg files when restoring devices
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/17213
To unsubscribe, visit
Arik Hadas has uploaded a new change for review.
Change subject: do not rely on default values on restoreFlags invocation
..
do not rely on default values on restoreFlags invocation
The signature of libvirt's verb
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Changing libvirt configure print
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2687/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netconf: Skip source routing cfg files when restoring devices
..
Patch Set 2:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: do not rely on default values on restoreFlags invocation
..
Patch Set 1:
Build Successful
Martin Sivák has uploaded a new change for review.
Change subject: Mark ksmtuned and ksm as conflicting services in the init file
..
Mark ksmtuned and ksm as conflicting services in the init file
MoM and ksmtuned fight over
Eduardo has posted comments on this change.
Change subject: do not rely on default values on restoreFlags invocation
..
Patch Set 1:
Is a minimal libvirt version required for this feature?
--
To view, visit
Allon Mureinik has posted comments on this change.
Change subject: Remove broken getDeviceInfo().
..
Patch Set 4: Looks good to me, but someone else must approve
(1 inline comment)
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Remove unused lvm._vgmknodes().
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2690/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Remove broken getDeviceInfo().
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2691/ : SUCCESS
Arik Hadas has posted comments on this change.
Change subject: do not rely on default values on restoreFlags invocation
..
Patch Set 1:
yes but the current dependencies configuration is ok since we require libvirt
=
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Mark ksmtuned and ksm as conflicting services in the init file
..
Patch Set 1:
Build Successful
Michal Skrivanek has posted comments on this change.
Change subject: do not rely on default values on restoreFlags invocation
..
Patch Set 1:
why don't we just bump up the requirement on RHEL?
--
To view, visit
Michal Skrivanek has posted comments on this change.
Change subject: do not rely on default values on restoreFlags invocation
..
Patch Set 1:
libvirt version i meant...
--
To view, visit http://gerrit.ovirt.org/17298
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Make guest agent FQDN information available
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2693/ :
Vinzenz Feenstra has posted comments on this change.
Change subject: vdsm: Make guest agent FQDN information available
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/16572
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: multipath: Use reload option on multipath rescan
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit
Yeela Kaplan has posted comments on this change.
Change subject: clientIF: automatically unpause vms in EIO when SD becomes
active
..
Patch Set 7: Verified
--
To view, visit http://gerrit.ovirt.org/16244
To unsubscribe,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: automatically unpause vms in EIO when SD becomes
active
..
Patch Set 7:
Build Successful
Antoni Segura Puimedon has posted comments on this change.
Change subject: netconf: Skip source routing cfg files when restoring devices
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: netconf: Skip source routing cfg files when restoring devices
..
netconf: Skip source routing cfg files when restoring devices
_sortModifiedIfcfgs()
Dan Kenigsberg has posted comments on this change.
Change subject: netconf: Skip source routing cfg files when restoring devices
..
Patch Set 2: Looks good to me, approved
This recent ugly behavior is due to the source routing
Dan Kenigsberg has posted comments on this change.
Change subject: dumpStorageTable: Avoid an unnecessary traceback if vdsmd is
down.
..
Patch Set 3: Looks good to me, approved
Fix seems safe enough for ovirt-3.3. Thanks.
--
Dan Kenigsberg has submitted this change and it was merged.
Change subject: dumpStorageTable: Avoid an unnecessary traceback if vdsmd is
down.
..
dumpStorageTable: Avoid an unnecessary traceback if vdsmd is down.
When vdsmd
Dan Kenigsberg has submitted this change and it was merged.
Change subject: image: shrink the new volume When merging block cow volumes
..
image: shrink the new volume When merging block cow volumes
On merge, size of the new
Petr Šebek has posted comments on this change.
Change subject: Deleted ovirt check from vdsm-restore-net-config
..
Patch Set 3: Verified
Verified on Red Hat Enterprise Virtualization Hypervisor release 6.4
(20130528.0.el6_4).
Ayal Baron has posted comments on this change.
Change subject: Removing update of 'node.startup' setting in 'addIscsiPortal'
..
Patch Set 3: No score
After discussing with Sergey, this is to make sure to override the basic
Doron Fediuck has posted comments on this change.
Change subject: Mark ksmtuned and ksm as conflicting services in the init file
..
Patch Set 1:
Martin,
what about the code part that starts ksmtuned in vdsm?
--
To view,
Yeela Kaplan has posted comments on this change.
Change subject: do not rely on default values on restoreFlags invocation
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit
Yeela Kaplan has posted comments on this change.
Change subject: mount: Reassign mount specification in case of backup option
..
Patch Set 2: (1 inline comment)
File
Michal Skrivanek has posted comments on this change.
Change subject: do not rely on default values on restoreFlags invocation
..
Patch Set 1:
I'd prefer bump up libvirt(or just rely on it's there) since pre-alpha 6.5 and
Ayal Baron has posted comments on this change.
Change subject: mount: Reassign mount specification in case of backup option
..
Patch Set 2: No score
(1 inline comment)
File
Dan Kenigsberg has posted comments on this change.
Change subject: Deleted ovirt check from vdsm-restore-net-config
..
Patch Set 3:
Good!
--
To view, visit http://gerrit.ovirt.org/16847
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Deleted ovirt check from vdsm-restore-net-config
..
Deleted ovirt check from vdsm-restore-net-config
Check if the machine is ovirt node prevented from
Sergey Gotliv has posted comments on this change.
Change subject: Use shared lock for setStorageDomainDescription command
..
Patch Set 3: I would prefer that you didn't submit this
--
To view, visit
Sergey Gotliv has posted comments on this change.
Change subject: Use shared lock for setStorageDomainDescription command
..
Patch Set 3: No score
--
To view, visit http://gerrit.ovirt.org/17198
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: do not rely on default values on restoreFlags invocation
..
Patch Set 1: Looks good to me, approved
Since passing the argument explicitly has not been
Dan Kenigsberg has submitted this change and it was merged.
Change subject: do not rely on default values on restoreFlags invocation
..
do not rely on default values on restoreFlags invocation
The signature of libvirt's verb
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 14: Verified
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings
Martin Sivák has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 14: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe,
Lee Yarwood has abandoned this change.
Change subject: sos: collect permissions of /etc/vdsm/
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/17287
To unsubscribe, visit http://gerrit.ovirt.org/settings
Martin Sivák has posted comments on this change.
Change subject: Mark ksmtuned and ksm as conflicting services in the init file
..
Patch Set 1:
That part (clientIF.py:176) executes only when MoM fails. So I think we are
good
Eduardo has posted comments on this change.
Change subject: Remove broken getDeviceInfo().
..
Patch Set 4: (1 inline comment)
File vdsm/storage/storage_exception.py
Line
Doron Fediuck has posted comments on this change.
Change subject: Use strings when reporting VM's memory stats
..
Patch Set 9: Looks good to me, but someone else must approve
Since the mom fix was merged:
Doron Fediuck has posted comments on this change.
Change subject: Mark ksmtuned and ksm as conflicting services in the init file
..
Patch Set 1: Looks good to me, but someone else must approve
In that case, I'm fine.
Dan,
Dan Kenigsberg has posted comments on this change.
Change subject: Mark ksmtuned and ksm as conflicting services in the init file
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Doron, yes: there
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Make guest agent FQDN information available
..
Patch Set 4: Looks good to me, approved
simple patch, required to work properly with ovirt-3.3's
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm: Make guest agent FQDN information available
..
vdsm: Make guest agent FQDN information available
The FQDN value is the fully qualified domain
Dan Kenigsberg has uploaded a new change for review.
Change subject: drop ominous log for libvirt errors
..
drop ominous log for libvirt errors
Patch http://gerrit.ovirt.org/13990 has introduced a log line whenever a
libvirt
Douglas Schilling Landgraf has abandoned this change.
Change subject: virtEnabledInCpuAndBios: return status/proper msg
..
Patch Set 3: Abandoned
otopi does that.
--
To view, visit http://gerrit.ovirt.org/3549
To
Antoni Segura Puimedon has posted comments on this change.
Change subject: drop ominous log for libvirt errors
..
Patch Set 1: Looks good to me, but someone else must approve
Yes, a thousand times yes!!!
--
To view, visit
Mark Wu has posted comments on this change.
Change subject: netconf: make ifcfg's rollback cover new added networks
..
Patch Set 1: (1 inline comment)
Thanks for the review!
53 matches
Mail list logo