Ayal Baron has posted comments on this change.
Change subject: mount: Reassign mount specification in case of backup option
......................................................................
Patch Set 2: No score
(1 inline comment)
....................................................
File vdsm/storage/storageServer.py
Line 269: return
Line 270:
Line 271: backupSpec = self._getBackupSpec()
Line 272: if backupSpec:
Line 273: if mount.Mount(backupSpec,
self._mount.fs_file).isMounted():
Got it.
I have 2 different questions though:
1. does gluster support more than one backupvolfile-server option? (if so, this
wouldn't cover the case of successful mount to third host I believe)
2. does this affect connectionMonitor?
Line 274: self._mount.fs_spec = backupSpec
Line 275: else:
Line 276: self.log.warning("Mount of backup: %s to: %s failed",
Line 277: backupSpec, self._mount.fs_file)
--
To view, visit http://gerrit.ovirt.org/16534
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3166c6863dffa297bc0adcdeb4c22f810d18de8e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
