Change in vdsm[master]: gluster: Get size information of a gluster volume

2013-08-23 Thread deepakcs
Deepak C Shetty has posted comments on this change. Change subject: gluster: Get size information of a gluster volume .. Patch Set 5: Code-Review-1 (9 comments) File

Change in vdsm[master]: gluster: Get size information of a gluster volume

2013-08-23 Thread deepakcs
Deepak C Shetty has posted comments on this change. Change subject: gluster: Get size information of a gluster volume .. Patch Set 5: A general Q: IF gfapi.py is used only to query the statvfs info... the same could be

Change in vdsm[master]: gluster: Using XML output for rebalance/remove-brick status ...

2013-08-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Using XML output for rebalance/remove-brick status verbs .. Patch Set 2: Build Successful

Change in vdsm[master]: tests: vdsProxy remove need to duplicate api

2013-08-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: vdsProxy remove need to duplicate api .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4107/ : SUCCESS

Change in vdsm[master]: cleanup of vm.py

2013-08-23 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: cleanup of vm.py .. Patch Set 12: (1 comment) File vdsm/vm.py Line 1823: Line 1824:

Change in vdsm[master]: Packaging: VDSM v4.12.0 packaged on Ubuntu

2013-08-23 Thread zhshzhou
Zhou Zheng Sheng has uploaded a new change for review. Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu .. Packaging: VDSM v4.12.0 packaged on Ubuntu Add files for building VDSM .deb package on Ubuntu. vdsm-reg is not

Change in vdsm[master]: packaging: rename supervdsmServer.py to supervdsmServer and ...

2013-08-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: packaging: rename supervdsmServer.py to supervdsmServer and add environment file .. Patch Set 9: Build Successful

Change in vdsm[master]: vdsm: Load softdog if hardware watchdog is not available

2013-08-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Load softdog if hardware watchdog is not available .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4108/

Change in vdsm[master]: Add vdsm upstart jobs

2013-08-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add vdsm upstart jobs .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4110/ : SUCCESS

Change in vdsm[master]: xmlrpcTests: Detect Ubuntu initramfs when booting VM

2013-08-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: xmlrpcTests: Detect Ubuntu initramfs when booting VM .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4112/ :

Change in vdsm[master]: Packageing: Move SystemD and SysVInit files to respective su...

2013-08-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Packageing: Move SystemD and SysVInit files to respective sub-dirs .. Patch Set 4: Build Successful

Change in vdsm[master]: xmlrpcTests: Mount configfs automatically

2013-08-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: xmlrpcTests: Mount configfs automatically .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4113/ : SUCCESS

Change in vdsm[master]: Packaging: VDSM v4.12.0 packaged on Ubuntu

2013-08-23 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu .. Patch Set 1: Verified+1 Test on Ubuntu 1304. The packages can be installed on Ubuntu together with the

Change in vdsm[master]: vdsmd and supervdsmd: extract common init tasks and add init...

2013-08-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsmd and supervdsmd: extract common init tasks and add init adapter .. Patch Set 19: Build Successful

Change in vdsm[master]: Packaging: VDSM v4.12.0 packaged on Ubuntu

2013-08-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4115/ : SUCCESS

Change in vdsm[master]: xmlrpcTests: Detect Ubuntu initramfs when booting VM

2013-08-23 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: xmlrpcTests: Detect Ubuntu initramfs when booting VM .. Patch Set 3: Verified+1 No change, just rebase, no conflicts, copy scores. -- To view, visit

Change in vdsm[master]: vdsm: Load softdog if hardware watchdog is not available

2013-08-23 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: vdsm: Load softdog if hardware watchdog is not available .. Patch Set 3: Verified+1 No change, just rebase, no conflicts, copy scores. -- To view, visit

Change in vdsm[master]: xmlrpcTests: Mount configfs automatically

2013-08-23 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: xmlrpcTests: Mount configfs automatically .. Patch Set 3: Verified+1 No change, just rebase, no conflicts, copy scores. -- To view, visit

Change in vdsm[master]: gluster: Using XML output for rebalance/remove-brick status ...

2013-08-23 Thread dnarayan
ndarshan has posted comments on this change. Change subject: gluster: Using XML output for rebalance/remove-brick status verbs .. Patch Set 2: (2 comments) File

Change in vdsm[master]: Add vdsm upstart jobs

2013-08-23 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: Add vdsm upstart jobs .. Patch Set 5: Verified+1 The parent is updated so rebase this patch, no conflicts. In the new patch set, the tmpfile list is read

Change in vdsm[master]: packaging: rename supervdsmServer.py to supervdsmServer and ...

2013-08-23 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: packaging: rename supervdsmServer.py to supervdsmServer and add environment file .. Patch Set 9: Verified+1 Parent updated, rebase and solve confilcts. Test

Change in vdsm[master]: Packageing: Move SystemD and SysVInit files to respective su...

2013-08-23 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: Packageing: Move SystemD and SysVInit files to respective sub-dirs .. Patch Set 4: Verified+1 Parent updated, rebase and solve confilcts. Test on RHEL6,

Change in vdsm[master]: vdsmd and supervdsmd: extract common init tasks and add init...

2013-08-23 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: vdsmd and supervdsmd: extract common init tasks and add init adapter .. Patch Set 19: Verified+1 Update according to Alon's suggestion. In the new patch

Change in vdsm[master]: gluster: Using XML output for rebalance/remove-brick status ...

2013-08-23 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: gluster: Using XML output for rebalance/remove-brick status verbs .. Patch Set 2: (2 comments) File

Change in vdsm[master]: Add vdsm upstart jobs

2013-08-23 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Add vdsm upstart jobs .. Patch Set 5: Code-Review+1 (1 comment) File init/upstart/vdsmd.upstart.in Line 18:

Change in vdsm[master]: Packageing: Move SystemD and SysVInit files to respective su...

2013-08-23 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Packageing: Move SystemD and SysVInit files to respective sub-dirs .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/18067 To

Change in vdsm[master]: packaging: rename supervdsmServer.py to supervdsmServer and ...

2013-08-23 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: rename supervdsmServer.py to supervdsmServer and add environment file .. Patch Set 9: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/17100

Change in vdsm[master]: gluster: Using XML output for rebalance/remove-brick status ...

2013-08-23 Thread dnarayan
ndarshan has posted comments on this change. Change subject: gluster: Using XML output for rebalance/remove-brick status verbs .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/18358 To unsubscribe,

Change in vdsm[master]: vdsmd and supervdsmd: extract common init tasks and add init...

2013-08-23 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: vdsmd and supervdsmd: extract common init tasks and add init adapter .. Patch Set 19: (1 comment) Federico, Allon, can you address the comment at

Change in vdsm[master]: gluster: Using XML output for rebalance/remove-brick status ...

2013-08-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Using XML output for rebalance/remove-brick status verbs .. Patch Set 3: Build Successful

Change in vdsm[master]: gluster: Using XML output for rebalance/remove-brick status ...

2013-08-23 Thread dnarayan
ndarshan has posted comments on this change. Change subject: gluster: Using XML output for rebalance/remove-brick status verbs .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/18358 To unsubscribe,

Change in vdsm[master]: Packageing: Move SystemD and SysVInit files to respective su...

2013-08-23 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: Packageing: Move SystemD and SysVInit files to respective sub-dirs .. Patch Set 4: Code-Review+1 Thanks a lot Zhou! I asked for this and I'm very

Change in vdsm[master]: xmlrpcTests: Detect Ubuntu initramfs when booting VM

2013-08-23 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: xmlrpcTests: Detect Ubuntu initramfs when booting VM .. Patch Set 3: This patch will most likely conflict with http://gerrit.ovirt.org/#/c/17893/

Change in vdsm[master]: xmlrpcTests: refactoring

2013-08-23 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: xmlrpcTests: refactoring .. Patch Set 17: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/17893 To unsubscribe, visit

Change in vdsm[master]: tests: vdsProxy remove need to duplicate api

2013-08-23 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: tests: vdsProxy remove need to duplicate api .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/18417 To unsubscribe, visit

Change in vdsm[master]: Allow configurators to be used as context managers

2013-08-23 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: Allow configurators to be used as context managers .. Patch Set 3: Verified+1 Passes the functional tests as Giuseppe verified and I manually verified

Change in vdsm[master]: gluster: add task support

2013-08-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: add task support .. Patch Set 12: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4117/ : SUCCESS

Change in vdsm[master]: Add vdsm upstart jobs

2013-08-23 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: Add vdsm upstart jobs .. Patch Set 5: (1 comment) File init/upstart/vdsmd.upstart.in Line 18:

Change in vdsm[master]: fix getVlanID returning an int issues

2013-08-23 Thread asegurap
Antoni Segura Puimedon has uploaded a new change for review. Change subject: fix getVlanID returning an int issues .. fix getVlanID returning an int issues The fact that getVlanId now returns an int causes issues across the

Change in vdsm[master]: fix getVlanID returning an int issues

2013-08-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: fix getVlanID returning an int issues .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4118/ : SUCCESS

Change in vdsm[master]: fix getVlanID returning an int issues

2013-08-23 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: fix getVlanID returning an int issues .. Patch Set 1: Verified+1 Verified to fix the functional tests -- To view, visit http://gerrit.ovirt.org/18449

Change in vdsm[master]: fix getVlanID returning an int issues

2013-08-23 Thread apahim
Amador Pahim has posted comments on this change. Change subject: fix getVlanID returning an int issues .. Patch Set 1: Code-Review-1 (1 comment) One more in configNetwork. vdsm/API.py affected on lines 1284, 1312, 1320 and

Change in vdsm[master]: xmlrpcTests: refactoring

2013-08-23 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: xmlrpcTests: refactoring .. Patch Set 17: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/17893 To unsubscribe, visit

Change in vdsm[master]: fix getVlanID returning an int issues

2013-08-23 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: fix getVlanID returning an int issues .. Patch Set 1: vdsm/API receives the parameter as string, so it's okay there. Good catch on the not vlan though

Change in vdsm[master]: fix getVlanID returning an int issues

2013-08-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: fix getVlanID returning an int issues .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4119/ : SUCCESS

Change in vdsm[master]: fix getVlanID returning an int issues

2013-08-23 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: fix getVlanID returning an int issues .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/18449 To unsubscribe, visit

Change in vdsm[master]: fix getVlanID returning an int issues

2013-08-23 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: fix getVlanID returning an int issues .. Patch Set 2: Code-Review-1 This latter patch set makes a wrong fix. since addnetworks being called with

Change in vdsm[master]: fix getVlanID returning an int issues

2013-08-23 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: fix getVlanID returning an int issues .. Patch Set 2: Verified-1 -- To view, visit http://gerrit.ovirt.org/18449 To unsubscribe, visit

Change in vdsm[master]: fix getVlanID returning an int issues

2013-08-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: fix getVlanID returning an int issues .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4120/ : SUCCESS

Change in vdsm[master]: fix getVlanID returning an int issues

2013-08-23 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: fix getVlanID returning an int issues .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/18449 To unsubscribe, visit

Change in vdsm[master]: fix getVlanID returning an int issues

2013-08-23 Thread apahim
Amador Pahim has posted comments on this change. Change subject: fix getVlanID returning an int issues .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/18449 To unsubscribe, visit

Change in vdsm[master]: [3/3] Use fixed getVlanDevice() and getVlanID().

2013-08-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: [3/3] Use fixed getVlanDevice() and getVlanID(). .. Patch Set 4: Amador: given the sad facts of http://gerrit.ovirt.org/18449 how come this patch was

Change in vdsm[master]: fix getVlanID returning an int issues

2013-08-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: fix getVlanID returning an int issues .. Patch Set 3: Code-Review-1 It's too bad that http://gerrit.ovirt.org/18182/ got in with no unit or functional test

Change in vdsm[master]: fix getVlanID returning an int issues

2013-08-23 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: fix getVlanID returning an int issues .. Patch Set 3: The functional tests reveal the problems I'm fixing here. I'd say that at the moment this was

Change in vdsm[master]: fix getVlanID returning an int issues

2013-08-23 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: fix getVlanID returning an int issues .. fix getVlanID returning an int issues The fact that getVlanId now returns an int causes issues across the

Change in vdsm[master]: fix getVlanID returning an int issues

2013-08-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: fix getVlanID returning an int issues .. Patch Set 3: Code-Review+2 Thanks, Toni. -- To view, visit http://gerrit.ovirt.org/18449 To unsubscribe, visit

Change in vdsm[master]: jenkins operstate fix?

2013-08-23 Thread asegurap
Antoni Segura Puimedon has uploaded a new change for review. Change subject: jenkins operstate fix? .. jenkins operstate fix? Change-Id: Ice38f15d9c0b96ca6fc826e8912427a17b86d783 Signed-off-by: Antoni S. Puimedon

Change in vdsm[master]: jenkins operstate fix?

2013-08-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: jenkins operstate fix? .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4121/ : SUCCESS

Change in vdsm[master]: jenkins operstate fix?

2013-08-23 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: jenkins operstate fix? .. Patch Set 1: Verified-1 Nah... Doesn't fix it. I didn't think so anyway... -- To view, visit http://gerrit.ovirt.org/18452