Sergey Gotliv has posted comments on this change.
Change subject: utils: Add unhandled exceptions logging decorator
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21778
To unsubscribe, visit http://ger
Mark Wu has posted comments on this change.
Change subject: netconf: provide a default rollback for configurators
..
Patch Set 4:
it needs a rebase on d4737dd40 to resolve the 'defaultdict' regression.
--
To view, visit http:
Martin Polednik has posted comments on this change.
Change subject: tests/functional/virt: drop ever-failing test
..
Patch Set 1: Code-Review-1
The previous test implementation always required that the system initramfs will
ha
Darshan N has posted comments on this change.
Change subject: gluster: correct parameter for creating hookpath in verb
hookAdd.
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/21538
To unsubscribe, visit
Zhou Zheng Sheng has posted comments on this change.
Change subject: package: allow redefine user and group as configure options
..
Patch Set 2: Code-Review-1
(2 comments)
F
Dan Kenigsberg has submitted this change and it was merged.
Change subject: storage: drop an unused configurable sd_validate_timeout
..
storage: drop an unused configurable sd_validate_timeout
Change-Id: Ic77b0a6f71f40fc0f3c0b5
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests/functional/virt: drop ever-failing test
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4991/ : SUCCESS
Dan Kenigsberg has uploaded a new change for review.
Change subject: tests/functional/virt: drop ever-failing test
..
tests/functional/virt: drop ever-failing test
testInitramfsReadable always fails when run on Fedora. Why would
Federico Simoncelli has posted comments on this change.
Change subject: storage: drop an unused configurable sd_validate_timeout
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21060
To unsubscribe, vis
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: drop unused MigrationSourceThreadClass abstraction
..
vm: drop unused MigrationSourceThreadClass abstraction
Since the libvirtvm.py merger into vm.
Dan Kenigsberg has posted comments on this change.
Change subject: vm: drop unused MigrationSourceThreadClass abstraction
..
Patch Set 1: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21560
To unsubscribe,
Dan Kenigsberg has posted comments on this change.
Change subject: sampling: take storageDomains directly from storage subsys
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/21334
To unsubscribe, visit htt
Dan Kenigsberg has posted comments on this change.
Change subject: storage: drop an unused configurable sd_validate_timeout
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/21060
To unsubscribe, visit http:
Federico Simoncelli has posted comments on this change.
Change subject: utils: Add unhandled exceptions logging decorator
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21778
To unsubscribe, visit http
Federico Simoncelli has posted comments on this change.
Change subject: hsm: Log unhandled exceptions in storage refresh thread
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21486
To unsubscribe, visi
Federico Simoncelli has posted comments on this change.
Change subject: sp: remove the getFormat method
..
Patch Set 3:
> why? Until we get rid of the whole thing Format is actually the correct
> terminology (vs. the old 'vers
Ayal Baron has posted comments on this change.
Change subject: sd: add inquireClusterLock method to StorageDomain
..
Patch Set 2: Code-Review+1
(1 comment)
Commit Message
Li
Dan Kenigsberg has abandoned this change.
Change subject: split xmlrpcTests.py
..
Abandoned
Martin Polednik has done this several months ago.
--
To view, visit http://gerrit.ovirt.org/11385
To unsubscribe, visit http://gerrit
Dan Kenigsberg has posted comments on this change.
Change subject: utils: Add unhandled exceptions logging decorator
..
Patch Set 4: Code-Review+1
(1 comment)
File tests/uti
Ayal Baron has posted comments on this change.
Change subject: sp: move validatePoolSD in the StoragePool class
..
Patch Set 3:
(2 comments)
File vdsm/storage/hsm.py
Line 13
Ayal Baron has posted comments on this change.
Change subject: sp: refresh metadata on hsm when listing domains
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21786
To unsubscribe, visit http://gerrit.
Ayal Baron has posted comments on this change.
Change subject: sp: remove the getFormat method
..
Patch Set 3:
why?
Until we get rid of the whole thing Format is actually the correct terminology
(vs. the old 'version').
--
T
Dan Kenigsberg has posted comments on this change.
Change subject: clientIF: Fix use of getConfDevices
..
Patch Set 2:
Martin, please verify this fix by adding a functional test that starts a VM,
kills vdsm, and verifies recov
Ayal Baron has posted comments on this change.
Change subject: sp: remove unused recoveryMode from spmStart
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21556
To unsubscribe, visit http://gerrit.ovir
Ayal Baron has posted comments on this change.
Change subject: sp: remove unused scsiFencing parameter
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21555
To unsubscribe, visit http://gerrit.ovirt.org
Dan Kenigsberg has submitted this change and it was merged.
Change subject: fix selinux dependency
..
fix selinux dependency
Fix a typo in the release field, introduced by commit 68d44c613.
Change-Id: I627deb840d2351b48c19eb7d
Dan Kenigsberg has posted comments on this change.
Change subject: fix selinux dependency
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21284
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ge
Ayal Baron has posted comments on this change.
Change subject: sp: add setMasterDomain to StoragePool
..
Patch Set 4:
1. I've never noticed this
2. You failed to explain that connectStoragePool returns true if you're already
c
Ayal Baron has posted comments on this change.
Change subject: sp: encapsulate spm status in StoragePool
..
Patch Set 6:
(1 comment)
File vdsm/storage/sp.py
Line 145:
Line
Sergey Gotliv has posted comments on this change.
Change subject: Fix getStorageDomainInfo() logic.
..
Patch Set 2:
I am wrong, the backport should be done to downstream!
--
To view, visit http://gerrit.ovirt.org/20209
To uns
Sergey Gotliv has posted comments on this change.
Change subject: Fix getStorageDomainInfo() logic.
..
Patch Set 2:
Ayal,
Please, check this bug, and Eduardo's latest comment:
https://bugzilla.redhat.com/show_bug.cgi?id=10339
Sergey Gotliv has posted comments on this change.
Change subject: Fix getStorageDomainInfo() logic.
..
Patch Set 2:
Ayal,
Did you check the bug I mentioned above?
--
To view, visit http://gerrit.ovirt.org/20209
To unsubscrib
Ayal Baron has posted comments on this change.
Change subject: Fix getStorageDomainInfo() logic.
..
Patch Set 2: Verified-1 Code-Review-1
This patch will break 3.3 as it expects pool.getInfo to return the info without
the 'inf
Dan Kenigsberg has submitted this change and it was merged.
Change subject: netinfo: fix defaultdict regression
..
netinfo: fix defaultdict regression
netinfo.get is supposed to retun a map containing the keys:
- bondings
- bri
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: fix defaultdict regression
..
Patch Set 1: Code-Review+2
I'm taking the quick fix, but you owe me a unit test that would have exposed
the bug.
--
To
Alon Bar-Lev has posted comments on this change.
Change subject: package: allow redefine user and group as configure options
..
Patch Set 2:
(1 comment)
File configure.ac
Li
Yaniv Bronhaim has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 4:
(1 comment)
looks good to me.
File client/v
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: add setMasterDomain to StoragePool
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4990/ : SUCCESS
http:
Yaniv Bronhaim has posted comments on this change.
Change subject: Reorder limit checks in grow quest
..
Patch Set 3: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21765
To unsubscribe, visit http://gerrit
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: Reorder limit checks in grow quest
..
Reorder limit checks in grow quest
balloon_min is a computed value that can (and will) go over
balloon_max. When
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: remove unused scsiFencing parameter
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4987/ : SUCCESS
http
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: remove scsiKey from connectStoragePool
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4989/ : SUCCESS
h
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: encapsulate spm status in StoragePool
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4988/ : SUCCESS
ht
Yaniv Bronhaim has posted comments on this change.
Change subject: fix selinux dependency
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21284
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ge
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: remove unused recoveryMode from spmStart
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4985/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sd: add inquireClusterLock method to StorageDomain
..
Patch Set 2: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/498
Assaf Muller has posted comments on this change.
Change subject: netinfo: fix defaultdict regression
..
Patch Set 1: Code-Review+1
Investigated into it and talked to Toni. I took a lot of time to get a host
running with no net
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: move reconnection info check to StoragePool
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4984/ : SUCCE
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm.spec: conditional for hostname require
..
Patch Set 8:
CommandPath is just a waist of running time imo btw..
--
To view, visit http://gerrit.ovirt.org/21
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: refresh metadata on hsm when listing domains
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4981/ : SUCC
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: move validatePoolSD in the StoragePool class
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4982/ : SUCC
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: remove the getFormat method
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4983/ : SUCCESS
http://jenki
Yaniv Bronhaim has posted comments on this change.
Change subject: package: allow redefine user and group as configure options
..
Patch Set 2:
(1 comment)
File configure.ac
Yaniv Bronhaim has posted comments on this change.
Change subject: Allow setting just a single value in MoM policy
..
Patch Set 1:
(1 comment)
nit comment.
Commit Message
L
Assaf Muller has posted comments on this change.
Change subject: netinfo: fix defaultdict regression
..
Patch Set 1:
I did test the offending patch on a machine with no networks (Remember I had
trouble with libvirt and removin
Martin Polednik has posted comments on this change.
Change subject: clientIF: Fix use of getConfDevices
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21832
To unsubscribe, visit http://gerrit.ovirt.or
Antoni Segura Puimedon has posted comments on this change.
Change subject: netinfo: fix defaultdict regression
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/21850
To unsubscribe, visit http://gerrit.ovir
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: fix defaultdict regression
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4980/ : SUCCESS
http://j
Federico Simoncelli has posted comments on this change.
Change subject: clientIF: Fix use of getConfDevices
..
Patch Set 2:
(1 comment)
File vdsm/clientIF.py
Line 454:
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: netinfo: fix defaultdict regression
..
netinfo: fix defaultdict regression
netinfo.get is supposed to retun a map containing the keys:
- bondings
- bri
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Revert "Ubuntu: make hard coded group names configurable in
configurator.py"
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vd
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Revert "Introducing configurator package in vdsm-tool"
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4979/
Amador Pahim has posted comments on this change.
Change subject: Allow setting just a single value in MoM policy
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21839
To unsubscribe, visit http://gerrit
Federico Simoncelli has uploaded a new change for review.
Change subject: Revert "Introducing configurator package in vdsm-tool"
..
Revert "Introducing configurator package in vdsm-tool"
This reverts commit 89d70a90288ba233eb760
Federico Simoncelli has uploaded a new change for review.
Change subject: Revert "Ubuntu: make hard coded group names configurable in
configurator.py"
..
Revert "Ubuntu: make hard coded group names configurable in configurator.p
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netconf: provide a default rollback for configurators
..
Patch Set 4: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netconfpersistence: add diffing method to Config
..
Patch Set 5: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4975/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netconf: define rollback contract at internal API
..
Patch Set 5: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4976
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netconf: provide a default rollback for configurators
..
Patch Set 3: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netconfpersistence: add diffing method to Config
..
Patch Set 4: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4973/
Michal Skrivanek has posted comments on this change.
Change subject: clientIF: Fix use of getConfDevices
..
Patch Set 2: Code-Review+1
ugh.
Yes, the tests should cover recovery. Well, The recovery should actually be
fixed to
oVirt Jenkins CI Server has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4972/ : SUCCESS
Doron Fediuck has posted comments on this change.
Change subject: Reorder limit checks in grow quest
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21765
To unsubscribe, visit http://gerrit.ovirt.org/s
Doron Fediuck has posted comments on this change.
Change subject: Allow setting just a single value in MoM policy
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21839
To unsubscribe, visit http://gerri
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netconf: define rollback contract at internal API
..
Patch Set 4: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4971
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: Fix use of getConfDevices
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4970/ : SUCCESS
http://j
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm.spec: conditional for hostname require
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_3.3_install_rpm_sanity_gerrit/308/ : S
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netconfpersistence: add diffing method to Config
..
Patch Set 3: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4967/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netconf: define rollback contract at internal API
..
Patch Set 3: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4968
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netconf: provide a default rollback for configurators
..
Patch Set 2: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: vdsm.spec: conditional for hostname require
..
vdsm.spec: conditional for hostname require
Fedora rawhide (F21) build is failing because cannot locate
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm.spec: conditional for hostname require
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21840
To unsubscribe, visit http://gerrit.o
Nir Soffer has posted comments on this change.
Change subject: fix selinux dependency
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21284
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: fix selinux dependency
..
Patch Set 2: Verified+1 Code-Review+1
Affecting:
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/label
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netconf: differentiate between MEMORY and PERSISTENT rollback
..
Patch Set 2: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_ge
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netconf: differentiate between MEMORY and PERSISTENT rollback
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_ge
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: netconf: differentiate between MEMORY and PERSISTENT rollback
..
netconf: differentiate between MEMORY and PERSISTENT rollback
The change:
"netconf
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm.spec: conditional for hostname require
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_3.3_install_rpm_sanity_gerrit/307/ : S
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec: conditional for hostname require
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/21840
To unsubscribe, visit http:/
Hello Bala.FA, Yaniv Bronhaim, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/21840
to review the following change.
Change subject: vdsm.spec: conditional for hostname require
..
vd
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm.spec: conditional to execute semanage
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_3.3_install_rpm_sanity_gerrit/306/ : SU
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm.spec: conditional for hostname require
..
Patch Set 8:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/56/ : FAI
Martin Sivák has posted comments on this change.
Change subject: Reorder limit checks in grow quest
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/21765
To unsubscribe, visit http://gerrit.ovirt.org/setti
Martin Sivák has posted comments on this change.
Change subject: Allow setting just a single value in MoM policy
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/21839
To unsubscribe, visit http://gerrit.ov
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm.spec: conditional to execute semanage
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_3.3_install_rpm_sanity_gerrit/305/ : SU
Hello Doron Fediuck, Amador Pahim, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/21839
to review the following change.
Change subject: Allow setting just a single value in MoM policy
..
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Revert "fix premature selinux dependency"
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_3.3_install_rpm_sanity_gerrit/304/ : SUC
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm.spec: conditional to execute semanage
..
Patch Set 3: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21830
To unsubscribe, visit http:
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: vdsm.spec: conditional to execute semanage
..
vdsm.spec: conditional to execute semanage
To avoid load policy when selinux is disabled, only
execute se
Yaniv Bronhaim has posted comments on this change.
Change subject: Revert "fix premature selinux dependency"
..
Patch Set 4: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/20760
To unsubscribe, visit http:/
1 - 100 of 178 matches
Mail list logo
