Ayal Baron has posted comments on this change. Change subject: sp: encapsulate spm status in StoragePool ......................................................................
Patch Set 6: (1 comment) .................................................... File vdsm/storage/sp.py Line 145: Line 146: return poolMeta[PMDK_LVER], poolMeta[PMDK_SPM_ID] Line 147: Line 148: def setSpmStatus(self, lVer, spmId): Line 149: self.invalidateMetadata() why are you invalidating here? if this is secured then our md should not be stale and if overriding then it's caller's responsibility to invalidate? Line 150: # this method must be secured (as it changes the pool metadata), Line 151: # but since it is also used during the SPM status transition by Line 152: # default we override the security for setMetaParams. Line 153: # NOTE: this introduces a race when the method is used in the -- To view, visit http://gerrit.ovirt.org/21527 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b71349e2a0dfc453b68cd2d9ca6c563b1bee90c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
