Change in vdsm[master]: supervdsmServer: Run sourceRouteThread in a thread

2013-12-25 Thread abaron
Ayal Baron has posted comments on this change. Change subject: supervdsmServer: Run sourceRouteThread in a thread .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22718 To unsubscribe, visit http://gerri

Change in vdsm[master]: hsm: Check all devices visibility after multipath rescan

2013-12-25 Thread abaron
Ayal Baron has posted comments on this change. Change subject: hsm: Check all devices visibility after multipath rescan .. Patch Set 5: Code-Review+2 u -- To view, visit http://gerrit.ovirt.org/21182 To unsubscribe, visit htt

Change in vdsm[ovirt-3.3]: fileSD: Fix image deletion on gluster domain

2013-12-25 Thread abaron
Ayal Baron has posted comments on this change. Change subject: fileSD: Fix image deletion on gluster domain .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22563 To unsubscribe, visit http://gerrit.ovir

Change in vdsm[master]: clientIF: Rescan devices if device not found after vmHotplug...

2013-12-25 Thread abaron
Ayal Baron has posted comments on this change. Change subject: clientIF: Rescan devices if device not found after vmHotplugDisk .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21181 To unsubscribe, visi

Change in vdsm[master]: hsm: Do not hide errors when checking device visibility

2013-12-25 Thread abaron
Ayal Baron has posted comments on this change. Change subject: hsm: Do not hide errors when checking device visibility .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21211 To unsubscribe, visit http://

Change in vdsm[master]: Revert "clientIF: rescan devices on failed hotplugDisk"

2013-12-25 Thread abaron
Ayal Baron has posted comments on this change. Change subject: Revert "clientIF: rescan devices on failed hotplugDisk" .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21173 To unsubscribe, visit http://

Change in vdsm[master]: Unified net persistence upgrade: Change 'bridged' from str t...

2013-12-25 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: Unified net persistence upgrade: Change 'bridged' from str to bool .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22721 To un

Change in vdsm[ovirt-3.3]: fileSD: Fix image deletion on gluster domain

2013-12-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: fileSD: Fix image deletion on gluster domain .. Patch Set 1: @Nir - yes - please open one. -- To view, visit http://gerrit.ovirt.org/22563 To unsubscribe, vis

Change in vdsm[master]: sourceRouteThread: log unhandled exceptions

2013-12-25 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: sourceRouteThread: log unhandled exceptions .. Patch Set 3: -Code-Review Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6379/ :

Change in vdsm[master]: sourceRouteThread: Encapsulate inotify thread

2013-12-25 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: sourceRouteThread: Encapsulate inotify thread .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22723 To unsubscribe, visit http:

Change in vdsm[master]: supervdsmServer: Run sourceRouteThread in a thread

2013-12-25 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: supervdsmServer: Run sourceRouteThread in a thread .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22718 To unsubscribe, visit

Change in vdsm[master]: supervdsmServer: Cleaner way to wait for signals

2013-12-25 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: supervdsmServer: Cleaner way to wait for signals .. Patch Set 2: Code-Review+1 Makes more sense to me now ;-) -- To view, visit http://gerrit.ovirt.or

Change in vdsm[master]: sp: remove scsiKey from connectStoragePool

2013-12-25 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: sp: remove scsiKey from connectStoragePool .. Patch Set 7: Code-Review-1 -1 for visibility. -- To view, visit http://gerrit.ovirt.org/21557 To unsubscribe, vi

Change in vdsm[master]: link monitor: do not leave stray `ip monitor` behind

2013-12-25 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: link monitor: do not leave stray `ip monitor` behind .. link monitor: do not leave stray `ip monitor` behind ipwrapper.Monitor.start() spawns an `ip mo

Change in vdsm[master]: link monitor: do not leave stray `ip monitor` behind

2013-12-25 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: link monitor: do not leave stray `ip monitor` behind .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22667 To unsubscribe, visit http:/

Change in vdsm[master]: supervdsmServer: Run sourceRouteThread in a thread

2013-12-25 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: supervdsmServer: Run sourceRouteThread in a thread .. Patch Set 3: -Code-Review Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/

Change in vdsm[master]: supervdsmServer: Cleaner way to wait for signals

2013-12-25 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: supervdsmServer: Cleaner way to wait for signals .. Patch Set 2: -Code-Review Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/63

Change in vdsm[master]: clientIF: Rescan devices if device not found after vmHotplug...

2013-12-25 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: clientIF: Rescan devices if device not found after vmHotplugDisk .. Patch Set 7: -Code-Review Build Successful http://jenkins.ovirt.org/job/vdsm_unit

Change in vdsm[master]: hsm: Do not hide errors when checking device visibility

2013-12-25 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: hsm: Do not hide errors when checking device visibility .. Patch Set 5: -Code-Review Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_ge

Change in vdsm[master]: hsm: Check all devices visibility after multipath rescan

2013-12-25 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: hsm: Check all devices visibility after multipath rescan .. Patch Set 5: -Code-Review Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_g

Change in vdsm[master]: Revert "clientIF: rescan devices on failed hotplugDisk"

2013-12-25 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Revert "clientIF: rescan devices on failed hotplugDisk" .. Patch Set 5: -Code-Review Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_ge

Change in vdsm[master]: Checking pep8 on jenkins

2013-12-25 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Checking pep8 on jenkins .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6386/ : FAILURE http://jenkins.ovirt.org/j

Change in vdsm[master]: sourceRouteThread: Encapsulate inotify thread

2013-12-25 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: sourceRouteThread: Encapsulate inotify thread .. Patch Set 3: -Code-Review Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6384/

Change in vdsm[master]: Checking pep8 on jenkins

2013-12-25 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Checking pep8 on jenkins .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6386/ : FAILURE http://jenkins.ovirt.org/j

Change in vdsm[master]: hsm: Do not hide errors when checking device visibility

2013-12-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: hsm: Do not hide errors when checking device visibility .. Patch Set 5: Verified+1 Verified sanity storage and vm flows on ISCSI environment. -- To view, visit ht

Change in vdsm[master]: clientIF: Rescan devices if device not found after vmHotplug...

2013-12-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: clientIF: Rescan devices if device not found after vmHotplugDisk .. Patch Set 7: Verified+1 Verified sanity storage and vm flows on ISCSI environment. -- To view,

Change in vdsm[master]: hsm: Check all devices visibility after multipath rescan

2013-12-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: hsm: Check all devices visibility after multipath rescan .. Patch Set 5: Verified+1 Verified sanity storage and vm flows on ISCSI environment. -- To view, visit h

Change in vdsm[master]: Revert "clientIF: rescan devices on failed hotplugDisk"

2013-12-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Revert "clientIF: rescan devices on failed hotplugDisk" .. Patch Set 5: Verified+1 Verified sanity storage and vm flows on ISCSI environment. -- To view, visit ht

Change in vdsm[master]: Checking pep8 on jenkins

2013-12-25 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Checking pep8 on jenkins .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6386/ : FAILURE http://jenkins.ovirt.org/j

Change in vdsm[master]: supervdsmServer: Cleaner way to wait for signals

2013-12-25 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: supervdsmServer: Cleaner way to wait for signals .. Patch Set 2: Code-Review-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/638

Change in vdsm[master]: supervdsmServer: Cleaner way to wait for signals

2013-12-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: supervdsmServer: Cleaner way to wait for signals .. Patch Set 2: Fix pep8 whitespace and rebase on master, separating from unrelated networking patches. -- To vi

Change in vdsm[master]: sourceRouteThread: Encapsulate inotify thread

2013-12-25 Thread amuller
Assaf Muller has posted comments on this change. Change subject: sourceRouteThread: Encapsulate inotify thread .. Patch Set 3: (1 comment) File vdsm/sourceRouteThread.py Lin

Change in vdsm[master]: sourceRouteThread: Encapsulate inotify thread

2013-12-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sourceRouteThread: Encapsulate inotify thread .. Patch Set 3: Removed the assert when starting the thread per Assaf request, and for separating refactoring and beh

Change in vdsm[master]: sourceRouteThread: Encapsulate inotify thread

2013-12-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sourceRouteThread: Encapsulate inotify thread .. Patch Set 3: Rebase on http://gerrit.ovirt.org/22718 to remove the unneeded dependency on http://gerrit.ovirt.org/

Change in vdsm[master]: sourceRouteThread: Encapsulate inotify thread

2013-12-25 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: sourceRouteThread: Encapsulate inotify thread .. Patch Set 3: Code-Review-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6384/

Change in vdsm[master]: sourceRouteThread: Encapsulate inotify thread

2013-12-25 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: sourceRouteThread: Encapsulate inotify thread .. Patch Set 2: Code-Review-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6382/

Change in vdsm[master]: supervdsmServer: Run sourceRouteThread in a thread

2013-12-25 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: supervdsmServer: Run sourceRouteThread in a thread .. Patch Set 3: Code-Review-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6

Change in vdsm[master]: supervdsmServer: Run sourceRouteThread in a thread

2013-12-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: supervdsmServer: Run sourceRouteThread in a thread .. Patch Set 3: Rebase on http://gerrit.ovirt.org/22670 to fix unhandled exceptions. -- To view, visit http://g

Change in vdsm[master]: link monitor: do not leave stray `ip monitor` behind

2013-12-25 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: link monitor: do not leave stray `ip monitor` behind .. Patch Set 2: Build Unstable http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1097/

Change in vdsm[master]: sourceRouteThread: log unhandled exceptions

2013-12-25 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: sourceRouteThread: log unhandled exceptions .. Patch Set 3: Code-Review-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6276/ : UNSTAB

Change in vdsm[master]: supervdsmServer: Run sourceRouteThread in a thread

2013-12-25 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: supervdsmServer: Run sourceRouteThread in a thread .. Patch Set 2: Code-Review-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6

Change in vdsm[master]: [1/2] getVdsCaps returns client iface for *current* connection

2013-12-25 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: [1/2] getVdsCaps returns client iface for *current* connection .. Patch Set 2: Code-Review-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_unit_te

Change in vdsm[master]: [1/2] getVdsCaps returns client iface for *current* connection

2013-12-25 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: [1/2] getVdsCaps returns client iface for *current* connection .. Patch Set 1: Code-Review-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_unit_te

Change in vdsm[master]: getVdsCaps returns client iface for *current* connection

2013-12-25 Thread amuller
Assaf Muller has uploaded a new change for review. Change subject: getVdsCaps returns client iface for *current* connection .. getVdsCaps returns client iface for *current* connection Previously getVdsCaps took server and client

Change in vdsm[master]: sourceRouteThread: log unhandled exceptions

2013-12-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sourceRouteThread: log unhandled exceptions .. Patch Set 3: Rebased on master, to make it easier to rebase http://gerrit.ovirt.org/22718 on this patch. -- To vie

Change in vdsm[master]: link monitor: do not leave stray `ip monitor` behind

2013-12-25 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: link monitor: do not leave stray `ip monitor` behind .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22667 To unsubscribe, visit http:/

Change in vdsm[ovirt-3.3]: fileSD: Fix image deletion on gluster domain

2013-12-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: fileSD: Fix image deletion on gluster domain .. Patch Set 1: We don't have a bug - add one? -- To view, visit http://gerrit.ovirt.org/22563 To unsubscribe, visit

Change in vdsm[ovirt-3.3]: fileSD: Fix image deletion on gluster domain

2013-12-25 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: fileSD: Fix image deletion on gluster domain .. Patch Set 1: please add bz url -- To view, visit http://gerrit.ovirt.org/22563 To unsubscribe, visit http://ge

Change in vdsm[ovirt-3.3]: fileSD: Fix image deletion on gluster domain

2013-12-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: fileSD: Fix image deletion on gluster domain .. Patch Set 1: Verified also on NFS. -- To view, visit http://gerrit.ovirt.org/22563 To unsubscribe, visit http://ge

Change in vdsm[master]: hsm: Fix race when checking visible devices readability

2013-12-25 Thread nsoffer
Nir Soffer has abandoned this change. Change subject: hsm: Fix race when checking visible devices readability .. Abandoned Replaced by http://gerrit.ovirt.org/21182 -- To view, visit http://gerrit.ovirt.org/21053 To unsubscri

Change in vdsm[master]: hsm: Remove uneeded public annotation

2013-12-25 Thread nsoffer
Nir Soffer has abandoned this change. Change subject: hsm: Remove uneeded public annotation .. Abandoned Replaced by http://gerrit.ovirt.org/21173 -- To view, visit http://gerrit.ovirt.org/21167 To unsubscribe, visit http://g

Change in vdsm[master]: hsm: Rescan multipath if device is missing when scanning dev...

2013-12-25 Thread nsoffer
Nir Soffer has abandoned this change. Change subject: hsm: Rescan multipath if device is missing when scanning devices .. Abandoned Replaced with http://gerrit.ovirt.org/21181 -- To view, visit http://gerrit.ovirt.org/20942 T

Change in vdsm[master]: clientIF: Rescan devices if device not found after vmHotplug...

2013-12-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: clientIF: Rescan devices if device not found after vmHotplugDisk .. Patch Set 7: Rebased over fixed commit - no code change. -- To view, visit http://gerrit.ovirt

Change in vdsm[master]: hsm: Do not hide errors when checking device visibility

2013-12-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: hsm: Do not hide errors when checking device visibility .. Patch Set 5: Ignore previous comments. This version fix a typo in errno name. -- To view, visit http://

Change in vdsm[master]: hsm: Do not hide errors when checking device visibility

2013-12-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: hsm: Do not hide errors when checking device visibility .. Patch Set 5: Rebased over fixed commit - no code change. -- To view, visit http://gerrit.ovirt.org/2121

Change in vdsm[master]: clientIF: Rescan devices if device not found after vmHotplug...

2013-12-25 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: clientIF: Rescan devices if device not found after vmHotplugDisk .. Patch Set 7: Code-Review-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_unit_

Change in vdsm[master]: hsm: Do not hide errors when checking device visibility

2013-12-25 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: hsm: Do not hide errors when checking device visibility .. Patch Set 5: Code-Review-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_unit_tests_ger

Change in vdsm[master]: Revert "clientIF: rescan devices on failed hotplugDisk"

2013-12-25 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Revert "clientIF: rescan devices on failed hotplugDisk" .. Patch Set 5: Code-Review-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_unit_tests_ger

Change in vdsm[master]: hsm: Check all devices visibility after multipath rescan

2013-12-25 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: hsm: Check all devices visibility after multipath rescan .. Patch Set 5: Code-Review-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_unit_tests_ge

Change in vdsm[master]: hsm: Check all devices visibility after multipath rescan

2013-12-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: hsm: Check all devices visibility after multipath rescan .. Patch Set 5: Rebased over modified commit - no code change. -- To view, visit http://gerrit.ovirt.org/

Change in vdsm[master]: Revert "clientIF: rescan devices on failed hotplugDisk"

2013-12-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Revert "clientIF: rescan devices on failed hotplugDisk" .. Patch Set 5: This version remove the getDeviceInfo method that was removed few month ago, and sneaked in

Change in vdsm[master]: link monitor: do not leave stray `ip monitor` behind

2013-12-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: link monitor: do not leave stray `ip monitor` behind .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22667 To unsubscribe, visit http://ger

Change in vdsm[master]: link monitor: do not leave stray `ip monitor` behind

2013-12-25 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: link monitor: do not leave stray `ip monitor` behind .. Patch Set 2: Code-Review-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_network_functiona

Change in vdsm[master]: link monitor: do not leave stray `ip monitor` behind

2013-12-25 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: link monitor: do not leave stray `ip monitor` behind .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/22667 To unsubscribe, visit http://ge

Change in vdsm[master]: link monitor: do not leave stray `ip monitor` behind

2013-12-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: link monitor: do not leave stray `ip monitor` behind .. Patch Set 1: (1 comment) File lib/vdsm/utils.py Line 5

Change in vdsm[master]: link monitor: do not leave stray `ip monitor` behind

2013-12-25 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: link monitor: do not leave stray `ip monitor` behind .. Patch Set 1: (1 comment) File lib/vdsm/utils.py Li

Change in vdsm[master]: Checking pep8 on jenkins

2013-12-25 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Checking pep8 on jenkins .. Patch Set 5: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5479/ : FAILURE

Change in vdsm[master]: Checking pep8 on jenkins

2013-12-25 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Checking pep8 on jenkins .. Patch Set 4: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5478/ : FAILURE

Change in vdsm[master]: Checking pep8 on jenkins

2013-12-25 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Checking pep8 on jenkins .. Patch Set 3: Code-Review-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5477/ : SUCCESS http://

Change in vdsm[master]: Checking pep8 on jenkins

2013-12-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Checking pep8 on jenkins .. Patch Set 4: Add back the pep8 violation in vdsm script. This is currently ignored by pep8 --diff. -- To view, visit http://gerrit.ov

Change in vdsm[master]: Checking pep8 on jenkins

2013-12-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Checking pep8 on jenkins .. Patch Set 3: Previous patch modified file without .py suffix, which is ignored by pep8 --diff. -- To view, visit http://gerrit.ovirt.

Change in vdsm[master]: Checking pep8 on jenkins

2013-12-25 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Checking pep8 on jenkins .. Patch Set 2: Code-Review-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5476/ : SUCCESS http://

Change in vdsm[master]: Checking pep8 on jenkins

2013-12-25 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Checking pep8 on jenkins .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5475/ : FAILURE http://jenkins.ovirt.or

Change in vdsm[master]: link monitor: do not leave stray `ip monitor` behind

2013-12-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: link monitor: do not leave stray `ip monitor` behind .. Patch Set 1: (1 comment) File lib/vdsm/utils.py Line 5

Change in vdsm[master]: sp: remove unused scsiFencing parameter

2013-12-25 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: sp: remove unused scsiFencing parameter .. sp: remove unused scsiFencing parameter Change-Id: I7d9b62c08cf8925fbc1856655dc49dd41eacd2d9 Signed-off-by:

Change in vdsm[master]: sp: remove unused recoveryMode from spmStart

2013-12-25 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: sp: remove unused recoveryMode from spmStart .. sp: remove unused recoveryMode from spmStart Change-Id: I4be0a2aad270e87cf6a83f8b1fd36d928312104e Signe

Change in vdsm[master]: sourceRouteThread: Encapsulate inotify thread

2013-12-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sourceRouteThread: Encapsulate inotify thread .. Patch Set 1: (5 comments) Asaf - the comments regarding DHClientEventHandler are relevant because we run now in a

Change in vdsm[master]: sourceRouteThread: Encapsulate inotify thread

2013-12-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sourceRouteThread: Encapsulate inotify thread .. Patch Set 1: > Seeing as http://gerrit.ovirt.org/#/c/22718/ is a subset of this patch, could > you please abandon

Change in vdsm[master]: link monitor: do not leave stray `ip monitor` behind

2013-12-25 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: link monitor: do not leave stray `ip monitor` behind .. Patch Set 1: (1 comment) File lib/vdsm/utils.py Li

Change in vdsm[master]: link monitor: do not leave stray `ip monitor` behind

2013-12-25 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: link monitor: do not leave stray `ip monitor` behind .. Patch Set 1: (1 comment) just a question . but +1 except that

Change in vdsm[master]: clientIF: Rescan devices if device not found after vmHotplug...

2013-12-25 Thread abaron
Ayal Baron has posted comments on this change. Change subject: clientIF: Rescan devices if device not found after vmHotplugDisk .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21181 To unsubscribe, visi

Change in vdsm[master]: tests: janitorial: cleanup temporary directories

2013-12-25 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: janitorial: cleanup temporary directories .. tests: janitorial: cleanup temporary directories A few tests don't cleanup the temporary directorie

Change in vdsm[master]: clientIF: Rescan devices if device not found after vmHotplug...

2013-12-25 Thread abaron
Ayal Baron has posted comments on this change. Change subject: clientIF: Rescan devices if device not found after vmHotplugDisk .. Patch Set 6: (1 comment) File vdsm/clientI

Change in vdsm[master]: hsm: Do not hide errors when checking device visibility

2013-12-25 Thread abaron
Ayal Baron has posted comments on this change. Change subject: hsm: Do not hide errors when checking device visibility .. Patch Set 4: Code-Review-1 (1 comment) File vdsm/st

Change in vdsm[master]: hsm: Check all devices visibility after multipath rescan

2013-12-25 Thread abaron
Ayal Baron has posted comments on this change. Change subject: hsm: Check all devices visibility after multipath rescan .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21182 To unsubscribe, visit http:/

Change in vdsm[master]: Revert "clientIF: rescan devices on failed hotplugDisk"

2013-12-25 Thread abaron
Ayal Baron has posted comments on this change. Change subject: Revert "clientIF: rescan devices on failed hotplugDisk" .. Patch Set 4: Looks like there is a rebase issue with this patch, other than that looks fine. -- To view

Change in vdsm[master]: Checking pep8 on jenkins

2013-12-25 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Checking pep8 on jenkins .. Patch Set 1: Code-Review-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5474/ : FAILURE http://je

Change in vdsm[master]: sourceRouteThread: Encapsulate inotify thread

2013-12-25 Thread amuller
Assaf Muller has posted comments on this change. Change subject: sourceRouteThread: Encapsulate inotify thread .. Patch Set 1: (3 comments) File vdsm/sourceRouteThread.py Li

Change in vdsm[master]: Checking pep8 on jenkins

2013-12-25 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Checking pep8 on jenkins .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5474/ : FAILURE http://jenkins.ovirt.or

Change in vdsm[master]: Checking pep8 on jenkins

2013-12-25 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Checking pep8 on jenkins .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5474/ : FAILURE http://jenkins.ovirt.or

Change in vdsm[master]: Checking pep8 on jenkins

2013-12-25 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Checking pep8 on jenkins .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5474/ : FAILURE http://jenkins.ovirt.or

Change in vdsm[master]: sourceRouteThread: Encapsulate inotify thread

2013-12-25 Thread amuller
Assaf Muller has posted comments on this change. Change subject: sourceRouteThread: Encapsulate inotify thread .. Patch Set 1: Code-Review-1 (2 comments) File vdsm/sourceRou