Change in vdsm[master]: vm: report migration progress in VmStats

2014-02-14 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: report migration progress in VmStats .. Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/24465/2/vdsm/vm.py File vdsm/vm.py: Line 2910: Line 2911:

Change in vdsm[master]: stats: report detailed VM down status

2014-02-14 Thread fromani
Francesco Romani has posted comments on this change. Change subject: stats: report detailed VM down status .. Patch Set 10: Verification: re-tested against an unaware engine (which doesn't fetch the new attribute), all OK --

Change in vdsm[master]: tests: validate cdrom path sent to/received from vdsm

2014-02-14 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: validate cdrom path sent to/received from vdsm .. tests: validate cdrom path sent to/received from vdsm related to http://gerrit.ovirt.org/#/c/2

Change in vdsm[master]: tests: validate cdrom path sent to/received from vdsm

2014-02-14 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: tests: validate cdrom path sent to/received from vdsm .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22194 To unsubscribe, visit http:

Change in vdsm[master]: vm: do not go Up if _dom is None

2014-02-14 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: do not go Up if _dom is None .. Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/24423/3//COMMIT_MSG Commit Message: Line 16: * the user restarts V

Change in vdsm[master]: vm: ensure finish recover with libvirt connection

2014-02-14 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: ensure finish recover with libvirt connection .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7244/ : SUCCES

Change in vdsm[master]: vm: ensure finish recover with libvirt connection

2014-02-14 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: vm: ensure finish recover with libvirt connection .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/24423/3/vdsm/vm.py File vdsm/vm.py: Line 2306: Li

Change in vdsm[master]: vdsm: add support for TPM device passthrough

2014-02-14 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm: add support for TPM device passthrough .. vdsm: add support for TPM device passthrough Libvirt has basic support for TPM passthrough, which allow

Change in vdsm[master]: vdsm: add support for TPM device passthrough

2014-02-14 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: add support for TPM device passthrough .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/20649 To unsubscribe, visit http://gerrit.

Change in vdsm[master]: hsm: encapsulate path in appropriateDevice

2014-02-14 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: hsm: encapsulate path in appropriateDevice .. hsm: encapsulate path in appropriateDevice As a continuation of Ie0d4d805ca333990ea1f612eb03a87f4a505f4a8

Change in vdsm[master]: tests: Move securable tests to its own test module

2014-02-14 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: tests: Move securable tests to its own test module .. tests: Move securable tests to its own test module The tests were hidden in tests/main.py making it harder t

Change in vdsm[master]: tests: Move securable tests to its own test module

2014-02-14 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Move securable tests to its own test module .. Patch Set 2: Verified+1 Now including the new test module. -- To view, visit http://gerrit.ovirt.org/24482 T

Change in vdsm[master]: client: update the help of `create` command

2014-02-14 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: client: update the help of `create` command .. client: update the help of `create` command This patch updates the help of the `create` command to keep

Change in vdsm[master]: schema: document the launchPaused parameter

2014-02-14 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: schema: document the launchPaused parameter .. schema: document the launchPaused parameter add documentation for the launchPaused param, which was miss

Change in vdsm[master]: client: update the help of `create` command

2014-02-14 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: client: update the help of `create` command .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24150 To unsubscribe, visit http://gerrit.o

Change in vdsm[master]: schema: document the launchPaused parameter

2014-02-14 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: schema: document the launchPaused parameter .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24144 To unsubscribe, visit http://gerrit.o

Change in vdsm[master]: tests: Move securable tests to its own test module

2014-02-14 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Move securable tests to its own test module .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7245/

Change in vdsm[master]: tests: Move securable tests to its own test module

2014-02-14 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Move securable tests to its own test module .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7246/ : SUCCE

Change in vdsm[master]: guest: Add support for guest cpu topology

2014-02-14 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: guest: Add support for guest cpu topology .. Patch Set 14: Verified+1 -- To view, visit http://gerrit.ovirt.org/23258 To unsubscribe, visit http://gerrit.ovi

Change in vdsm[ovirt-3.3]: vm iface statistics: never report negative rates

2014-02-14 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vm iface statistics: never report negative rates .. Patch Set 2: Code-Review+1 Yaniv, I see no problem with the target release of https://bugzilla.redhat.com/s

Change in vdsm[master]: vm: ensure finish recover with libvirt connection

2014-02-14 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: ensure finish recover with libvirt connection .. Patch Set 4: (2 comments) Error handling can be more precise. http://gerrit.ovirt.org/#/c/24423/4/vdsm/vm.py

Change in vdsm[master]: vm: ensure finish recover with libvirt connection

2014-02-14 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: ensure finish recover with libvirt connection .. Patch Set 4: (1 comment) And the title can also be refined. http://gerrit.ovirt.org/#/c/24423/4//COMMIT_MSG C

Change in vdsm[master]: securable: Do not try to secure inner classes

2014-02-14 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: securable: Do not try to secure inner classes .. securable: Do not try to secure inner classes Previously the class decorator was not careful enough, "securing" an

Change in vdsm[master]: securable: Do not try to secure inner classes

2014-02-14 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: securable: Do not try to secure inner classes .. Patch Set 1: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerr

Change in vdsm[master]: tests: Clean up test classes names

2014-02-14 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: tests: Clean up test classes names .. tests: Clean up test classes names Now when the securable tests have their own module, we don't need to use inner classes. Us

Change in vdsm[master]: securable: Do not try to secure inner classes

2014-02-14 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: securable: Do not try to secure inner classes .. Patch Set 2: Make pep8 happy. -- To view, visit http://gerrit.ovirt.org/24487 To unsubscribe, visit http://gerrit

Change in vdsm[master]: tests: Clean up test classes names

2014-02-14 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Clean up test classes names .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7249/ : SUCCESS http://jenki

Change in vdsm[master]: securable: Do not try to secure inner classes

2014-02-14 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: securable: Do not try to secure inner classes .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/24487 To unsubscribe, visit http://gerrit.ovirt.

Change in vdsm[master]: tests: Clean up test classes names

2014-02-14 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Clean up test classes names .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/24488 To unsubscribe, visit http://gerrit.ovirt.org/setting

Change in vdsm[master]: securable: Do not try to secure inner classes

2014-02-14 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: securable: Do not try to secure inner classes .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7248/ : SUCCESS h

Change in vdsm[master]: client: add the domainsMap in connectStoragePool

2014-02-14 Thread Federico Simoncelli
Federico Simoncelli has uploaded a new change for review. Change subject: client: add the domainsMap in connectStoragePool .. client: add the domainsMap in connectStoragePool Change-Id: I5c3037456ac045b7ac03043bb2f46ccd48b67045

Change in vdsm[master]: Revert "Fixing ssl config validation"

2014-02-14 Thread Federico Simoncelli
Federico Simoncelli has uploaded a new change for review. Change subject: Revert "Fixing ssl config validation" .. Revert "Fixing ssl config validation" This reverts commit cff03f968e882d94808cf272d9cc3e2ac29fabd0. Setting ssl=

Change in vdsm[master]: client: add the domainsMap in connectStoragePool

2014-02-14 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: client: add the domainsMap in connectStoragePool .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7250/ : SUCCESS

Change in vdsm[master]: sp: stop all poolMonitoredDomains on disconnect

2014-02-14 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: stop all poolMonitoredDomains on disconnect .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7251/ : SUCCESS

Change in vdsm[master]: Revert "Fixing ssl config validation"

2014-02-14 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Revert "Fixing ssl config validation" .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7252/ : SUCCESS http://je

Change in vdsm[master]: libvirt_configure.sh: fix commit cff03f968e

2014-02-14 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: libvirt_configure.sh: fix commit cff03f968e .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/24492 To unsubscribe, visit http://gerrit.ovir

Change in vdsm[master]: sp: stop all poolMonitoredDomains on disconnect

2014-02-14 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sp: stop all poolMonitoredDomains on disconnect .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24088 To unsubscribe, visit http://gerrit.o

Change in vdsm[master]: vm: ensure finish recover with libvirt connection

2014-02-14 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: ensure finish recover with libvirt connection .. Patch Set 4: (3 comments) http://gerrit.ovirt.org/#/c/24423/4//COMMIT_MSG Commit Message: Line 3: Autho

Change in vdsm[master]: libvirt_configure.sh: fix commit cff03f968e

2014-02-14 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: libvirt_configure.sh: fix commit cff03f968e .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7253/ : SUCCESS htt

Change in vdsm[master]: vm: ensure finish recover with libvirt connection

2014-02-14 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: ensure finish recover with libvirt connection .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/24423/4//COMMIT_MSG Commit Message: Line 3: Author

Change in vdsm[master]: vm: recover must finish with libvirt connection

2014-02-14 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: recover must finish with libvirt connection .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7254/ : SUCCESS

Change in vdsm[master]: vm: recover must finish with libvirt connection

2014-02-14 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: recover must finish with libvirt connection .. Patch Set 5: (3 comments) Some text issues. http://gerrit.ovirt.org/#/c/24423/5//COMMIT_MSG Commit Message: Li

Change in vdsm[master]: vm: recover must finish with libvirt connection

2014-02-14 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: recover must finish with libvirt connection .. Patch Set 5: (3 comments) http://gerrit.ovirt.org/#/c/24423/5//COMMIT_MSG Commit Message: Line 33: This p

Change in vdsm[master]: vm: recover must finish with libvirt connection

2014-02-14 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: recover must finish with libvirt connection .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7255/ : SUCCESS

Change in vdsm[master]: libvirt_configure.sh: fix commit cff03f968e

2014-02-14 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: libvirt_configure.sh: fix commit cff03f968e .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24492 To unsubscribe, visit http://ger

Change in vdsm[master]: libvirt_configure.sh: fix commit cff03f968e

2014-02-14 Thread Federico Simoncelli
Federico Simoncelli has submitted this change and it was merged. Change subject: libvirt_configure.sh: fix commit cff03f968e .. libvirt_configure.sh: fix commit cff03f968e This patch fixes two blatant errors, redering ssl=False

Change in vdsm[master]: sp: stop all poolMonitoredDomains on disconnect

2014-02-14 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: sp: stop all poolMonitoredDomains on disconnect .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24088 To unsubscribe, visit http://gerri