Change in vdsm[master]: vm: Set numatune and guest numa topology

2014-03-04 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: vm: Set numatune and guest numa topology .. Patch Set 1: Code-Review-1 (2 comments) Please update vdsm_api/vdsmapi-schema.json if you modify the API Also I

Change in vdsm[master]: vm: consider 'action' when handling I/O errors

2014-03-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: consider 'action' when handling I/O errors .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/25157 To unsubscribe, visit http://gerrit.ov

Change in vdsm[master]: clientIF: prepareVolumePath payload cleanup

2014-03-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: clientIF: prepareVolumePath payload cleanup .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/24636/2/vdsm/clientIF.py File vdsm/clientIF.py: Line 297:

Change in vdsm[master]: unified pers: fix restoration when moving from ifcfg pers

2014-03-04 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: unified pers: fix restoration when moving from ifcfg pers .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/25063/4/init/vdsmd_init_common.sh.in File ini

Change in vdsm[master]: vm: consider 'action' when handling I/O errors

2014-03-04 Thread dgibson
David Gibson has posted comments on this change. Change subject: vm: consider 'action' when handling I/O errors .. Patch Set 5: Code-Review+1 Looks good to me now. -- To view, visit http://gerrit.ovirt.org/25157 To unsubscrib

Change in vdsm[master]: caps: Collect numa information

2014-03-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: caps: Collect numa information .. Patch Set 8: No Builds Executed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7411/ : To avoid overloading

Change in vdsm[master]: setupNetworks: Fix incorrect mtu overriding when adding mult...

2014-03-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: setupNetworks: Fix incorrect mtu overriding when adding multiple networks .. Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/25343/1//COMMI

Change in vdsm[master]: clientIF: prepareVolumePath payload cleanup

2014-03-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: clientIF: prepareVolumePath payload cleanup .. Patch Set 2: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/24636/2/vdsm/clientIF.py File vdsm/clientIF.

Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults

2014-03-04 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 13: When running all functional network tests (in alphabetical order), the testIPv6Confi

Change in vdsm[master]: resourceManager: Keep resource state if registerResource fails

2014-03-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: resourceManager: Keep resource state if registerResource fails .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/

Change in vdsm[master]: resourceManager: Keep resource state if registerResource fails

2014-03-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: resourceManager: Keep resource state if registerResource fails .. Patch Set 4: Changes: - Make pep8 happy - "timeout=0" is more clear than "0" -- To view, visit h

Change in vdsm[master]: resourceManager: Keep resource state if registerResource fails

2014-03-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: resourceManager: Keep resource state if registerResource fails .. Patch Set 3: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vds

Change in vdsm[master]: setupNetworks: Fix incorrect mtu overriding when adding mult...

2014-03-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: setupNetworks: Fix incorrect mtu overriding when adding multiple networks .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_

Change in vdsm[master]: resourceManager: Keep resource state if registerResource fails

2014-03-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: resourceManager: Keep resource state if registerResource fails .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/25284/2/tests/resourceManagerTests.py File t

Change in vdsm[master]: resourceManager: Keep resource state if registerResource fails

2014-03-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: resourceManager: Keep resource state if registerResource fails .. Patch Set 3: Changes: - When checking if resource can be acquired, check both exclusive and shared

Change in vdsm[master]: setupNetworks: Fix incorrect mtu overriding when adding mult...

2014-03-04 Thread asegurap
Antoni Segura Puimedon has uploaded a new change for review. Change subject: setupNetworks: Fix incorrect mtu overriding when adding multiple networks .. setupNetworks: Fix incorrect mtu overriding when adding multiple networks

Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults

2014-03-04 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 13: Verified-1 There are a few functional tests that fail, we are dealing with them, ther

Change in vdsm[master]: multipath: Move all calls to multipath exe to a single method

2014-03-04 Thread ykaplan
Yeela Kaplan has posted comments on this change. Change subject: multipath: Move all calls to multipath exe to a single method .. Patch Set 10: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19255 To unsubscribe, visi

Change in vdsm[master]: lvm: remove unused add/remove tags

2014-03-04 Thread ykaplan
Yeela Kaplan has posted comments on this change. Change subject: lvm: remove unused add/remove tags .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/25013 To unsubscribe, visit http://gerrit.ovirt.org/setti

Change in vdsm[master]: resourceManager: Keep resource state if registerResource fails

2014-03-04 Thread laravot
Liron Ar has posted comments on this change. Change subject: resourceManager: Keep resource state if registerResource fails .. Patch Set 2: (6 comments) http://gerrit.ovirt.org/#/c/25284/2/tests/resourceManagerTests.py File te

Change in vdsm[master]: Install vdsm.conf.example during build

2014-03-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Install vdsm.conf.example during build .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24945 To unsubscribe, visit http://gerrit.ovirt.

Change in vdsm[master]: Adding remove/disable verbs to vdsm-tool for admin usages

2014-03-04 Thread mtayer
mooli tayer has posted comments on this change. Change subject: Adding remove/disable verbs to vdsm-tool for admin usages .. Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/21772/5/lib/vdsm/tool/configurator.py File lib/v

Change in vdsm[master]: Adding remove/disable verbs to vdsm-tool for admin usages

2014-03-04 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Adding remove/disable verbs to vdsm-tool for admin usages .. Patch Set 5: Code-Review+1 ok, I am good, now vdsm people will probably wake up :) -- To view, visi

Change in vdsm[master]: logging: Enable all storage loggers

2014-03-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: logging: Enable all storage loggers .. Patch Set 1: This can help to configure the new loggers that were missing before. For example, some logger may log to syslog

Change in vdsm[master]: Adding remove/disable verbs to vdsm-tool for admin usages

2014-03-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding remove/disable verbs to vdsm-tool for admin usages .. Patch Set 5: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_mas

Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults

2014-03-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 13: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7406

Change in vdsm[master]: Adding remove/disable verbs to vdsm-tool for admin usages

2014-03-04 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Adding remove/disable verbs to vdsm-tool for admin usages .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/21772/4/lib/vdsm/tool/passwd.py File lib/vdsm/t

Change in vdsm[master]: Adding remove/disable verbs to vdsm-tool for admin usages

2014-03-04 Thread mtayer
mooli tayer has posted comments on this change. Change subject: Adding remove/disable verbs to vdsm-tool for admin usages .. Patch Set 4: (4 comments) http://gerrit.ovirt.org/#/c/21772/4/lib/vdsm/constants.py.in File lib/vdsm/

Change in vdsm[master]: netinfo: bootproto4 is now 'dhcp'/'none' instead of a boolean

2014-03-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: netinfo: bootproto4 is now 'dhcp'/'none' instead of a boolean .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/25170 To unsubscribe, vi

Change in vdsm[master]: netinfo: bootproto4 is now 'dhcp'/'none' instead of a boolean

2014-03-04 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: netinfo: bootproto4 is now 'dhcp'/'none' instead of a boolean .. netinfo: bootproto4 is now 'dhcp'/'none' instead of a boolean testSetupNetworksAddDelD

Change in vdsm[master]: netinfo: Add shorthand NetInfo.bridges for consistency

2014-03-04 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: netinfo: Add shorthand NetInfo.bridges for consistency .. netinfo: Add shorthand NetInfo.bridges for consistency Change-Id: Ibf14be0a4db0678b4653512acc

Change in vdsm[master]: netinfo: Add shorthand NetInfo.bridges for consistency

2014-03-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: netinfo: Add shorthand NetInfo.bridges for consistency .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/25212 To unsubscribe, visit http

Change in vdsm[master]: vm: consider 'action' when handling I/O errors

2014-03-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: consider 'action' when handling I/O errors .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7405/ : SUCCESS

Change in vdsm[master]: resourceManager: Keep resource state if registerResource fails

2014-03-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: resourceManager: Keep resource state if registerResource fails .. Patch Set 2: Changes: - Extract helper assertions - Move tests higher to acquireResource, so we do

Change in vdsm[master]: resourceManager: Keep resource state if registerResource fails

2014-03-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: resourceManager: Keep resource state if registerResource fails .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/

Change in vdsm[master]: resourceManager: Keep resource state if registerResource fails

2014-03-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: resourceManager: Keep resource state if registerResource fails .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25284/1/vdsm/storage/resourceManager.py File

Change in vdsm[master]: logging: Enable all storage loggers

2014-03-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: logging: Enable all storage loggers .. Patch Set 1: Is this still needed when http://gerrit.ovirt.org/#/c/25185/ is merged? -- To view, visit http://gerrit.ov

Change in vdsm[master]: logging: Enable all loggers

2014-03-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: logging: Enable all loggers .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/25185 To unsubscribe, visit http://gerrit.ovirt.org/setting

Change in vdsm[master]: resourceManager: Keep resource state if registerResource fails

2014-03-04 Thread laravot
Liron Ar has posted comments on this change. Change subject: resourceManager: Keep resource state if registerResource fails .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25284/1/vdsm/storage/resourceManager.py File v

Change in vdsm[master]: logging: Enable all loggers

2014-03-04 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: logging: Enable all loggers .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/25185 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: resourceManager: Keep resource state if registerResource fails

2014-03-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: resourceManager: Keep resource state if registerResource fails .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25284/1/vdsm/storage/resourceManager.py File

Change in vdsm[master]: resourceManager: Keep resource state if registerResource fails

2014-03-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: resourceManager: Keep resource state if registerResource fails .. Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/25284/1/tests/resourceManagerTests.py File