Michal Skrivanek has posted comments on this change.
Change subject: virt: graphdev: support multiple graphics devices
..
Patch Set 16: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/27215
To unsubscribe, visit http:/
Dan Kenigsberg has posted comments on this change.
Change subject: virt: graphdev: support multiple graphics devices
..
Patch Set 16: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/27215
To unsubscribe, visit http://g
Dan Kenigsberg has posted comments on this change.
Change subject: virt: graphdev: add the GraphicsDevice class
..
Patch Set 22: Code-Review+1
(2 comments)
http://gerrit.ovirt.org/#/c/26895/22/vdsm/virt/vm.py
File vdsm/virt/vm
Nir Soffer has posted comments on this change.
Change subject: core: removal of unneeded callback passing
..
Patch Set 1:
Why not verify this simple change and get it merged?
--
To view, visit http://gerrit.ovirt.org/26760
To
Nir Soffer has posted comments on this change.
Change subject: fileVolume: avoid full size truncation for cow
..
Patch Set 1: Code-Review-1
(5 comments)
There are 4 different changes here - the two changes described in the com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bridge_opts: Add iproute2 configurator support
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1285/ : FAILU
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bridge_opts: Add iproute2 configurator support
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1284/ : FAILU
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bridge_opts: Add iproute2 configurator support
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1283/ : FAILU
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bridge_opts: Add iproute2 configurator support
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1282/ : FAILU
Dan Kenigsberg has posted comments on this change.
Change subject: hsm: fix setStoragePoolDescription execution
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/27543
To unsubscribe, visit http://gerrit.
Dan Kenigsberg has posted comments on this change.
Change subject: bridge_opts: Add iproute2 configurator support
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26762
To unsubscribe, visit http://gerri
Dan Kenigsberg has submitted this change and it was merged.
Change subject: bridge_opts: Add iproute2 configurator support
..
bridge_opts: Add iproute2 configurator support
This patch implements bridging option setting for the
Nir Soffer has posted comments on this change.
Change subject: utils: Faster version of list2cmdline
..
Patch Set 1:
jenkins is sick again.
--
To view, visit http://gerrit.ovirt.org/27548
To unsubscribe, visit http://gerrit.o
oVirt Jenkins CI Server has posted comments on this change.
Change subject: utils: Faster version of list2cmdline
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8709/ : SUCCESS
http://jenki
Nir Soffer has posted comments on this change.
Change subject: utils: Faster version of list2cmdline
..
Patch Set 1:
This is draft because the implementation is maybe too simple and may not be
correct for some inputs. I wrote
oVirt Jenkins CI Server has posted comments on this change.
Change subject: utils: Faster version of list2cmdline
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8709/ : SUCCESS
http://jenki
Nir Soffer has uploaded a new change for review.
Change subject: utils: Faster version of list2cmdline
..
utils: Faster version of list2cmdline
The original version from the subprocess module show on the top of a
profile on idle
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bridge_opts: Add iproute2 configurator support
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: net_tests: Move network unit tests into a subdirectory
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8707/ : SUCC
Antoni Segura Puimedon has posted comments on this change.
Change subject: bridge_opts: Add iproute2 configurator support
..
Patch Set 3: Verified+1
Copying verification score since it was a simple rebase.
--
To view, visit h
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fileVolume: avoid full size truncation for cow
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8706/ : SUCCESS
htt
Federico Simoncelli has uploaded a new change for review.
Change subject: fileVolume: avoid full size truncation for cow
..
fileVolume: avoid full size truncation for cow
During the creation of a new file volume we are supposed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: net_tests: Move network unit tests into package
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8705/ : SUCCESS
ht
Antoni Segura Puimedon has posted comments on this change.
Change subject: net_tests: Move network unit tests into package
..
Patch Set 1:
(5 comments)
http://gerrit.ovirt.org/#/c/26874/1/tests/network/Makefile.am
File tests/n
Federico Simoncelli has uploaded a new change for review.
Change subject: hsm: fix setStoragePoolDescription execution
..
hsm: fix setStoragePoolDescription execution
In commit ab6014b the pool metadata operations were moved to
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: graphdev: add the GraphicsDevice class
..
Patch Set 22:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8704/ : SUCCESS
http
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: graphdev: support multiple graphics devices
..
Patch Set 16:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8703/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: spice: allow to disable the agent file transfer
..
Patch Set 24:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8701/ : SUCCESS
h
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: graphdev: handle ticket for multiple devices
..
Patch Set 25:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8702/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: spice: allow to disable the to clipboard copypaste
..
Patch Set 24:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8700/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: virt: graphdev: add the GraphicsDevice class
..
Patch Set 22:
rebased; addressed reviewer comments
handled spice channels in a proper way
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hsm: fix setStoragePoolDescription execution
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1281/ : SUC
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hsm: fix setStoragePoolDescription execution
..
hsm: fix setStoragePoolDescription execution
In commit ab6014b the pool metadata operations were moved
Dan Kenigsberg has posted comments on this change.
Change subject: hsm: fix setStoragePoolDescription execution
..
Patch Set 3: Verified+1
Copying verification from ps1, no code change.
--
To view, visit http://gerrit.ovirt.o
Dan Kenigsberg has posted comments on this change.
Change subject: hsm: fix setStoragePoolDescription execution
..
Patch Set 3: Code-Review+2
(1 comment)
http://gerrit.ovirt.org/#/c/27540/3//COMMIT_MSG
Commit Message:
Line 13
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bridge_opts: Add ifcfg configurator support
..
Patch Set 14:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1280/ : SUC
Dan Kenigsberg has posted comments on this change.
Change subject: bridge_opts: Add iproute2 configurator support
..
Patch Set 2: Code-Review-1
Manual rebase required.
--
To view, visit http://gerrit.ovirt.org/26762
To unsubs
Dan Kenigsberg has submitted this change and it was merged.
Change subject: bridge_opts: Add ifcfg configurator support
..
bridge_opts: Add ifcfg configurator support
bridge_opts is a new custom netwrok property that allows to
Antoni Segura Puimedon has posted comments on this change.
Change subject: bridge_opts: Add ifcfg configurator support
..
Patch Set 13: Verified+1
--
To view, visit http://gerrit.ovirt.org/26708
To unsubscribe, visit http://ge
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hsm: fix setStoragePoolDescription execution
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8699/ : SUCCESS
http:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bridge_opts: Add ifcfg configurator support
..
Patch Set 13:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/13
Dan Kenigsberg has posted comments on this change.
Change subject: bridge_opts: Add ifcfg configurator support
..
Patch Set 13: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26708
To unsubscribe, visit http://gerrit.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: report exit reason for migration failed
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1279/ : SUCC
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: report exit reason for migration failed
..
vm: report exit reason for migration failed
this patch add reporting for an explicit exit
reason when mi
Dan Kenigsberg has posted comments on this change.
Change subject: vm: report exit reason for migration failed
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/25164
To unsubscribe, visit http://gerrit.o
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: Use testrunner.namedTemporaryDir
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1278/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: Ensure cleanup when tests fail
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1277/ : SUCCESS
-
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Use testrunner.namedTemporaryDir
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/27506
To unsubscribe, visit http://gerrit.ovirt
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Use testrunner.namedTemporaryDir
..
tests: Use testrunner.namedTemporaryDir
Some tests were working hard ensuring proper cleanup when a test fai
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Ensure cleanup when tests fail
..
Patch Set 3: Code-Review+2
(1 comment)
http://gerrit.ovirt.org/#/c/27505/3/tests/miscTests.py
File tests/miscTests.py:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Ensure cleanup when tests fail
..
tests: Ensure cleanup when tests fail
Some tests were using an optimstic approach:
create_temporary_stuff
oVirt Jenkins CI Server has posted comments on this change.
Change subject: net_persistence: Make unified persistence default
..
Patch Set 8:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1276/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ifcfg: set onboot=no when persistence is 'unified'
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1275/
Dan Kenigsberg has submitted this change and it was merged.
Change subject: ifcfg: set onboot=no when persistence is 'unified'
..
ifcfg: set onboot=no when persistence is 'unified'
Up until now the ifcfg network configurator ha
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net_persistence: Make unified persistence default
..
net_persistence: Make unified persistence default
Up until now, we've been using the legacy ifcfg
Dan Kenigsberg has posted comments on this change.
Change subject: net_persistence: Make unified persistence default
..
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/25784
To unsubscribe, visit http://ge
Dan Kenigsberg has posted comments on this change.
Change subject: ifcfg: set onboot=no when persistence is 'unified'
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/27541
To unsubscribe, visit http://g
Antoni Segura Puimedon has posted comments on this change.
Change subject: net_persistence: Make unified persistence default
..
Patch Set 7: Verified+1
Ran the functional tests and did the verification as before and this time t
oVirt Jenkins CI Server has posted comments on this change.
Change subject: configfile.py utility for common config file editing operations.
..
Patch Set 8:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_install_rp
oVirt Jenkins CI Server has posted comments on this change.
Change subject: net_persistence: Make unified persistence default
..
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8697/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: network: fix unrecognized engine values for STP
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1273/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: Use testrunner.TEMPDIR
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1272/ : SUCCESS
--
To vi
Dan Kenigsberg has submitted this change and it was merged.
Change subject: configfile.py utility for common config file editing operations.
..
configfile.py utility for common config file editing operations.
Add utility to edi
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network: fix unrecognized engine values for STP
..
network: fix unrecognized engine values for STP
The engine sends STP settings in a 'yes'/'no' range
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Use testrunner.TEMPDIR
..
tests: Use testrunner.TEMPDIR
Storage functional tests used to define their own temporary directory
path. They use now
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: Use testrunner.TEMPDIR
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8696/ : SUCCESS
http://jenkins.ovirt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: Ensure cleanup when tests fail
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8695/ : SUCCESS
http://jenki
Nir Soffer has abandoned this change.
Change subject: fileUtils: Make memory filesystems support configurable
..
Abandoned
Replaced by http://gerrit.ovirt.org/27441
--
To view, visit http://gerrit.ovirt.org/27236
To unsubscri
Nir Soffer has posted comments on this change.
Change subject: tests: Use testrunner.namedTemporaryDir
..
Patch Set 3:
Rebase, no code change.
--
To view, visit http://gerrit.ovirt.org/27506
To unsubscribe, visit http://gerri
Nir Soffer has posted comments on this change.
Change subject: tests: Ensure cleanup when tests fail
..
Patch Set 3: Verified+1
Rebased since error handling when deleting temporary files was abandoned.
When testing cleanupDir,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: Use testrunner.namedTemporaryDir
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8694/ : SUCCESS
http:/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: Use testrunner.TEMPDIR
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8693/ : SUCCESS
http://jenkins.ovirt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: Ensure cleanup when tests fail
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8692/ : SUCCESS
http://jenki
Nir Soffer has posted comments on this change.
Change subject: tests: Use testrunner.TEMPDIR
..
Patch Set 3: Verified+1
Verified by running the tests.
--
To view, visit http://gerrit.ovirt.org/27503
To unsubscribe, visit http
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: Use testrunner.namedTemporaryDir
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8691/ : SUCCESS
http://jen
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hsm: fix setStoragePoolDescription execution
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8690/ : SUCCESS
http:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ifcfg: set onboot=no when persistence is 'unified'
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_ger
Federico Simoncelli has posted comments on this change.
Change subject: sp: setDomainRegularRole is implemented by backend
..
Patch Set 1: Code-Review+2
(1 comment)
Ok, but please add the new bug-url.
http://gerrit.ovirt.org/
Antoni Segura Puimedon has posted comments on this change.
Change subject: network: fix unrecognized engine values for STP
..
Patch Set 1: Verified+1
Manually verified by doing:
toniel602 ~ # vdsClient -s 0 addNetwork bridg
Nir Soffer has abandoned this change.
Change subject: tests: Fix error handling when cleaning up temporaries
..
Abandoned
The maintainer likes the current broken code.
--
To view, visit http://gerrit.ovirt.org/27504
To unsubs
Nir Soffer has posted comments on this change.
Change subject: tests: Fix error handling when cleaning up temporaries
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/27504/1//COMMIT_MSG
Commit Message:
Line 6:
Line 7
Antoni Segura Puimedon has posted comments on this change.
Change subject: ifcfg: set onboot=no when persistence is 'unified'
..
Patch Set 1:
Additionally set net_persistence back to ifcfg and checked that onboot=yes is
correc
Antoni Segura Puimedon has posted comments on this change.
Change subject: ifcfg: set onboot=no when persistence is 'unified'
..
Patch Set 1: Verified+1
Manually verified by setting net_persistence to 'unified' and then doing:
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: ifcfg: set onboot=no when persistence is 'unified'
..
ifcfg: set onboot=no when persistence is 'unified'
Up until now the ifcfg network configurator ha
oVirt Jenkins CI Server has posted comments on this change.
Change subject: caps: report if QEMU supports live snapshots
..
Patch Set 11:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/574
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Fix error handling when cleaning up temporaries
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/27504/1//COMMIT_MSG
Commit Message:
Line 6:
Li
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: adding gfs2 symlink test
..
Patch Set 2:
No Builds Executed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8688/ : To avoid
overloading
Dan Kenigsberg has posted comments on this change.
Change subject: caps: report if QEMU supports live snapshots
..
Patch Set 10: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26149
To unsubscribe, visit http://gerrit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: caps: report if QEMU supports live snapshots
..
caps: report if QEMU supports live snapshots
Depending on QEMU version and configuration, live snapshot
Francesco Romani has posted comments on this change.
Change subject: virt: graphdev: add the GraphicsDevice class
..
Patch Set 21:
(5 comments)
http://gerrit.ovirt.org/#/c/26895/21/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1
oVirt Jenkins CI Server has posted comments on this change.
Change subject: unified_persistence: Fix whitelist value types
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1270/ : S
Dan Kenigsberg has submitted this change and it was merged.
Change subject: unified_persistence: Fix whitelist value types
..
unified_persistence: Fix whitelist value types
The upgrade script didn't convert the types to what th
Dan Kenigsberg has posted comments on this change.
Change subject: unified_persistence: Fix whitelist value types
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/27058
To unsubscribe, visit http://gerri
oVirt Jenkins CI Server has posted comments on this change.
Change subject: caps: report if QEMU supports live snapshots
..
Patch Set 10:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8687/ : SUCCESS
http
Francesco Romani has posted comments on this change.
Change subject: caps: report if QEMU supports live snapshots
..
Patch Set 10: Verified+1
removed spurious whitespace change; rebased.
Copied score.
--
To view, visit http:/
Francesco Romani has posted comments on this change.
Change subject: caps: report if QEMU supports live snapshots
..
Patch Set 8:
(2 comments)
http://gerrit.ovirt.org/#/c/26149/8/vdsm/caps.py
File vdsm/caps.py:
Line 81: P
Francesco Romani has posted comments on this change.
Change subject: caps: report if QEMU supports live snapshots
..
Patch Set 9: Verified+1
addressed Dan's comment.
Re-verified using unit tests.
--
To view, visit http://gerr
oVirt Jenkins CI Server has posted comments on this change.
Change subject: caps: report if QEMU supports live snapshots
..
Patch Set 9:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8686/ : SUCCESS
http:
Dan Kenigsberg has posted comments on this change.
Change subject: hsm: fix setStoragePoolDescription execution
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/27540/1//COMMIT_MSG
Commit Message:
Line 7: hsm: fix setS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: virt: add infrastructure to test getStats
..
Patch Set 8:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1269/ :
1 - 100 of 143 matches
Mail list logo