Dan Kenigsberg has posted comments on this change. Change subject: virt: graphdev: add the GraphicsDevice class ......................................................................
Patch Set 22: Code-Review+1 (2 comments) http://gerrit.ovirt.org/#/c/26895/22/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1358: vmc.appendChildWithArgs('target', type='virtio', Line 1359: name='com.redhat.spice.0') Line 1360: return vmc Line 1361: Line 1362: def _getSpiceChannels(self): actually, I would have preferred this to occur in a separate patch. This patch is too complex anyway. Adding more refactoring does not help. Never mind now. Line 1363: for name in self.specParams['spiceSecureChannels'].split(','): Line 1364: if name in GraphicsDevice.SPICE_CHANNEL_NAMES: Line 1365: yield name Line 1366: elif (name[0] == 's' and name[1:] in Line 2650: # we need to handle the case getStats is called before 'devices' is Line 2651: # updated in Vm._run (buildConfDevices and the following code). Line 2652: # easily reproduced with functional tests, but also possible Line 2653: # in the wild Line 2654: for dev in self.conf.get('devices', []) + self.getConfGraphics(): Seeing that we've missed such a serious flaw previously, does not make me feel safe. How was it missed by prior verifications? Line 2655: if dev['type'] == GRAPHICS_DEVICES: Line 2656: stats.update(getInfo(dev)) Line 2657: break Line 2658: -- To view, visit http://gerrit.ovirt.org/26895 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82e4414aa3efe7c756ba8ef9b7b47e591613a717 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
