oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: added missing diskReplicate slot in Drive class
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8535/
Allon Mureinik has posted comments on this change.
Change subject: vm: added missing diskReplicate slot in Drive class
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28131
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: vm: added missing diskReplicate slot in Drive class
..
Patch Set 1:
The unit test issue looks like a Jenkins foobar, not a real failure.
--
To view, visit
Allon Mureinik has posted comments on this change.
Change subject: tests: fix wrong use of assertions
..
Patch Set 2:
Did you analyze the problem with the network functional tests? Is it just a
normal Jenkins foobar, or does
Michal Skrivanek has posted comments on this change.
Change subject: nfsSD: Remove unneeded and expensive mount check
..
Patch Set 1:
aside from this patch which is a clear improvement, I wonder why do we have to
Francesco Romani has abandoned this change.
Change subject: vm: spice support to clipboard copypaste disable
..
Abandoned
implemented in a different way.
--
To view, visit http://gerrit.ovirt.org/22646
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: vm: wrong message formatting leads to an exception
..
Patch Set 2:
Can you verify this? I don't see any reason to wait with such trivial patch.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: wrong message formatting leads to an exception
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9317/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: added missing diskReplicate slot in Drive class
..
Patch Set 1:
Build Unstable
Nir Soffer has posted comments on this change.
Change subject: vm: added missing diskReplicate slot in Drive class
..
Patch Set 1: Code-Review-1
(1 comment)
Please fix pep8 issue.
Michal Skrivanek has posted comments on this change.
Change subject: spice: allow to disable the agent file transfer
..
Patch Set 38: Code-Review-1
(1 comment)
I'm still not happy with the version check…
for abort_on_eio it
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: fix wrong use of assertions
..
Patch Set 2:
Build Unstable
Nir Soffer has posted comments on this change.
Change subject: tests: fix wrong use of assertions
..
Patch Set 2:
Adding Antoni and Francesco since these changes are probably also needed in the
network and virt functional
Francesco Romani has posted comments on this change.
Change subject: spice: allow to disable the agent file transfer
..
Patch Set 38:
(1 comment)
I'll try to summarize the point.
- I agree dropping the clusterLevel for this
Nir Soffer has posted comments on this change.
Change subject: json-rpc: Protocol detection
..
Patch Set 22:
(1 comment)
http://gerrit.ovirt.org/#/c/26300/22/vdsm/protocolDetector.py
File vdsm/protocolDetector.py:
Line 88:
Francesco Romani has posted comments on this change.
Change subject: tests: fix wrong use of assertions
..
Patch Set 2:
(2 comments)
http://gerrit.ovirt.org/#/c/28124/2/tests/testrunner.py
File tests/testrunner.py:
Line 36:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: added missing diskReplicate slot in Drive class
..
Patch Set 2:
Build Successful
Francesco Romani has posted comments on this change.
Change subject: profile: Support yappi clock types
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/27816
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: json-rpc: Protocol detection
..
Patch Set 22:
(1 comment)
http://gerrit.ovirt.org/#/c/26300/22/vdsm/protocolDetector.py
File vdsm/protocolDetector.py:
Line 88:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: wrong message formatting leads to an exception
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8537/
Dima Kuznetsov has posted comments on this change.
Change subject: vdsm-tool: Change upgrade mechanism
..
Patch Set 8:
Assaf, the ordering is truly a bit problematic, because logging facilities only
added in a latter patch,
Nir Soffer has posted comments on this change.
Change subject: json-rpc: Protocol detection
..
Patch Set 22:
(1 comment)
http://gerrit.ovirt.org/#/c/26300/22/vdsm/protocolDetector.py
File vdsm/protocolDetector.py:
Line 201:
Francesco Romani has posted comments on this change.
Change subject: spice: allow to disable the agent file transfer
..
Patch Set 38:
Just to think aloud: at the best of my knowledge, nobody in the full stack
engine - VDSM -
Yoav Kleinberger has posted comments on this change.
Change subject: tests: fix wrong use of assertions
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/28124
To unsubscribe, visit
Liron Ar has posted comments on this change.
Change subject: BindingXmlRPC - do_PUT to return execution result in headers
..
Patch Set 2:
(2 comments)
http://gerrit.ovirt.org/#/c/27997/2/vdsm/BindingXMLRPC.py
File
Yoav Kleinberger has posted comments on this change.
Change subject: tests: fix wrong use of assertions
..
Patch Set 2:
(2 comments)
http://gerrit.ovirt.org/#/c/28124/2/tests/testrunner.py
File tests/testrunner.py:
Line 36:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: fix wrong use of assertions
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9472/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: fix wrong use of assertions
..
Patch Set 3:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: fix wrong use of assertions
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1427/
Arik Hadas has posted comments on this change.
Change subject: Always use OOP when padding snapshot's memory volume
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/26538/2//COMMIT_MSG
Commit Message:
Line 8:
Line 9:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: json-rpc: Protocol detection
..
Patch Set 23:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8540/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Always use OOP when padding snapshot's memory volume
..
Patch Set 3:
Build Failed
Dima Kuznetsov has posted comments on this change.
Change subject: unit_tests: Make run_tests_local.sh not be a generated file
..
Patch Set 1:
Why not give tests/run_tests.sh the same treatment?
Also, need to remove the file
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Always use OOP when padding snapshot's memory volume
..
Patch Set 4:
Build Failed
Michal Skrivanek has posted comments on this change.
Change subject: Always use OOP when padding snapshot's memory volume
..
Patch Set 4:
Then I'd even argue that we should use OOP for all storage types as even the
block
Liron Ar has posted comments on this change.
Change subject: core: introducing uploadImageToStream
..
Patch Set 8:
(6 comments)
http://gerrit.ovirt.org/#/c/26741/8/vdsm/BindingXMLRPC.py
File vdsm/BindingXMLRPC.py:
Line 118:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: introducing uploadImageToStream
..
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8543/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BindingXmlRPC - do_PUT to return execution result in headers
..
Patch Set 3:
Build Successful
Ondřej Svoboda has posted comments on this change.
Change subject: ifcfg: remove and re-create bonds when they are not to be
destroyed
..
Patch Set 8: Code-Review-1
(2 comments)
Thanks for the patch, I will check it with my
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: BindingXMLRPC - exporting logic out from do_PUT.
..
Patch Set 9: Code-Review-1 Verified-1
Build Unstable
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: generify streamDownloadImage related methods
..
Patch Set 8:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: removal of unneeded callback passing
..
Patch Set 8:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8547/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: imageSharing - export logic to functions
..
Patch Set 8: Code-Review-1 Verified-1
Build Unstable
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: introducing uploadImageToStream
..
Patch Set 10:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8549/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: generify streamDownloadImage related methods
..
Patch Set 9:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8551/
Dan Kenigsberg has posted comments on this change.
Change subject: net_tests: add reusing dhclient owned iface
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/28049
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net_tests: add reusing dhclient owned iface
..
net_tests: add reusing dhclient owned iface
https://bugzilla.redhat.com/1100264 showed us that we are
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: BindingXMLRPC - exporting logic out from do_PUT.
..
Patch Set 10:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: net_tests: add reusing dhclient owned iface
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1362/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: removal of unneeded callback passing
..
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8552/ :
Nir Soffer has posted comments on this change.
Change subject: core: BindingXMLRPC - exporting logic out from do_PUT.
..
Patch Set 10: Code-Review+1
(1 comment)
There is one issue with _getIntHeader implementation.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: imageSharing - export logic to functions
..
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8553/
Dima Kuznetsov has posted comments on this change.
Change subject: vdsm-tool: Add logging and verbosity flags
..
Patch Set 5:
We can use argparse, but if we want to preserve the usage of all @exposed
commands, we'd have to
Nir Soffer has posted comments on this change.
Change subject: core: imageSharing - export logic to functions
..
Patch Set 9: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26759
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: core: introducing uploadImageToStream
..
Patch Set 10:
(2 comments)
Looks good, one typo and one missing empty line.
Nir Soffer has posted comments on this change.
Change subject: BindingXmlRPC - do_PUT to return execution result in headers
..
Patch Set 3:
(1 comment)
Looks ok except the fact that the status code and error message are
Nir Soffer has posted comments on this change.
Change subject: json-rpc: Protocol detection
..
Patch Set 22:
(1 comment)
http://gerrit.ovirt.org/#/c/26300/22/vdsm/protocolDetector.py
File vdsm/protocolDetector.py:
Line 201:
Dan Kenigsberg has posted comments on this change.
Change subject: dmidecode: Handle missing values
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26942
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding utility methods and conf for CPU limit MOM integration
..
Patch Set 24: Code-Review-1 Verified-1
Build Failed
Antoni Segura Puimedon has posted comments on this change.
Change subject: ifcfg: remove and re-create bonds when they are not to be
destroyed
..
Patch Set 8:
(2 comments)
Antoni Segura Puimedon has posted comments on this change.
Change subject: ifcfg: remove and re-create bonds when they are not to be
destroyed
..
Patch Set 9: Verified+1
Only removed an extra import, copying score.
--
To
Martin Sivák has posted comments on this change.
Change subject: Fix memShared units when reported from MOM
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/28115
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: virt: Lookup conf and device by path
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/27951
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: Fix memShared units when reported from MOM
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28115
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ifcfg: remove and re-create bonds when they are not to be
destroyed
..
Patch Set 9:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix memShared units when reported from MOM
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8556/ :
Yaniv Bronhaim has posted comments on this change.
Change subject: caps: Collect kdump status
..
Patch Set 7: Code-Review-1
(5 comments)
no tests?
http://gerrit.ovirt.org/#/c/25926/7/vdsm/caps.py
File vdsm/caps.py:
Line 58:
Ondřej Svoboda has uploaded a new change for review.
Change subject: networkTests: Use bond5 in functional network tests.
..
networkTests: Use bond5 in functional network tests.
bond0, originally used in the tests, is one of
Ondřej Svoboda has posted comments on this change.
Change subject: ifcfg: remove and re-create bonds when they are not to be
destroyed
..
Patch Set 8:
(1 comment)
I will retest http://gerrit.ovirt.org/24456/ with bond5, see
oVirt Jenkins CI Server has posted comments on this change.
Change subject: json-rpc: Protocol detection
..
Patch Set 24:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8557/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: networkTests: Use bond5 in functional network tests.
..
Patch Set 1: Code-Review-1 Verified-1
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Stomp support
..
Patch Set 16:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8558/ : SUCCESS
Ondřej Svoboda has posted comments on this change.
Change subject: networkTests: Use bond5 in functional network tests.
..
Patch Set 1:
(1 comment)
ERR_BAD_BONDING is the exception we are getting now.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: networkTests: Use bond5 in functional network tests.
..
Patch Set 2:
Build Failed
Vered Volansky has posted comments on this change.
Change subject: tests: fix wrong use of assertions
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28124
To unsubscribe, visit
Yoav Kleinberger has posted comments on this change.
Change subject: tests: use 'localhost' explicitly in test
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/28107/1/tests/functional/storageTests.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm_config: move download certificate
..
Patch Set 34: Code-Review+2
I think we can take this now, and worry about the ovirt-patch
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm_config: move download certificate
..
vdsm_config: move download certificate
DHCP servers might delay to deliver the ip address
and we can't
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm_config: move download certificate
..
Patch Set 35:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1363/ : SUCCESS
Yaniv Bronhaim has posted comments on this change.
Change subject: Sign sanlock not configured when service down and stop
reconfigure of force
..
Patch Set 1:
(1 comment)
Douglas Schilling Landgraf has posted comments on this change.
Change subject: caps: Collect kdump status
..
Patch Set 7:
(2 comments)
http://gerrit.ovirt.org/#/c/25926/7/vdsm/caps.py
File vdsm/caps.py:
Line 416:
Line 417:
Dan Kenigsberg has posted comments on this change.
Change subject: Fix memShared units when reported from MOM
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/28115
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Fix memShared units when reported from MOM
..
Patch Set 4: Code-Review-1
manual rebase required.
--
To view, visit http://gerrit.ovirt.org/28115
To
Dan Kenigsberg has posted comments on this change.
Change subject: tests: fix wrong use of assertions
..
Patch Set 4: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/28124/4/tests/functional/storageTests.py
File
Martin Peřina has posted comments on this change.
Change subject: caps: Collect kdump status
..
Patch Set 7:
(3 comments)
http://gerrit.ovirt.org/#/c/25926/7/vdsm/caps.py
File vdsm/caps.py:
Line 58:
Line 59:
Line 60:
Alon Bar-Lev has posted comments on this change.
Change subject: Sign sanlock not configured when service down and stop
reconfigure of force
..
Patch Set 1:
(1 comment)
Dan Kenigsberg has posted comments on this change.
Change subject: Always use OOP when padding snapshot's memory volume
..
Patch Set 4: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/26538/4//COMMIT_MSG
Commit
Yoav Kleinberger has posted comments on this change.
Change subject: tests: fix wrong use of assertions
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/28124/4/tests/testrunner.py
File tests/testrunner.py:
Line 392:
Douglas Schilling Landgraf has posted comments on this change.
Change subject: caps: Collect kdump status
..
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/25926/7/vdsm/caps.py
File vdsm/caps.py:
Line 422:
Yoav Kleinberger has posted comments on this change.
Change subject: tests: fix wrong use of assertions
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/28124/4/tests/functional/storageTests.py
File
Yoav Kleinberger has posted comments on this change.
Change subject: tests: fix wrong use of assertions
..
Patch Set 5: Verified+1
--
To view, visit http://gerrit.ovirt.org/28124
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: fix wrong use of assertions
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8562/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix memShared units when reported from MOM
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8561/ :
Dima Kuznetsov has posted comments on this change.
Change subject: vdsm-tool: Change upgrade mechanism
..
Patch Set 8:
Upon further examination, this was missing logs, because logger was ignoring
DEBUG level logs, fixed in
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm-tool: Change upgrade mechanism
..
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8563/ : SUCCESS
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: vdsmcli: Add a contrib command line client alternative
..
vdsmcli: Add a contrib command line client alternative
This command line client is built by
Federico Simoncelli has posted comments on this change.
Change subject: utils: Decrease cpu usage when executing commands
..
Patch Set 13:
Ping Saggi? Can you point us to any issue/bug we were addressing with AsyncProc?
--
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm-tool: Add logging and verbosity flags
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8564/ :
Nir Soffer has posted comments on this change.
Change subject: tests: fix wrong use of assertions
..
Patch Set 4:
(2 comments)
http://gerrit.ovirt.org/#/c/28124/4/tests/functional/storageTests.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsmcli: Add a contrib command line client alternative
..
Patch Set 1:
Build Successful
1 - 100 of 129 matches
Mail list logo
