Francesco Romani has posted comments on this change.
Change subject: vdsm: add support for hostdev passthrough
..
Patch Set 10:
Was version 10 just a rebase?
--
To view, visit http://gerrit.ovirt.org/22462
To unsubscribe, vis
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for hostdev passthrough
..
Patch Set 10:
No, we realized that the libvirt device XML is not usable as hostdev XML,
therefore adding the need
oVirt Jenkins CI Server has posted comments on this change.
Change subject: lvm: ignore LVs with special tag
..
Patch Set 8:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9683/ : FAILURE
http://jenk
Dan Kenigsberg has uploaded a new change for review.
Change subject: xen: libvirtconnection: connect to xen, if it is available
..
xen: libvirtconnection: connect to xen, if it is available
Change-Id: I6cc6474b012d900fe3c5e1dab7
Dan Kenigsberg has uploaded a new change for review.
Change subject: xen: do not attempt to read underlying device info
..
xen: do not attempt to read underlying device info
Xen's device information is quite different than what
Dan Kenigsberg has uploaded a new change for review.
Change subject: libvirtconnection: refactor: open a new connection in special
function
..
libvirtconnection: refactor: open a new connection in special function
This patch sp
Dan Kenigsberg has uploaded a new change for review.
Change subject: _findLiveSnapshotSupport: do not assume that guest
exist
..
_findLiveSnapshotSupport: do not assume that guest exist
Change-Id: I8e6d1ae6d020bedcfa8f2986fce
Dan Kenigsberg has uploaded a new change for review.
Change subject: xen: hook: let oVirt run VMs on Xen hosts
..
xen: hook: let oVirt run VMs on Xen hosts
With this hook installed (and previous hacks applied) it is possible to
Dan Kenigsberg has uploaded a new change for review.
Change subject: xen: use qemu connection, as compareCPU is unavailable via xen
..
xen: use qemu connection, as compareCPU is unavailable via xen
This patch is required until c
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: upgrade_unified: fix for nicless and bridges with vnics
..
upgrade_unified: fix for nicless and bridges with vnics
The upgrade script had a mistake whe
Antoni Segura Puimedon has posted comments on this change.
Change subject: upgrade_unified: fix for nicless and bridges with vnics
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/28354
To unsubscribe, visi
Antoni Segura Puimedon has posted comments on this change.
Change subject: upgrade_unified: fix for nicless and bridges with vnics
..
Patch Set 1:
Verified manually trying several network configurations:
Add nicless net
to
Francesco Romani has uploaded a new change for review.
Change subject: virt: migration: replace magic number
..
virt: migration: replace magic number
replace a magic constant with the symbolic name to clarify
the intent of the c
oVirt Jenkins CI Server has posted comments on this change.
Change subject: _findLiveSnapshotSupport: do not assume that guest
exist
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerri
Francesco Romani has uploaded a new change for review.
Change subject: virt: migration: rename helper function
..
virt: migration: rename helper function
rename helper function to be a bit more consistent
with the new style guid
oVirt Jenkins CI Server has posted comments on this change.
Change subject: libvirtconnection: refactor: open a new connection in special
function
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_uni
Martin Polednik has posted comments on this change.
Change subject: faqemu hook: move memory limitation to config
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/28320
To unsubscribe, visit http://gerrit.o
Francesco Romani has posted comments on this change.
Change subject: virt: migration: add monitor thread control loop
..
Patch Set 16: Verified+1
fixed a rebase glitch which cause an AttributeError (MONITOR_INTERVAL vs
MIGRATI
Michal Skrivanek has posted comments on this change.
Change subject: faqemu hook: move memory limitation to config
..
Patch Set 1: Code-Review+1
i believe this is much better than the last modification for ppc.
faqemu still ha
Francesco Romani has posted comments on this change.
Change subject: virt: migration: replace magic number
..
Patch Set 1: Verified+1
trivial.
Verified by doing a migration, just to rule out spelling mistakes (seems OK)
--
To
Francesco Romani has posted comments on this change.
Change subject: virt: migration: rename helper function
..
Patch Set 1: Verified+1
trivial.
Verified by running a migration just to rule out spelling mistakes.
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: xen: libvirtconnection: connect to xen, if it is available
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerri
oVirt Jenkins CI Server has posted comments on this change.
Change subject: xen: use qemu connection, as compareCPU is unavailable via xen
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerri
Francesco Romani has posted comments on this change.
Change subject: faqemu hook: move memory limitation to config
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28320
To unsubscribe, visit http://gerr
Francesco Romani has posted comments on this change.
Change subject: virt: migration: merge monitor and downtime thread
..
Patch Set 17: Verified+1
Verified with 25976, 25978, 25979 by running migrations and by inspecting the
Francesco Romani has posted comments on this change.
Change subject: virt: migration: use contextmanager for monitor
..
Patch Set 18: Verified+1
Verified with 25976, 25977 and 25979 by running a few migrations.
--
To view, vi
Francesco Romani has posted comments on this change.
Change subject: virt: migration: merge monitor and downtime thread
..
Patch Set 17:
s/25979/26279/
--
To view, visit http://gerrit.ovirt.org/25977
To unsubscribe, visit htt
Francesco Romani has posted comments on this change.
Change subject: virt: migration: use contextmanager for monitor
..
Patch Set 18:
s/25979/26279/
--
To view, visit http://gerrit.ovirt.org/25978
To unsubscribe, visit http:/
Francesco Romani has posted comments on this change.
Change subject: virt: migration: add monitor thread control loop
..
Patch Set 16:
s/25979/26279/
--
To view, visit http://gerrit.ovirt.org/25976
To unsubscribe, visit http:
Francesco Romani has posted comments on this change.
Change subject: virt: migration: decouple monitoring from thread
..
Patch Set 7: Verified+1
Verified with 25976, 25977, 25978 running migrations a few times and observing
th
oVirt Jenkins CI Server has posted comments on this change.
Change subject: xen: do not attempt to read underlying device info
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9688/
Dan Kenigsberg has posted comments on this change.
Change subject: libvirtconnection: refactor: open a new connection in special
function
..
Patch Set 1: Verified+1
Verified by running unit tests. Has no functional effect.
--
oVirt Jenkins CI Server has posted comments on this change.
Change subject: xen: hook: let oVirt run VMs on Xen hosts
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9689/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: _findLiveSnapshotSupport: do not assume that guest
exist
..
Patch Set 1: Verified+1
Verified to have no effect on qemu:///system connections, and to return No
Francesco Romani has posted comments on this change.
Change subject: _findLiveSnapshotSupport: do not assume that guest
exist
..
Patch Set 1: Code-Review+1
there is probably room for a beautification, but this can surely wait
oVirt Jenkins CI Server has posted comments on this change.
Change subject: upgrade_unified: fix for nicless and bridges with vnics
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9690/
Vinzenz Feenstra has posted comments on this change.
Change subject: virt: migration: replace magic number
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28356
To unsubscribe, visit http://gerrit.ovirt
Vinzenz Feenstra has posted comments on this change.
Change subject: virt: migration: rename helper function
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28355
To unsubscribe, visit http://gerrit.ovi
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: use contextmanager for monitor
..
Patch Set 18:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9691/ :
Vinzenz Feenstra has posted comments on this change.
Change subject: virt: migration: use contextmanager for monitor
..
Patch Set 18: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25978
To unsubscribe, visit http://g
Vinzenz Feenstra has posted comments on this change.
Change subject: virt: migration: merge monitor and downtime thread
..
Patch Set 17: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25977
To unsubscribe, visit http:
Vinzenz Feenstra has posted comments on this change.
Change subject: virt: migration: decouple monitoring from thread
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26279
To unsubscribe, visit http://g
Vinzenz Feenstra has posted comments on this change.
Change subject: virt: migration: add monitor thread control loop
..
Patch Set 16: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25976
To unsubscribe, visit http://
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: merge monitor and downtime thread
..
Patch Set 17:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9692/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: add monitor thread control loop
..
Patch Set 16:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9693/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: decouple monitoring from thread
..
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9694/ : FAIL
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: rename helper function
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9695/ : FAILURE
http
Francesco Romani has uploaded a new change for review.
Change subject: vm: fix odd migration progress reporting
..
vm: fix odd migration progress reporting
migration progress should not start from 100,
otherwise the user will se
Francesco Romani has posted comments on this change.
Change subject: vm: fix odd migration progress reporting
..
Patch Set 1:
this patch is not the same of master due to recent refactorings.
--
To view, visit http://gerrit.ov
Francesco Romani has abandoned this change.
Change subject: vm: fix odd migration progress reporting
..
Abandoned
will do proper cherry-pick to make automation happy
--
To view, visit http://gerrit.ovirt.org/28362
To unsubscr
Hello Tomas Jelinek, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/28363
to review the following change.
Change subject: vm: fix odd migration progress reporting
..
vm: fix odd mig
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: replace magic number
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9696/ : SUCCESS
ht
Federico Simoncelli has posted comments on this change.
Change subject: sp: ensure that master domain is active
..
Patch Set 2: Verified+1
Verified:
* it is impossible to connect to a pool where the master domain is attached
Federico Simoncelli has posted comments on this change.
Change subject: sp: prevent master demotion on activation
..
Patch Set 2: Verified+1
Verified (regular flow only):
* it is possible to activate a storage domain
--
To v
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: ensure that master domain is active
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9697/ : FAILURE
http
Dan Kenigsberg has submitted this change and it was merged.
Change subject: sp: ensure that master domain is active
..
sp: ensure that master domain is active
It's not possible to be connected to a pool where the master domain
Dan Kenigsberg has posted comments on this change.
Change subject: sp: ensure that master domain is active
..
Patch Set 2: Code-Review+2
Seems reasonable to me.
--
To view, visit http://gerrit.ovirt.org/28331
To unsubscribe,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: ensure that master domain is active
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1385/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: prevent master demotion on activation
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9698/ : SUCCESS
Dan Kenigsberg has submitted this change and it was merged.
Change subject: mutipath: Remove unneeded and dangerous -r parameter
..
mutipath: Remove unneeded and dangerous -r parameter
Since commit dbf2089488 (Jul 9 2013) multi
oVirt Jenkins CI Server has posted comments on this change.
Change subject: mutipath: Remove unneeded and dangerous -r parameter
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/138
Dan Kenigsberg has posted comments on this change.
Change subject: Fix memShared units when reported from MOM
..
Patch Set 1:
I do not really mind this patch, but strictly speaking, the ovirt-3.3 branch is
no longer supported.
David Caro has abandoned this change.
Change subject: IGNORE: testing gerrit triggered jobs
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/26570
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageTyp
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/28379
to review the following change.
Change subject: hsm: unify vm ovf management lock
..
hsm: unify vm ovf management lock
Ta
Dan Kenigsberg has posted comments on this change.
Change subject: faqemu hook: move memory limitation to config
..
Patch Set 1: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/28320/1//COMMIT_MSG
Commit Message:
Line
Dan Kenigsberg has posted comments on this change.
Change subject: sp: prevent master demotion on activation
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/28332/2/vdsm/storage/sp.py
File vdsm/storage/sp.py:
Line 104
Dan Kenigsberg has abandoned this change.
Change subject: drop ominous log for libvirt errors
..
Abandoned
I reserve the right to restore this patch, and remove the needless log line.
--
To view, visit http://gerrit.ovirt.org
oVirt Jenkins CI Server has posted comments on this change.
Change subject: net: janitorial: format log messages lazily
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9699/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: faqemu: move hook logic out of vdsm
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9700/ : FAILURE
http://j
Dan Kenigsberg has posted comments on this change.
Change subject: net: janitorial: format log messages lazily
..
Patch Set 2: Verified+1
Passes the network functional tests, no functional change.
--
To view, visit http://ger
70 matches
Mail list logo
