Change in vdsm[master]: do not wait for dhcp

2014-10-05 Thread ibarkan
Ido Barkan has uploaded a new change for review. Change subject: do not wait for dhcp .. do not wait for dhcp Change-Id: I06fc809666a5859204c37956c9c958322a3cceab Signed-off-by: ibarkan --- M tests/functional/networkTests.py 1

Change in vdsm[master]: fixing according to review:

2014-10-05 Thread ibarkan
Ido Barkan has uploaded a new change for review. Change subject: fixing according to review: .. fixing according to review: removed wait_for_predicate() because we use the blocking mode of DHCP and also because it re-implemented

Change in vdsm[master]: Functional test for Multiple Gateways source routing

2014-10-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Functional test for Multiple Gateways source routing .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12763/

Change in vdsm[master]: do not wait for dhcp

2014-10-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: do not wait for dhcp .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12764/ : SUCCESS http://jenkins.ovirt.

Change in vdsm[master]: fixing according to review:

2014-10-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: fixing according to review: .. Patch Set 1: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12765/

Change in vdsm[master]: fixing according to review:

2014-10-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: fixing according to review: .. Patch Set 1: Code-Review-1 the fix should be squashed into the original change in your private git, and posted as a new post set

Change in vdsm[master]: protocol_acceptor: Make SSL handshake asynchronous

2014-10-05 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: protocol_acceptor: Make SSL handshake asynchronous .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/33657/3/vdsm/protocoldetector.py File vdsm/protocolde

Change in vdsm[master]: vdsm: require kernel-2.6.32-465 on for NFSv4 fixes

2014-10-05 Thread ykleinbe
Yoav Kleinberger has uploaded a new change for review. Change subject: vdsm: require kernel-2.6.32-465 on for NFSv4 fixes .. vdsm: require kernel-2.6.32-465 on for NFSv4 fixes This patch updates vdsm's dependencies to incorporat

Change in vdsm[master]: better error reporting when configuring source routing

2014-10-05 Thread ibarkan
Ido Barkan has uploaded a new change for review. Change subject: better error reporting when configuring source routing .. better error reporting when configuring source routing Change-Id: I09337470478aa73c8aa06ec129d0105b5f93bb

Change in vdsm[master]: net: source route: don't attempt to configure invalid values

2014-10-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: net: source route: don't attempt to configure invalid values .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created

Change in vdsm[master]: Functional test for Multiple Gateways source routing

2014-10-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Functional test for Multiple Gateways source routing .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12768/

Change in vdsm[master]: better error reporting when configuring source routing

2014-10-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: better error reporting when configuring source routing .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12769

Change in vdsm[master]: vdsm: require kernel-2.6.32-465 on for NFSv4 fixes

2014-10-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: require kernel-2.6.32-465 on for NFSv4 fixes .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12766/ :

Change in vdsm[master]: vdsm: require kernel-2.6.32-465 on for NFSv4 fixes

2014-10-05 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: vdsm: require kernel-2.6.32-465 on for NFSv4 fixes .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/33810 To unsubscribe, visit http://ge

Change in vdsm[master]: better error reporting when configuring source routing

2014-10-05 Thread ibarkan
Ido Barkan has abandoned this change. Change subject: better error reporting when configuring source routing .. Abandoned git mistake- this patch isn't needed -- To view, visit http://gerrit.ovirt.org/33812 To unsubscribe, vi

Change in vdsm[master]: net: source route: don't attempt to configure invalid values

2014-10-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: net: source route: don't attempt to configure invalid values .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created

Change in vdsm[master]: vdsm: require kernel-2.6.32-465 on for NFSv4 fixes

2014-10-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: require kernel-2.6.32-465 on for NFSv4 fixes .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12770/ :

Change in vdsm[master]: ioprocess: Move and reword rename() warning log line

2014-10-05 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: ioprocess: Move and reword rename() warning log line .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/32194/1/vdsm/storage/outOfProcess.py File vdsm/stor

Change in vdsm[master]: vdsm: require kernel-2.6.32-465 on for NFSv4 fixes

2014-10-05 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: vdsm: require kernel-2.6.32-465 on for NFSv4 fixes .. Patch Set 2: Code-Review-1 (2 comments) This kernel build isn't available for EL6 http://gerrit.ovirt.or

Change in vdsm[master]: utils: Move functionality from storage.misc

2014-10-05 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: utils: Move functionality from storage.misc .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/31583 To unsubscribe, visit http://gerrit.o

Change in vdsm[master]: Move multipath configuration to vdsm-tool configurator

2014-10-05 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Move multipath configuration to vdsm-tool configurator .. Patch Set 13: I intend to agree with nir about the code changes. most of the comments I had were abou

Change in vdsm[master]: ioprocess: Move and reword rename() warning

2014-10-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ioprocess: Move and reword rename() warning .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12772/ : SUC

Change in vdsm[master]: vdsm-infra: zombie-reaper refactor

2014-10-05 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: vdsm-infra: zombie-reaper refactor .. Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/31301/1/configure.ac File configure.ac: Line 132: AC_SUBST([vdsmtsd

Change in vdsm[master]: sslutils: Support non-blocking accept_ssl

2014-10-05 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: sslutils: Support non-blocking accept_ssl .. sslutils: Support non-blocking accept_ssl Previously the client socket was in blocking mode when accept_ssl() was call

Change in vdsm[master]: sslutils: Support non-blocking accept_ssl

2014-10-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: sslutils: Support non-blocking accept_ssl .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12773/ : SUCCE

Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required

2014-10-05 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Signs vdsm upgraded version for special treatment if required .. Patch Set 15: looks smoothly :) -- To view, visit http://gerrit.ovirt.org/31561 To unsubscrib

Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required

2014-10-05 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Signs vdsm upgraded version for special treatment if required .. Patch Set 15: Verified+1 -- To view, visit http://gerrit.ovirt.org/31561 To unsubscribe, visit

Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required

2014-10-05 Thread mtayer
mooli tayer has posted comments on this change. Change subject: Signs vdsm upgraded version for special treatment if required .. Patch Set 15: Code-Review-1 -- To view, visit http://gerrit.ovirt.org/31561 To unsubscribe, visit

Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required

2014-10-05 Thread mtayer
mooli tayer has posted comments on this change. Change subject: Signs vdsm upgraded version for special treatment if required .. Patch Set 15: (1 comment) http://gerrit.ovirt.org/#/c/31561/15/vdsm.spec.in File vdsm.spec.in: L

Change in vdsm[master]: ioprocess: Move and reword rename() warning

2014-10-05 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: ioprocess: Move and reword rename() warning .. Patch Set 2: Code-Review+1 Thanks. -- To view, visit http://gerrit.ovirt.org/32194 To unsubscribe, visit http://ger

Change in vdsm[master]: do not wait for dhcp

2014-10-05 Thread ibarkan
Ido Barkan has abandoned this change. Change subject: do not wait for dhcp .. Abandoned git mistake. should have been ammended by following commits -- To view, visit http://gerrit.ovirt.org/33797 To unsubscribe, visit http://

Change in vdsm[master]: fixing according to review:

2014-10-05 Thread ibarkan
Ido Barkan has abandoned this change. Change subject: fixing according to review: .. Abandoned git mistake- this should have been amended by following commits -- To view, visit http://gerrit.ovirt.org/33798 To unsubscribe, vi

Change in vdsm[master]: tool: avoid swallowing errors in seboolsetup calls.

2014-10-05 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: tool: avoid swallowing errors in seboolsetup calls. .. Patch Set 2: I agree that sebool-* verb should be converted to configurator class (\package), with is-co

Change in vdsm[master]: ioprocess: Move and reword rename() warning

2014-10-05 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: ioprocess: Move and reword rename() warning .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/32194/2/vdsm/storage/outOfProcess.py File vdsm/storage/outO

Change in vdsm[master]: ioprocess: Move and reword rename() warning

2014-10-05 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: ioprocess: Move and reword rename() warning .. Patch Set 2: Code-Review-1 after reading the commit msg...(sorry to miss that before) i don't see why we need th

Change in vdsm[master]: Functional test for Multiple Gateways source routing

2014-10-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Functional test for Multiple Gateways source routing .. Patch Set 4: Code-Review-1 (4 comments) http://gerrit.ovirt.org/#/c/33612/4/tests/functional/dhcp.py Fi

Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required

2014-10-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Signs vdsm upgraded version for special treatment if required .. Patch Set 15: -Code-Review -- To view, visit http://gerrit.ovirt.org/31561 To unsubscribe, vis

Change in vdsm[master]: ioprocess: Move and reword rename() warning

2014-10-05 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: ioprocess: Move and reword rename() warning .. Patch Set 2: Yaniv, using warnings, we have the required control where and how to see the warnings, for example, as

Change in vdsm[master]: virt: sampling: consolidate disk statistics

2014-10-05 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: virt: sampling: consolidate disk statistics .. Patch Set 5: Code-Review-1 (3 comments) Please remove unrelated changes. http://gerrit.ovirt.org/#/c/29953/5/vdsm/v

Change in vdsm[master]: utils: Move functionality from storage.misc

2014-10-05 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: utils: Move functionality from storage.misc .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/31583 To unsubscribe, visit http://gerrit.ovirt

Change in vdsm[master]: getExternalVmList

2014-10-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: getExternalVmList .. Patch Set 2: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12774/ : FAILURE

Change in vdsm[master]: sslutils: Support non-blocking accept_ssl

2014-10-05 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sslutils: Support non-blocking accept_ssl .. Patch Set 1: Verified+1 Verified with xmlrpc: - Start host, put host to maintenance - Reboot host when host is active

Change in vdsm[master]: utils: Move functionality from storage.misc

2014-10-05 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: utils: Move functionality from storage.misc .. Patch Set 5: Yeela, can you verify? there is no reason to wait with such simple and safe patch. -- To view, visit

Change in vdsm[master]: Functional test for Multiple Gateways source routing

2014-10-05 Thread amuller
Assaf Muller has posted comments on this change. Change subject: Functional test for Multiple Gateways source routing .. Patch Set 4: Code-Review-1 (7 comments) http://gerrit.ovirt.org/#/c/33612/4/AUTHORS File AUTHORS: Line 1

Change in vdsm[master]: netinfotests: Do not assume the existence of /var/lib/vdsm/b...

2014-10-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfotests: Do not assume the existence of /var/lib/vdsm/bonding-defaults.json .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_

Change in vdsm[master]: netinfotests: Do not assume the existence of /var/lib/vdsm/b...

2014-10-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: netinfotests: Do not assume the existence of /var/lib/vdsm/bonding-defaults.json .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33766

Change in vdsm[master]: Functional test for Multiple Gateways source routing

2014-10-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Functional test for Multiple Gateways source routing .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/33612/4/AUTHORS File AUTHORS: Line 11: Patches ha

Change in vdsm[master]: netinfotests: Do not assume the existence of /var/lib/vdsm/b...

2014-10-05 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: netinfotests: Do not assume the existence of /var/lib/vdsm/bonding-defaults.json .. Patch Set 5: Verified+1 Unit tests in the source tree and in /usr/share/vds

Change in vdsm[ovirt-3.5]: netinfo, tool: Add a vdsm-tool to determine bonding defaults...

2014-10-05 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults offline .. Patch Set 1: I am inclined to squash the follow-up fix into this patch, putting TWO Ch

Change in vdsm[master]: domainMonitor: Cleanup logging

2014-10-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: domainMonitor: Cleanup logging .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12776/ : SUCCESS http://

Change in vdsm[master]: domainMonitor: Cleanup logging

2014-10-05 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: domainMonitor: Cleanup logging .. Patch Set 4: Verified+1 Rebase and verify on RHEL 6.5 and 7 with iscsi storage. - Activate spm/hsm - Put host spm/hsm to maintena

Change in vdsm[master]: volume: Log the correct error when creating a volume fails

2014-10-05 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: volume: Log the correct error when creating a volume fails .. Patch Set 2: Verified+1 Rebase - no code change. Verified by creating volume with vdsClient. -- To

Change in vdsm[master]: volume: Log the correct error when creating a volume fails

2014-10-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: volume: Log the correct error when creating a volume fails .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit-tests_creat

Change in vdsm[master]: sslutils: Support non-blocking accept_ssl

2014-10-05 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sslutils: Support non-blocking accept_ssl .. Patch Set 1: Verified also when using ssl=false (no regressions). -- To view, visit http://gerrit.ovirt.org/33815 To

Change in vdsm[master]: vdsm-infra: zombie-reaper refactor

2014-10-05 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm-infra: zombie-reaper refactor .. Patch Set 1: (1 comment) I don't have anything too important to comment on. lets push new version of it, without the tab

Change in vdsm[master]: virt: sampling: consolidate disk statistics

2014-10-05 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: sampling: consolidate disk statistics .. Patch Set 5: (3 comments) http://gerrit.ovirt.org/#/c/29953/5/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 219:

Change in vdsm[master]: domainMonitor: Cleanup logging

2014-10-05 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: domainMonitor: Cleanup logging .. domainMonitor: Cleanup logging - Use INFO level for the important state change message, and uppercase VALID and INV