Change in vdsm[master]: vm: make _set_lastStatus safer

2014-12-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: make _set_lastStatus safer .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-el6-x86_64_merged/72/ : FAI

Change in vdsm[master]: networkTests: Extend a test to also consider DHCPv6

2014-12-05 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: networkTests: Extend a test to also consider DHCPv6 .. Patch Set 37: (4 comments) Some clarification, hopefully. http://gerrit.ovirt.org/#/c/30532/37/tests/fu

Change in vdsm[master]: net tests: rename temporary variable

2014-12-05 Thread danken
Dan Kenigsberg has uploaded a new change for review. Change subject: net tests: rename temporary variable .. net tests: rename temporary variable vdsm_net is too confusing with self.vdsm_net. Change-Id: I7f7bc32a0014d83a3ee

Change in vdsm[master]: network: unified configureLibvirtNetwork parameters

2014-12-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: unified configureLibvirtNetwork parameters .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-el6-x86

Change in vdsm[master]: vm: make _set_lastStatus safer

2014-12-05 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: make _set_lastStatus safer .. vm: make _set_lastStatus safer It is not safe to set concurrently state of a VM, because the function which does that

Change in vdsm[master]: vm: make _set_lastStatus safer

2014-12-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vm: make _set_lastStatus safer .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/35896 To unsubscribe, visit http://gerrit.ovirt.org/sett

Change in vdsm[master]: vm: leave VM responsive when sampling ends

2014-12-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: leave VM responsive when sampling ends .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13913/ : SUCCESS http:/

Change in vdsm[master]: vm: make _set_lastStatus safer

2014-12-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: make _set_lastStatus safer .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13914/ : SUCCESS http://jenkins.ovi

Change in vdsm[master]: vm: make _set_lastStatus safer

2014-12-05 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: make _set_lastStatus safer .. Patch Set 3: Verified+1 changed comment and commit message, thus copying score from last revision. -- To view, visit http:

Change in vdsm[master]: Adding removeConf to sanlock module

2014-12-05 Thread dougsland
Douglas Schilling Landgraf has abandoned this change. Change subject: Adding removeConf to sanlock module .. Abandoned -- To view, visit http://gerrit.ovirt.org/26055 To unsubscribe, visit http://gerrit.ovirt.org/settings Ger

Change in vdsm[master]: vdsm-tool: add the cmd get-ca-issuer

2014-12-05 Thread dougsland
Douglas Schilling Landgraf has abandoned this change. Change subject: vdsm-tool: add the cmd get-ca-issuer .. Abandoned -- To view, visit http://gerrit.ovirt.org/27651 To unsubscribe, visit http://gerrit.ovirt.org/settings Ge

Change in vdsm[master]: Add man page for vdsm.conf

2014-12-05 Thread dougsland
Douglas Schilling Landgraf has abandoned this change. Change subject: Add man page for vdsm.conf .. Abandoned -- To view, visit http://gerrit.ovirt.org/22891 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-Messa

Change in vdsm[master]: vm: leave VM responsive when sampling ends

2014-12-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: leave VM responsive when sampling ends .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13912/ : SUCCESS http:/

Change in vdsm[master]: vm: make _set_lastStatus safer

2014-12-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: make _set_lastStatus safer .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13911/ : SUCCESS http://jenkins.ovi

Change in vdsm[master]: ipwrapperTests: prevent infinite stuck

2014-12-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ipwrapperTests: prevent infinite stuck .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13909/ : SUCCESS http://jen

Change in vdsm[master]: ipwrapperTests: prevent infinite stuck

2014-12-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ipwrapperTests: prevent infinite stuck .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13908/ : SUCCESS http://jen

Change in vdsm[master]: networkTests: Extend a test to also consider DHCPv6

2014-12-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: networkTests: Extend a test to also consider DHCPv6 .. Patch Set 37: Code-Review-1 (4 comments) http://gerrit.ovirt.org/#/c/30532/37/tests/functional/dhcp.py F

Change in vdsm[master]: vm: leave VM responsive when sampling ends

2014-12-05 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: vm: leave VM responsive when sampling ends .. vm: leave VM responsive when sampling ends There is a known and (usually) benign race between the sampling thre

Change in vdsm[master]: libnl: non-existing link returns exception instead of None

2014-12-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: libnl: non-existing link returns exception instead of None .. Patch Set 15: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/34690/15/lib/vdsm/netlink/lin

Change in vdsm[master]: network: unified configureLibvirtNetwork parameters

2014-12-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: network: unified configureLibvirtNetwork parameters .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/34198 To unsubscribe, visit http://

Change in vdsm[master]: network: unified configureLibvirtNetwork parameters

2014-12-05 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: network: unified configureLibvirtNetwork parameters .. network: unified configureLibvirtNetwork parameters configureLibvirtNetwork() parameters in ipro

Change in vdsm[master]: ipwrapperTests: prevent infinite stuck

2014-12-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: ipwrapperTests: prevent infinite stuck .. Patch Set 2: Code-Review-1 (3 comments) http://gerrit.ovirt.org/#/c/35901/2/tests/ipwrapperTests.py File tests/ipwrap

Change in vdsm[master]: ipwrapperTests: prevent infinite stuck

2014-12-05 Thread phoracek
Petr Horáček has uploaded a new change for review. Change subject: ipwrapperTests: prevent infinite stuck .. ipwrapperTests: prevent infinite stuck In case when iterator.next() has nothing to return, thread stuck. To prevent thi

Change in vdsm[master]: vm: make _set_lastStatus safer

2014-12-05 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: make _set_lastStatus safer .. Patch Set 1: Verified+1 Verification: addressing a race, there is still room for uncertainity. However: - basic sanity check

Change in vdsm[master]: vdsm: expose hostdev via vdsClient

2014-12-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: expose hostdev via vdsClient .. Patch Set 11: Build Failed http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-el6-x86_64_merged/70/

Change in vdsm[master]: tests: Add tests for registering instancemethod

2014-12-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Add tests for registering instancemethod .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-el6-x86_64_

Change in vdsm[master]: networkTests: Introduce IPv6_ADDRESS_AND_CIDR

2014-12-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: networkTests: Introduce IPv6_ADDRESS_AND_CIDR .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-el6-x86_64_me

Change in vdsm[master]: networkTests: Reorganize parameters to dnsmasq and improve c...

2014-12-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: networkTests: Reorganize parameters to dnsmasq and improve comments .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master-libfapi_cr

Change in vdsm[master]: vm: make _set_lastStatus safer

2014-12-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: make _set_lastStatus safer .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13907/ : SUCCESS http://jenkins.ovi

Change in vdsm[master]: vm: make _set_lastStatus safer

2014-12-05 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: vm: make _set_lastStatus safer .. vm: make _set_lastStatus safer It is not safe to set concurrently state of a VM, because the function which does that is no

Change in vdsm[master]: storage: Fix VMPathNotExists text

2014-12-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: storage: Fix VMPathNotExists text .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-el6-x86_64_merged/66/ :

Change in vdsm[master]: networkTests: Introduce IPv6_ADDRESS_AND_CIDR

2014-12-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: networkTests: Introduce IPv6_ADDRESS_AND_CIDR .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13879/ : SUCCESS htt

Change in vdsm[master]: networkTests: Fix operator precedence so a parameter to dnsm...

2014-12-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: networkTests: Fix operator precedence so a parameter to dnsmasq is not empty .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master-l

Change in vdsm[master]: Fixed parted utils for newer parted

2014-12-05 Thread dcaroest
David Caro has posted comments on this change. Change subject: Fixed parted utils for newer parted .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/35700 To unsubscribe, visit http://gerrit.ovirt.org/settin

Change in vdsm[master]: gluster: add glusterStorageDevicesList verb

2014-12-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: gluster: add glusterStorageDevicesList verb .. Patch Set 11: Code-Review-1 New verbs must appear in the schema, too. -- To view, visit http://gerrit.ovirt.org

Change in vdsm[master]: net_func_tests: add calling method name to setupNetworks

2014-12-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: net_func_tests: add calling method name to setupNetworks .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-el

Change in vdsm[master]: Add the missing --enable-rhev definition to configure.ac

2014-12-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add the missing --enable-rhev definition to configure.ac .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-el

Change in vdsm[master]: networkTests: Extend a test to also consider DHCPv6

2014-12-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: networkTests: Extend a test to also consider DHCPv6 .. Patch Set 35: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13878/ : SUCCE

Change in vdsm[master]: net_func_tests: add calling method name to setupNetworks

2014-12-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: net_func_tests: add calling method name to setupNetworks .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13875/ : S

Change in vdsm[master]: Restore the default value of rhev_build in the spec file

2014-12-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Restore the default value of rhev_build in the spec file .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-el

Change in vdsm[master]: sampling: live merge: avoid wasteful picklecopy

2014-12-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: sampling: live merge: avoid wasteful picklecopy .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-el6-x86_64_

Change in vdsm[master]: virt: log.error(exc_info=True) -> log.exception()

2014-12-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: log.error(exc_info=True) -> log.exception() .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-el6-x86_6

Change in vdsm[master]: jsonrpc: VM_updateVmPolicy

2014-12-05 Thread msivak
Martin Sivák has posted comments on this change. Change subject: jsonrpc: VM_updateVmPolicy .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35556 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: jsonrpc: VM_setIoTune

2014-12-05 Thread msivak
Martin Sivák has posted comments on this change. Change subject: jsonrpc: VM_setIoTune .. Patch Set 2: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/35554/2/vdsm/rpc/Bridge.py File vdsm/rpc/Bridge.py: Line 463: 'V

Change in vdsm[master]: jsonrpc: VM_setCpuTuneQuota

2014-12-05 Thread msivak
Martin Sivák has posted comments on this change. Change subject: jsonrpc: VM_setCpuTuneQuota .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35553 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: jsonrpc: VM_setCpuTunePeriod

2014-12-05 Thread msivak
Martin Sivák has posted comments on this change. Change subject: jsonrpc: VM_setCpuTunePeriod .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35552 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: hooks: Remove sudo use from ethtool_options hooks

2014-12-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: hooks: Remove sudo use from ethtool_options hooks .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-el6-x86_6

Change in vdsm[master]: vdscli: 'port' argument must be an int

2014-12-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdscli: 'port' argument must be an int .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-el6-x86_64_merged/57

Change in vdsm[master]: tests: add vdscli.cannonizeHostPort unit tests

2014-12-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: add vdscli.cannonizeHostPort unit tests .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-el6-x86_64_m

Change in vdsm[master]: xmlrpc: remove useless 'serverPort' attribute

2014-12-05 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: xmlrpc: remove useless 'serverPort' attribute .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master-libfapi_create-rpms-el6-x86_64_me

Change in vdsm[ovirt-3.5]: sosreport: remove Base class

2014-12-05 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: sosreport: remove Base class .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35879 To unsubscribe, visit http://gerrit.ovirt.org/sett