Yaniv Bronhaim has submitted this change and it was merged.
Change subject: spec: require latest version of IOProcess
..
spec: require latest version of IOProcess
This version includes an important fix for
IOProcess being
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo._parse_lease_file: change order of branches, to aid
reading
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/36851
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: netinfo._parse_lease_file: change order of branches, to aid
reading
..
netinfo._parse_lease_file: change order of branches, to aid reading
We first
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: oop: Use a single instance of IOProcess per SD
..
oop: Use a single instance of IOProcess per SD
Next step after switching from RFH to IOPROC is to
Yaniv Bronhaim has posted comments on this change.
Change subject: oop: Use a single instance of IOProcess per SD
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/36953
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: Split a DHCPv4-specific portion from a branch in
_parse_lease_file
..
Patch Set 3: Code-Review+2
(1 comment)
Nir Soffer has posted comments on this change.
Change subject: Simplify tests for qemuimg to allow additional capabilities
checks
..
Patch Set 5:
(5 comments)
http://gerrit.ovirt.org/#/c/36366/5//COMMIT_MSG
Commit Message:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: fix volume name parsing in getVmVolumeInfo
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15071/
Nir Soffer has posted comments on this change.
Change subject: tests: -T src_cache option in qemu-img convert command
..
Patch Set 2:
(1 comment)
Please check the jenkins server failures.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: Do not require the callers of _get_dhclient_ifaces to
know the paths
..
Patch Set 2:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: report 'dhcpv6' based on dhclient-6 leases
..
Patch Set 17:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: Split a DHCPv4-specific portion from a branch in
_parse_lease_file
..
Patch Set 4:
Build Failed
Nir Soffer has posted comments on this change.
Change subject: virt: Optimize guest agent string filtering
..
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/36630/6/vdsm/virt/guestagent.py
File vdsm/virt/guestagent.py:
Nir Soffer has posted comments on this change.
Change subject: qemu-img convert: check/use -T src_cache option when available
..
Patch Set 8: Code-Review+1
Thanks Amador!
--
To view, visit http://gerrit.ovirt.org/36308
To
Dan Kenigsberg has posted comments on this change.
Change subject: tests: deduplicate clientIF fakes
..
Patch Set 2: Code-Review-1
(3 comments)
/me is not sure regrading the benefit of this.
Nir Soffer has posted comments on this change.
Change subject: virt: cleaner getAllVmStats
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35140
To unsubscribe, visit http://gerrit.ovirt.org/settings
oVirt Jenkins CI Server has posted comments on this change.
Change subject: oop: Use a single instance of IOProcess per SD
..
Patch Set 3:
Build Successful
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: cleaner retrieval of graphics stats
..
vm: cleaner retrieval of graphics stats
Device object and device configuration
data are kept in sync, so
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: cleaner getVMList implementation
..
virt: cleaner getVMList implementation
Avoid wasteful work and make
the verb implementation cleaner with no
Dan Kenigsberg has posted comments on this change.
Change subject: vm: cleaner retrieval of graphics stats
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/36791
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: virt: cleaner getVMList implementation
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/35139
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netlink: event monitor
..
Patch Set 21:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/302/ :
FAILURE
Dan Kenigsberg has submitted this change and it was merged.
Change subject: netinfo: report 'dhcpv6' based on dhclient-6 leases
..
netinfo: report 'dhcpv6' based on dhclient-6 leases
Change-Id:
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: report 'dhcpv6' based on dhclient-6 leases
..
Patch Set 16: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/35985
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: report 'dhcpv6' based on dhclient-6 leases
..
Patch Set 16:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15070/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: spec: require latest version of IOProcess
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/155/ :
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: Do not require the callers of _get_dhclient_ifaces to
know the paths
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/36950
Dan Kenigsberg has submitted this change and it was merged.
Change subject: netinfo: Do not require the callers of _get_dhclient_ifaces to
know the paths
..
netinfo: Do not require the callers of _get_dhclient_ifaces to know
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netlink: event monitor
..
Patch Set 22:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/303/ :
SUCCESS
Dan Kenigsberg has submitted this change and it was merged.
Change subject: netinfo: Split a DHCPv4-specific portion from a branch in
_parse_lease_file
..
netinfo: Split a DHCPv4-specific portion from a branch in
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: Split a DHCPv4-specific portion from a branch in
_parse_lease_file
..
Patch Set 3:
(1 comment)
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Revert supervdsm: Add zombiereaper to supervdsm
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15068/
Nir Soffer has posted comments on this change.
Change subject: virt: Check the full range of replaceble chars in filtering
..
Patch Set 1:
(5 comments)
http://gerrit.ovirt.org/#/c/36952/1/tests/guestagentTests.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: netlink: event monitor
..
Patch Set 22: Code-Review-1
--
To view, visit http://gerrit.ovirt.org/36197
To unsubscribe, visit http://gerrit.ovirt.org/settings
Dan Kenigsberg has posted comments on this change.
Change subject: netlink: event monitor
..
Patch Set 22:
(7 comments)
http://gerrit.ovirt.org/#/c/36197/22/lib/vdsm/netlink/monitor.py
File lib/vdsm/netlink/monitor.py:
Line
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo._parse_lease_file: change order of branches, to aid
reading
..
Patch Set 4:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo._parse_lease_file: change order of branches, to aid
reading
..
Patch Set 3:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: testSetupNetworksAddDelDhcp: Delete a lease file left over by
dhclient
..
Patch Set 1:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: adapt host outbound qos link share values so they would be
always divisible by 8
..
Patch Set 4:
Build Failed
Ondřej Svoboda has posted comments on this change.
Change subject: testSetupNetworksAddDelDhcp: Delete a lease file left over by
dhclient
..
Patch Set 2: Verified+1
Even though testSetupNetworksAddDelDhcp fails with
Ondřej Svoboda has uploaded a new change for review.
Change subject: testSetupNetworksAddDelDhcp: Delete a lease file left over by
dhclient
..
testSetupNetworksAddDelDhcp: Delete a lease file left over by dhclient
Change-Id:
Ondřej Svoboda has posted comments on this change.
Change subject: testSetupNetworksAddDelDhcp: Delete a lease file left over by
dhclient
..
Patch Set 2:
(1 comment)
Too much whitespace, but otherwise no unnecessary
Ondřej Svoboda has posted comments on this change.
Change subject: testSetupNetworksAddDelDhcp: Delete a lease file left over by
dhclient
..
Patch Set 6: Verified+1
The correct lease files were deleted after each iteration of
Federico Simoncelli has posted comments on this change.
Change subject: qemu-img convert: check/use -T src_cache option when available
..
Patch Set 8:
(1 comment)
http://gerrit.ovirt.org/#/c/36308/8/lib/vdsm/qemuimg.py
File
Ondřej Svoboda has posted comments on this change.
Change subject: testSetupNetworksAddDelDhcp: Extend to also consider DHCPv6
..
Patch Set 55: Verified+1
The test fails (expectedly) on source routing, but only in v4-only
oVirt Jenkins CI Server has posted comments on this change.
Change subject: testSetupNetworksAddDelDhcp: Delete a lease file left over by
dhclient
..
Patch Set 6:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: testSetupNetworksAddDelDhcp: Extend to also consider DHCPv6
..
Patch Set 55:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: testSetupNetworksAddDelDhcp: Extend to also consider DHCPv6
..
Patch Set 52:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: testSetupNetworksAddDelDhcp: Delete a lease file left over by
dhclient
..
Patch Set 3: Code-Review-1 Verified-1
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: testSetupNetworksAddDelDhcp: Extend to also consider DHCPv6
..
Patch Set 53: Code-Review-1 Verified-1
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: testSetupNetworksAddDelDhcp: Delete a lease file left over by
dhclient
..
Patch Set 4: Code-Review-1 Verified-1
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: testSetupNetworksAddDelDhcp: Delete a lease file left over by
dhclient
..
Patch Set 5: Code-Review-1 Verified-1
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: testSetupNetworksAddDelDhcp: Extend to also consider DHCPv6
..
Patch Set 54: Code-Review-1 Verified-1
Build Failed
Bala.FA has posted comments on this change.
Change subject: gluster: add glusterStorageDevicesList verb
..
Patch Set 15: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35028
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: testSetupNetworksAddDelDhcp: Delete a lease file left over by
dhclient
..
Patch Set 2:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: add createBrick verb
..
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15083/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: testSetupNetworksAddDelDhcp: Delete a lease file left over by
dhclient
..
Patch Set 7:
Build Failed
Francesco Romani has posted comments on this change.
Change subject: vm: cleaner retrieval of graphics stats
..
Patch Set 3:
(2 comments)
http://gerrit.ovirt.org/#/c/36791/3//COMMIT_MSG
Commit Message:
Line 3: AuthorDate:
Francesco Romani has posted comments on this change.
Change subject: vm: cleaner retrieval of graphics stats
..
Patch Set 4: Verified+1
Rebased, copied score.
--
To view, visit http://gerrit.ovirt.org/36791
To unsubscribe,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: cleaner retrieval of graphics stats
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15051/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: cleaner getVMList implementation
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15053/ : FAILURE
Ido Barkan has posted comments on this change.
Change subject: net test: unbreak qosTests
..
Patch Set 2: Code-Review+1
the exact change is mistakenly a part of http://gerrit.ovirt.org/#/c/36636/
(and should have been part of
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: cleaner getAllVmStats
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15052/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: virt: sampling: add bulk stats implementation
..
Patch Set 5:
(8 comments)
http://gerrit.ovirt.org/#/c/36722/5/vdsm/virt/sampling.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: sampling: vm: use bulk-stats-style sample format
..
Patch Set 3:
(2 comments)
http://gerrit.ovirt.org/#/c/36731/3/vdsm/virt/sampling.py
File
Francesco Romani has posted comments on this change.
Change subject: tests: add test case for getAllVmStats
..
Patch Set 2: Verified+1
with more careful rebase and the help of more caffeine (see comment to version
1), test
Francesco Romani has posted comments on this change.
Change subject: vm: cleaner retrieval of graphics stats
..
Patch Set 4:
...and fixed commit message.
--
To view, visit http://gerrit.ovirt.org/36791
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt: cleaner getVMList implementation
..
Patch Set 3: Verified+1
fixed commit message to reflect the sad truth - code is faster, but only on
almost useless
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: add test case for getAllVmStats
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15048/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: net test: unbreak qosTests
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15049/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: tests: Make it easy to debug assertXMLEqual failures
..
Patch Set 2: Code-Review+1
Nice idea. Like it.
--
To view, visit http://gerrit.ovirt.org/36930
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: deduplicate clientIF fakes
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15047/ : SUCCESS
Michal Skrivanek has posted comments on this change.
Change subject: vm: add debug log for getStats()
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/36732/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2293:
Daniel Erez has posted comments on this change.
Change subject: tests: Make it easy to debug assertXMLEqual failures
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/36930
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: avoid automatic start in __init__
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15050/ :
Ondřej Svoboda has uploaded a new change for review.
Change subject: netinfo: Do not require the callers of _get_dhclient_ifaces to
know the paths
..
netinfo: Do not require the callers of _get_dhclient_ifaces to know the paths
Vinzenz Feenstra has posted comments on this change.
Change subject: virt: Optimize guest agent string filtering
..
Patch Set 6:
Fully checked by unit tests, no breakage
--
To view, visit http://gerrit.ovirt.org/36630
To
Vinzenz Feenstra has posted comments on this change.
Change subject: virt: Check the full range of replaceble chars in filtering
..
Patch Set 1:
Extension also successfully checked
--
To view, visit
Vinzenz Feenstra has posted comments on this change.
Change subject: virt: Check the full range of replaceble chars in filtering
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/36952
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Only filter guest agent data, only on XMLRPC
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15055/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: Assess and report 'dhcpv6' from dhclient -6 leases,
with tests
..
Patch Set 15:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: net test: unbreak qosTests
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15056/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Check the full range of replaceble chars in filtering
..
Patch Set 1:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Only filter guest agent data, only on XMLRPC
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15063/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Only filter guest agent data, only on XMLRPC
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15062/ :
Vinzenz Feenstra has uploaded a new change for review.
Change subject: virt: Only filter guest agent data, only on XMLRPC
..
virt: Only filter guest agent data, only on XMLRPC
Change-Id:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Optimize guest agent string filtering
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15054/ :
Vinzenz Feenstra has posted comments on this change.
Change subject: virt: Optimize guest agent string filtering
..
Patch Set 6: Verified+1
--
To view, visit http://gerrit.ovirt.org/36630
To unsubscribe, visit
Hello Saggi Mizrahi, Dima Kuznetsov,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/36953
to review the following change.
Change subject: oop: Use a single instance of IOProcess per SD
..
oop: Use
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: Do not require the callers of _get_dhclient_ifaces to
know the paths
..
Patch Set 1:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: net test: unbreak qosTests
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15061/ : FAILURE
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net test: unbreak qosTests
..
net test: unbreak qosTests
commit a42f9854 moved a function without touching its test.
Change-Id:
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: Split a DHCPv4-specific portion from a branch in
_parse_lease_file
..
Patch Set 3:
Verified together with
netinfo: Assess and report 'dhcpv6' from
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: Split a DHCPv4-specific portion from a branch in
_parse_lease_file
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/36836
To
Ondřej Svoboda has posted comments on this change.
Change subject: net test: unbreak qosTests
..
Patch Set 4:
Sorry for the mess, the commit message and topic are now Dan's again.
Francesco, how did you or how can I cleanly
Vinzenz Feenstra has uploaded a new change for review.
Change subject: virt: Check the full range of replaceble chars in filtering
..
virt: Check the full range of replaceble chars in filtering
The string filtering now checks
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: Reflect the order of parsing in the order of branches,
to aid reading
..
Patch Set 2:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: Split a DHCPv4-specific portion from a branch in
_parse_lease_file
..
Patch Set 3:
Build Failed
Dan Kenigsberg has posted comments on this change.
Change subject: net test: unbreak qosTests
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/36909
To unsubscribe, visit
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: Do not require the callers of _get_dhclient_ifaces to
know the paths
..
Patch Set 1: Verified+1
Verified together with
netinfo: Assess and report
1 - 100 of 108 matches
Mail list logo