Change in vdsm[master]: netinfo: report DHCP from configuration to avoid confusion a...

2015-02-11 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: netinfo: report DHCP from configuration to avoid confusion after stopping DHCP .. Patch Set 9: Verified+1 The functional test passed on EL7 (okay, there's

Change in vdsm[master]: testSetupNetworksOverDhcpIface: respect the system version f...

2015-02-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: testSetupNetworksOverDhcpIface: respect the system version for dnsmasq .. Patch Set 1: Build Failed

Change in vdsm[master]: _get_gateway: allow duplicated gateways if they are in fact ...

2015-02-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: _get_gateway: allow duplicated gateways if they are in fact the same routes .. Patch Set 5: Build Failed

Change in vdsm[master]: gluster: add createBrick verb

2015-02-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: add createBrick verb .. Patch Set 17: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15616/ : SUCCESS

Change in vdsm[master]: netinfo: Replacing xml.dom.minidom with lxml.etree module

2015-02-11 Thread gcheresh
Genadi Chereshnya has uploaded a new change for review. Change subject: netinfo: Replacing xml.dom.minidom with lxml.etree module .. netinfo: Replacing xml.dom.minidom with lxml.etree module The change is done as etree is

Change in vdsm[master]: netinfo: Replacing xml.dom.minidom with lxml.etree module

2015-02-11 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: netinfo: Replacing xml.dom.minidom with lxml.etree module .. Patch Set 1: Code-Review-1 (1 comment) if lxml is required it should be a dependency. This should

Change in vdsm[master]: networkTests: give an instructory message when an address co...

2015-02-11 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: networkTests: give an instructory message when an address could not be added .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/37699 To

Change in vdsm[master]: gluster: Added gluster snapshot restore verb.

2015-02-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Added gluster snapshot restore verb. .. Patch Set 12: Build Failed

Change in vdsm[master]: netinfo: Replacing xml.dom.minidom with lxml.etree module

2015-02-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Replacing xml.dom.minidom with lxml.etree module .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15615/

Change in vdsm[master]: vm: bootstrap services using updateVolume

2015-02-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: bootstrap services using updateVolume .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2357/ :

Change in vdsm[master]: vm: stats: split up stats production

2015-02-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: stats: split up stats production .. Patch Set 11: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/438/ :

Change in vdsm[master]: virt: add ExpiringCache

2015-02-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: add ExpiringCache .. Patch Set 11: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2359/ : There was an

Change in vdsm[master]: clientIF: add API to get all registered VMs

2015-02-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: clientIF: add API to get all registered VMs .. Patch Set 11: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15562/ : SUCCESS

Change in vdsm[master]: vm: restore highWrite monitoring

2015-02-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: restore highWrite monitoring .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2360/ : There

Change in vdsm[master]: RFE: Report downtime for each live migration

2015-02-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 2: Build Failed

Change in vdsm[master]: virt: Add Drive.chunked property

2015-02-11 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: virt: Add Drive.chunked property .. Patch Set 4: This version address Federico comments, replacing extendable with chunked -- To view, visit

Change in vdsm[master]: v2v: additional info for disk and network

2015-02-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: v2v: additional info for disk and network .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15565/ : SUCCESS

Change in vdsm[master]: virt: Move status constant to vmstatus

2015-02-11 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: Move status constant to vmstatus .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/37677 To unsubscribe, visit

Change in vdsm[master]: RFE: Report downtime for each live migration

2015-02-11 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/37075/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1796:

Change in vdsm[master]: vm: stats: sample using bulk stats and services

2015-02-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: stats: sample using bulk stats and services .. Patch Set 13: Build Failed

Change in vdsm[master]: v2v: additional info for disk and network

2015-02-11 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: additional info for disk and network .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/37655/2/vdsm/v2v.py File vdsm/v2v.py: Line 132:

Change in vdsm[master]: virt: introduce the services infrastracture

2015-02-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: introduce the services infrastracture .. Patch Set 3: Build Failed

Change in vdsm[master]: vm: stats: cache metadata value

2015-02-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: stats: cache metadata value .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2354/ : There

Change in vdsm[master]: vm: add an API to check if the domain is busy

2015-02-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: add an API to check if the domain is busy .. Patch Set 12: Build Failed

Change in vdsm[master]: vm: guestagent: do not access guestinfo directly

2015-02-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: guestagent: do not access guestinfo directly .. Patch Set 3: Build Failed

Change in vdsm[master]: vm: move queryBlockJobs under services

2015-02-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: move queryBlockJobs under services .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2355/ :

Change in vdsm[master]: vm: drop now unused code

2015-02-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: drop now unused code .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2356/ : There was an

Change in vdsm[master]: virt: Add Drive.extendable property

2015-02-11 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: virt: Add Drive.extendable property .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/37570/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1406: #

Change in vdsm[master]: virt: Check if a drive is chuhked before extending

2015-02-11 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: virt: Check if a drive is chuhked before extending .. Patch Set 2: Updated to use new chunked property. -- To view, visit http://gerrit.ovirt.org/37573 To

Change in vdsm[master]: virt: add ExpiringCache

2015-02-11 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: add ExpiringCache .. Patch Set 10: (1 comment) http://gerrit.ovirt.org/#/c/36716/10/vdsm/virt/utils.py File vdsm/virt/utils.py: Line 77: Line 78:

Change in vdsm[master]: virt: add ExpiringCache

2015-02-11 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: add ExpiringCache .. Patch Set 11: Verified+1 fixed docstring. Verified using the tests. -- To view, visit http://gerrit.ovirt.org/36716 To

Change in vdsm[master]: RFE: Report downtime for each live migration

2015-02-11 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 2: Verified-1 -- To view, visit http://gerrit.ovirt.org/37075 To unsubscribe, visit

Change in vdsm[master]: v2v: additional info for disk and network

2015-02-11 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: additional info for disk and network .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/37655 To unsubscribe, visit

Change in vdsm[master]: virt: Invalidate drive blockDev when path changes

2015-02-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Invalidate drive blockDev when path changes .. Patch Set 2: Build Failed

Change in vdsm[master]: virt: Check if a drive is chuhked before extending

2015-02-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Check if a drive is chuhked before extending .. Patch Set 2: Build Failed

Change in vdsm[master]: virt: Add Drive.chunked property

2015-02-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Add Drive.chunked property .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2362/ : There

Change in vdsm[master]: virt: add ExpiringCache

2015-02-11 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: virt: add ExpiringCache .. Patch Set 11: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/36716 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: v2v: additional info for disk and network

2015-02-11 Thread fromani
Francesco Romani has posted comments on this change. Change subject: v2v: additional info for disk and network .. Patch Set 3: Code-Review+1 thanks for the updates! -- To view, visit http://gerrit.ovirt.org/37655 To

Change in vdsm[master]: vm: add missing vm id to get stats of down vm

2015-02-11 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: vm: add missing vm id to get stats of down vm .. Patch Set 2: @Francesco, I think the old code added the vm id automatically and now with json it is not.

Change in vdsm[master]: virt: Move status constant to vmstatus

2015-02-11 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: virt: Move status constant to vmstatus .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/37677 To unsubscribe, visit

Change in vdsm[master]: storageServer: Add log when isSession fails.

2015-02-11 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storageServer: Add log when isSession fails. .. Patch Set 1: This is already fixed http://gerrit.ovirt.org/36028 since Dec 17. -- To view, visit

Change in vdsm[master]: vm: add missing vm id to get stats of down vm

2015-02-11 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: add missing vm id to get stats of down vm .. Patch Set 3: mentioned the commit who broke the flow, no code changes. -- To view, visit

Change in vdsm[master]: vm: add missing vm id to get stats of down vm

2015-02-11 Thread ahadas
Arik Hadas has uploaded a new change for review. Change subject: vm: add missing vm id to get stats of down vm .. vm: add missing vm id to get stats of down vm The stats that are returned for a VM which is down does not

Change in vdsm[master]: vm: add missing vm id to get stats of down vm

2015-02-11 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: vm: add missing vm id to get stats of down vm .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/37694 To unsubscribe, visit

Change in vdsm[master]: Build gluster packages only for rhel 7 and above

2015-02-11 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Build gluster packages only for rhel 7 and above .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/37646/1//COMMIT_MSG Commit Message: Line 3:

Change in vdsm[master]: vm: add missing vm id to get stats of down vm

2015-02-11 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: add missing vm id to get stats of down vm .. Patch Set 2: Arik, please mention how you verified the patch, it is mandated to document this step by the

Change in vdsm[master]: vm: add missing vm id to get stats of down vm

2015-02-11 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: add missing vm id to get stats of down vm .. Patch Set 2: Code-Review+1 I don't see how it could be a regression, because in ovirt 3.4, before all the

Change in vdsm[master]: vm: add missing vm id to get stats of down vm

2015-02-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: add missing vm id to get stats of down vm .. Patch Set 2: Build Failed

Change in vdsm[master]: vm: add missing vm id to get stats of down vm

2015-02-11 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: add missing vm id to get stats of down vm .. Patch Set 2: Arik, right. Actually I broke it in my 7f577ab94b35f2cb2560d3ae49d6b0f753588474 because I

Change in vdsm[master]: virt: Invalidate drive blockDev when path changes

2015-02-11 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: virt: Invalidate drive blockDev when path changes .. Patch Set 3: This version fixes copy and paste error in the tests. -- To view, visit

Change in vdsm[master]: schema: require vmId in {Exited, Running}VmStats

2015-02-11 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: schema: require vmId in {Exited,Running}VmStats .. schema: require vmId in {Exited,Running}VmStats On http://gerrit.ovirt.org/#/c/37694/3 we were reminded

Change in vdsm[master]: vm: factor out common fields in vm stats

2015-02-11 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: vm: factor out common fields in vm stats .. vm: factor out common fields in vm stats vmId must always be present in vm stats, so factor it out, to remove

Change in vdsm[master]: tests: forbid tabs in schema

2015-02-11 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: tests: forbid tabs in schema .. tests: forbid tabs in schema Our schema parser doesn't like tabs. Add a test to detect them, to avoid wasting times chasing

Change in vdsm[master]: vm: add missing vm id to get stats of down vm

2015-02-11 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: add missing vm id to get stats of down vm .. Patch Set 4: version 4 is a rebase. I have schema updates on top of this patch. See 37696 in particular.

Change in vdsm[master]: networkTests: remove a broken approach to unmanaging devices...

2015-02-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: networkTests: remove a broken approach to unmanaging devices by NetworkManager .. Patch Set 4: Build Failed

Change in vdsm[master]: netinfo: report DHCP from configuration to avoid confusion a...

2015-02-11 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: netinfo: report DHCP from configuration to avoid confusion after stopping DHCP .. Patch Set 9: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/37617 To

Change in vdsm[master]: testSetupNetworksOverDhcpIface: respect the system version f...

2015-02-11 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: testSetupNetworksOverDhcpIface: respect the system version for dnsmasq .. Patch Set 1: Code-Review-1 can you explain the motivation in the commit message? -- To

Change in vdsm[master]: networkTests: show the dnsmasq command on failure to ease de...

2015-02-11 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: networkTests: show the dnsmasq command on failure to ease debugging on EL6 .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/37734 To

Change in vdsm[master]: Better logging for network restoration.

2015-02-11 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: Better logging for network restoration. .. Patch Set 1: so? +1? -- To view, visit http://gerrit.ovirt.org/37506 To unsubscribe, visit

Change in vdsm[master]: netinfoTests: no need to import each and every netinfo function

2015-02-11 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: netinfoTests: no need to import each and every netinfo function .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/37681 To unsubscribe,

Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...

2015-02-11 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/37733 To

Change in vdsm[master]: networkTests: delete our lease files also on EL6

2015-02-11 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: networkTests: delete our lease files also on EL6 .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/37684 To unsubscribe, visit

Change in vdsm[master]: pep8: fix `make check` on EL6

2015-02-11 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: pep8: fix `make check` on EL6 .. Patch Set 1: Verified+1 make check runs out of the box now on EL6. The two failures are omnipresent (with a cherry on the

Change in vdsm[master]: testSetupNetworksOverDhcpIface: respect the system version f...

2015-02-11 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: testSetupNetworksOverDhcpIface: respect the system version for dnsmasq .. Patch Set 1: Verified+1 I no longer get testSetupNetworksOverDhcpIface

Change in vdsm[master]: _get_gateway: allow duplicated gateways if they are in fact ...

2015-02-11 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: _get_gateway: allow duplicated gateways if they are in fact the same routes .. Patch Set 5: Verified+1 On my EL6 host the duplicated gateway is now reported

Change in vdsm[master]: networkTests: show the dnsmasq command on failure to ease de...

2015-02-11 Thread osvoboda
Ondřej Svoboda has uploaded a new change for review. Change subject: networkTests: show the dnsmasq command on failure to ease debugging on EL6 .. networkTests: show the dnsmasq command on failure to ease debugging on EL6

Change in vdsm[master]: netinfo: do not report DHCP from (typically still valid) leases

2015-02-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: do not report DHCP from (typically still valid) leases .. Patch Set 8: Build Failed

Change in vdsm[master]: netinfo: report DHCP from configuration to avoid confusion a...

2015-02-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: report DHCP from configuration to avoid confusion after stopping DHCP .. Patch Set 9: Build Failed

Change in vdsm[master]: networkTests: show the dnsmasq command on failure to ease de...

2015-02-11 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: networkTests: show the dnsmasq command on failure to ease debugging on EL6 .. Patch Set 1: Verified+1 The patch helped to show that

Change in vdsm[master]: gluster: Added gluster snapshot restore verb.

2015-02-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Added gluster snapshot restore verb. .. Patch Set 12: Build Failed

<    1   2