Francesco Romani has posted comments on this change.
Change subject: vm: stats: cache metadata value
..
Patch Set 7:
rebased with no code changes.
--
To view, visit http://gerrit.ovirt.org/37592
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: clientIF: add API to get all registered VMs
..
Patch Set 15:
rebased with no code changes.
--
To view, visit http://gerrit.ovirt.org/36719
To unsubscribe,
Shahar Havivi has posted comments on this change.
Change subject: v2v: Convert VM from external source to Data Domain
..
Patch Set 4:
(4 comments)
http://gerrit.ovirt.org/#/c/37509/4/lib/vdsm/constants.py.in
File
Francesco Romani has posted comments on this change.
Change subject: virt: make updateVolume a periodic operation
..
Patch Set 7:
rebased with no code changes
--
To view, visit http://gerrit.ovirt.org/37594
To unsubscribe,
Francesco Romani has posted comments on this change.
Change subject: virt: periodic: add utilities
..
Patch Set 2:
rebased with no code changes
--
To view, visit http://gerrit.ovirt.org/37885
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt: introduce support for periodic operations
..
Patch Set 7:
rebased with no code changes.
--
To view, visit http://gerrit.ovirt.org/37593
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: Replacing xml.dom.minidom with lxml.etree module
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15787/
Francesco Romani has posted comments on this change.
Change subject: vm: stats: periodic bulk stats sampling
..
Patch Set 17:
this version includes removal of code made obsolete, instead of delaying the
removal into a later
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: add an API to check if the domain is busy
..
Patch Set 16:
Build Failed
Francesco Romani has posted comments on this change.
Change subject: vm: add an API to check if the domain is busy
..
Patch Set 16: Code-Review+1
trivial usage of libvirt APIs. Verified the happy path.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: network: remove unused execCmd outputs
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/656/ :
Ondřej Svoboda has posted comments on this change.
Change subject: testSetupNetworksAddDelDhcp: check that IPv4 gateways are
reported correctly
..
Patch Set 4:
The test passed (again) on EL6 (DHCPv4-only, but this is enough).
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: stats: periodic bulk stats sampling
..
Patch Set 17:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2439/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: stats: cache metadata value
..
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2440/ :
There
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: stats: split up stats production
..
Patch Set 15:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/457/ :
Ondřej Svoboda has posted comments on this change.
Change subject: netinfoTests: no need to import each and every netinfo function
..
Patch Set 3:
All except skipped unit tests passed now.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: make updateVolume a periodic operation
..
Patch Set 7:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: periodic: add utilities
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2446/ :
There was
Francesco Romani has posted comments on this change.
Change subject: vm: add an API to check if the domain is busy
..
Patch Set 16: -Code-Review Verified+1
wrong click
--
To view, visit http://gerrit.ovirt.org/36721
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: make queryBlockJobs periodic
..
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2441/ :
There
Yeela Kaplan has posted comments on this change.
Change subject: infra: Introduce EventFD support
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/37051
To unsubscribe, visit
Ondřej Svoboda has uploaded a new change for review.
Change subject: _addNetwork: never try to set mtu=None to an existing bridge
..
_addNetwork: never try to set mtu=None to an existing bridge
On my EL6 host I tried to
Ondřej Svoboda has posted comments on this change.
Change subject: _addNetwork: never try to set mtu=None to an existing bridge
..
Patch Set 1: Verified+1
setupNetworks now succeeded and the default MTU is set all over:
#
Ondřej Svoboda has posted comments on this change.
Change subject: _get_gateway: allow duplicated gateways if they are in fact the
same routes
..
Patch Set 6:
Confirmed again that _with_ this patch the duplicated gateway is
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: drop now unused code
..
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2444/ :
There was an
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: add API to get all registered VMs
..
Patch Set 15:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15798/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: v2v: fix wrong handling of errCode in get_external_vms
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15800/ :
Francesco Romani has posted comments on this change.
Change subject: vm: drop now unused code
..
Patch Set 7:
this version removes more no longer useful code
--
To view, visit http://gerrit.ovirt.org/37597
To unsubscribe,
Francesco Romani has posted comments on this change.
Change subject: vm: make queryBlockJobs periodic
..
Patch Set 7:
this version does the dispatching only to VMs which actually have VM jobs to
monitor, to reduce the traffic
Francesco Romani has posted comments on this change.
Change subject: vm: restore highWrite monitoring
..
Patch Set 7:
this version includes removal of code made obsolete, instead of delaying the
removal into a later patch.
Martin Polednik has posted comments on this change.
Change subject: vmTests: move device tests out of vmTests
..
Patch Set 1: Verified+1
no real change in functionality, tests work as before (- the split)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: introduce support for periodic operations
..
Patch Set 7:
Build Failed
Francesco Romani has posted comments on this change.
Change subject: virt: make updateVolume a periodic operation
..
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/37594/7/vdsm/virt/periodic.py
File
Francesco Romani has posted comments on this change.
Change subject: vm: add an API to check if the domain is busy
..
Patch Set 16:
rebased with no code changes
--
To view, visit http://gerrit.ovirt.org/36721
To unsubscribe,
Ondřej Svoboda has posted comments on this change.
Change subject: network: remove unused execCmd outputs
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/37568
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: add 'name' property
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2438/ :
There was an
Francesco Romani has posted comments on this change.
Change subject: v2v: fix wrong handling of errCode in get_external_vms
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/37895/1//COMMIT_MSG
Commit Message:
Line 3:
Francesco Romani has posted comments on this change.
Change subject: v2v: fix wrong handling of errCode in get_external_vms
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/37895
To unsubscribe, visit
Yeela Kaplan has posted comments on this change.
Change subject: stomp: use monotonic timer instead of clock
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/37056
To unsubscribe, visit
Ondřej Svoboda has posted comments on this change.
Change subject: _get_gateway: allow duplicated gateways if they are in fact the
same routes
..
Patch Set 6:
Further information:
Without this patch a gateway is not reported
oVirt Jenkins CI Server has posted comments on this change.
Change subject: v2v: Convert VM from external source to Data Domain
..
Patch Set 5:
Build Failed
Yeela Kaplan has posted comments on this change.
Change subject: jsonrpc: Change _AsyncoreEvent to use EventFD
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/37052
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vm: stats: split up stats production
..
Patch Set 15:
rebased with no code changes
--
To view, visit http://gerrit.ovirt.org/36730
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vm: add 'name' property
..
Patch Set 4:
rebased with no code changes
--
To view, visit http://gerrit.ovirt.org/37824
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: network: remove unused execCmd outputs
..
Patch Set 2: Code-Review+2
Keeping the names of returned arguments has the benefit of better
documentation. But I
Yeela Kaplan has posted comments on this change.
Change subject: betterAsyncore: Bind the dispatcher implementation
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35252
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network: remove unused execCmd outputs
..
network: remove unused execCmd outputs
Change-Id: Iab297f67a8765ac34e5457afc3364f645607b360
Signed-off-by:
Shahar Havivi has uploaded a new change for review.
Change subject: v2v: fix wrong handling of errCode in get_external_vms
..
v2v: fix wrong handling of errCode in get_external_vms
Change-Id:
Yeela Kaplan has posted comments on this change.
Change subject: asyncore: Move AsyncoreEvent to betterAsyncore
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/37053
To unsubscribe, visit
Ondřej Svoboda has posted comments on this change.
Change subject: testSetupNetworksAddDelDhcp: shorten before adding checks for
gateways
..
Patch Set 4:
Confirming that the test still works (tested now on EL6, before it was
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: restore highWrite monitoring
..
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2447/ :
There
oVirt Jenkins CI Server has posted comments on this change.
Change subject: _addNetwork: never try to set mtu=None to an existing bridge
..
Patch Set 1:
Build Failed
Francesco Romani has posted comments on this change.
Change subject: v2v: Convert VM from external source to Data Domain
..
Patch Set 5:
(4 comments)
http://gerrit.ovirt.org/#/c/37509/5/vdsm/v2v.py
File vdsm/v2v.py:
Line 96:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: gluster: add _getDeviceDict function to reuse common code
..
gluster: add _getDeviceDict function to reuse common code
Added internal function to
oVirt Jenkins CI Server has posted comments on this change.
Change subject: _get_gateway: formally require an interface for lookup
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15817/ :
Dan Kenigsberg has posted comments on this change.
Change subject: gluster: add _getDeviceDict function to reuse common code
..
Patch Set 5: Code-Review+2
Raising
--
To view, visit http://gerrit.ovirt.org/37643
To
Francesco Romani has posted comments on this change.
Change subject: virt: Fix wrong usage of apparentsize and truesize
..
Patch Set 2: Code-Review+1
codewise seems fine, and I trust your investigation.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: add _getDeviceDict function to reuse common code
..
Patch Set 6:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: add createBrick verb
..
Patch Set 22:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/465/ :
SUCCESS
Timothy Asir has posted comments on this change.
Change subject: gluster: add createBrick verb
..
Patch Set 22: Verified+1
--
To view, visit http://gerrit.ovirt.org/35498
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ondřej Svoboda has posted comments on this change.
Change subject: network: api: allow removal of bond with no slaves
..
Patch Set 5: Code-Review+1
The code is good! English (in the commit message) silently weeps but is still
Candace Sheremeta has uploaded a new change for review.
Change subject: vdsm: added documentation for downloadImage method
..
vdsm: added documentation for downloadImage method
Added documentation for downloadImage in both
Candace Sheremeta has posted comments on this change.
Change subject: vdsm: added documentation for downloadImage method
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/37934
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: added documentation for downloadImage method
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15819/ :
Dan Kenigsberg has posted comments on this change.
Change subject: utils: Add memoized invalidation
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/37788
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: utils: Add memoized invalidation
..
utils: Add memoized invalidation
We learned in the hard way that memoizing and monkey-patching do work
nicely
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: add _getDeviceDict function to reuse common code
..
Patch Set 6:
Build Failed
Dan Kenigsberg has posted comments on this change.
Change subject: v2v: fix wrong handling of errCode in get_external_vms
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/37895
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: v2v: fix wrong handling of errCode in get_external_vms
..
v2v: fix wrong handling of errCode in get_external_vms
Opening connection via libvirt didn't
Dan Kenigsberg has posted comments on this change.
Change subject: vmTests: move device tests out of vmTests
..
Patch Set 1: Code-Review+2
Trusting you!
--
To view, visit http://gerrit.ovirt.org/37818
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vmTests: move device tests out of vmTests
..
vmTests: move device tests out of vmTests
vmTests.py, like vm.py, has grown in size a lot. Since some of
oVirt Jenkins CI Server has posted comments on this change.
Change subject: v2v: fix wrong handling of errCode in get_external_vms
..
Patch Set 5:
Build Failed
Nir Soffer has posted comments on this change.
Change subject: blockSD: Simplify metadata provider selection
..
Patch Set 1: Verified+1
Trivial patch, no verification needed.
--
To view, visit http://gerrit.ovirt.org/37936
Nir Soffer has uploaded a new change for review.
Change subject: blockSD: Simplify metadata provider selection
..
blockSD: Simplify metadata provider selection
The code was using unneeded temporary, confusing the reader.
This
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: volume snapshot list verb.
..
Patch Set 20:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/469/ :
Nir Soffer has posted comments on this change.
Change subject: profiling: import yappi outside lock
..
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/37915/2//COMMIT_MSG
Commit Message:
Line 9: Importing
oVirt Jenkins CI Server has posted comments on this change.
Change subject: blockSD: Simplify metadata provider selection
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15826/ : SUCCESS
Darshan N has posted comments on this change.
Change subject: gluster: volume snapshot list verb.
..
Patch Set 20: Verified+1
--
To view, visit http://gerrit.ovirt.org/36087
To unsubscribe, visit
Darshan N has posted comments on this change.
Change subject: gluster: volume snapshot list verb.
..
Patch Set 19:
(1 comment)
http://gerrit.ovirt.org/#/c/36087/19/vdsm/gluster/exception.py
File vdsm/gluster/exception.py:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: fileUtils: Improve logging when creating directories
..
fileUtils: Improve logging when creating directories
Log the mode when specified and format
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fileUtils: Improve logging when creating directories
..
Patch Set 4:
Build Failed
Ondřej Svoboda has uploaded a new change for review.
Change subject: _get_gateway: formally require an interface for lookup
..
_get_gateway: formally require an interface for lookup
All callers pass the interface name so let's
Dan Kenigsberg has submitted this change and it was merged.
Change subject: testSetupNetworksAddDelDhcp: shorten before adding checks for
gateways
..
testSetupNetworksAddDelDhcp: shorten before adding checks for gateways
Dan Kenigsberg has posted comments on this change.
Change subject: testSetupNetworksAddDelDhcp: check that IPv4 gateways are
reported correctly
..
Patch Set 4: Code-Review-1
(2 comments)
Shahar Havivi has posted comments on this change.
Change subject: v2v: fix wrong handling of errCode in get_external_vms
..
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/37895/1/vdsm/v2v.py
File vdsm/v2v.py:
Line 38:
Shahar Havivi has posted comments on this change.
Change subject: v2v: Convert VM from external source to Data Domain
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/37509/5/vdsm/v2v.py
File vdsm/v2v.py:
Line 96: def
Francesco Romani has posted comments on this change.
Change subject: v2v: fix wrong handling of errCode in get_external_vms
..
Patch Set 3: Code-Review+1
hoepfully this time I'm not missing anything
--
To view, visit
Shahar Havivi has posted comments on this change.
Change subject: v2v: fix wrong handling of errCode in get_external_vms
..
Patch Set 2: Verified-1
bad version...
--
To view, visit http://gerrit.ovirt.org/37895
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: v2v: fix wrong handling of errCode in get_external_vms
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15805/ :
Dan Kenigsberg has posted comments on this change.
Change subject: v2v: fix wrong handling of errCode in get_external_vms
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/37895/3/vdsm/v2v.py
File vdsm/v2v.py:
Line 45:
Ondřej Svoboda has posted comments on this change.
Change subject: testSetupNetworksAddDelDhcp: check that IPv4 gateways are
reported correctly
..
Patch Set 4:
(2 comments)
http://gerrit.ovirt.org/#/c/37680/4//COMMIT_MSG
Timothy Asir has posted comments on this change.
Change subject: gluster: add createBrick verb
..
Patch Set 20:
(1 comment)
http://gerrit.ovirt.org/#/c/35498/20/vdsm/rpc/vdsmapi-gluster-schema.json
File
Bala.FA has posted comments on this change.
Change subject: gluster: volume snapshot list verb.
..
Patch Set 19: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/36087/19/vdsm/gluster/exception.py
File
Timothy Asir has posted comments on this change.
Change subject: gluster: add createBrick verb
..
Patch Set 21: Verified+1
--
To view, visit http://gerrit.ovirt.org/35498
To unsubscribe, visit http://gerrit.ovirt.org/settings
Francesco Romani has posted comments on this change.
Change subject: v2v: fix wrong handling of errCode in get_external_vms
..
Patch Set 1: Code-Review-1
(2 comments)
reverted score after being pointed out to a mistake which
oVirt Jenkins CI Server has posted comments on this change.
Change subject: testSetupNetworksAddDelDhcp: shorten before adding checks for
gateways
..
Patch Set 5:
Build Failed
Francesco Romani has abandoned this change.
Change subject: API: better integration with MOM
..
Abandoned
found new and better approach.
--
To view, visit http://gerrit.ovirt.org/37183
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: v2v: fix wrong handling of errCode in get_external_vms
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15804/ :
Dan Kenigsberg has posted comments on this change.
Change subject: testSetupNetworksAddDelDhcp: shorten before adding checks for
gateways
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/37679
To
Darshan N has posted comments on this change.
Change subject: gluster: volume snapshot config list and set verbs.
..
Patch Set 11: Verified+1
--
To view, visit http://gerrit.ovirt.org/34741
To unsubscribe, visit
1 - 100 of 156 matches
Mail list logo