Dan Kenigsberg has posted comments on this change.
Change subject: v2v: Convert VM from external source to Data Domain
..
Patch Set 7:
(3 comments)
https://gerrit.ovirt.org/#/c/37509/7/vdsm/v2v.py
File vdsm/v2v.py:
Line 196:
Francesco Romani has posted comments on this change.
Change subject: RFE: Report downtime for each live migration
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/37075/5/vdsm.spec.in
File vdsm.spec.in:
Line 194:
Dan Kenigsberg has posted comments on this change.
Change subject: RFE: Report downtime for each live migration
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/37075/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: Fix LSM when using libvirt = 1.2.8
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2561/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: move find() helper into testlib
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16070/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: RFE: Report downtime for each live migration
..
Patch Set 5: Code-Review-1
Please document the new attribute in the schema. Also, please explain in the
commit
Francesco Romani has posted comments on this change.
Change subject: RFE: Report downtime for each live migration
..
Patch Set 5: -Code-Review
sorry, my fault. Codewise is fine, but schema docs are missing.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: network: test: remove bond with removed enslaved nics
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16069/ :
Dan Kenigsberg has posted comments on this change.
Change subject: tests: move find() helper into testlib
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/38152
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: move find() helper into testlib
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/685/ :
Nir Soffer has posted comments on this change.
Change subject: vm: Fix LSM when using libvirt = 1.2.8
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/38142/4//COMMIT_MSG
Commit Message:
Line 21: effected
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: drive: allow error policy fine tuning
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2559/ :
Nir Soffer has posted comments on this change.
Change subject: monitor: return whether the reported status is real
..
Patch Set 4:
Looks ok and the discussion about nextStaus.actual was resolved by flipping a
coin :-)
Just
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: move find() helper into testlib
..
tests: move find() helper into testlib
Recently the vmTests gained a find() helper
function to make xml
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: drive: allow error policy fine tuning
..
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2560/ :
Adam Litke has posted comments on this change.
Change subject: virt: Fix limit when calculating next volume size
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38088
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: virt: Check if a drive is chuhked before extending
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38087
To unsubscribe, visit
Shahar Havivi has posted comments on this change.
Change subject: RFE: Report downtime for each live migration
..
Patch Set 5:
(2 comments)
https://gerrit.ovirt.org/#/c/37075/5/vdsm.spec.in
File vdsm.spec.in:
Line 194: %else
Dan Kenigsberg has posted comments on this change.
Change subject: vm: stats: cache metadata value
..
Patch Set 11: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/37592
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: network: api: allow removal of bond with no slaves
..
Patch Set 2:
Build Failed
Dan Kenigsberg has posted comments on this change.
Change subject: tests: InterfaceSampleTests are failing with IOError
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/38113/1//COMMIT_MSG
Commit Message:
Line 5:
Dan Kenigsberg has posted comments on this change.
Change subject: clientIF: add method to get all registered VMs
..
Patch Set 19: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/36719
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: vm: add 'name' property
..
Patch Set 10: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/37824/10/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3794:
Nir Soffer has posted comments on this change.
Change subject: vm: Fix LSM when using libvirt = 1.2.8
..
Patch Set 5: -Code-Review
--
To view, visit https://gerrit.ovirt.org/38142
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: Fix LSM when using libvirt = 1.2.8
..
vm: Fix LSM when using libvirt = 1.2.8
Libvirt 1.2.8 introduced a regression where disk type is converted
Martin Sivák has posted comments on this change.
Change subject: vm: stats: cache metadata value
..
Patch Set 11: Code-Review+1
Looks fine to me.
--
To view, visit https://gerrit.ovirt.org/37592
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: Fix LSM when using libvirt = 1.2.8
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/686/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: json-rpc: fix the Host.getVMList return value
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16074/ : SUCCESS
Francesco Romani has uploaded a new change for review.
Change subject: json-rpc: fix the Host.getVMList return value
..
json-rpc: fix the Host.getVMList return value
Host.getVMList() should return either VmDefinition or
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: InterfaceSampleTests are failing with IOError
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16076/ : To
Petr Horáček has uploaded a new change for review.
Change subject: init: fix network service status checking
..
init: fix network service status checking
In init file, we check if network servuce is running by its status
return
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: InterfaceSampleTests are failing with IOError
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16077/ : To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: init: fix network service status checking
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16075/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: block: use the contextmanager for getVolumeMetadataSlot
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16078/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sdm: Allow query of task information on SDM hosts
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16080/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: create gc and delete
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16081/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: virt: Fix limit when calculating next volume size
..
Patch Set 4: Verified-1
When working with qcow format, we must allocate extra space for qcow internal
data.
Nir Soffer has posted comments on this change.
Change subject: virt: Fix limit when calculating next volume size
..
Patch Set 4:
This version update the bug url to the zstream clone - no code change.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: virt: Add Drive.chunked property
..
Patch Set 3:
This version update the bug url to the zstream clone - no code change.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: virt: Check if a drive is chuhked before extending
..
Patch Set 3:
This version update the bug url to the zstream clone - no code change.
--
To view, visit
Ido Barkan has posted comments on this change.
Change subject: netinfo: Replacing xml.dom.minidom with lxml.etree module
..
Patch Set 2: Code-Review+1
Genadi, please verify...
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: json-rpc: fix the Host.getVMList return value
..
Patch Set 1:
did initial rough verification and this seems to fix the issue. Doing proper
verification.
--
Dan Kenigsberg has posted comments on this change.
Change subject: network: filter out networks with unconfigured bonds
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/37967
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: network: test: remove bond with removed enslaved nics
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/38083
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: stats: periodic bulk stats sampling
..
Patch Set 23:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2550/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: stats: cache metadata value
..
Patch Set 11:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2552/ :
There
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: restore unresponsive on timeout when sampling
..
Patch Set 2:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: make queryBlockJobs a periodic operation
..
Patch Set 13:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: periodic: dispatch work to VMs.
..
Patch Set 8:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2547/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: add method to get all registered VMs
..
Patch Set 19:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16056/ : FAILURE
Francesco Romani has posted comments on this change.
Change subject: tests: move find() helper into testlib
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/38152/1/tests/vmTests.py
File tests/vmTests.py:
Line 37:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: method to check if dom is ready for commands
..
Patch Set 20:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: add 'name' property
..
Patch Set 10:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2549/ :
There was an
Ido Barkan has posted comments on this change.
Change subject: _addNetwork: never try to set mtu=None to an existing bridge
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/37899
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: network: api: allow removal of bond with no slaves
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/38079
To unsubscribe, visit
Shahar Havivi has posted comments on this change.
Change subject: RFE: Report downtime for each live migration
..
Patch Set 5:
(1 comment)
We don't need it soon, its for 3.6
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: move find() helper into testlib
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16052/ : SUCCESS
Allon Mureinik has posted comments on this change.
Change subject: virt: Add Drive.chunked property
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/38086/2//COMMIT_MSG
Commit Message:
Line 17: test module fail to
Allon Mureinik has posted comments on this change.
Change subject: virt: Check if a drive is chuhked before extending
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/38087/2//COMMIT_MSG
Commit Message:
Line 22:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: drive: allow error policy fine tuning
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2545/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: Fix LSM when using libvirt = 1.2.8
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2546/ :
Francesco Romani has uploaded a new change for review.
Change subject: DONTMERGE: jsonrpc: debug log
..
DONTMERGE: jsonrpc: debug log
Change-Id: I68a4bb7ab8c4b1c086214e5c08341382aa20c701
Signed-off-by: Francesco Romani
Francesco Romani has posted comments on this change.
Change subject: vm: stats: cache metadata value
..
Patch Set 11:
version 11 addresses comments of version 10
--
To view, visit https://gerrit.ovirt.org/37592
To
Francesco Romani has posted comments on this change.
Change subject: vm: method to check if dom is ready for commands
..
Patch Set 20:
version 20 attempts to fix naming
--
To view, visit https://gerrit.ovirt.org/36721
To
Francesco Romani has posted comments on this change.
Change subject: virt: make updateVolume a periodic operation
..
Patch Set 13:
rebased
--
To view, visit https://gerrit.ovirt.org/37594
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: clientIF: add method to get all registered VMs
..
Patch Set 19:
version 19 improves naming (API - method)
--
To view, visit https://gerrit.ovirt.org/36719
Francesco Romani has posted comments on this change.
Change subject: vm: add 'name' property
..
Patch Set 10:
rebased
--
To view, visit https://gerrit.ovirt.org/37824
To unsubscribe, visit https://gerrit.ovirt.org/settings
Francesco Romani has posted comments on this change.
Change subject: virt: make updateVolume a periodic operation
..
Patch Set 13:
port the the isDomainReadyForCommands API
--
To view, visit https://gerrit.ovirt.org/37594
To
Francesco Romani has posted comments on this change.
Change subject: vm: stats: periodic bulk stats sampling
..
Patch Set 23:
rebased and ported to the the isDomainReadyForCommands API
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: virt: periodic: dispatch work to VMs.
..
Patch Set 8:
version 8 narrows down the change and improves wording
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: virt: introduce support for periodic operations
..
Patch Set 13:
version 13 does (very) minor cleanup
--
To view, visit https://gerrit.ovirt.org/37593
To
Francesco Romani has posted comments on this change.
Change subject: vm: restore unresponsive on timeout when sampling
..
Patch Set 2:
rebased
--
To view, visit https://gerrit.ovirt.org/38066
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vm: drop now unused code
..
Patch Set 13:
rebased
--
To view, visit https://gerrit.ovirt.org/37597
To unsubscribe, visit https://gerrit.ovirt.org/settings
Francesco Romani has posted comments on this change.
Change subject: vm: restore highWrite monitoring
..
Patch Set 13:
rebased and ported the the isDomainReadyForCommands API
--
To view, visit https://gerrit.ovirt.org/37596
Francesco Romani has posted comments on this change.
Change subject: vm: stats: split up stats production
..
Patch Set 21:
rebased
--
To view, visit https://gerrit.ovirt.org/36730
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vm: make queryBlockJobs a periodic operation
..
Patch Set 13:
rbased and ported the the isDomainReadyForCommands API
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: vm: Fix LSM when using libvirt = 1.2.8
..
Patch Set 4: -Code-Review Verified+1
Verified on:
Fedora 21:
- lsm with block thin disk (extended correctly)
- live
Nir Soffer has posted comments on this change.
Change subject: tests: move find() helper into testlib
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/38152/1/tests/vmTests.py
File tests/vmTests.py:
Line 37: from
Nir Soffer has posted comments on this change.
Change subject: tests: InterfaceSampleTests are failing with IOError
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/38113/2/lib/vdsm/libvirtconnection.py
File
Francesco Romani has uploaded a new change for review.
Change subject: tests: move find() helper into testlib
..
tests: move find() helper into testlib
Recently the vmTests gained a find() helper
function to make xml tests less
Francesco Romani has posted comments on this change.
Change subject: tests: move find() helper into testlib
..
Patch Set 1: Verified+1
verified running the tests.
--
To view, visit https://gerrit.ovirt.org/38152
To
Francesco Romani has posted comments on this change.
Change subject: vm: drive: allow error policy fine tuning
..
Patch Set 5:
This version makes tests more robust as Nir suggested, leveraging patch 38152
and find() helper.
Nir Soffer has posted comments on this change.
Change subject: vm: Fix LSM when using libvirt = 1.2.8
..
Patch Set 3: Code-Review-1
(1 comment)
Commit message need update (libvirt version was wrong)
Francesco Romani has posted comments on this change.
Change subject: vm: pessimistic monitor response check
..
Patch Set 17: Verified-1
will hopefullt be made obsolete by the sampling overhaul for 3.6.
Keeping for tracking
Allon Mureinik has posted comments on this change.
Change subject: virt: Fix limit when calculating next volume size
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/38088/3//COMMIT_MSG
Commit Message:
Line 28:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: make updateVolume a periodic operation
..
Patch Set 13:
Build Failed
Francesco Romani has posted comments on this change.
Change subject: tests: move find() helper into testlib
..
Patch Set 1:
version 2 renames vmTests.find to testlib.find_xml_element with no further code
changes
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: drop now unused code
..
Patch Set 13:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2557/ :
There was an
Francesco Romani has posted comments on this change.
Change subject: vm: drive: allow error policy fine tuning
..
Patch Set 6:
(previosuly, I wrongly commented an outdated version)
version 6 renames find() to
Francesco Romani has posted comments on this change.
Change subject: vm: drive: allow error policy fine tuning
..
Patch Set 5:
version 6 renames find() to find_xml_element() in tests with no further code
changes
--
To view,
Nir Soffer has posted comments on this change.
Change subject: tests: move find() helper into testlib
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38152
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: _addNetwork: never try to set mtu=None to an existing bridge
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/37899
To unsubscribe,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: _addNetwork: never try to set mtu=None to an existing bridge
..
_addNetwork: never try to set mtu=None to an existing bridge
On my EL6 host I tried to
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: restore highWrite monitoring
..
Patch Set 13:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2558/ :
There
Nir Soffer has posted comments on this change.
Change subject: vm: drive: allow error policy fine tuning
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/38009/4//COMMIT_MSG
Commit Message:
Line 10: so this patch
Francesco Romani has posted comments on this change.
Change subject: tests: move find() helper into testlib
..
Patch Set 2: Verified+1
verified again running 'make check' with no issues.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: vm: drive: allow error policy fine tuning
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/38009/4//COMMIT_MSG
Commit Message:
Line 10: so this
oVirt Jenkins CI Server has posted comments on this change.
Change subject: _addNetwork: never try to set mtu=None to an existing bridge
..
Patch Set 2:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: DONTMERGE: jsonrpc: debug log
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16068/ : FAILURE
Francesco Romani has posted comments on this change.
Change subject: vm: drive: allow error policy fine tuning
..
Patch Set 6: Code-Review-1
missed to address some comments in version 4
--
To view, visit
100 matches
Mail list logo