Dan Kenigsberg has posted comments on this change. Change subject: tests: InterfaceSampleTests are failing with IOError ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/38113/1//COMMIT_MSG Commit Message: Line 5: CommitDate: 2015-02-24 05:04:13 +0530 Line 6: Line 7: tests: InterfaceSampleTests are failing with IOError Line 8: Line 9: Both testHostSampleHandlesDisappearingVlanInterfaces and testHostSampleReportsNewInterface are failing due to IOError: No such file or directory: '/etc/pki/vdsm/keys/libvirt_password'. Both the testcases are lookng for libvirt_password file which will be installed with package installation. It is not appropriate for a testcase to look for a file which will be installed after the package is installed. Current changes will allow testcases to look for the libvirt_password file in sources if the file is not present in '/etc/pki/vdsm/keys/libvirt_password' location. yes, this happens when the unit tests are run on a host that does not have vdsm installed. Thank you for handliing this issue. However, I believe that the proper solution is to monkey-patch the read_password function. There is no need to read the actual "password" from file, as the local libvirt daemon is not configured to use it, and no connection to it is ever done during the test. Line 10: Line 11: Change-Id: Id1de7ed2222c9f531d490ffdd3f71a3130faf63b Line 12: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1195594 -- To view, visit https://gerrit.ovirt.org/38113 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1de7ed2222c9f531d490ffdd3f71a3130faf63b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Madhu Pavan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
