Change in vdsm[master]: asyncore: dynamic tick support

2015-03-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: asyncore: dynamic tick support .. Patch Set 16: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16781/ : SUCCESS

Change in vdsm[master]: jsonrpc: Fix callMethod in JsonRpcClient

2015-03-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: Fix callMethod in JsonRpcClient .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16782/ : SUCCESS

Change in vdsm[master]: jsonrpc: events

2015-03-17 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpc: events .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '

Change in vdsm[master]: stomp: server side subscriptions

2015-03-17 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: stomp: server side subscriptions .. Patch Set 8: Verified+1 Verified with engine based on latest master -- To view, visit https://gerrit.ovirt.org/38451 To

Change in vdsm[master]: stomp: server side subscriptions

2015-03-17 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: stomp: server side subscriptions .. Patch Set 7: Verified-1 Failed verification with engine using latest master. -- To view, visit

Change in vdsm[master]: stomp: outgoing connection to a broker

2015-03-17 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: stomp: outgoing connection to a broker .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: API: getVMList: compatibity with internal clients

2015-03-17 Thread fromani
Francesco Romani has posted comments on this change. Change subject: API: getVMList: compatibity with internal clients .. Patch Set 2: verified also against Engine master (9682bc4e4576d4e877c7f8933f3c7229533f5dcc) with both

Change in vdsm[master]: jsonrpc: Properly initialize RuntimeError for JsonRpcError

2015-03-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16783/

Change in vdsm[master]: stomp: server side subscriptions

2015-03-17 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: stomp: server side subscriptions .. Patch Set 8: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: gluster: add createBrick verb

2015-03-17 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: gluster: add createBrick verb .. Patch Set 24: (3 comments) https://gerrit.ovirt.org/#/c/35498/24/vdsm/gluster/fstab.py File vdsm/gluster/fstab.py: Line

Change in vdsm[master]: API: onlyUUID should affect only short status

2015-03-17 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit

Change in vdsm[master]: vm: do not poll for scheduler parameters

2015-03-17 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: do not poll for scheduler parameters .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/38483/4/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 410

Change in vdsm[master]: RFE: Report downtime for each live migration

2015-03-17 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 8: sorry for being so late, but how about changing the naming of getActualDowntime into something

Change in vdsm[master]: ceph: Support hotunplug of network disks

2015-03-17 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: ceph: Support hotunplug of network disks .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/38804/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3142:

Change in vdsm[master]: ceph: Initial support for network disk

2015-03-17 Thread fromani
Francesco Romani has posted comments on this change. Change subject: ceph: Initial support for network disk .. Patch Set 4: I'm not familiar with the support of network drives in Engine, so I wonder: this change is nicer and

Change in vdsm[master]: API: getVMList: compatibity with internal clients

2015-03-17 Thread fromani
Francesco Romani has posted comments on this change. Change subject: API: getVMList: compatibity with internal clients .. Patch Set 2: No need of MOM change *if* my analysis is correct! Please help me reviewing it, I need at

Change in vdsm[master]: vm: do not poll for scheduler parameters

2015-03-17 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: vm: do not poll for scheduler parameters .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/38483/4/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 410

Change in vdsm[master]: vm: method to check if dom is ready for commands

2015-03-17 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: vm: method to check if dom is ready for commands .. Patch Set 27: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/36721/27/vdsm/virt/vm.py File

Change in vdsm[master]: API: getVMList: compatibity with internal clients

2015-03-17 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: API: getVMList: compatibity with internal clients .. Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/38805/2//COMMIT_MSG Commit Message:

Change in vdsm[master]: storage: Add multipath-resize command line tool

2015-03-17 Thread fromani
Francesco Romani has posted comments on this change. Change subject: storage: Add multipath-resize command line tool .. Patch Set 6: (2 comments) https://gerrit.ovirt.org/#/c/38467/6/vdsm/storage/multipath-resize File

Change in vdsm[master]: RFE: Report downtime for each live migration

2015-03-17 Thread fromani
Francesco Romani has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/37075/8/vdsm/rpc/vdsmapi-schema.json File

Change in vdsm[master]: gluster: add createBrick verb

2015-03-17 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: gluster: add createBrick verb .. Patch Set 24: (2 comments) https://gerrit.ovirt.org/#/c/35498/24/vdsm/gluster/storagedev.py File

Change in vdsm[master]: vm: do not poll for scheduler parameters

2015-03-17 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: vm: do not poll for scheduler parameters .. Patch Set 4: +1 for the concept note vCPUs are reported in 'guestCPUCount' I'd remove it from sampling too. It's

Change in vdsm[master]: vm: rename internal method for clarity

2015-03-17 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: vm: rename internal method for clarity .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38674 To unsubscribe, visit

Change in vdsm[master]: RFE: Report downtime for each live migration

2015-03-17 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 8: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/37075/8/vdsm/rpc/vdsmapi-schema.json

Change in vdsm[master]: vmTests: unbreak tests on el6

2015-03-17 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vmTests: unbreak tests on el6 .. Patch Set 1: Code-Review+1 the problem is that I'm focusing on RHEL7 lately, so these mistakes slip in. That's bad, I'll

Change in vdsm[master]: ceph: Support hotunplug of network disks

2015-03-17 Thread fromani
Francesco Romani has posted comments on this change. Change subject: ceph: Support hotunplug of network disks .. Patch Set 3: Code-Review+1 (2 comments) https://gerrit.ovirt.org/#/c/38804/3/vdsm/virt/vm.py File

Change in vdsm[master]: API: getVMList: compatibity with internal clients

2015-03-17 Thread fromani
Francesco Romani has posted comments on this change. Change subject: API: getVMList: compatibity with internal clients .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/38805/2//COMMIT_MSG Commit Message: Line 27:

Change in vdsm[master]: Introduce storage domain version 4

2015-03-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Introduce storage domain version 4 .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16815/ : SUCCESS

Change in vdsm[master]: sdm: introduce the new createVolumeContainer command

2015-03-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: sdm: introduce the new createVolumeContainer command .. Patch Set 7: Build Failed

Change in vdsm[master]: vmTests: unbreak tests on el6

2015-03-17 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vmTests: unbreak tests on el6 .. Patch Set 1: Verified+1 Code-Review+2 testReadPauseCodeDomainPausedCrash SKIP:

Change in vdsm[master]: vmTests: unbreak tests on el6

2015-03-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmTests: unbreak tests on el6 .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/750/ : SUCCESS

Change in vdsm[master]: SDM: removeVolume command and volume garbage collection

2015-03-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: SDM: removeVolume command and volume garbage collection .. Patch Set 7: Code-Review-1 Verified-1 Build Failed

Change in vdsm[master]: vmTests: unbreak tests on el6

2015-03-17 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vmTests: unbreak tests on el6 .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[ovirt-3.5]: network: models: tag non-VDSM devices used by VDSM

2015-03-17 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: network: models: tag non-VDSM devices used by VDSM .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/38771 To unsubscribe, visit

Change in vdsm[master]: utils: add logged CPopen command execution

2015-03-17 Thread Federico Simoncelli
Federico Simoncelli has uploaded a new change for review. Change subject: utils: add logged CPopen command execution .. utils: add logged CPopen command execution Now that we're moving to a more wide use of CPopen in the code

Change in vdsm[master]: utils: add logged CPopen command execution

2015-03-17 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: utils: add logged CPopen command execution .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: qemuimg: add support for convert progress

2015-03-17 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: qemuimg: add support for convert progress .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: task: add the support for abort_callback

2015-03-17 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: task: add the support for abort_callback .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: storage: Stop using tempnam in deleteImage

2015-03-17 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: storage: Stop using tempnam in deleteImage .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: clusterLock: Acquire, release, and inquire volume leases

2015-03-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: clusterLock: Acquire, release, and inquire volume leases .. Patch Set 4: Code-Review-1 Verified-1 Build Unstable

Change in vdsm[master]: vmTests: unbreak tests on el6

2015-03-17 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: vmTests: unbreak tests on el6 .. vmTests: unbreak tests on el6 test_change_cd_failure and testReadPauseCodeDomainPausedCrash have been failing since

Change in vdsm[master]: Query interface for all VM fields Change-Id: Iddb4657d73...

2015-03-17 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: Query interface for all VM fields Change-Id: Iddb4657d738ca0406950d07b84a7c85721e80b78 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1083070 Signed-off-by: Vinzenz Feenstra vfeen...@redhat.com

Change in vdsm[master]: gluster: add createBrick verb

2015-03-17 Thread tjeyasin
Timothy Asir has posted comments on this change. Change subject: gluster: add createBrick verb .. Patch Set 24: (6 comments) https://gerrit.ovirt.org/#/c/35498/24/vdsm/gluster/fstab.py File vdsm/gluster/fstab.py: Line 22:

Change in vdsm[master]: gluster: add createBrick verb

2015-03-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: add createBrick verb .. Patch Set 25: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/613/ : FAILURE

Change in vdsm[master]: gluster: add createBrick verb

2015-03-17 Thread tjeyasin
Timothy Asir has posted comments on this change. Change subject: gluster: add createBrick verb .. Patch Set 25: Verified+1 -- To view, visit https://gerrit.ovirt.org/35498 To unsubscribe, visit

Change in vdsm[master]: API: getVMList: compatibity with internal clients

2015-03-17 Thread fromani
Francesco Romani has posted comments on this change. Change subject: API: getVMList: compatibity with internal clients .. Patch Set 2: TL;DR: Initial verification passed using VDSM master and Engine 3.5.0. VERY LONG report of

Change in vdsm[master]: gluster: add createBrick verb

2015-03-17 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: gluster: add createBrick verb .. Patch Set 25: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: asyncore: Move generic reactor functionality

2015-03-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: asyncore: Move generic reactor functionality .. Patch Set 16: Build Successful

Change in vdsm[master]: vdscli: allow a connection with a configurable timeout

2015-03-17 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: vdscli: allow a connection with a configurable timeout .. Patch Set 4: the test in the following patch passes while vdsm is up. we need to fix the test, move

Change in vdsm[master]: Query interface for all VM fields Change-Id: Iddb4657d73...

2015-03-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Query interface for all VM fields Change-Id: Iddb4657d738ca0406950d07b84a7c85721e80b78 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1083070 Signed-off-by: Vinzenz Feenstra vfeen...@redhat.com

Change in vdsm[master]: task: add the support for abort_callback

2015-03-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: task: add the support for abort_callback .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16808/ : SUCCESS

Change in vdsm[master]: utils: add CommandStream class

2015-03-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: add CommandStream class .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16807/ : SUCCESS

Change in vdsm[master]: utils: add logged CPopen command execution

2015-03-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: add logged CPopen command execution .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16809/ : SUCCESS

Change in vdsm[master]: qemuimg: add support for convert progress

2015-03-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: qemuimg: add support for convert progress .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16806/ : SUCCESS

Change in vdsm[master]: sdm: introduce the new createVolumeContainer command

2015-03-17 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: sdm: introduce the new createVolumeContainer command .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: SDM: add the copyVolumeData command

2015-03-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: SDM: add the copyVolumeData command .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16813/ : SUCCESS

Change in vdsm[master]: storage: Stop using tempnam in deleteImage

2015-03-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: storage: Stop using tempnam in deleteImage .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16810/ : SUCCESS

Change in vdsm[master]: clusterLock: Make inquire retval consistent

2015-03-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: clusterLock: Make inquire retval consistent .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16812/ : SUCCESS

Change in vdsm[master]: storage: export volume lease state in getVolumeInfo

2015-03-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: storage: export volume lease state in getVolumeInfo .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16814/ :

Change in vdsm[master]: utils: add CommandStream class

2015-03-17 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: utils: add CommandStream class .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: storage: export volume lease state in getVolumeInfo

2015-03-17 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: storage: export volume lease state in getVolumeInfo .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: clusterLock: Acquire, release, and inquire volume leases

2015-03-17 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: clusterLock: Acquire, release, and inquire volume leases .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[master]: Introduce storage domain version 4

2015-03-17 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: Introduce storage domain version 4 .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager

2015-03-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: block: convert getVolumeMetadataSlot into a contexmanager .. Patch Set 10: Build Successful

Change in vdsm[master]: API: getVMList: compatibity with internal clients

2015-03-17 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: API: getVMList: compatibity with internal clients .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38805 To unsubscribe, visit

Change in vdsm[master]: clusterLock: Make inquire retval consistent

2015-03-17 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: clusterLock: Make inquire retval consistent .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: SDM: add the copyVolumeData command

2015-03-17 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: SDM: add the copyVolumeData command .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: block: convert getVolumeMetadataSlot into a contexmanager

2015-03-17 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: block: convert getVolumeMetadataSlot into a contexmanager .. Patch Set 10: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[master]: SDM: removeVolume command and volume garbage collection

2015-03-17 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: SDM: removeVolume command and volume garbage collection .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[master]: storage: Stop using tempnam in deleteImage

2015-03-17 Thread alitke
Adam Litke has posted comments on this change. Change subject: storage: Stop using tempnam in deleteImage .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/38768 To unsubscribe, visit

Change in vdsm[master]: API: getVMList: compatibity with internal clients

2015-03-17 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: API: getVMList: compatibity with internal clients .. Patch Set 2: How does it looks from the engine perspective? Can you look for getVMFullList? -- To

Change in vdsm[master]: gluster: add createBrick verb

2015-03-17 Thread barumuga
Bala.FA has posted comments on this change. Change subject: gluster: add createBrick verb .. Patch Set 25: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/35498 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: API: getVMList: compatibity with internal clients

2015-03-17 Thread fromani
Francesco Romani has posted comments on this change. Change subject: API: getVMList: compatibity with internal clients .. Patch Set 2: Piotr: before to do the test again with VDSM 3.5.0, I will toggle Debug log on Engine

Change in vdsm[master]: API: getVMList: compatibity with internal clients

2015-03-17 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: API: getVMList: compatibity with internal clients .. Patch Set 2: -Code-Review Logs seems good. Please check with master and if that works I am fine with the

Change in vdsm[master]: jsonrpc: add ability to get dictionary directly from JsonRpc...

2015-03-17 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpc: add ability to get dictionary directly from JsonRpcRequest .. Patch Set 10: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN,

Change in vdsm[master]: stomp: Remove redundant code

2015-03-17 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: stomp: Remove redundant code .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: jsonrpc: events

2015-03-17 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: events .. Patch Set 7: Verified+1 Rebased, added event test and verified with engine 3.5. -- To view, visit https://gerrit.ovirt.org/38069 To

Change in vdsm[master]: stomp: use the atomic dict.setdefault() instead for check an...

2015-03-17 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: stomp: use the atomic dict.setdefault() instead for check and set .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no

Change in vdsm[master]: Have the protocol detector use the Reactor

2015-03-17 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: Have the protocol detector use the Reactor .. Patch Set 13: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: stomp: outgoing connection to a broker

2015-03-17 Thread piotr . kliczewski
Piotr Kliczewski has uploaded a new change for review. Change subject: stomp: outgoing connection to a broker .. stomp: outgoing connection to a broker Change-Id: Ied3095a305fd5a5bfc19c8bc0342fba7cb811843 Signed-off-by:

Change in vdsm[master]: stomp: outgoing connection to a broker

2015-03-17 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: stomp: outgoing connection to a broker .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: jsonrpc: events

2015-03-17 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpc: events .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '

Change in vdsm[master]: jsonrpc: Fix callMethod in JsonRpcClient

2015-03-17 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpc: Fix callMethod in JsonRpcClient .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: API: getVMList: compatibity with internal clients

2015-03-17 Thread fromani
Francesco Romani has posted comments on this change. Change subject: API: getVMList: compatibity with internal clients .. Patch Set 2: VDSM 3.5 + patches with Engine 3.5.0 seems OK. VDSM logs here: http://fpaste.org/198943/.

Change in vdsm[master]: asyncore: dynamic tick support

2015-03-17 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: asyncore: dynamic tick support .. Patch Set 16: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: jsonrpc: Properly initialize RuntimeError for JsonRpcError

2015-03-17 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[master]: jsonrpc: events

2015-03-17 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: events .. Patch Set 8: Verified+1 Updaed __init__.py by moving part of change from broker patch which belong to this patch. Verified with engine

Change in vdsm[master]: jsonrpc: events

2015-03-17 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpc: events .. Patch Set 8: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '

Change in vdsm[master]: API: getVMList: compatibity with internal clients

2015-03-17 Thread fromani
Francesco Romani has posted comments on this change. Change subject: API: getVMList: compatibity with internal clients .. Patch Set 2: here for engine logs is http://fpaste.org/198930/ -- To view, visit

Change in vdsm[master]: stomp: Pop the frame even if a frame handler isn't defined

2015-03-17 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: stomp: Pop the frame even if a frame handler isn't defined .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[master]: stomp: Make sure the \0 is a last char in the buffer

2015-03-17 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: stomp: Make sure the \0 is a last char in the buffer .. Patch Set 9: * Update tracker::#1169100::OK * Check Bug-Url::OK * Check Public Bug::#1169100::OK,

Change in vdsm[master]: stomp: parsing buffer refactoring

2015-03-17 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: stomp: parsing buffer refactoring .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: jsonrpc: Properly log and return an error if the threadFacto...

2015-03-17 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpc: Properly log and return an error if the threadFactory fails .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN,

Change in vdsm[master]: stomp: Stomp encoder\decoder improvements

2015-03-17 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: stomp: Stomp encoder\decoder improvements .. Patch Set 10: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: stomp: client side subscription

2015-03-17 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: stomp: client side subscription .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: stomp: server side subscriptions

2015-03-17 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: stomp: server side subscriptions .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: stomp: outgoing connection to a broker

2015-03-17 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: stomp: outgoing connection to a broker .. Patch Set 1: Verified-1 (1 comment) Connection to broker not tested yet.

Change in vdsm[master]: jsonrpc: Remove JsonRpcClientPool

2015-03-17 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpc: Remove JsonRpcClientPool .. Patch Set 11: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: asyncore: Move ssl buffer handling to dispatcher

2015-03-17 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: asyncore: Move ssl buffer handling to dispatcher .. Patch Set 15: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

  1   2   >