Change in vdsm[master]: spec: Drop el6 support

2015-05-04 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: spec: Drop el6 support .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/40419/3/vdsm.spec.in File vdsm.spec.in: Line 836: # fallback to

Change in vdsm[master]: network: wait for udev after configuring SRIOV

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: network: wait for udev after configuring SRIOV .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: network: wait for udev after configuring SRIOV

2015-05-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: network: wait for udev after configuring SRIOV .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/40400/6/vdsm/network/api.py File vdsm/network/api.py:

Change in vdsm[master]: python3: use python3-compatible raising

2015-05-04 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: python3: use python3-compatible raising .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40214 To unsubscribe, visit

Change in vdsm[master]: stomp: add an option to create a stomp client

2015-05-04 Thread ykaplan
Yeela Kaplan has posted comments on this change. Change subject: stomp: add an option to create a stomp client .. Patch Set 6: Nir, Please see Piotr's comment on patch set 2. Piotr, What do you think? -- To view, visit

Change in vdsm[master]: gluster: Adds a new element 'additionalFeatures' to getVdsCaps.

2015-05-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: gluster: Adds a new element 'additionalFeatures' to getVdsCaps. .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/39324/4/vdsm/caps.py File

Change in vdsm[master]: vm: Simplify error handling in diskReplicateStart

2015-05-04 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: vm: Simplify error handling in diskReplicateStart .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40022 To unsubscribe, visit

Change in vdsm[master]: hooks: ovs

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: hooks: ovs .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and

Change in vdsm[master]: vm: Streamline names in diskReplicateStart

2015-05-04 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: vm: Streamline names in diskReplicateStart .. Patch Set 8: Code-Review+1 +1 to the idea, I haven't checked closely the code (if it's missing a replace,

Change in vdsm[master]: hooks: ovs

2015-05-04 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: hooks: ovs .. Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/40312/9/vdsm_hooks/ovs/ovs_network_setup.py File vdsm_hooks/ovs/ovs_network_setup.py: Line

Change in vdsm[master]: vm: Add required information to replica dict

2015-05-04 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: vm: Add required information to replica dict .. Patch Set 9: (4 comments) https://gerrit.ovirt.org/#/c/40024/9/vdsm/virt/vm.py File vdsm/virt/vm.py:

Change in vdsm[master]: spec: Require libvirt-python supporting blockCopy

2015-05-04 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: spec: Require libvirt-python supporting blockCopy .. Patch Set 7: Why is this separated from where you're using it? https://gerrit.ovirt.org/#/c/40112/6

Change in vdsm[master]: spec: Require libvirt-python supporting blockCopy

2015-05-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: spec: Require libvirt-python supporting blockCopy .. Patch Set 7: For better visibility - I don't like to hide requirement changes. -- To view, visit

Change in vdsm[master]: storage: Add resize map support in multipath.py

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: storage: Add resize map support in multipath.py .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: vm: Add required information to replica dict

2015-05-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: Add required information to replica dict .. Patch Set 9: (4 comments) https://gerrit.ovirt.org/#/c/40024/9/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2990:

Change in vdsm[master]: hsm: Call for resize_if_needed in getDeviceList

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: hsm: Call for resize_if_needed in getDeviceList .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: hsm: Call for resize_if_needed in getDeviceList

2015-05-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: hsm: Call for resize_if_needed in getDeviceList .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/40469/3//COMMIT_MSG Commit Message: Line 3: AuthorDate:

Change in vdsm[master]: hooks: ovs

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: hooks: ovs .. Patch Set 10: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and

Change in vdsm[ovirt-3.5-gluster]: Add remoteServer parameter into gluster volumes list

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: Add remoteServer parameter into gluster volumes list .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[ovirt-3.5-gluster]: gluster: Add geo-replication start and stop session

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Add geo-replication start and stop session .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[ovirt-3.5-gluster]: gluster: add glusterStorageDevicesList verb

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: gluster: add glusterStorageDevicesList verb .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[ovirt-3.5-gluster]: gluster: volume snapshot create and delete verbs.

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: gluster: volume snapshot create and delete verbs. .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[ovirt-3.5-gluster]: gluster: Added geo-replication session list and session status

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Added geo-replication session list and session status .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug

Change in vdsm[ovirt-3.5-gluster]: gluster: Added gluster snapshot restore verb.

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Added gluster snapshot restore verb. .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[ovirt-3.5-gluster]: gluster: Fix arguments name for geo-replication status verb.

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Fix arguments name for geo-replication status verb. .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[ovirt-3.5-gluster]: gluster: geo-replication configuration related verbs.

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: gluster: geo-replication configuration related verbs. .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[ovirt-3.5-gluster]: gluster: volume snapshot activate and deactivate verbs.

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: gluster: volume snapshot activate and deactivate verbs. .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[ovirt-3.5-gluster]: spec: temporarily revert build dependency on non-existing bl...

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: spec: temporarily revert build dependency on non-existing blivet .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug

Change in vdsm[ovirt-3.5-gluster]: gluster: add _getDeviceDict function to reuse common code

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: gluster: add _getDeviceDict function to reuse common code .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[ovirt-3.5-gluster]: lvm:moved metadatasize as an optional param for pv create in...

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: lvm:moved metadatasize as an optional param for pv create in lvm module .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check

Change in vdsm[ovirt-3.5-gluster]: gluster: Modified geo-rep verbs to include newly added user

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Modified geo-rep verbs to include newly added user .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[ovirt-3.5-gluster]: gluster: storage devices list provides device size in MiB

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: gluster: storage devices list provides device size in MiB .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[ovirt-3.5-gluster]: gluster: modified parsing logic in snapshot config list.

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: gluster: modified parsing logic in snapshot config list. .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[ovirt-3.5-gluster]: gluster: volume snapshot list verb.

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: gluster: volume snapshot list verb. .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[ovirt-3.5-gluster]: spec: revert build dependency on non-existing blivet

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: spec: revert build dependency on non-existing blivet .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[ovirt-3.5-gluster]: gluster: geo-replication pause and resume session

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: gluster: geo-replication pause and resume session .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[ovirt-3.5-gluster]: gluster: Adds new verbs to setup gluster geo-replication.

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[ovirt-3.5-gluster]: gluster: Fetch disperse count and redundacy count for volume

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Fetch disperse count and redundacy count for volume .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[ovirt-3.5-gluster]: gluster: add createBrick verb

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: gluster: add createBrick verb .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[ovirt-3.5-gluster]: gluster: Corrected return value of gluster volume snapshot c...

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Corrected return value of gluster volume snapshot create .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no

Change in vdsm[ovirt-3.5-gluster]: gluster: Patch adds geo-replication create and delete verbs.

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Patch adds geo-replication create and delete verbs. .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[ovirt-3.5-gluster]: gluster: get rdma port number as part of volume status.

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: gluster: get rdma port number as part of volume status. .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[ovirt-3.5-gluster]: gluster: volume snapshot config list and set verbs.

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: gluster: volume snapshot config list and set verbs. .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[ovirt-3.5-gluster]: gluster: Adds new verb to setup geo-rep mount broker.

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Adds new verb to setup geo-rep mount broker. .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: python3: use python3-compatible raising

2015-05-04 Thread fromani
Francesco Romani has posted comments on this change. Change subject: python3: use python3-compatible raising .. Patch Set 3: Code-Review+1 assuming six is in RHEL (I expect so, but didn't check yet) -- To view, visit

Change in vdsm[ovirt-3.5]: netlink: fix PEP8 missing line in netlink memory leak patch

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: netlink: fix PEP8 missing line in netlink memory leak patch .. Patch Set 1: * Update tracker::#1158108::OK * Check Bug-Url::OK * Check Public

Change in vdsm[ovirt-3.5]: netlink: fix PEP8 missing line in netlink memory leak patch

2015-05-04 Thread phoracek
Petr Horáček has uploaded a new change for review. Change subject: netlink: fix PEP8 missing line in netlink memory leak patch .. netlink: fix PEP8 missing line in netlink memory leak patch Change-Id:

Change in vdsm[master]: hooks: ovs

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: hooks: ovs .. Patch Set 11: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and

Change in vdsm[ovirt-3.5]: netlink: fix PEP8 missing line in netlink memory leak patch

2015-05-04 Thread dnarayan
Darshan N has posted comments on this change. Change subject: netlink: fix PEP8 missing line in netlink memory leak patch .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40488 To unsubscribe, visit

Change in vdsm[master]: WIP: tests: add tests for sampling.SampleVMs

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: WIP: tests: add tests for sampling.SampleVMs .. Patch Set 20: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: vm: fix again stats_cache cleaning

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vm: fix again stats_cache cleaning .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: WIP: rename stats cache to vm stats cache

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: WIP: rename stats cache to vm stats cache .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: periodic: simplify per_vm_operation

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: periodic: simplify per_vm_operation .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: WIP: virt: better timeout for periodic operations

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: WIP: virt: better timeout for periodic operations .. Patch Set 34: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: sampling: more detailed stale sampling reporting

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: sampling: more detailed stale sampling reporting .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: sampling: introduce expensive checks

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: sampling: introduce expensive checks .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: periodic: improve isolation in VM dispatching

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: periodic: improve isolation in VM dispatching .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: virt: rename SampleVMs for clarity

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: virt: rename SampleVMs for clarity .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: vm: disappeared domain are not ready for commands

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vm: disappeared domain are not ready for commands .. Patch Set 30: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: sampling: statscache: support multiple removals

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: sampling: statscache: support multiple removals .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: network: wait for udev after configuring SRIOV

2015-05-04 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: network: wait for udev after configuring SRIOV .. Patch Set 6: Verified+1 after some inspection of kernel code it seems like every driver is free to implement a

Change in vdsm[master]: hooks: ovs

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: hooks: ovs .. Patch Set 12: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and

Change in vdsm[master]: sampling: statscache: more robust remove()

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: sampling: statscache: more robust remove() .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: vm: move stats_cache cleaning in Vm._cleanup()

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vm: move stats_cache cleaning in Vm._cleanup() .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: WIP: tests: add tests for sampling.SampleVMs

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: WIP: tests: add tests for sampling.SampleVMs .. Patch Set 21: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: sampling: introduce expensive checks

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: sampling: introduce expensive checks .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: WIP: rename stats cache to vm stats cache

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: WIP: rename stats cache to vm stats cache .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: WIP: virt: better timeout for periodic operations

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: WIP: virt: better timeout for periodic operations .. Patch Set 35: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: migration: typo: destServer attribute is private

2015-05-04 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: migration: typo: destServer attribute is private .. migration: typo: destServer attribute is private A typo in migration.py cause all migrations to fail.

Change in vdsm[master]: migration: use the response module

2015-05-04 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: migration: use the response module .. migration: use the response module Switch to response module for the sake of code clarity. Change-Id:

Change in vdsm[master]: migration: typo: destServer attribute is private

2015-05-04 Thread fromani
Francesco Romani has posted comments on this change. Change subject: migration: typo: destServer attribute is private .. Patch Set 1: Verified+1 verified doing migrations with a patched VDSM -- To view, visit

Change in vdsm[master]: lib: add the response.success() helper

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: lib: add the response.success() helper .. Patch Set 16: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: migration: typo: destServer attribute is private

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: migration: typo: destServer attribute is private .. Patch Set 1: * Update tracker::#1217362::OK * Check Bug-Url::OK * Check Public Bug::#1217362::OK,

Change in vdsm[master]: migration: use the response module

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: migration: use the response module .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: lib: add the response.success() helper

2015-05-04 Thread fromani
Francesco Romani has posted comments on this change. Change subject: lib: add the response.success() helper .. Patch Set 16: Verified+1 verified using the tests. -- To view, visit https://gerrit.ovirt.org/38270 To

Change in vdsm[master]: vm: Unify disk replication terms

2015-05-04 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: vm: Unify disk replication terms .. Patch Set 5: It looks like this should have been part of https://gerrit.ovirt.org/#/c/40023/8 -- To view, visit

Change in vdsm[master]: vm: Add _findConfDisk() helper

2015-05-04 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: vm: Add _findConfDisk() helper .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/40217/5/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2709:

Change in vdsm[master]: periodic: simplify per_vm_operation

2015-05-04 Thread fromani
Francesco Romani has posted comments on this change. Change subject: periodic: simplify per_vm_operation .. Patch Set 6: Verified+1 verified running a patched VDSM and checking that the periodic operations still run (they

Change in vdsm[master]: virt: rename SampleVMs for clarity

2015-05-04 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: rename SampleVMs for clarity .. Patch Set 5: Verified+1 verified running patched VDSM and inspecting logs: periodic.Scheduler::DEBUG::2015-05-04

Change in vdsm[master]: vm: Add _findConfDisk() helper

2015-05-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: Add _findConfDisk() helper .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/40217/5/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2709:

Change in vdsm[master]: vm: Unify disk replication terms

2015-05-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: Unify disk replication terms .. Patch Set 5: It could be squashed with the other patch, but at the time I posted the first, patch these changes were not

Change in vdsm[ovirt-3.5]: netlink: fix PEP8 missing line in netlink memory leak patch

2015-05-04 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: netlink: fix PEP8 missing line in netlink memory leak patch .. Patch Set 1: Verified+1 Fixed PEP8 error 'E302 expected 2 blank lines' introduced here

Change in vdsm[master]: models, configurators: replace the internal 'async' flag wit...

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: models, configurators: replace the internal 'async' flag with blockingdhcp .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check

Change in vdsm[master]: ifcfg: let ifup accept a NetDevice so 'async' flag can be re...

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: ifcfg: let ifup accept a NetDevice so 'async' flag can be removed .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no

Change in vdsm[ovirt-3.5-gluster]: gluster: adds a verb to check if a gluster volume is empty

2015-05-04 Thread dnarayan
Hello Piotr Kliczewski, Bala.FA, Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/40495 to review the following change. Change subject: gluster: adds a verb to check if a gluster volume is empty

Change in vdsm[ovirt-3.5-gluster]: gluster: adds a verb to check if a gluster volume is empty

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: gluster: adds a verb to check if a gluster volume is empty .. Patch Set 1: * Update tracker::#1207960::OK * Check Bug-Url::OK * Check Public

Change in vdsm[ovirt-3.5]: monitor: return whether the reported status is actual

2015-05-04 Thread alitke
Adam Litke has posted comments on this change. Change subject: monitor: return whether the reported status is actual .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38874 To unsubscribe, visit

Change in vdsm[master]: vm: move stats_cache cleaning in Vm._cleanup()

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vm: move stats_cache cleaning in Vm._cleanup() .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: virt: rename SampleVMs for clarity

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: virt: rename SampleVMs for clarity .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: vm: disappeared domain are not ready for commands

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vm: disappeared domain are not ready for commands .. Patch Set 31: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: sampling: statscache: more robust remove()

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: sampling: statscache: more robust remove() .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: sampling: more detailed stale sampling reporting

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: sampling: more detailed stale sampling reporting .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: network: wait for udev after configuring SRIOV

2015-05-04 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: network: wait for udev after configuring SRIOV .. Patch Set 6: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/40400/6/vdsm/network/api.py File

Change in vdsm[master]: gluster: New verb to mount update fstab for meta-volume

2015-05-04 Thread dnarayan
Darshan N has uploaded a new change for review. Change subject: gluster: New verb to mount update fstab for meta-volume .. gluster: New verb to mount update fstab for meta-volume This patch adds a new verb 'MetaVolumeMount'

Change in vdsm[master]: gluster: New verb to mount update fstab for meta-volume

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: gluster: New verb to mount update fstab for meta-volume .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[ovirt-3.5-gluster]: gluster: adds a verb to check if a gluster volume is empty

2015-05-04 Thread dnarayan
Darshan N has posted comments on this change. Change subject: gluster: adds a verb to check if a gluster volume is empty .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/40495 To unsubscribe, visit

Change in vdsm[ovirt-3.5]: netlink: fix PEP8 missing line in netlink memory leak patch

2015-05-04 Thread dnarayan
Darshan N has posted comments on this change. Change subject: netlink: fix PEP8 missing line in netlink memory leak patch .. Patch Set 1: With this fix build is going through for me. Pep8 version:

Change in vdsm[master]: migration: typo: destServer attribute is private

2015-05-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: migration: typo: destServer attribute is private .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40491 To unsubscribe, visit

Change in vdsm[master]: migration: typo: destServer attribute is private

2015-05-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: migration: typo: destServer attribute is private .. Patch Set 2: * Update tracker::#1217362::OK * Check TR::#1217362::ERROR, --- should not match .* --

Change in vdsm[master]: migration: typo: destServer attribute is private

2015-05-04 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: migration: typo: destServer attribute is private .. migration: typo: destServer attribute is private A typo in migration.py cause all migrations to

  1   2   >