Change in vdsm[master]: gluster: Modified volumeReplaceBrickCommit verb.

2015-05-08 Thread dnarayan
Darshan N has posted comments on this change. Change subject: gluster: Modified volumeReplaceBrickCommit verb. .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/40587 To unsubscribe, visit

Change in vdsm[master]: sampling: hoststats: rationalize getInterfaceStats

2015-05-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: sampling: hoststats: rationalize getInterfaceStats .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: sampling: hoststats: kill sample() method

2015-05-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: sampling: hoststats: kill sample() method .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: sampling: HostStatsThread as periodic operation

2015-05-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: sampling: HostStatsThread as periodic operation .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: sampling: make _getInterfaceStats a function

2015-05-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: sampling: make _getInterfaceStats a function .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: sampling: less verbose debug in _getInterfaceStats

2015-05-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: sampling: less verbose debug in _getInterfaceStats .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: WIP: sampling: allow to get the nth-last sample

2015-05-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: WIP: sampling: allow to get the nth-last sample .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: sampling: make _getCpuCoresStats a function

2015-05-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: sampling: make _getCpuCoresStats a function .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: network: factor out method from unified restoration logic.

2015-05-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: network: factor out method from unified restoration logic. .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url

Change in vdsm[master]: network: factor out method from unified restoration logic.

2015-05-08 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: network: factor out method from unified restoration logic. .. Patch Set 2: Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/40536 To

Change in vdsm[master]: network: move NET_LOGICALNET_CONF_BACK_DIR to ifcfg

2015-05-08 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: network: move NET_LOGICALNET_CONF_BACK_DIR to ifcfg .. Patch Set 3: Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/40538 To unsubscribe,

Change in vdsm[master]: network: move NET_LOGICALNET_CONF_BACK_DIR to ifcfg

2015-05-08 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: network: move NET_LOGICALNET_CONF_BACK_DIR to ifcfg .. network: move NET_LOGICALNET_CONF_BACK_DIR to ifcfg It is not used elsewhere. Change-Id:

Change in vdsm[master]: network: do not try to clean running configuration

2015-05-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: network: do not try to clean running configuration .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found.

Change in vdsm[master]: network: do not try to clean running configuration

2015-05-08 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: network: do not try to clean running configuration .. network: do not try to clean running configuration This small optimization was also the behavior

Change in vdsm[master]: network: do not try to clean running configuration

2015-05-08 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: network: do not try to clean running configuration .. Patch Set 2: Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/40537 To unsubscribe,

Change in vdsm[master]: network: factor out method from unified restoration logic.

2015-05-08 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: network: factor out method from unified restoration logic. .. network: factor out method from unified restoration logic. Change-Id:

Change in vdsm[master]: network: move NET_LOGICALNET_CONF_BACK_DIR to ifcfg

2015-05-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: network: move NET_LOGICALNET_CONF_BACK_DIR to ifcfg .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found.

Change in vdsm[master]: virt: Add getReplicaXML method

2015-05-08 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: virt: Add getReplicaXML method .. Patch Set 9: (5 comments) https://gerrit.ovirt.org/#/c/40068/9/tests/vmStorageTests.py File tests/vmStorageTests.py:

Change in vdsm[master]: sampling: make _getInterfaceStats a function

2015-05-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: sampling: make _getInterfaceStats a function .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: sampling: hoststats: switch to SampleWindow

2015-05-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: sampling: hoststats: switch to SampleWindow .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: sampling: hoststats: kill sample() method

2015-05-08 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: sampling: hoststats: kill sample() method .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40425 To unsubscribe, visit

Change in vdsm[master]: vm: Detect RNG device by type

2015-05-08 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: Detect RNG device by type .. Patch Set 1: Thanks for the fix! I'd like to have/enhance an unit test to highlight the failure, and to make sure this will

Change in vdsm[master]: sampling: make _getCpuCoresStats a function

2015-05-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: sampling: make _getCpuCoresStats a function .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: sampling: allow to get the nth-last sample

2015-05-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: sampling: allow to get the nth-last sample .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: sampling: HostStatsThread as periodic operation

2015-05-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: sampling: HostStatsThread as periodic operation .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: vm: Add required information to replica dict

2015-05-08 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: vm: Add required information to replica dict .. Patch Set 11: (1 comment) https://gerrit.ovirt.org/#/c/40024/11/vdsm/virt/vm.py File vdsm/virt/vm.py:

Change in vdsm[master]: virt: Add Drive.replicaChunked property

2015-05-08 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: virt: Add Drive.replicaChunked property .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40184 To unsubscribe, visit

Change in vdsm[master]: vm: Unify disk replication terms

2015-05-08 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: vm: Unify disk replication terms .. Patch Set 7: Code-Review-1 Please squash with https://gerrit.ovirt.org/#/c/40023 -- To view, visit

Change in vdsm[master]: vm: Gather disk replication private methods

2015-05-08 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: vm: Gather disk replication private methods .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40221 To unsubscribe, visit

Change in vdsm[master]: vm: Delete Drive.diskReplicate before saving config

2015-05-08 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: vm: Delete Drive.diskReplicate before saving config .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40220 To unsubscribe, visit

Change in vdsm[ovirt-3.5.2]: Adding qemu-kvm-ev and qemu-img-ev to caps report

2015-05-08 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: Adding qemu-kvm-ev and qemu-img-ev to caps report .. Patch Set 1: -Verified -- To view, visit https://gerrit.ovirt.org/40693 To unsubscribe, visit

Change in vdsm[ovirt-3.5.2]: Adding qemu-kvm-ev and qemu-img-ev to caps report

2015-05-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: Adding qemu-kvm-ev and qemu-img-ev to caps report .. Patch Set 1: * Update tracker::#1218581::OK * Check Bug-Url::OK * Check Public Bug::#1218581::OK,

Change in vdsm[ovirt-3.5.2]: Adding qemu-kvm-ev and qemu-img-ev to caps report

2015-05-08 Thread sbonazzo
Hello Yaniv Bronhaim, Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/40693 to review the following change. Change subject: Adding qemu-kvm-ev and qemu-img-ev to caps report ..

Change in vdsm[ovirt-3.5.2]: Adding qemu-kvm-ev and qemu-img-ev to caps report

2015-05-08 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: Adding qemu-kvm-ev and qemu-img-ev to caps report .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/40693 To unsubscribe, visit

Change in vdsm[ovirt-3.5.2]: Adding qemu-kvm-ev and qemu-img-ev to caps report

2015-05-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: Adding qemu-kvm-ev and qemu-img-ev to caps report .. Patch Set 2: * Update tracker::#1219754::OK * Check Bug-Url::OK * Check Public Bug::#1219754::OK,

Change in vdsm[ovirt-3.5.2]: Adding qemu-kvm-ev and qemu-img-ev to caps report

2015-05-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: Adding qemu-kvm-ev and qemu-img-ev to caps report .. Patch Set 3: * Update tracker::#1219754::OK * Check TR::#1219754::OK * Set MODIFIED::bug

Change in vdsm[ovirt-3.5]: Adding qemu-kvm-ev and qemu-img-ev to caps report

2015-05-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: Adding qemu-kvm-ev and qemu-img-ev to caps report .. Patch Set 2: * Update tracker::#1219754::OK * Set MODIFIED::bug 1219754#1219754IGNORE, not

Change in vdsm[ovirt-3.5]: Adding qemu-kvm-ev and qemu-img-ev to caps report

2015-05-08 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Adding qemu-kvm-ev and qemu-img-ev to caps report .. Patch Set 1: Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/40695 To unsubscribe,

Change in vdsm[ovirt-3.5.2]: Adding qemu-kvm-ev and qemu-img-ev to caps report

2015-05-08 Thread ybronhei
Yaniv Bronhaim has submitted this change and it was merged. Change subject: Adding qemu-kvm-ev and qemu-img-ev to caps report .. Adding qemu-kvm-ev and qemu-img-ev to caps report ev suffix for those packages were added -

Change in vdsm[master]: python3: avoid python3-inconsistent syntax

2015-05-08 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: python3: avoid python3-inconsistent syntax .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40215 To unsubscribe, visit

Change in vdsm[ovirt-3.5]: Fixed parted utils for newer parted

2015-05-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: Fixed parted utils for newer parted .. Patch Set 2: * Update tracker::#1219875::OK * Check Bug-Url::OK * Check Public Bug::#1219875::OK, public bug *

Change in vdsm[ovirt-3.5]: Fixed parted utils for newer parted

2015-05-08 Thread dcaroest
David Caro has posted comments on this change. Change subject: Fixed parted utils for newer parted .. Patch Set 2: Rerun-Hooks: all -- To view, visit https://gerrit.ovirt.org/40703 To unsubscribe, visit

Change in vdsm[ovirt-3.5.2]: Adding qemu-kvm-ev and qemu-img-ev to caps report

2015-05-08 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Adding qemu-kvm-ev and qemu-img-ev to caps report .. Patch Set 2: Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/40693 To unsubscribe,

Change in vdsm[master]: stomp: client side subscription

2015-05-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: stomp: client side subscription .. Patch Set 18: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: jsonrpc: allow processing of notifications

2015-05-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpc: allow processing of notifications .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: jsonrpc: events

2015-05-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpc: events .. Patch Set 18: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '

Change in vdsm[master]: stomp: server side subscriptions

2015-05-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: stomp: server side subscriptions .. Patch Set 17: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: reactor: using single instance

2015-05-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: reactor: using single instance .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[ovirt-3.5]: Fixed parted utils for newer parted

2015-05-08 Thread dcaroest
David Caro has uploaded a new change for review. Change subject: Fixed parted utils for newer parted .. Fixed parted utils for newer parted In the newer parted, the new flag 'esp' is added to the 'boot' flag on all partitions.

Change in vdsm[ovirt-3.5]: Adding qemu-kvm-ev and qemu-img-ev to caps report

2015-05-08 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Adding qemu-kvm-ev and qemu-img-ev to caps report .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40695 To unsubscribe, visit

Change in vdsm[master]: jsonrpc: remove not needed param

2015-05-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpc: remove not needed param .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: events: vm status notifications

2015-05-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: events: vm status notifications .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: stompReactor: fix naming of default destination

2015-05-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: stompReactor: fix naming of default destination .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: stomp: subscription cleanup when connection lost

2015-05-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: stomp: subscription cleanup when connection lost .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: jsonrpc: ignore not needed transport

2015-05-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpc: ignore not needed transport .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: python3: avoid python3-inconsistent syntax

2015-05-08 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: python3: avoid python3-inconsistent syntax .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/40215/5/Makefile.am File Makefile.am: Line 130:

Change in vdsm[ovirt-3.5]: Adding qemu-kvm-ev and qemu-img-ev to caps report

2015-05-08 Thread ybronhei
Yaniv Bronhaim has submitted this change and it was merged. Change subject: Adding qemu-kvm-ev and qemu-img-ev to caps report .. Adding qemu-kvm-ev and qemu-img-ev to caps report ev suffix for those packages were added -

Change in vdsm[master]: stomp: outgoing connection to a broker

2015-05-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: stomp: outgoing connection to a broker .. Patch Set 12: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[ovirt-3.5]: Fixed parted utils for newer parted

2015-05-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: Fixed parted utils for newer parted .. Patch Set 2: -Verified * Update tracker::#1219875::OK * Check Bug-Url::OK * Check Public Bug::#1219875::OK, public

Change in vdsm[master]: events: sending stats with vm status change event

2015-05-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: events: sending stats with vm status change event .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found -- To view, visit

Change in vdsm[master]: events: sending stats with vm status change event

2015-05-08 Thread piotr . kliczewski
Piotr Kliczewski has abandoned this change. Change subject: events: sending stats with vm status change event .. Abandoned This patch was squashed with vm status notifications. -- To view, visit

Change in vdsm[ovirt-3.5]: Fixed parted utils for newer parted

2015-05-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: Fixed parted utils for newer parted .. Patch Set 1: Verified-1 * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url

Change in vdsm[master]: WIP: virt: bind console to unix domain socket

2015-05-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: WIP: virt: bind console to unix domain socket .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[ovirt-3.5]: Fixed parted utils for newer parted

2015-05-08 Thread dcaroest
David Caro has posted comments on this change. Change subject: Fixed parted utils for newer parted .. Patch Set 2: Continuous-Integration+1 Verified+1 Though the ci test failed, the test related to this issue passed -- To

Change in vdsm[master]: python3: avoid python3-inconsistent syntax

2015-05-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: python3: avoid python3-inconsistent syntax .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To

Change in vdsm[master]: python3: avoid python3-inconsistent syntax

2015-05-08 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: python3: avoid python3-inconsistent syntax .. python3: avoid python3-inconsistent syntax There is a long long way before vdsm becomes compatible with

Change in vdsm[master]: python3: avoid python3-inconsistent syntax

2015-05-08 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: python3: avoid python3-inconsistent syntax .. Patch Set 5: Verified+1 -- To view, visit https://gerrit.ovirt.org/40215 To unsubscribe, visit

Change in vdsm[master]: python3: avoid python3-inconsistent syntax

2015-05-08 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: python3: avoid python3-inconsistent syntax .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/40215/5/Makefile.am File Makefile.am: Line 130:

Change in vdsm[ovirt-3.5]: Fixed parted utils for newer parted

2015-05-08 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Fixed parted utils for newer parted .. Patch Set 2: Code-Review+2 indeed, the following failure is unrelated to this patch. 16:20:48 FAIL:

Change in vdsm[master]: WIP: virt: bind console to unix domain socket

2015-05-08 Thread fromani
Francesco Romani has posted comments on this change. Change subject: WIP: virt: bind console to unix domain socket .. Patch Set 1: (4 comments) https://gerrit.ovirt.org/#/c/40704/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line

Change in vdsm[master]: spec: require qemu-*-ev on CentOS = 7

2015-05-08 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: spec: require qemu-*-ev on CentOS = 7 .. Patch Set 1: I'll rephrase, as I'm not sure this was clear enough. Upstream oVirt should run on EL. ANY EL. The

Change in vdsm[ovirt-3.5]: Added missing bond default options

2015-05-08 Thread dcaroest
David Caro has uploaded a new change for review. Change subject: Added missing bond default options .. Added missing bond default options Change-Id: Iafabb9b575bb3b1cb3a00402d3e588c74792104d Bug-Url:

Change in vdsm[ovirt-3.5]: Added missing bond default options

2015-05-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: Added missing bond default options .. Patch Set 1: * Update tracker::#1219932::OK * Check Bug-Url::OK * Check Public Bug::#1219932::OK, public bug *

Change in vdsm[ovirt-3.5]: Fixed parted utils for newer parted

2015-05-08 Thread dcaroest
David Caro has posted comments on this change. Change subject: Fixed parted utils for newer parted .. Patch Set 2: btw. for the ci flag, no need to remove reviewer, setting it +1 will allow the submit (max needed, min no

Change in vdsm[ovirt-3.5]: Added missing bond default options

2015-05-08 Thread dcaroest
David Caro has posted comments on this change. Change subject: Added missing bond default options .. Patch Set 1: I don't really know if that json is used for anything else or if that is the correct fix, let me know, so far

Change in vdsm[master]: spec: require qemu-*-ev on CentOS = 7

2015-05-08 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: spec: require qemu-*-ev on CentOS = 7 .. Patch Set 1: No, VDSM cares about these features, and cares about being built on Centos. Totally it's responsibility

Change in vdsm[master]: virt: Add getReplicaXML method

2015-05-08 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: virt: Add getReplicaXML method .. Patch Set 9: (5 comments) https://gerrit.ovirt.org/#/c/40068/9/tests/vmStorageTests.py File tests/vmStorageTests.py: Line 140:

Change in vdsm[master]: utils: add command execution logging helpers

2015-05-08 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: utils: add command execution logging helpers .. Patch Set 7: (2 comments) https://gerrit.ovirt.org/#/c/38831/7/lib/vdsm/cmdutils.py File lib/vdsm/cmdutils.py:

Change in vdsm[ovirt-3.5.2]: Adding qemu-kvm-ev and qemu-img-ev to caps report

2015-05-08 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: Adding qemu-kvm-ev and qemu-img-ev to caps report .. Patch Set 2: Verified+1 vdsClient -s 0 getVdsCaps: 'qemu-img': {'buildtime':

Change in vdsm[ovirt-3.5]: Adding qemu-kvm-ev and qemu-img-ev to caps report

2015-05-08 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: Adding qemu-kvm-ev and qemu-img-ev to caps report .. Patch Set 1: Verified+1 vdsClient -s 0 getVdsCaps: 'qemu-img': {'buildtime':

Change in vdsm[master]: spec: require qemu-*-ev on CentOS = 7

2015-05-08 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: spec: require qemu-*-ev on CentOS = 7 .. Patch Set 1: Allon, why the missing features in the ev packages are not available in qemu upstream? Upstream project

Change in vdsm[master]: python3: fix forgotten python2-ish syntax

2015-05-08 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: python3: fix forgotten python2-ish syntax .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40511 To unsubscribe, visit

Change in vdsm[master]: python3: fix forgotten python2-ish syntax

2015-05-08 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: python3: fix forgotten python2-ish syntax .. python3: fix forgotten python2-ish syntax A print statement and a few old-style octal literal hid in

Change in vdsm[master]: python3: fix forgotten python2-ish syntax

2015-05-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: python3: fix forgotten python2-ish syntax .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To

Change in vdsm[master]: python3: fix forgotten python2-ish syntax

2015-05-08 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: python3: fix forgotten python2-ish syntax .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/40511 To unsubscribe, visit

Change in vdsm[master]: DONTMERGE: jsonrpc: debug log

2015-05-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: DONTMERGE: jsonrpc: debug log .. Patch Set 48: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/38155 To

Change in vdsm[master]: DONTMERGE: jsonrpc: debug log

2015-05-08 Thread fromani
Francesco Romani has abandoned this change. Change subject: DONTMERGE: jsonrpc: debug log .. Abandoned -- To view, visit https://gerrit.ovirt.org/38155 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: Move passwd (set saslpassword for libvirt) to vdsm-tool

2015-05-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool .. Patch Set 9: * Update tracker::#1169338::OK * Check Bug-Url::OK * Check Public

Change in vdsm[master]: vm: Add required information to replica dict

2015-05-08 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: Add required information to replica dict .. Patch Set 11: (1 comment) https://gerrit.ovirt.org/#/c/40024/11/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3051:

Change in vdsm[master]: vm: Unify disk replication terms

2015-05-08 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: Unify disk replication terms .. Patch Set 7: Federico, this cannot be squashed with 40023 - it contains changes added in 40024. I can move it down above

Change in vdsm[ovirt-3.5]: Adding qemu-kvm-ev and qemu-img-ev to caps report

2015-05-08 Thread sbonazzo
Hello Yaniv Bronhaim, Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/40695 to review the following change. Change subject: Adding qemu-kvm-ev and qemu-img-ev to caps report ..

Change in vdsm[ovirt-3.5.2]: Adding qemu-kvm-ev and qemu-img-ev to caps report

2015-05-08 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Adding qemu-kvm-ev and qemu-img-ev to caps report .. Patch Set 2: Code-Review+2 excuse me for missing that... but since when we have this branch?? -- To

Change in vdsm[master]: spec: require qemu-*-ev on CentOS = 7

2015-05-08 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: spec: require qemu-*-ev on CentOS = 7 .. Patch Set 1: I don't think we should consume qemu-*-ev packages - on upstream we should consume the standard qemu

Change in vdsm[ovirt-3.5]: Adding qemu-kvm-ev and qemu-img-ev to caps report

2015-05-08 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: Adding qemu-kvm-ev and qemu-img-ev to caps report .. Patch Set 1: * Update tracker::#1219754::OK * Check Bug-Url::OK * Check Public Bug::#1219754::OK,

Change in vdsm[master]: spec: updated qemu-*-rhev version

2015-05-08 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: spec: updated qemu-*-rhev version .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/40671/1//COMMIT_MSG Commit Message: Line 6: Line 7: spec: updated

Change in vdsm[master]: spec: require qemu-*-ev on CentOS = 7

2015-05-08 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: spec: require qemu-*-ev on CentOS = 7 .. Patch Set 1: (2 comments) Nir, I don't understand this comment at all. EL builds of qemu lack all live features

Change in vdsm[master]: Don't prepare image with illegal volumes

2015-05-08 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Don't prepare image with illegal volumes .. Patch Set 2: There is no significant difference with or without this patch. But we may like to test more snapshots, or