Change in vdsm[master]: mailbox: Use threading instead of thread

2015-05-18 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: mailbox: Use threading instead of thread .. Patch Set 1: Tested extend flows during vm provisioning and live storage migration. -- To view, visit https://gerrit.o

Change in vdsm[master]: vdsm: hook for booting from an ISO image gathered via http

2015-05-18 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vdsm: hook for booting from an ISO image gathered via http .. Patch Set 1: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#917026::ERROR, pr

Change in vdsm[master]: vdsm: hook for booting from an ISO image gathered via http

2015-05-18 Thread stirabos
Simone Tiraboschi has uploaded a new change for review. Change subject: vdsm: hook for booting from an ISO image gathered via http .. vdsm: hook for booting from an ISO image gathered via http Let the VM boot from an ISO image m

Change in vdsm[master]: Add unit test to caps.py to prepare for minidom replacement

2015-05-18 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: Add unit test to caps.py to prepare for minidom replacement .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url f

Change in vdsm[master]: vdsm: hook for booting from an ISO image gathered via http

2015-05-18 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vdsm: hook for booting from an ISO image gathered via http .. Patch Set 2: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#917026::ERROR, pr

Change in vdsm[master]: mailbox: Use threading instead of thread

2015-05-18 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: mailbox: Use threading instead of thread .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/41061 To unsubscribe, visit https://gerrit.ovirt.org

Change in vdsm[master]: Add unit test to caps.py to prepare for minidom replacement

2015-05-18 Thread mmirecki
Marcin Mirecki has uploaded a new change for review. Change subject: Add unit test to caps.py to prepare for minidom replacement .. Add unit test to caps.py to prepare for minidom replacement minidom will be replaced by ElementT

Change in vdsm[master]: Configure libvirt to generate VM's core dumps

2015-05-18 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: Configure libvirt to generate VM's core dumps .. Patch Set 2: * Update tracker::#1220993::OK * Check Bug-Url::OK * Check Public Bug::#1220993::OK, public

Change in vdsm[master]: Add unit test to caps.py to prepare for minidom replacement

2015-05-18 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: Add unit test to caps.py to prepare for minidom replacement .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url f

Change in vdsm[master]: Replacing minidom with ElementTree in caps.py

2015-05-18 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: Replacing minidom with ElementTree in caps.py .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sur

Change in vdsm[master]: Adding unittests for caps.py

2015-05-18 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: Adding unittests for caps.py .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: Replacing minidom with ElementTree in caps.py

2015-05-18 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: Replacing minidom with ElementTree in caps.py .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sur

Change in vdsm[master]: Replacing minidom with ElementTree in caps.py

2015-05-18 Thread mmirecki
Marcin Mirecki has uploaded a new change for review. Change subject: Replacing minidom with ElementTree in caps.py .. Replacing minidom with ElementTree in caps.py minidom is replaced by ElementTree.py in caps.py. This is becaus

Change in vdsm[master]: tcTests: base pseudo-random bridge names on PID, too.

2015-05-18 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: tcTests: base pseudo-random bridge names on PID, too. .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: tcTests: base pseudo-random bridge names on PID, too.

2015-05-18 Thread danken
Dan Kenigsberg has uploaded a new change for review. Change subject: tcTests: base pseudo-random bridge names on PID, too. .. tcTests: base pseudo-random bridge names on PID, too. It seems that the Jenkins-driven mock test provi

Change in vdsm[master]: jsonrpc: rename setMessageHandler method

2015-05-18 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: rename setMessageHandler method .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/41065/2//COMMIT_MSG Commit Message: Line 4: Commit: Da

Change in vdsm[master]: status: adding elapsed time in millis

2015-05-18 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: status: adding elapsed time in millis .. Patch Set 3: (4 comments) https://gerrit.ovirt.org/#/c/40904/3//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015

Change in vdsm[master]: mailbox: Use threading instead of thread

2015-05-18 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: mailbox: Use threading instead of thread .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

Change in vdsm[master]: mailbox: Rename mailbox monitor threads

2015-05-18 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: mailbox: Rename mailbox monitor threads .. mailbox: Rename mailbox monitor threads Name the HSM and SPM mail monitor threads "mailbox.HSMMonitor" and "mailbox.SPMM

Change in vdsm[master]: mailbox: Rename mailbox monitor threads

2015-05-18 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: mailbox: Rename mailbox monitor threads .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure head

Change in vdsm[master]: events: vm status notifications

2015-05-18 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: events: vm status notifications .. Patch Set 12: (3 comments) https://gerrit.ovirt.org/#/c/38937/12/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 363: Line 36

Change in vdsm[master]: Configure libvirt to generate VM's core dumps

2015-05-18 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: Configure libvirt to generate VM's core dumps .. Patch Set 2: Code-Review+1 Hi Amador, please tick in verified as soon you confirm the patch works.

Change in vdsm[master]: jsonrpc: rename setMessageHandler method for pep8 compliance

2015-05-18 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpc: rename setMessageHandler method for pep8 compliance .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[master]: stomp: creation of outbox class

2015-05-18 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: stomp: creation of outbox class .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/41067/2/lib/yajsonrpc/stomp.py File lib/yajsonrpc/stomp.py: Line 2

Change in vdsm[ovirt-3.5]: Actually use the NUMA stats thread

2015-05-18 Thread fromani
Francesco Romani has posted comments on this change. Change subject: Actually use the NUMA stats thread .. Patch Set 4: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/41059/4/vdsm/virt/vm.py File vdsm/virt/vm.py: Line

Change in vdsm[master]: mailbox: Rename mailbox monitor threads

2015-05-18 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: mailbox: Rename mailbox monitor threads .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure head

Change in vdsm[master]: mailbox: Rename mailbox monitor threads

2015-05-18 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: mailbox: Rename mailbox monitor threads .. Patch Set 2: Fix copy and paste error. -- To view, visit https://gerrit.ovirt.org/41080 To unsubscribe, visit https://g

Change in vdsm[master]: properties: Add properties module

2015-05-18 Thread derez
Daniel Erez has posted comments on this change. Change subject: properties: Add properties module .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/40822/3/lib/vdsm/properties.py File lib/vdsm/properties.py: Line 2: re

Change in vdsm[master]: ceph: Input validation using properties

2015-05-18 Thread derez
Daniel Erez has posted comments on this change. Change subject: ceph: Input validation using properties .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/41049/2/vdsm/virt/secret.py File vdsm/virt/secret.py: Line 21:

Change in vdsm[ovirt-3.5]: Actually use the NUMA stats thread

2015-05-18 Thread msivak
Martin Sivák has posted comments on this change. Change subject: Actually use the NUMA stats thread .. Patch Set 4: Yep, the 3.5 stats collecting requires at least two samples or it is not collecting at all (I tried that). --

Change in vdsm[master]: vdsm: hook for booting from an ISO image gathered via http

2015-05-18 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vdsm: hook for booting from an ISO image gathered via http .. Patch Set 2: (7 comments) https://gerrit.ovirt.org/#/c/41076/2/vdsm_hooks/httpisoboot/before_vm

Change in vdsm[master]: tests: also delete a legacy lease file if it exists

2015-05-18 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: tests: also delete a legacy lease file if it exists .. Patch Set 2: (2 comments) English is broken, I admit. https://gerrit.ovirt.org/#/c/40906/2/tests/functi

Change in vdsm[master]: properties: Add properties module

2015-05-18 Thread fromani
Francesco Romani has posted comments on this change. Change subject: properties: Add properties module .. Patch Set 3: Code-Review+1 (2 comments) yes, this is cool. It reminds me of definitions of columns in Model classes in

Change in vdsm[master]: ceph: Input validation using properties

2015-05-18 Thread fromani
Francesco Romani has posted comments on this change. Change subject: ceph: Input validation using properties .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41049 To unsubscribe, visit https://gerrit.o

Change in vdsm[master]: mailbox: Rename mailbox monitor threads

2015-05-18 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: mailbox: Rename mailbox monitor threads .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/41080 To unsubscribe, visit https://gerrit.ovirt.org/

Change in vdsm[master]: ceph: Clear all secrets during startup and shutdown

2015-05-18 Thread fromani
Francesco Romani has posted comments on this change. Change subject: ceph: Clear all secrets during startup and shutdown .. Patch Set 3: (1 comment) looks good, but one question inside https://gerrit.ovirt.org/#/c/40968/3/vds

Change in vdsm[master]: ceph: Validate network disk parameters

2015-05-18 Thread fromani
Francesco Romani has posted comments on this change. Change subject: ceph: Validate network disk parameters .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40477 To unsubscribe, visit https://gerrit.ov

Change in vdsm[master]: ceph: Add libvirt secret testing infrastructure

2015-05-18 Thread fromani
Francesco Romani has posted comments on this change. Change subject: ceph: Add libvirt secret testing infrastructure .. Patch Set 7: Code-Review+1 thanks for moving test code in the shared fakelib. -- To view, visit https://g

Change in vdsm[master]: ifcfg: extract _ifup and call _ifup_nonblocking when 'async'...

2015-05-18 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: ifcfg: extract _ifup and call _ifup_nonblocking when 'async' flag was used .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/40478/3/vdsm/network/confi

Change in vdsm[master]: ifcfg: extract _ifup and call _ifup_nonblocking when 'async'...

2015-05-18 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: ifcfg: extract _ifup and call _ifup_nonblocking when 'async' flag was used .. Patch Set 3: Code-Review-1 Visibility -- To view, visit https://gerrit.ovirt.or

<    1   2   3