Yaniv Bronhaim has posted comments on this change.
Change subject: drop vds_bootstrap
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41527
To unsubscribe, visit https://gerrit.ovirt.org/settings
automat...@ovirt.org has posted comments on this change.
Change subject: Add support for KSM and CpuTune calls to XMLRPC for MOM to use
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug
automat...@ovirt.org has posted comments on this change.
Change subject: sourceroute: move private static methods out of
DynamicSourceRoute
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 19:
(1 comment)
https://gerrit.ovirt.org/#/c/38937/19/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1181:
automat...@ovirt.org has posted comments on this change.
Change subject: stomp: outgoing connection to a broker
..
Patch Set 22:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: virt: Trigger event on guest agent status changes
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
automat...@ovirt.org has posted comments on this change.
Change subject: status: logging status values before sending event
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
automat...@ovirt.org has posted comments on this change.
Change subject: stomp: subscription cleanup when connection lost
..
Patch Set 15:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
automat...@ovirt.org has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 19:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: jsonrpc: events
..
Patch Set 28:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Piotr Kliczewski has posted comments on this change.
Change subject: status: logging status values before sending event
..
Patch Set 4: Verified+1
Verified with the engine containing event changes to see that events are send
automat...@ovirt.org has posted comments on this change.
Change subject: Separate MOM to an external process
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Martin Sivák has posted comments on this change.
Change subject: Separate MOM to an external process
..
Patch Set 1:
This is a concept of how the MOM/VDSM separation could look like. It touches
the minimal amount of files and
Ondřej Svoboda has uploaded a new change for review.
Change subject: sourceroutethread: use models.IPv4 to validate configuration
..
sourceroutethread: use models.IPv4 to validate configuration
Change-Id:
automat...@ovirt.org has posted comments on this change.
Change subject: sourceroutethread: use models.IPv4 to validate configuration
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
automat...@ovirt.org has posted comments on this change.
Change subject: sourceroute: move private static methods out of
DynamicSourceRoute
..
Patch Set 9:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no
automat...@ovirt.org has posted comments on this change.
Change subject: sourceroutethread: use models.IPv4 to validate configuration
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
automat...@ovirt.org has posted comments on this change.
Change subject: status: adding elapsed time in millis
..
Patch Set 9:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: sourceroute: move removal to network configurators
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 19: Verified+1
Verified with the engine containing event changes to see that events are send
on vm status
Piotr Kliczewski has posted comments on this change.
Change subject: status: adding elapsed time in millis
..
Patch Set 9: Verified+1
Verified with the engine containing event changes to see that events are send
on vm status
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: events
..
Patch Set 28: Verified+1
Verified with the engine containing event changes to see that events are send
on vm status changes.
--
To
Dan Kenigsberg has posted comments on this change.
Change subject: drop vds_bootstrap
..
Patch Set 1: Code-Review+2 Verified+1
rpm builds without the now-unneeded vds_bootstrap
--
To view, visit
automat...@ovirt.org has posted comments on this change.
Change subject: virt: cleanup: fix link to libvirt docs
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: drop vds_bootstrap
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Jan Tomko has uploaded a new change for review.
Change subject: virt: cleanup: fix link to libvirt docs
..
virt: cleanup: fix link to libvirt docs
The API reference on the libvirt website was split into multiple
pages in
Dan Kenigsberg has submitted this change and it was merged.
Change subject: drop vds_bootstrap
..
drop vds_bootstrap
ovirt-engine-3.0 needed vds_bootstrap.rpm in order to install new hosts.
Now that we no longer support engine
Petr Horáček has posted comments on this change.
Change subject: iproute2: source routes are removed by the kernel on ifdown
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/36652
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: sourceroute: move exception handling to the respective
configurator
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no
automat...@ovirt.org has posted comments on this change.
Change subject: sourceroute: move removal to network configurators
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
automat...@ovirt.org has posted comments on this change.
Change subject: sourceroute: move configuration to network configurators
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
automat...@ovirt.org has posted comments on this change.
Change subject: sourceroute: split gathering of routes and rules off
configure() and remove()
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: fix vg create failed first time during brick create
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: Added an optional argument to mountBrokerSetup verb.
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug
Darshan N has uploaded a new change for review.
Change subject: gluster: Added an optional argument to mountBrokerSetup verb.
..
gluster: Added an optional argument to mountBrokerSetup verb.
Added an optional argument called
Darshan N has posted comments on this change.
Change subject: gluster: Added an optional argument to mountBrokerSetup verb.
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/41600
To unsubscribe, visit
Ondřej Svoboda has posted comments on this change.
Change subject: iproute2: source routes are removed by the kernel on ifdown
..
Patch Set 4: Verified+1
There is a test, actually.
testSetupNetworksAddDelDhcp checks that both
automat...@ovirt.org has posted comments on this change.
Change subject: Separate MOM to an external process
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has posted comments on this change.
Change subject: vm: Detect smartcard device by type
..
Patch Set 1: Code-Review+1
I'm ok with this patch. Later on, we should make the devices all consistent,
right now we
Francesco Romani has posted comments on this change.
Change subject: RFE: Report downtime for each live migration
..
Patch Set 1: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/41415
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: migration: Support SPICE seamless migration over NAT
..
Patch Set 6: Code-Review+1
(2 comments)
https://gerrit.ovirt.org/#/c/41223/6/client/vdsClient.py
automat...@ovirt.org has posted comments on this change.
Change subject: models: remove __nonzero__ from IPv4 and IPv6
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: iproute2, pyroute2: shorten _setIpConfig
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: Separate MOM to an external process
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 19:
(1 comment)
https://gerrit.ovirt.org/#/c/38937/19/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 393:
Dan Kenigsberg has posted comments on this change.
Change subject: tests: make assertSourceRoutingConfiguration more readable
..
Patch Set 2: Code-Review+2
raising Ido's score
--
To view, visit https://gerrit.ovirt.org/41236
automat...@ovirt.org has posted comments on this change.
Change subject: tests: make assertSourceRoutingConfiguration more readable
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url
Francesco Romani has posted comments on this change.
Change subject: RFE: Report downtime for each live migration
..
Patch Set 1:
(1 comment)
reverting score only for visibility, the patch is fine.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: make assertSourceRoutingConfiguration more readable
..
tests: make assertSourceRoutingConfiguration more readable
Change-Id:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: Detect smartcard device by type
..
vm: Detect smartcard device by type
Use 'type' instead of 'device' to detect smartcard devices. For
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm: hook for booting from an ISO image gathered via https
..
vdsm: hook for booting from an ISO image gathered via https
Let the VM boot from an ISO
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: hook for booting from an ISO image gathered via https
..
Patch Set 13: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41076
To unsubscribe,
automat...@ovirt.org has posted comments on this change.
Change subject: vdsm: hook for booting from an ISO image gathered via https
..
Patch Set 14:
* update_tracker: OK
* Set MODIFIED::bug 917026#917026IGNORE, not
Dan Kenigsberg has posted comments on this change.
Change subject: migration: Support SPICE seamless migration over NAT
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41223
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: vm: Detect smartcard device by type
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41479
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: vm: Detect smartcard device by type
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
automat...@ovirt.org has posted comments on this change.
Change subject: migration: Support SPICE seamless migration over NAT
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: migration: Support SPICE seamless migration over NAT
..
migration: Support SPICE seamless migration over NAT
Change-Id:
Francesco Romani has posted comments on this change.
Change subject: lib: pthread: allow to set system thread names
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/41052/10//COMMIT_MSG
Commit Message:
Line 12: The
automat...@ovirt.org has posted comments on this change.
Change subject: jsonrpc: events
..
Patch Set 29:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
automat...@ovirt.org has posted comments on this change.
Change subject: jsonrpc: ignore not needed transport
..
Patch Set 14:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: stomp: subscription cleanup when connection lost
..
Patch Set 16:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
automat...@ovirt.org has posted comments on this change.
Change subject: jsonrpc: remove not needed param
..
Patch Set 14:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: sourceroute: use a more explicit name (_add_static_source_route)
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug
Dan Kenigsberg has posted comments on this change.
Change subject: lib: pthread: allow to set system thread names
..
Patch Set 10: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41052
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: stomp: calling super explicitly
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: virt: Trigger event on guest agent status changes
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
automat...@ovirt.org has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 20:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: fix vg create failed first time during brick create
..
Patch Set 8:
* Update tracker::#1226186::OK
* Check Bug-Url::OK
* Check Public
automat...@ovirt.org has posted comments on this change.
Change subject: stompReactor: fix naming of default destination
..
Patch Set 12:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Ondřej Svoboda has uploaded a new change for review.
Change subject: sourceroute: use a more explicit name (_add_static_source_route)
..
sourceroute: use a more explicit name (_add_static_source_route)
Change-Id:
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 20: Verified+1
Rebased and fixed 2 comments (removals). Copying verify flag from previous
patch set.
--
To
automat...@ovirt.org has posted comments on this change.
Change subject: reactor: move creation to clientIF
..
Patch Set 14:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: status: logging status values before sending event
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
automat...@ovirt.org has posted comments on this change.
Change subject: stomp: client side subscription
..
Patch Set 28:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: stomp: allow single stomp reactor
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Dan Kenigsberg has posted comments on this change.
Change subject: tests: sampling: more careful elapsedTime check
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41504
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: virt: cleanup: fix link to libvirt docs
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41598
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: virt: cleanup: fix link to libvirt docs
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Fabian Deutsch has posted comments on this change.
Change subject: change libvirtd to use upstart except in over node
..
Patch Set 3: Code-Review+1 Verified+1
In my testing this patch worked.
--
To view, visit
automat...@ovirt.org has posted comments on this change.
Change subject: stomp: server side subscriptions
..
Patch Set 27:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: stomp: outgoing connection to a broker
..
Patch Set 23:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Ondřej Svoboda has uploaded a new change for review.
Change subject: sourceroute: remove removeSourceRoute in favour of
remove_dynamic_source_route
..
sourceroute: remove removeSourceRoute in favour of
automat...@ovirt.org has posted comments on this change.
Change subject: sourceroute: remove removeSourceRoute in favour of
remove_dynamic_source_route
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check
Ondřej Svoboda has uploaded a new change for review.
Change subject: sourceroute: replace _removeSourceRoute by parametrized versions
..
sourceroute: replace _removeSourceRoute by parametrized versions
Ifcfg configurator now
Ondřej Svoboda has uploaded a new change for review.
Change subject: sourceroute: replace configureSourceRoute by
configure_source_route
..
sourceroute: replace configureSourceRoute by configure_source_route
The new function
automat...@ovirt.org has posted comments on this change.
Change subject: sourceroute: replace _removeSourceRoute by parametrized versions
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug
automat...@ovirt.org has posted comments on this change.
Change subject: sourceroute: replace configureSourceRoute by
configure_source_route
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no
automat...@ovirt.org has posted comments on this change.
Change subject: tests: sampling: more careful elapsedTime check
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: sourceroute: move most of validation to configure_source_route
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: sampling: more careful elapsedTime check
..
tests: sampling: more careful elapsedTime check
When checking HostMonitor.get() with empty samples
automat...@ovirt.org has posted comments on this change.
Change subject: tests: sampling: more careful elapsedTime check
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
automat...@ovirt.org has posted comments on this change.
Change subject: sourceroute: move validation into IPv4.validate_source_route
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
automat...@ovirt.org has posted comments on this change.
Change subject: sourceroute: use a more explicit name (_add_static_source_route)
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug
automat...@ovirt.org has posted comments on this change.
Change subject: sourceroute: move most of validation to configure_source_route
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug
automat...@ovirt.org has posted comments on this change.
Change subject: sourceroute: move exception handling to the respective
configurator
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no
automat...@ovirt.org has posted comments on this change.
Change subject: sourceroutethread: use models.IPv4 to validate configuration
(partially)
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check
automat...@ovirt.org has posted comments on this change.
Change subject: sourceroute: replace configureSourceRoute by
configure_source_route
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no
automat...@ovirt.org has posted comments on this change.
Change subject: sourceroute: remove removeSourceRoute in favour of
remove_dynamic_source_route
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check
automat...@ovirt.org has posted comments on this change.
Change subject: sourceroute: move most of validation to configure_source_route
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug
1 - 100 of 122 matches
Mail list logo