Francesco Romani has posted comments on this change. Change subject: migration: Support SPICE seamless migration over NAT ......................................................................
Patch Set 6: Code-Review+1 (2 comments) https://gerrit.ovirt.org/#/c/41223/6/client/vdsClient.py File client/vdsClient.py: Line 2165: '[autoConverge:bool] [compressed:bool]', Line 2166: 'Migrate a desktop from src machine to dst host using ' Line 2167: 'the specified ports and an optional address for ' Line 2168: 'migration data traffic.', Line 2169: 'o consoleAddress: destination host grapics address', typo: grapHics (but I don't mind) Line 2170: 'o autoConverge: force convergence during migration', Line 2171: 'o compressed: compress repeated pages during migration' Line 2172: )), Line 2173: 'migrateStatus': (serv.do_mStat, https://gerrit.ovirt.org/#/c/41223/6/vdsm/virt/migration.py File vdsm/virt/migration.py: Line 63: def __init__(self, vm, dst='', dstparams='', Line 64: mode=MODE_REMOTE, method=METHOD_ONLINE, Line 65: tunneled=False, dstqemu='', abortOnError=False, Line 66: consoleAddress=None, compressed=False, Line 67: autoConverge=False, **kwargs): we should cleanup this mess. In a later patch of course. Line 68: self.log = vm.log Line 69: self._vm = vm Line 70: self._dst = dst Line 71: self._mode = mode -- To view, visit https://gerrit.ovirt.org/41223 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7b2b765c62aaf1cc694990205b518558e808516 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
