automat...@ovirt.org has posted comments on this change.
Change subject: gluster: Verify volume is Replica 3
..
Patch Set 36:
* Update tracker::#1123052::OK
* Check Bug-Url::OK
* Check Public Bug::#1123052::OK, public bug
*
automat...@ovirt.org has posted comments on this change.
Change subject: build: Build vdsm-gluster as part of RHEV vdsm build
..
Patch Set 14:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Ido Barkan has posted comments on this change.
Change subject: net: tests: wait for a specific state of a device
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/42675/4/tests/functional/networkTests.py
File
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: introducing KernelConfig
..
net: introducing KernelConfig
KernelConfig can be created from a NetInfo object. It reflects the
network kernel state
Dan Kenigsberg has posted comments on this change.
Change subject: net: introducing KernelConfig
..
Patch Set 23: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41973
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: during boot, restore only networks that were actually
changed.
..
net: during boot, restore only networks that were actually changed.
This is an
Ido Barkan has posted comments on this change.
Change subject: net: Drop default bonding options
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/42594/6/vdsm/network/models.py
File vdsm/network/models.py:
Line 243:
automat...@ovirt.org has posted comments on this change.
Change subject: net: SetupNetworks small cleanups.
..
Patch Set 21:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: net: ifcfg: ONBOOT=yes on all persisted network files.
..
Patch Set 13:
* Update tracker::#1203422::OK
* Check Bug-Url::OK
* Check Public
automat...@ovirt.org has posted comments on this change.
Change subject: net: tests: wait for a specific state of a device
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Ido Barkan has posted comments on this change.
Change subject: net: ifcfg: ONBOOT=yes on all persisted network files.
..
Patch Set 13: Verified+1
--
To view, visit https://gerrit.ovirt.org/42362
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: net: Drop default bonding options
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42594
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: net: Drop default bonding options
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Drop default bonding options
..
net: Drop default bonding options
On old engines, no bonding options were provided to VDSM and it
used to
automat...@ovirt.org has posted comments on this change.
Change subject: net: tests: wait for a specific state of a device
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
automat...@ovirt.org has posted comments on this change.
Change subject: net: tests: wait for a specific state of a device
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: tests: wait for a specific state of a device
..
net: tests: wait for a specific state of a device
5d6c571d added _waitForKnownOperstate. This
automat...@ovirt.org has posted comments on this change.
Change subject: net: during boot, restore only networks that were actually
changed.
..
Patch Set 17:
* Update tracker::#1203422::OK
* Check Bug-Url::OK
* Check Public
automat...@ovirt.org has posted comments on this change.
Change subject: net: introducing KernelConfig
..
Patch Set 21:
* Update tracker::#1203422::OK
* Check Bug-Url::OK
* Check Public Bug::#1203422::OK, public bug
* Check
automat...@ovirt.org has posted comments on this change.
Change subject: net: during boot, restore only networks that were actually
changed.
..
Patch Set 18:
* Update tracker::#1203422::OK
* Check Bug-Url::OK
* Check Public
Dan Kenigsberg has posted comments on this change.
Change subject: net: during boot, restore only networks that were actually
changed.
..
Patch Set 18: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42355
To
automat...@ovirt.org has posted comments on this change.
Change subject: net: introducing KernelConfig
..
Patch Set 24:
* Update tracker::#1203422::OK
* Set MODIFIED::bug 1203422#1203422IGNORE, not all related patches
automat...@ovirt.org has posted comments on this change.
Change subject: net: introducing KernelConfig
..
Patch Set 23:
* Update tracker::#1203422::OK
* Check Bug-Url::OK
* Check Public Bug::#1203422::OK, public bug
* Check
automat...@ovirt.org has posted comments on this change.
Change subject: net: introducing KernelConfig
..
Patch Set 22:
* Update tracker::#1203422::OK
* Check Bug-Url::OK
* Check Public Bug::#1203422::OK, public bug
* Check
automat...@ovirt.org has posted comments on this change.
Change subject: net: ifcfg: ONBOOT=yes on all persisted network files.
..
Patch Set 15:
* Update tracker::#1203422::OK
* Check TR::#1203422::ERROR, 3.5.4 should not
Dan Kenigsberg has posted comments on this change.
Change subject: tests: netlink: update expected events
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40814
To unsubscribe, visit
Ido Barkan has posted comments on this change.
Change subject: net: tests: wait for a specific state of a device
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/42675
To unsubscribe, visit
Ido Barkan has posted comments on this change.
Change subject: net: Drop default bonding options
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/42594
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: net: tests: wait for a specific state of a device
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42675
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: net: during boot, restore only networks that were actually
changed.
..
Patch Set 19:
* Update tracker::#1203422::OK
* Set MODIFIED::bug
automat...@ovirt.org has posted comments on this change.
Change subject: net: ifcfg: ONBOOT=yes on all persisted network files.
..
Patch Set 14:
* Update tracker::#1203422::OK
* Check Bug-Url::OK
* Check Public
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: ifcfg: ONBOOT=yes on all persisted network files.
..
net: ifcfg: ONBOOT=yes on all persisted network files.
This will cause network service to
Dan Kenigsberg has posted comments on this change.
Change subject: net: ifcfg: ONBOOT=yes on all persisted network files.
..
Patch Set 14: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42362
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: network: allow custom bondOption
..
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40882
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Improve readability of _ownedIfcfg procedure
..
Patch Set 4: Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/42287
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Improve readability of _ownedIfcfg procedure
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42287
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: Improve readability of _ownedIfcfg procedure
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: Improve readability of _ownedIfcfg procedure
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
automat...@ovirt.org has posted comments on this change.
Change subject: hooks: Open vSwitch configurator
..
Patch Set 42:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has posted comments on this change.
Change subject: virt: Only filter guest agent data, only on XMLRPC
..
Patch Set 10:
besides previous comments, I'm fine with the concept.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: virt: Only filter guest agent data, only on XMLRPC
..
Patch Set 10: Code-Review-1
(1 comment)
I don't like to pass filter=blah all around, but can't think
Dan Kenigsberg has posted comments on this change.
Change subject: tests: skip jsonrpc tests
..
Patch Set 1: Code-Review-1
this would not help, as @brokentest only convert a FAIL to SKIP. It does not
help regarding tests that
Francesco Romani has posted comments on this change.
Change subject: virt: Forcibly unregister fds with errors from epoll
..
Patch Set 3: Code-Review-1
(1 comment)
-1 for visibility because of a question inside
automat...@ovirt.org has posted comments on this change.
Change subject: caps: remove CPU map parsing
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
automat...@ovirt.org has posted comments on this change.
Change subject: tests: network: when using bonding, attach at least 2 slaves
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Michal Skrivanek has posted comments on this change.
Change subject: caps: remove CPU map parsing
..
Patch Set 2: Code-Review+1
about time to remove this hack. It should cause no harm, even though Intel
processors report
Martin Polednik has posted comments on this change.
Change subject: tests: fix pep8 indentation
..
Patch Set 1: Verified+1
pep8 passes
--
To view, visit https://gerrit.ovirt.org/42802
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: tests: fix pep8 indentation
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Martin Polednik has uploaded a new change for review.
Change subject: tests: fix pep8 indentation
..
tests: fix pep8 indentation
Change-Id: I482d31bdef7744ef5769b805f382b0051f47888c
Signed-off-by: Martin Polednik
Bala.FA has posted comments on this change.
Change subject: gluster: create pv with custom dataalignment value
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/42782/1//COMMIT_MSG
Commit Message:
Line
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: run restorecon for files created during geo-rep create.
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug
Darshan N has uploaded a new change for review.
Change subject: gluster: run restorecon for files created during geo-rep create.
..
gluster: run restorecon for files created during geo-rep create.
This patch runs restorecon on
Sandro Bonazzola has posted comments on this change.
Change subject: build: Add dependency on gluster-cli
..
Patch Set 15: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41858
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: networkTests: fix pep8 overindent
..
Patch Set 1: Verified+1
pep8 passes
--
To view, visit https://gerrit.ovirt.org/42793
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt: Force a vdsm restart on too many epoll errors on
untracked FDs
..
Patch Set 3:
(1 comment)
-1 for visibility and discussion. Mixed feelings here.
Petr Horáček has posted comments on this change.
Change subject: tests: netlink: update expected events
..
Patch Set 3: Verified+1
Passed NetlinkEventMonitorTests with IPv6 enabled and with disabled as well.
--
To view,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: netlink: update expected events
..
tests: netlink: update expected events
If IPv6 is disabled in kernel, we don't get all expected events on
automat...@ovirt.org has posted comments on this change.
Change subject: tests: netlink: update expected events
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
automat...@ovirt.org has posted comments on this change.
Change subject: networkTests: fix pep8 overindent
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Martin Polednik has uploaded a new change for review.
Change subject: networkTests: fix pep8 overindent
..
networkTests: fix pep8 overindent
Change-Id: I307667f450018006d8b53e4699e604722c534fe6
Signed-off-by: Martin Polednik
automat...@ovirt.org has posted comments on this change.
Change subject: build: Add dependency on gluster-cli
..
Patch Set 15:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: Verify volume is Replica 3
..
Patch Set 37:
* Update tracker::#1123052::OK
* Check Bug-Url::OK
* Check Public Bug::#1123052::OK, public bug
*
Bala.FA has posted comments on this change.
Change subject: gluster: run restorecon for files created during geo-rep create.
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42804
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Improve readability of _ownedIfcfg procedure
..
Improve readability of _ownedIfcfg procedure
Before this patch, _ownedIfcfg returned three possible
Dan Kenigsberg has posted comments on this change.
Change subject: register tool: Add lower() to compare fingerprints
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42752
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: utils: NoIntr* references moved from misc to utils
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Francesco Romani has uploaded a new change for review.
Change subject: migration: move progress update into an helper
..
migration: move progress update into an helper
Streamline migration.SourceThread.getStat() by moving
Francesco Romani has uploaded a new change for review.
Change subject: migration: de-entangle migration stat reporting
..
migration: de-entangle migration stat reporting
migration.SourceThread has very entangled and messy
automat...@ovirt.org has posted comments on this change.
Change subject: virt: enhance/fix migration.SourceThread.stop()
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Francesco Romani has uploaded a new change for review.
Change subject: migration: make status attribute private
..
migration: make status attribute private
No code outsiee the migration.SourceThread
should now access this field
Francesco Romani has uploaded a new change for review.
Change subject: migration: add helper to add status field
..
migration: add helper to add status field
In the case the migration is correctly progressing,
or if it
Francesco Romani has uploaded a new change for review.
Change subject: lib: migration: add response.is_failure helper
..
lib: migration: add response.is_failure helper
Add little helper to make the code more explicit
and
Francesco Romani has uploaded a new change for review.
Change subject: migration: return plain response on error
..
migration: return plain response on error
We should add extra status fields only when migration
is OK (either
automat...@ovirt.org has posted comments on this change.
Change subject: migration: make status attribute private
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has uploaded a new change for review.
Change subject: migration: on abort, override reason on dest VM
..
migration: on abort, override reason on dest VM
When a migration is aborted, the Engine looks
for the
automat...@ovirt.org has posted comments on this change.
Change subject: migration: add helper to add status field
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: migration: return plain response on error
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: migration: de-entangle migration stat reporting
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Timothy Asir has uploaded a new change for review.
Change subject: gluster: create pv with custom dataalignment value
..
gluster: create pv with custom dataalignment value
Blivet creates pv with 1mb dataalignment forcefully for
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: create pv with custom dataalignment value
..
Patch Set 1:
* Update tracker::#1178705::OK
* Check Bug-Url::OK
* Check Public Bug::#1178705::OK,
automat...@ovirt.org has posted comments on this change.
Change subject: virt: do not use status after getStat()
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: lib: migration: add response.is_failure helper
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: migration: move progress update into an helper
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Francesco Romani has uploaded a new change for review.
Change subject: migration: build new reason on success
..
migration: build new reason on success
There is no need to cache successfull responses,
it is cleaner and safer to
automat...@ovirt.org has posted comments on this change.
Change subject: migration: build new reason on success
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: migration: on abort, override reason on dest VM
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: migration: use the response module
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: migration: on abort, override reason on dest VM
..
Patch Set 2:
* Update tracker::#1154397::OK
* Check Bug-Url::OK
* Check Public Bug::#1154397::OK,
automat...@ovirt.org has posted comments on this change.
Change subject: Live Merge: Prevent merge when base volume is too small
..
Patch Set 1:
* Update tracker::#1232481::OK
* Check Bug-Url::OK
* Check Public
Adam Litke has uploaded a new change for review.
Change subject: Live Merge: Prevent merge when base volume is too small
..
Live Merge: Prevent merge when base volume is too small
When a disk with snapshots is resized you can
Adam Litke has posted comments on this change.
Change subject: gluster: Verify volume is Replica 3
..
Patch Set 37:
(1 comment)
https://gerrit.ovirt.org/#/c/41931/37/vdsm/storage/storageServer.py
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: register: Replace log location
..
Patch Set 1:
Dan, what do you say?
--
To view, visit https://gerrit.ovirt.org/42831
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: tests: skip jsonrpc tests
..
Patch Set 2: Verified+1
Verified by running local build and seeing the jsonrpc tests are excluded.
--
To view, visit
Petr Horáček has posted comments on this change.
Change subject: net: SetupNetworks small cleanups.
..
Patch Set 22:
(1 comment)
https://gerrit.ovirt.org/#/c/42022/22//COMMIT_MSG
Commit Message:
Line 3: AuthorDate:
automat...@ovirt.org has posted comments on this change.
Change subject: adding detachAnyStoragePoolHsm
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Adam Litke has posted comments on this change.
Change subject: build: Add dependency on gluster-cli
..
Patch Set 15: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41858
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: net: tests: do not use KernelConfig.__eq__ in tests
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Petr Horáček has posted comments on this change.
Change subject: net: SetupNetworks small cleanups.
..
Patch Set 22: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/42022/22/vdsm/network/api.py
File
automat...@ovirt.org has posted comments on this change.
Change subject: tests: skip jsonrpc tests
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
automat...@ovirt.org has posted comments on this change.
Change subject: build: Add dependency on gluster-cli
..
Patch Set 16:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
1 - 100 of 128 matches
Mail list logo
