Ido Barkan has posted comments on this change.
Change subject: tests: Isolate tcTests test properly
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44144
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Fix expandPermutations use with Mixins
..
Patch Set 2:
(2 comments)
Very nice, but should be updated to current master behavior, and could also be
more
Nir Soffer has posted comments on this change.
Change subject: tests: Fix expandPermutations use with Mixins
..
Patch Set 2: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/44151
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vm: event: simplify send_status_event
..
Patch Set 15: Verified+1
Verification: started overwriting the disk inside the VM (dd ... oflag=direct
...),
Adam Litke has posted comments on this change.
Change subject: tests: Fix expandPermutations use with Mixins
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/44151
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: periodic: Use thread names that can be used as system thread
names
..
Patch Set 3:
yep, I'm fine with periodic-sched.
--
To view, visit
automat...@ovirt.org has posted comments on this change.
Change subject: hyperv: enforce hypervclock presence
..
Patch Set 3:
* Update tracker::#1083529::OK
* Set MODIFIED::bug 1083529#1083529IGNORE, not oVirt prod but
Allon Mureinik has posted comments on this change.
Change subject: spmprotect: Switch from fencing by pid to fencing using
systemctl
..
Patch Set 7:
ping?
--
To view, visit https://gerrit.ovirt.org/43211
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: periodic: Use thread names that can be used as system thread
names
..
Patch Set 3:
Francesco, foo/\d is good notation for multiple threads running the same code.
Dan Kenigsberg has posted comments on this change.
Change subject: vm: remove unused 'output' value in response
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/44116
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: vm: remove unused 'output' value in response
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: vm: make up pauseCode if libvirt is omitting it
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Francesco Romani has posted comments on this change.
Change subject: vm: make up pauseCode if libvirt is omitting it
..
Patch Set 2: Verified+1
HOji 17:57:58 root [~]$ vdsClient -s 0 getAllVmStats
Francesco Romani has posted comments on this change.
Change subject: vm: event: simplify send_status_event
..
Patch Set 15: -Verified
wrong copy/paste, removing score
--
To view, visit https://gerrit.ovirt.org/43414
To
automat...@ovirt.org has posted comments on this change.
Change subject: vm: remove unused 'output' value in response
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: vm: event: send status event on IO Error
..
Patch Set 22:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: vm: make up pauseCode if libvirt is omitting it
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: vmstats: avoid explicit string conversion
..
Patch Set 10:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Adam Litke has posted comments on this change.
Change subject: Live Merge: Prevent merge when base volume is too small
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/42836
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Fix expandPermutations use with Mixins
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: hyperv: enforce hypervclock presence
..
Patch Set 2:
* Update tracker::#1083529::OK
* Check Bug-Url::OK
* Check Public Bug::#1083529::OK, public bug
*
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hyperv: enforce hypervclock presence
..
hyperv: enforce hypervclock presence
It is not enough for libvirt to have the
clock ...
timer
Dan Kenigsberg has posted comments on this change.
Change subject: hyperv: enforce hypervclock presence
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/44119
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: Live Merge: Allow extension of non-leaf raw volumes
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/43407
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: virt: Add _getVolumeInfo helper
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/43560
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vm: event: send status event on IO Error
..
Patch Set 21: Verified+1
works:
libvirtEventLoop::INFO::2015-07-29 17:56:07,654::vm::3608::virt.vm::(onIOError)
Adam Litke has posted comments on this change.
Change subject: tests: Fix expandPermutations use with Mixins
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/44151
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: mount: Better and simpler __hash__
..
Patch Set 5: Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/43978
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: mount: Better and simpler __hash__
..
mount: Better and simpler __hash__
The hash values were mixed in a poor way. There is no need to implement
this
automat...@ovirt.org has posted comments on this change.
Change subject: mount: Better and simpler __hash__
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
automat...@ovirt.org has posted comments on this change.
Change subject: net/api: drop support for legacy mgmt networks
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
Nir Soffer has posted comments on this change.
Change subject: tests: Fix expandPermutations use with Mixins
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/44151/2/tests/testlibTests.py
File tests/testlibTests.py:
automat...@ovirt.org has posted comments on this change.
Change subject: vm: event: send status event on pause and resume
..
Patch Set 19:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
automat...@ovirt.org has posted comments on this change.
Change subject: vmstats: do not report empty balloonInfo
..
Patch Set 12:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: vmstats: do not report empty ioTune
..
Patch Set 10:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: vmstats: report disks stats only if present
..
Patch Set 10:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: vm: event: simplify send_status_event
..
Patch Set 16:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has posted comments on this change.
Change subject: vm: remove unused 'output' value in response
..
Patch Set 3:
moved on vdsm_driven_events5 branch to enforce patch order
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: net/api: drop support for legacy mgmt networks
..
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.ovirt.org/43615
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net/api: drop support for legacy mgmt networks
..
net/api: drop support for legacy mgmt networks
Change-Id: I45d956b117f7a6cbfa97ce7e060a08307e62a883
Dan Kenigsberg has posted comments on this change.
Change subject: vm: make up pauseCode if libvirt is omitting it
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/44115
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Wait until an interface is up
..
Patch Set 12:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Remove hack for devices with same names
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Nir Soffer has uploaded a new change for review.
Change subject: tests: Remove hack for devices with same names
..
tests: Remove hack for devices with same names
After the test isolation issues in tcTests.py and
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Fix ipwrapper tests isolation
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Isolate tcTests test properly
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: Live Merge: Prevent merge when base volume is too small
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42836
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: Add _getVolumeInfo helper
..
virt: Add _getVolumeInfo helper
The next patch needs to call into to storage to get detailed volume size
automat...@ovirt.org has posted comments on this change.
Change subject: virt: Add _getVolumeInfo helper
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: virt: Add _getVolumeInfo helper
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/43560
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Abusing permutations to run tests multiple times
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Abusing permutations to run tests multiple times
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Isolate tcTests test properly
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Isolate tcTests test properly
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Use more random interface names
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Fix expandPermutations use with Mixins
..
tests: Fix expandPermutations use with Mixins
When using the expandPermutations decorator on Mixin
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Use more random interface names
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Fix expandPermutations use with Mixins
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Fix expandPermutations use with Mixins
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/44151
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Use more random interface names
..
tests: Use more random interface names
Shorten the default prefix, allowing longer random suffix, and
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Fix ipwrapper tests isolation
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has uploaded a new change for review.
Change subject: tests: Fix ipwrapper tests isolation
..
tests: Fix ipwrapper tests isolation
Similar to tcTests, tests were sharing same devices, so failure to
delete a device
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Isolate tcTests test properly
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: tests: Fix expandPermutations use with Mixins
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44151
To unsubscribe, visit
Nir Soffer has abandoned this change.
Change subject: tests: Wait until an interface is up
..
Abandoned
Still does not work. We need to fix test isolation first.
--
To view, visit https://gerrit.ovirt.org/44108
To
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Wait until an interface is up
..
Patch Set 12:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/44108
To
Nir Soffer has abandoned this change.
Change subject: tests: Abusing permutations to run tests multiple times
..
Abandoned
Need to get the basic test running first.
--
To view, visit https://gerrit.ovirt.org/44109
To
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Use more random interface names
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/44111
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Fix error handling when checking dependencies
..
tests: Fix error handling when checking dependencies
We used to hide *all* exceptions and skip
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Fix error handling when checking dependencies
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Fix error handling when checking dependencies
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/44110
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: packaging: updating for VDSM 4.17 on Debian jessie
..
Patch Set 29:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Dan Kenigsberg has posted comments on this change.
Change subject: net: always persist owned ifcfg files on ovirt node
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/44112/1/vdsm/vdsm-store-net-config.in
File
automat...@ovirt.org has posted comments on this change.
Change subject: net: always persist owned ifcfg files on ovirt node
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Ido Barkan has uploaded a new change for review.
Change subject: net: always persist owned ifcfg files on ovirt node
..
net: always persist owned ifcfg files on ovirt node
Change-Id: Ibc717b86194a32c050d346e235a5c35fd318e1ff
Nir Soffer has posted comments on this change.
Change subject: tests: Use more random interface names
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/44111/3/tests/tcTests.py
File tests/tcTests.py:
Line 69:
Line
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Fix error handling when checking dependencies
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Dan Kenigsberg has posted comments on this change.
Change subject: fix pep8
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44026
To unsubscribe, visit https://gerrit.ovirt.org/settings
Ido Barkan has posted comments on this change.
Change subject: tests: Use more random interface names
..
Patch Set 3:
Roman is right. So each test can create it's own bridge to isolate failures.
--
To view, visit
automat...@ovirt.org has posted comments on this change.
Change subject: net: always persist owned ifcfg files on ovirt node
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
automat...@ovirt.org has posted comments on this change.
Change subject: net: fix
testSetupNetworksDeletesTheBridgeOnlyWhenItIsReconfigured
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no
Dan Kenigsberg has posted comments on this change.
Change subject: net: fix
testSetupNetworksDeletesTheBridgeOnlyWhenItIsReconfigured
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/43995
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: fix
testSetupNetworksDeletesTheBridgeOnlyWhenItIsReconfigured
..
net: fix testSetupNetworksDeletesTheBridgeOnlyWhenItIsReconfigured
since the
Ido Barkan has posted comments on this change.
Change subject: net: always persist owned ifcfg files on ovirt node
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/44112/1/vdsm/network/configurators/ifcfg.py
File
Ido Barkan has posted comments on this change.
Change subject: tcTests: Fix problem of left over bridges
..
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/44028/2/tests/tcTests.py
File tests/tcTests.py:
Francesco Romani has uploaded a new change for review.
Change subject: vm: make up pauseCode if libvirt is omitting it
..
vm: make up pauseCode if libvirt is omitting it
When VDSM receives one IOError notification from libvirt,
automat...@ovirt.org has posted comments on this change.
Change subject: vm: make up pauseCode if libvirt is omitting it
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Dan Kenigsberg has posted comments on this change.
Change subject: net: always persist owned ifcfg files on ovirt node
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/44112/1/vdsm/network/configurators/ifcfg.py
File
Francesco Romani has uploaded a new change for review.
Change subject: vm: remove unused 'output' value in response
..
vm: remove unused 'output' value in response
The 'output' value is not documented in schema, and apparently
automat...@ovirt.org has posted comments on this change.
Change subject: vm: remove unused 'output' value in response
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: packaging: updating for VDSM 4.17 on Debian jessie
..
Patch Set 30:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Roman Mohr has posted comments on this change.
Change subject: tests: Use more random interface names
..
Patch Set 3:
Using choice instead of sample seems to be OK, but be aware that messages like
this:
SKIP: device
Yeela Kaplan has posted comments on this change.
Change subject: migration: fix parameters
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/44120
To unsubscribe, visit https://gerrit.ovirt.org/settings
Dima Kuznetsov has posted comments on this change.
Change subject: migration: fix parameters
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44120
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Wait until an interface is up
..
Patch Set 10:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Use more random interface names
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Martin Polednik has posted comments on this change.
Change subject: vmstats: do not report empty balloonInfo
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43539
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: vmstats: do not report empty ioTune
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43596
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Wait until an interface is up
..
Patch Set 11:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has posted comments on this change.
Change subject: vmstats: avoid explicit string conversion
..
Patch Set 9: Verified+1
--
To view, visit https://gerrit.ovirt.org/43718
To unsubscribe, visit
1 - 100 of 213 matches
Mail list logo
