Ido Barkan has posted comments on this change. Change subject: tcTests: Fix problem of left over bridges ......................................................................
Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/44028/2/tests/tcTests.py File tests/tcTests.py: Line 105: Line 106: def delDevice(self): Line 107: try: Line 108: self._ifDown() Line 109: check_call([EXT_BRCTL, 'delbr', self.devName]) this smells bad. we need to understand why does it happen and do it right, instead of just banging harder. I0e4b82fe488356c7553b2243dae21cab39a56939 is a good idea Line 110: except ExecError: Line 111: # Sometimes the bridge is not shut down, although ip reports so. Line 112: # Just retrying the shutdown and the removal once is enough to Line 113: # work around that. -- To view, visit https://gerrit.ovirt.org/44028 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd0d8f20283fdf80977bd1f78f5b2ac62f7e83c8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roman Mohr <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Roman Mohr <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
