Douglas Schilling Landgraf has posted comments on this change.
Change subject: register: remove legacy code
..
Patch Set 2:
doesn't look register error.
02:44:55 FAILED (SKIP=64, errors=3)
02:44:55 Exception AttributeError: "'
Douglas Schilling Landgraf has posted comments on this change.
Change subject: register: use node name and fqdn when needed
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/44221
To unsubscribe, visit http
automat...@ovirt.org has posted comments on this change.
Change subject: register: use node name and fqdn when needed
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: register: simplify check fqdn
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: register: use node name and fqdn when needed
..
register: use node name and fqdn when needed
Currently, we collect host fqdn before registering but
Douglas Schilling Landgraf has posted comments on this change.
Change subject: register: simplify check fqdn
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/44220
To unsubscribe, visit https://gerrit.ovir
Douglas Schilling Landgraf has posted comments on this change.
Change subject: register: remove legacy code
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/44219
To unsubscribe, visit https://gerrit.ovirt
automat...@ovirt.org has posted comments on this change.
Change subject: register: remove legacy code
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
automat...@ovirt.org has posted comments on this change.
Change subject: register: simplify check fqdn
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Douglas Schilling Landgraf has posted comments on this change.
Change subject: change downloaded ca pem filename
..
Patch Set 1: Code-Review-1
-1 for now
--
To view, visit https://gerrit.ovirt.org/42837
To unsubscribe, visit
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: register: simplify check fqdn
..
register: simplify check fqdn
Currently we use --check-fqdn (True or False) which
is unneeded. We can simplify usi
Douglas Schilling Landgraf has posted comments on this change.
Change subject: register: remove legacy code
..
Patch Set 1: Verified+1
I could make registration
--
To view, visit https://gerrit.ovirt.org/44219
To unsubscribe,
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: register: remove legacy code
..
register: remove legacy code
The legacy code should be dropped. The new registration
schema should only support Eng
automat...@ovirt.org has posted comments on this change.
Change subject: register: remove legacy code
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: tests: Add requires_brctl and requries_tc decorators
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/44218
To unsubscribe, visit https://gerr
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Add requires_brctl and requries_tc decorators
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, m
Nir Soffer has uploaded a new change for review.
Change subject: tests: Add requires_brctl and requries_tc decorators
..
tests: Add requires_brctl and requries_tc decorators
Lot of tests used nettestlib.checkDependencies() in se
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Add requires_brctl and requries_tc decorators
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, m
Douglas Schilling Landgraf has abandoned this change.
Change subject: vdsm-tool: remove register verb
..
Abandoned
The verb will remain.
--
To view, visit https://gerrit.ovirt.org/43921
To unsubscribe, visit https://gerrit.ov
automat...@ovirt.org has posted comments on this change.
Change subject: vdsm-tool: remove register verb
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/43921
To unsubscri
Nir Soffer has posted comments on this change.
Change subject: nettestlib: Remove unneeded hack for improving randomness
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/44216
To unsubscribe, visit https:/
Nir Soffer has uploaded a new change for review.
Change subject: nettestlib: Remove unneeded hack for improving randomness
..
nettestlib: Remove unneeded hack for improving randomness
Python seed the random number generator from
automat...@ovirt.org has posted comments on this change.
Change subject: nettestlib: Remove unneeded hack for improving randomness
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fou
Nir Soffer has posted comments on this change.
Change subject: Live Merge: Prevent merge when base volume is too small
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42836
To unsubscribe, visit https:
Adam Litke has posted comments on this change.
Change subject: Live Merge: Prevent merge when base volume is too small
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/42836
To unsubscribe, visit https://g
automat...@ovirt.org has posted comments on this change.
Change subject: Live merge: Update base size after live merge
..
Patch Set 7:
* Update tracker::#1232481::OK
* Check Bug-Url::OK
* Check Public Bug::#1232481::OK, public
automat...@ovirt.org has posted comments on this change.
Change subject: Live Merge: Allow extension of non-leaf raw volumes
..
Patch Set 4:
* Update tracker::#1232481::OK
* Check Bug-Url::OK
* Check Public Bug::#1232481::OK, p
automat...@ovirt.org has posted comments on this change.
Change subject: Live Merge: Prevent merge when base volume is too small
..
Patch Set 7:
* Update tracker::#1232481::OK
* Check Bug-Url::OK
* Check Public Bug::#1232481::O
Adam Litke has posted comments on this change.
Change subject: tests: Enhance permutations tests
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/44214
To unsubscribe, visit https://gerrit.ovirt.org/set
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Enhance permutations tests
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
Nir Soffer has posted comments on this change.
Change subject: tests: Enhance permutations tests
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/44214
To unsubscribe, visit https://gerrit.ovirt.org/settin
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Enhance permutations tests
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
Nir Soffer has uploaded a new change for review.
Change subject: tests: Enhance permutations tests
..
tests: Enhance permutations tests
- Move nested class to module to avoid clumsy self.Class syntax. We don't
really need to h
Nir Soffer has posted comments on this change.
Change subject: tests: Extract nettestlib module
..
Patch Set 3: Verified+1
This version fixes typo in the module name so no it actually works.
--
To view, visit https://gerrit.o
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Extract nettestlib module
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
Nir Soffer has posted comments on this change.
Change subject: tests: Extract nettestlib module
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/44212
To unsubscribe, visit https://gerrit.ovirt.org/setting
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Extract nettestlib module
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
Nir Soffer has posted comments on this change.
Change subject: vm: switch to response.error()
..
Patch Set 19: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38268
To unsubscribe, visit https://gerrit.ovirt.org/setti
automat...@ovirt.org has posted comments on this change.
Change subject: network: fix parameters to ConfigNetworkError
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
Nir Soffer has posted comments on this change.
Change subject: v2v: use the response module
..
Patch Set 13: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38447
To unsubscribe, visit https://gerrit.ovirt.org/setting
automat...@ovirt.org has posted comments on this change.
Change subject: network: wait for a bridge to appear before disabling IPv6 on it
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug
Nir Soffer has uploaded a new change for review.
Change subject: tests: Extract nettestlib module
..
tests: Extract nettestlib module
ipwrapperTests was using tcTests as a library. Move the shared code to
new module and use it f
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Extract nettestlib module
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
Ido Barkan has posted comments on this change.
Change subject: make pep8-1.4.6 (el7) happy
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/44201
To unsubscribe, visit https://gerrit.ovirt.org/settings
Ge
Ido Barkan has posted comments on this change.
Change subject: make pep8-1.4.6 (el7) happy
..
Patch Set 2: Code-Review+1
➜ vdsm git:(a30eb7e) ✗ ../pep8/pep8.py --version
1.4.6
➜ vdsm git:(a30eb7e) ✗ ../pep8/pep8.py --exclude=
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: stats: remove try/except for KeyError
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/42
automat...@ovirt.org has posted comments on this change.
Change subject: make pep8-1.4.6 (el7) happy
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches '
Francesco Romani has abandoned this change.
Change subject: virt: avoid spam logs if sampling hollow VMs
..
Abandoned
too high risk of hiding worse bugs
--
To view, visit https://gerrit.ovirt.org/41406
To unsubscribe, visit h
automat...@ovirt.org has posted comments on this change.
Change subject: virt: avoid spam logs if sampling hollow VMs
..
Patch Set 14:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/4140
automat...@ovirt.org has posted comments on this change.
Change subject: virt: avoid spam logs with periodic false negative
..
Patch Set 13:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.or
Francesco Romani has abandoned this change.
Change subject: virt: avoid spam logs with periodic false negative
..
Abandoned
wrong direction
--
To view, visit https://gerrit.ovirt.org/41659
To unsubscribe, visit https://gerrit
automat...@ovirt.org has posted comments on this change.
Change subject: periodic: virt: do not poll storage in migrations
..
Patch Set 17:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org
automat...@ovirt.org has posted comments on this change.
Change subject: executor: allow caller to resize TaskQueue
..
Patch Set 13:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/41658
Francesco Romani has abandoned this change.
Change subject: executor: allow caller to resize TaskQueue
..
Abandoned
wong direction
--
To view, visit https://gerrit.ovirt.org/41658
To unsubscribe, visit https://gerrit.ovirt.or
Francesco Romani has abandoned this change.
Change subject: periodic: virt: do not poll storage in migrations
..
Abandoned
wrong direction
--
To view, visit https://gerrit.ovirt.org/40507
To unsubscribe, visit https://gerrit.
automat...@ovirt.org has posted comments on this change.
Change subject: v2v: use the response module
..
Patch Set 13:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
automat...@ovirt.org has posted comments on this change.
Change subject: vm: switch to response.error()
..
Patch Set 19:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
automat...@ovirt.org has posted comments on this change.
Change subject: virt: fully convert to response module
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
Francesco Romani has abandoned this change.
Change subject: sampling: stats: remove try/except for KeyError
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/42744
To unsubscribe, visit https://gerrit.ovirt.org/settings
automat...@ovirt.org has posted comments on this change.
Change subject: vm: remove _reportError
..
Patch Set 19:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug
automat...@ovirt.org has posted comments on this change.
Change subject: tests: add tests for disk hotplug/hotunplug
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: vm: remove unused 'output' value in response
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: clientIF: add logs during the recovery
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
automat...@ovirt.org has posted comments on this change.
Change subject: call stop_event_loop upon exit
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
automat...@ovirt.org has posted comments on this change.
Change subject: virt: let Engine start a VM on an UNKOWN OS
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has posted comments on this change.
Change subject: stomp: make sure to send error message when no subscription
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/43724/2/lib/yajsonrpc/stompreactor.py
File lib
automat...@ovirt.org has posted comments on this change.
Change subject: WIP: virt: better timeout for periodic operations
..
Patch Set 35:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org
Francesco Romani has abandoned this change.
Change subject: WIP: virt: better timeout for periodic operations
..
Abandoned
dead trail
--
To view, visit https://gerrit.ovirt.org/39333
To unsubscribe, visit https://gerrit.ovirt
automat...@ovirt.org has posted comments on this change.
Change subject: vm: debug log for getAllVmStats() and getVMList()
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: client: update to keep up with setLogLevel changes
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, mak
automat...@ovirt.org has posted comments on this change.
Change subject: json-rpc: export setLogLevel API
..
Patch Set 10:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
automat...@ovirt.org has posted comments on this change.
Change subject: API: streamline and make setLogLevel correct
..
Patch Set 10:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
automat...@ovirt.org has posted comments on this change.
Change subject: API: restore setLogLevel backward compatibility
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make s
automat...@ovirt.org has posted comments on this change.
Change subject: API: allow setLogLevel to tune a specific logger
..
Patch Set 10:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Ido Barkan has posted comments on this change.
Change subject: make pep8-1.4.6 (el7) happy
..
Patch Set 1: Verified-1
for x in config.py constants.py crossImportsTests.py vdsm.py ; do
exclude="${exclude},${x}" ; done ;
../pep8
Nir Soffer has posted comments on this change.
Change subject: tests: Isolate tcTests test properly
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/44144
To unsubscribe, visit https://gerrit.ovirt.org/set
Nir Soffer has posted comments on this change.
Change subject: tests: Remove hack for devices with same names
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/44166
To unsubscribe, visit https://gerrit.ovi
Nir Soffer has posted comments on this change.
Change subject: tests: Fix ipwrapper tests isolation
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/44165
To unsubscribe, visit https://gerrit.ovirt.org/set
Dan Kenigsberg has posted comments on this change.
Change subject: make pep8-1.4.6 (el7) happy
..
Patch Set 1: Verified+1
gitpydiff sees no change
pep8-1.4.6 and -1.5.6 are happy
--
To view, visit https://gerrit.ovirt.org/442
Francesco Romani has posted comments on this change.
Change subject: stomp: allow to mock monotonic_time method
..
Patch Set 1:
(3 comments)
suggestion about alternate approach inside
https://gerrit.ovirt.org/#/c/43745/1/lib/
Dan Kenigsberg has uploaded a new change for review.
Change subject: make pep8-1.4.6 (el7) happy
..
make pep8-1.4.6 (el7) happy
Change-Id: Iee593cee60690c43f82f30900f5c992bfba49000
Signed-off-by: Dan Kenigsberg
---
M tests/func
automat...@ovirt.org has posted comments on this change.
Change subject: make pep8-1.4.6 (el7) happy
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches '
Francesco Romani has posted comments on this change.
Change subject: stomp: make sure to send error message when no subscription
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/43724/2/lib/yajsonrpc/stompreactor.py
Fi
Dan Kenigsberg has posted comments on this change.
Change subject: fix pep8
..
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.ovirt.org/44026
To unsubscribe, visit https://gerrit.ovirt.org/settings
Ger
Dan Kenigsberg has posted comments on this change.
Change subject: fix pep8
..
Patch Set 1: Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/44026
To unsubscribe, visit https://gerrit.ovirt.org/settings
Ger
Dan Kenigsberg has submitted this change and it was merged.
Change subject: fix pep8
..
fix pep8
Change-Id: I4e0d9c4fc179825e9d14b4787e65b77dcfec59d7
Signed-off-by: Ido Barkan
Reviewed-on: https://gerrit.ovirt.org/44026
Review
automat...@ovirt.org has posted comments on this change.
Change subject: fix pep8
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https://gerrit.ovirt.org
Francesco Romani has posted comments on this change.
Change subject: jsonrpc: ignore unknown message id
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/43746/1/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:
Francesco Romani has posted comments on this change.
Change subject: hostdev: don't send address type for source address
..
Patch Set 1: Code-Review-1
(1 comment)
patch itself seems OK, but maybe better file libvirt bug. -1 fo
Ido Barkan has posted comments on this change.
Change subject: restore-net-config: set main thread name
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/44199
To unsubscribe, visit https://gerrit.ovirt.org
Dan Kenigsberg has posted comments on this change.
Change subject: restore-net-config: set main thread name
..
Patch Set 1: Code-Review+2 Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/44199
To unsubscribe
Francesco Romani has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 2:
Seems fine once Nir's comments in v2 are addressed
--
To view, visit https://gerrit.ovirt.org/43759
T
Dan Kenigsberg has posted comments on this change.
Change subject: net: ignore pass through ifcfg parameters for selective
restoration
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/44152
To unsubscr
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: ignore pass through ifcfg parameters for selective
restoration
..
net: ignore pass through ifcfg parameters for selective restoration
Ignore keys
automat...@ovirt.org has posted comments on this change.
Change subject: net: ignore pass through ifcfg parameters for selective
restoration
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no
Ido Barkan has posted comments on this change.
Change subject: net: ignore pass through ifcfg parameters for selective
restoration
..
Patch Set 1: Verified+1
created a network with 'PEERNTP': 'yes' as part of it's parameters
v
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/44199
to review the following change.
Change subject: restore-net-config: set main thread name
..
restore-net-config: set main
automat...@ovirt.org has posted comments on this change.
Change subject: restore-net-config: set main thread name
..
Patch Set 1:
* Update tracker::#1203422::OK
* Check Bug-Url::OK
* Check Public Bug::#1203422::OK, public bug
*
Ido Barkan has posted comments on this change.
Change subject: shell_helper: remove redundant ./configure calls
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/44198
To unsubscribe, visit https://gerrit.o
automat...@ovirt.org has posted comments on this change.
Change subject: shell_helper: remove redundant ./configure calls
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
1 - 100 of 148 matches
Mail list logo
