Francesco Romani has posted comments on this change.
Change subject: sampling: make _getInterfaceStats a function
..
Patch Set 19:
Jenjins failure unrelated
00:10:22.063
Dan Kenigsberg has posted comments on this change.
Change subject: Live Merge: Prevent merge when base volume is too small
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42836
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: sampling: make _getCpuCoresStats a function
..
Patch Set 19: Verified+1
verified with the bundled test(s) and comparing the output of patched and
unpatched
Francesco Romani has posted comments on this change.
Change subject: sampling: make _getInterfaceStats a function
..
Patch Set 19: Verified+1
verified like 40429 manually comparing the output of patched and unpatched VDSM
Allon Mureinik has posted comments on this change.
Change subject: jsonrpc: StoragePool_removeVM
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44321
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: fc-connect-server: Add FcpConnection class
..
Patch Set 1:
(5 comments)
https://gerrit.ovirt.org/#/c/44010/1/vdsm/storage/storageServer.py
File
Nir Soffer has posted comments on this change.
Change subject: fc-connect-server: Support FCP on connect server
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/44011/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Nir Soffer has posted comments on this change.
Change subject: Live Merge: Fix pre-extension calculation for chunked drives
..
Patch Set 1: Code-Review-1
(3 comments)
Looks good, need to fix a typo and can use more meaningful
Ido Barkan has posted comments on this change.
Change subject: nettestlib: Extract nettestlib module
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44212
To unsubscribe, visit
Ido Barkan has posted comments on this change.
Change subject: nettestlib: Add requires_brctl and requries_tc decorators
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44218
To unsubscribe, visit
Dima Kuznetsov has posted comments on this change.
Change subject: logging: remove log messages which give little or no value
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43720
To unsubscribe,
Freddy Rolland has posted comments on this change.
Change subject: storageServer: Move unrelated method
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44295
To unsubscribe, visit
Ido Barkan has posted comments on this change.
Change subject: net: try restore networks harder.
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/44274
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: net: try restore networks harder.
..
Patch Set 2:
* Update tracker::#1242532::OK
* Check Bug-Url::OK
* Check Public Bug::#1242532::OK, public bug
* Check
Ido Barkan has posted comments on this change.
Change subject: net: tests: add requiresUnifiedPersistence decorator
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/44307
To unsubscribe, visit
Ido Barkan has uploaded a new change for review.
Change subject: net: tests: add requiresUnifiedPersistence decorator
..
net: tests: add requiresUnifiedPersistence decorator
So we can stop repeating
if
automat...@ovirt.org has posted comments on this change.
Change subject: net: tests: add requiresUnifiedPersistence decorator
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: add 'ncpus' property to HostSample
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: move translation code into hoststats.py
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: remove HostStatsThread.get()
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: HostStatsThread as periodic operation
..
Patch Set 21:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Francesco Romani has posted comments on this change.
Change subject: v2v: get VM information from OVA file
..
Patch Set 4: Code-Review-1
(10 comments)
mostly questions, but quite some of them. -1 for visibility.
automat...@ovirt.org has posted comments on this change.
Change subject: clientif: hoststats: move elapsedTime in clientIF
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: remove HostStatsThread.get()
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: add 'ncpus' property to HostSample
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: make _getInterfaceStats a function
..
Patch Set 19:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: make _getCpuCoresStats a function
..
Patch Set 19:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: move translation code into hoststats.py
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: HostStatsThread as periodic operation
..
Patch Set 20:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Yaniv Bronhaim has posted comments on this change.
Change subject: Removing prefix definition for qemu-kvm-ev
..
Patch Set 2: Verified+1
any additional verification is required?
--
To view, visit
Sandro Bonazzola has posted comments on this change.
Change subject: Removing prefix definition for qemu-kvm-ev
..
Patch Set 2:
Not sure what you tested so I can't say :-) but if you installed it on el7
centos and rhel and it
Freddy Rolland has posted comments on this change.
Change subject: storageServer: Fix MountConnection.__eq__
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44292
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: clientif: hoststats: move elapsedTime in clientIF
..
Patch Set 6: Code-Review-1
it's a bad idea to add more state to clientIF
--
To view, visit
Ramesh N has posted comments on this change.
Change subject: gluster: fix AttributeError and TypeError in exception.py
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/41530/2//COMMIT_MSG
Commit Message:
Line 13:
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: StoragePool_updateVMs
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44271
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: v2v: Import VM from OVA file
..
Patch Set 4:
(4 comments)
big question(s) inside, -1 for visibility.
Francesco Romani has posted comments on this change.
Change subject: v2v: Import VM from OVA file
..
Patch Set 4: Code-Review-1
furthermore: can you please point me where you addressed comments from Arik in
V2?
--
To view,
Michal Skrivanek has posted comments on this change.
Change subject: Removing prefix definition for qemu-kvm-ev
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43993
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: v2v: refactor create command
..
Patch Set 6: Code-Review+1
(1 comment)
maybe less nice than it could but still looks good enough
automat...@ovirt.org has posted comments on this change.
Change subject: v2v: handle exception on probing external VMs
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit
Shahar Havivi has abandoned this change.
Change subject: v2v: handle exception on probing external VMs
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/43259
To unsubscribe, visit https://gerrit.ovirt.org/settings
Freddy Rolland has posted comments on this change.
Change subject: storageServer: Add MountConnection.__ne__
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44293
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: storageServer: Fix MountConnection.__hash__
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44294
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: m2crypto removal
..
Patch Set 17: Code-Review-1
Code rebased. Copying review flag.
--
To view, visit https://gerrit.ovirt.org/39990
To unsubscribe,
automat...@ovirt.org has posted comments on this change.
Change subject: ssl: m2crypto removal
..
Patch Set 17:
* Update tracker::#1147148::OK
* Check Bug-Url::OK
* Check Public Bug::#1147148::OK, public bug
* Check
Arik Hadas has posted comments on this change.
Change subject: v2v: get VM information from OVA file
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/43271/4/vdsm/v2v.py
File vdsm/v2v.py:
Line 175: root =
Shahar Havivi has posted comments on this change.
Change subject: v2v: get VM information from OVA file
..
Patch Set 4:
(9 comments)
https://gerrit.ovirt.org/#/c/43271/4/vdsm/rpc/vdsmapi-schema.json
File
automat...@ovirt.org has posted comments on this change.
Change subject: Live Merge: Fix pre-extension calculation for chunked drives
..
Patch Set 1:
* Update tracker::#1240360::OK
* Check Bug-Url::OK
* Check Public
Adam Litke has uploaded a new change for review.
Change subject: Live Merge: Fix pre-extension calculation for chunked drives
..
Live Merge: Fix pre-extension calculation for chunked drives
Live merge causes data to be written
Adam Litke has posted comments on this change.
Change subject: Live Merge: Fix pre-extension calculation for chunked drives
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/44331
To unsubscribe, visit
Allon Mureinik has uploaded a new change for review.
Change subject: gluster: Allow Replica 1 domains
..
gluster: Allow Replica 1 domains
Patch 322ce98d17e585b156891ed711063d5e2c0ce5de introduced the ability to
verify the
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: Allow Replica 1 domains
..
Patch Set 1:
* Update tracker::#1238093::OK
* Check Bug-Url::OK
* Check Public Bug::#1238093::OK, public bug
* Check
automat...@ovirt.org has posted comments on this change.
Change subject: Live merge: Update base size after live merge
..
Patch Set 8:
* Update tracker::#1232481::OK
* Check Bug-Url::OK
* Check Public Bug::#1232481::OK, public
automat...@ovirt.org has posted comments on this change.
Change subject: Live Merge: Prevent merge when base volume is too small
..
Patch Set 8:
* Update tracker::#1232481::OK
* Check Bug-Url::OK
* Check Public
automat...@ovirt.org has posted comments on this change.
Change subject: Live Merge: Allow extension of non-leaf raw volumes
..
Patch Set 5:
* Update tracker::#1232481::OK
* Check Bug-Url::OK
* Check Public Bug::#1232481::OK,
Omer Frenkel has posted comments on this change.
Change subject: jsonrpc: StoragePool_updateVMs
..
Patch Set 2:
i verified this fix the issue on my host (rhel 6.6 with latest 3.5) for
updateVMs but there is still (the same)
Hello Piotr Kliczewski, Adam Litke,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/44321
to review the following change.
Change subject: jsonrpc: StoragePool_removeVM
..
jsonrpc:
Maor Lipchuk has posted comments on this change.
Change subject: jsonrpc: StoragePool_removeVM
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/44321
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: jsonrpc: StoragePool_removeVM
..
Patch Set 1: Verified-1
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-url is
automat...@ovirt.org has posted comments on this change.
Change subject: jsonrpc: StoragePool_removeVM
..
Patch Set 2: -Verified
* Update tracker::#1237061::OK
* Check Bug-Url::OK
* Check Public Bug::#1237061::OK, public bug
*
Omer Frenkel has posted comments on this change.
Change subject: jsonrpc: StoragePool_updateVMs
..
Patch Set 2: Verified+1
verified updateVM is working
--
To view, visit https://gerrit.ovirt.org/44271
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: hooks: Open vSwitch configurator
..
Patch Set 52:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Shahar Havivi has posted comments on this change.
Change subject: v2v: Import VM from OVA file
..
Patch Set 4:
(4 comments)
https://gerrit.ovirt.org/#/c/43367/4/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:
Maor Lipchuk has posted comments on this change.
Change subject: jsonrpc: StoragePool_updateVMs
..
Patch Set 2:
Added the other patch that fixes also removeVM
--
To view, visit https://gerrit.ovirt.org/44271
To unsubscribe,
Omer Frenkel has posted comments on this change.
Change subject: jsonrpc: StoragePool_removeVM
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/44321
To unsubscribe, visit
Petr Horáček has posted comments on this change.
Change subject: hooks: Open vSwitch configurator
..
Patch Set 51:
(26 comments)
https://gerrit.ovirt.org/#/c/40312/51/tests/functional/networkTestsOVS.py
File
Ala Hino has posted comments on this change.
Change subject: gluster: Allow Replica 1 domains
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44332
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: gluster: Allow Replica 1 domains
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44332
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: Allow Replica 1 domains
..
Patch Set 2:
* Update tracker::#1238093::OK
* Check Bug-Url::OK
* Check Public Bug::#1238093::OK, public bug
* Check
69 matches
Mail list logo
