Hello Nir Soffer, Greg Padgett,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/44990
to review the following change.
Change subject: storage: don't chmod local storage symlink
..
storage: don't
automat...@ovirt.org has posted comments on this change.
Change subject: storage: don't chmod local storage symlink
..
Patch Set 1:
* Update tracker::#1112171::OK
* Check Bug-Url::OK
* Check Public Bug::#1112171::OK, public
Greg Padgett has posted comments on this change.
Change subject: storage: don't chmod local storage symlink
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/44990
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: v2v: get VM information from OVA file
..
Patch Set 12:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Shahar Havivi has posted comments on this change.
Change subject: v2v: Import VM from OVA file
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/44914
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: v2v: get VM information from OVA file
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Hello Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/44913
to review the following change.
Change subject: v2v: get VM information from OVA file
..
v2v: get VM information from
automat...@ovirt.org has posted comments on this change.
Change subject: v2v: Import VM from OVA file
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Hello Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/44914
to review the following change.
Change subject: v2v: Import VM from OVA file
..
v2v: Import VM from OVA file
OVA is a
Dan Kenigsberg has submitted this change and it was merged.
Change subject: v2v: get VM information from OVA file
..
v2v: get VM information from OVA file
In order to import a VM that exists in an OVA file the oVirt engine
automat...@ovirt.org has posted comments on this change.
Change subject: hooks: Open vSwitch configurator
..
Patch Set 63:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has abandoned this change.
Change subject: multipath: Backup old configuration using hard link
..
Abandoned
Will not work on node, and there is no reason to invest time in this.
--
To view, visit
automat...@ovirt.org has posted comments on this change.
Change subject: multipath: Backup old configuration using hard link
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit
automat...@ovirt.org has posted comments on this change.
Change subject: net: tests: enable tests to run with OVS
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has posted comments on this change.
Change subject: vm: graphics: fix console open after restore
..
Patch Set 4:
Martin: sure make sense! will polish in the next upload (if any, see previous
comment)
--
To
Francesco Romani has posted comments on this change.
Change subject: vm: graphics: fix console open after restore
..
Patch Set 4: Verified-1
failed verification. restoreFlags doesn't allow us to fix the bit we need,
hence
Dan Kenigsberg has submitted this change and it was merged.
Change subject: v2v: Import VM from OVA file
..
v2v: Import VM from OVA file
OVA is a tar file which contain a VM with its Ovf file and its disks as
well.
Change-Id:
automat...@ovirt.org has posted comments on this change.
Change subject: v2v: Import VM from OVA file
..
Patch Set 12:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Shahar Havivi has posted comments on this change.
Change subject: v2v: get VM information from OVA file
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/44913
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: hooks: Open vSwitch configurator
..
Patch Set 62:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: concurrent: Introduce concurrent.thread() utility
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/44894/1/lib/vdsm/concurrent.py
File
Francesco Romani has posted comments on this change.
Change subject: concurrent: Introduce concurrent.thread() utility
..
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/44894/1/lib/vdsm/concurrent.py
File
Francesco Romani has posted comments on this change.
Change subject: concurrent: Use new concurrent.thread() utility
..
Patch Set 2: Code-Review+1
yep, code looks nicer.
--
To view, visit https://gerrit.ovirt.org/44895
To
Nir Soffer has posted comments on this change.
Change subject: StorageDomainManifest: deleteImage and deps
..
Patch Set 21: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42268
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: StorageDomainManifest: move extend and extendVolume
..
Patch Set 21: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42266
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: StorageDomainManifest: move image and volume enumeration
..
Patch Set 21: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42269
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: storage: don't chmod local storage symlink
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44990
To unsubscribe, visit
Ido Barkan has posted comments on this change.
Change subject: net: always persist ifcfg files.
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/44926
To unsubscribe, visit
Ido Barkan has posted comments on this change.
Change subject: net: always persist ifcfg files.
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/44929
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: multipath: Write multipath.conf atomically
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/44869/3/lib/vdsm/tool/configurators/multipath.py
File
automat...@ovirt.org has posted comments on this change.
Change subject: net: always persist ifcfg files.
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Ido Barkan has posted comments on this change.
Change subject: net: tests: make monitor test_events_keys more readable
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44927
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: StorageDomainManifest: move extend and extendVolume
..
Patch Set 20:
(1 comment)
https://gerrit.ovirt.org/#/c/42266/20/tests/sdm_indirection_tests.py
File
Francesco Romani has uploaded a new change for review.
Change subject: WIP virt: add and use vm.acpiReboot() method
..
WIP virt: add and use vm.acpiReboot() method
WRITEME
Change-Id: I5d6dd3a81cd4ad981a839849a4a2914e35a53fa6
automat...@ovirt.org has posted comments on this change.
Change subject: WIP virt: add and use vm.acpiReboot() method
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: vm: make acpiShutdown more robust
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Fabian Deutsch has posted comments on this change.
Change subject: multipath: Write multipath.conf atomically
..
Patch Set 3: Code-Review+1
(1 comment)
Ido Barkan has uploaded a new change for review.
Change subject: net: always persist ifcfg files.
..
net: always persist ifcfg files.
Currently the persistence of ifcfg files is only done during
setSafeNetworkConfig. But, if
automat...@ovirt.org has posted comments on this change.
Change subject: net: always persist ifcfg files.
..
Patch Set 1: Verified-1
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-url is
Petr Horáček has uploaded a new change for review.
Change subject: net: tests: make monitor test_events_keys more readable
..
net: tests: make monitor test_events_keys more readable
When this tests fails, print lists of
automat...@ovirt.org has posted comments on this change.
Change subject: net: tests: make monitor test_events_keys more readable
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
automat...@ovirt.org has posted comments on this change.
Change subject: makefile: Run pep8/pyflakes inside virtualenv
..
Patch Set 1:
* Update tracker::#1182088::OK
* Check Bug-Url::OK
* Check Public Bug::#1182088::OK, public
Ido Barkan has uploaded a new change for review.
Change subject: net: always persist ifcfg files.
..
net: always persist ifcfg files.
Currently the persistence of ifcfg files is only done during
setSafeNetworkConfig. But, if
Francesco Romani has uploaded a new change for review.
Change subject: virt: rename {Notifying,Disconnected}VirDomain
..
virt: rename {Notifying,Disconnected}VirDomain
Now that these classes resides in virdomain module,
we can
automat...@ovirt.org has posted comments on this change.
Change subject: virt: cosmetic fixes
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
automat...@ovirt.org has posted comments on this change.
Change subject: WIP: RFC: virt: add VmTracker
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: virt: periodic: factor out periodic operations
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: vm: periodic: NumaInfoMonitor doesn't need jobs
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: vmstats: network: avoid ZeroDivisionError
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: WIP: RFC: track domain availability
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has uploaded a new change for review.
Change subject: virt: make virdomain.Notifying inherit from object
..
virt: make virdomain.Notifying inherit from object
The only known reason virdomain.Notifying()
is not
automat...@ovirt.org has posted comments on this change.
Change subject: v2v: use the response module
..
Patch Set 24:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Yeela Kaplan has posted comments on this change.
Change subject: m2c: rename m2c modules
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44493
To unsubscribe, visit https://gerrit.ovirt.org/settings
Dan Kenigsberg has posted comments on this change.
Change subject: net: always persist ifcfg files.
..
Patch Set 2: Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/44929
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: always persist ifcfg files.
..
net: always persist ifcfg files.
Currently the persistence of ifcfg files is only done during
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: always persist ifcfg files.
..
net: always persist ifcfg files.
Currently the persistence of ifcfg files is only done during
automat...@ovirt.org has posted comments on this change.
Change subject: net: always persist ifcfg files.
..
Patch Set 3:
* Update tracker::#1252268::OK
* Set MODIFIED::bug 1252268#1252268IGNORE, not oVirt prod but Red
automat...@ovirt.org has posted comments on this change.
Change subject: net: always persist ifcfg files.
..
Patch Set 3:
* Update tracker::#1252268::OK
* Set MODIFIED::bug 1252268#1252268IGNORE, not oVirt prod but Red
automat...@ovirt.org has posted comments on this change.
Change subject: virt: make virdomain.Notifying inherit from object
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Francesco Romani has posted comments on this change.
Change subject: virt: periodic: factor out periodic operations
..
Patch Set 6: Verified+1
verified running patched vdsm and inspecting the output of vdsClient -s 0
automat...@ovirt.org has posted comments on this change.
Change subject: vm: do not log known missing alias
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: vm: remove unused 'output' value in response
..
Patch Set 15:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Francesco Romani has posted comments on this change.
Change subject: periodic: make runnable a method
..
Patch Set 2: Verified+1
verified running patched VDSM and checking the logs for errors (none in sight)
--
To view,
Shahar Havivi has uploaded a new change for review.
Change subject: schema: add v2vJobs to HostStats
..
schema: add v2vJobs to HostStats
v2vJobs reports via HostStats and needs to be declared in schema
Change-Id:
automat...@ovirt.org has posted comments on this change.
Change subject: schema: add v2vJobs to HostStats
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: v2v: add test for getOvaInfo verb
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: WIP virt: add and use vm.acpiReboot() method
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: vm: make acpiShutdown more robust
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: net: always persist ifcfg files.
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: always persist ifcfg files.
..
net: always persist ifcfg files.
Currently the persistence of ifcfg files is only done during
automat...@ovirt.org has posted comments on this change.
Change subject: periodic: make runnable a method
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: virt: rename {Notifying,Disconnected}VirDomain
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Dan Kenigsberg has posted comments on this change.
Change subject: net: always persist ifcfg files.
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/44929
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: net: always persist ifcfg files.
..
Patch Set 2: Code-Review+2 Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/44926
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: virt: periodic: avoid NotConnectedError noise
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: virt: make virdomain.Notifying inherit from object
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
automat...@ovirt.org has posted comments on this change.
Change subject: vmstats: make nic_traffic private
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: vmstats: handle known-missing stats
..
Patch Set 10:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: virt: introduce virdomain module
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has posted comments on this change.
Change subject: vmstats: handle known-missing stats
..
Patch Set 10: -Code-Review
with (artificially slowed down) migration in progress:
domstats on dest side:
Domain:
automat...@ovirt.org has posted comments on this change.
Change subject: WIP: RFC: virt: add VmTracker
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: virt: cosmetic fixes
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
automat...@ovirt.org has posted comments on this change.
Change subject: periodic: make VmDispatcher ignore TooManyTasks
..
Patch Set 29:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: vmstats: handle known-missing stats
..
Patch Set 11:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: periodic: make runnable a method
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: virt: introduce virdomain module
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: virt: periodic: factor out periodic operations
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: virt: periodic: avoid NotConnectedError noise
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: virt: rename {Notifying,Disconnected}VirDomain
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: WIP: RFC: track domain availability
..
Patch Set 9:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Dan Kenigsberg has posted comments on this change.
Change subject: net: tests: make monitor test_events_keys more readable
..
Patch Set 2:
14:29:24 + git cherry-pick FETCH_HEAD
14:29:24 error: could not apply 7b15e79... Adding
automat...@ovirt.org has posted comments on this change.
Change subject: net: always persist ifcfg files.
..
Patch Set 2: -Verified
* Update tracker::#1252268::OK
* Check Bug-Url::OK
* Check Public Bug::#1252268::OK, public
automat...@ovirt.org has posted comments on this change.
Change subject: tests: add tests for disk hotplug/hotunplug
..
Patch Set 19:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: vm: remove _reportError
..
Patch Set 30:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
automat...@ovirt.org has posted comments on this change.
Change subject: clientIF: add logs during the recovery
..
Patch Set 14:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: virt: fully convert to response module
..
Patch Set 14:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: numa: make use of DisconnectedVirDomain
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Adam Litke has posted comments on this change.
Change subject: StorageDomainManifest: deleteImage and deps
..
Patch Set 20:
(3 comments)
https://gerrit.ovirt.org/#/c/42268/20/tests/sdm_indirection_tests.py
File
Francesco Romani has posted comments on this change.
Change subject: vmstats: handle known-missing stats
..
Patch Set 10: Verified+1
(4 comments)
verified running a slowd down migration (migration_max_bandwidth=1) and
Ido Barkan has posted comments on this change.
Change subject: netinfo: Replace misused asserts with InvalidConfiguration
..
Patch Set 3:
Gladly! But begin with writing the tests please ☺
--
To view, visit
1 - 100 of 150 matches
Mail list logo