Francesco Romani has posted comments on this change. Change subject: vmstats: handle known-missing stats ......................................................................
Patch Set 10: Verified+1 (4 comments) verified running a slowd down migration (migration_max_bandwidth=1) and checking VDSM dest logs https://gerrit.ovirt.org/#/c/43777/10/vdsm/virt/vmstats.py File vdsm/virt/vmstats.py: Line 209: ifStats['txRate'] = '%.1f' % ifTxBytes Line 210: Line 211: ifStats['rx'] = str(end_sample['net.%d.rx.bytes' % end_index]) Line 212: ifStats['tx'] = str(end_sample['net.%d.tx.bytes' % end_index]) Line 213: nice, but unrelated Line 214: ifStats['sampleTime'] = monotonic_time() Line 215: Line 216: return ifStats Line 217: Line 313: 'readRate': str( Line 314: (last_sample['block.%d.rd.bytes' % last_index] - Line 315: first_sample['block.%d.rd.bytes' % first_index]) Line 316: / interval Line 317: ), nice, but unrelated Line 318: 'writeRate': str( Line 319: (last_sample['block.%d.wr.bytes' % last_index] - Line 320: first_sample['block.%d.wr.bytes' % first_index]) Line 321: / interval Line 318: 'writeRate': str( Line 319: (last_sample['block.%d.wr.bytes' % last_index] - Line 320: first_sample['block.%d.wr.bytes' % first_index]) Line 321: / interval Line 322: ), nice, but unrelated Line 323: } Line 324: Line 325: Line 326: def _disk_latency(first_sample, first_index, last_sample, last_index): Line 340: return { Line 341: 'readLatency': str(compute_latency('rd')), Line 342: 'writeLatency': str(compute_latency('wr')), Line 343: 'flushLatency': str(compute_latency('fl')) Line 344: } nice, but unrelated Line 345: Line 346: Line 347: def _disk_iops_bytes(first_sample, first_index, last_sample, last_index): Line 348: return { -- To view, visit https://gerrit.ovirt.org/43777 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04ecbf98d36d576ede3c3cde36586245ea5e4218 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
