Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm.py: State saving in hotunplugDisk.
..
vm.py: State saving in hotunplugDisk.
VM's state was saved before detatching a disk in hotunplugDisk.
Saving
automat...@ovirt.org has posted comments on this change.
Change subject: vm.py: State saving in hotunplugDisk.
..
Patch Set 13:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: broken unsubscribe process
..
Patch Set 1: Verified+1
Verified together with jsonrpc fd leak patch and split later from it.
Verification flag copied f
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: fd leak
..
Patch Set 3: Verified+1
No code changes. Patch split as Nir suggested. Copying verification flag from
previous patch set.
--
To view, v
automat...@ovirt.org has posted comments on this change.
Change subject: stomp: broken unsubscribe process
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
automat...@ovirt.org has posted comments on this change.
Change subject: jsonrpc: fd leak
..
Patch Set 3:
* Update tracker::#1256446::OK
* Check Bug-Url::OK
* Check Public Bug::#1256446::OK, public bug
* Check Product::#1256446
Piotr Kliczewski has uploaded a new change for review.
Change subject: stomp: broken unsubscribe process
..
stomp: broken unsubscribe process
There is a logic common for incoming and outgoing connection which
cleans the subscrip
automat...@ovirt.org has posted comments on this change.
Change subject: volume: fix failing metadata parsing
..
Patch Set 3:
* Update tracker::#1258835::OK
* Check Bug-Url::OK
* Check Public Bug::#1258835::OK, public bug
* Che
Dan Kenigsberg has submitted this change and it was merged.
Change subject: concurrent: Add support for target function kwargs
..
concurrent: Add support for target function kwargs
Turns out we pass kwargs to some threads, so w
automat...@ovirt.org has posted comments on this change.
Change subject: concurrent: Add support for target function kwargs
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
-
Dan Kenigsberg has posted comments on this change.
Change subject: concurrent: Add support for target function kwargs
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/45470
To unsubscribe, visit https:/
Shahar Havivi has posted comments on this change.
Change subject: Update v2v to use new jobs infrastructure
..
Patch Set 2:
> Hi Shahar, I checked with Nisim and he does not have a VMWare
> environment. I will not be able to
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: fd leak
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/45615/2/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:
Line 244:
Nir Soffer has posted comments on this change.
Change subject: jsonrpc: fd leak
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/45615/2/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:
Line 244:
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: fd leak
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/45615/2/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:
Line 244:
Nir Soffer has posted comments on this change.
Change subject: concurrent: Add support for target function kwargs
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/45470
To unsubscribe, visit https://gerrit
Nir Soffer has posted comments on this change.
Change subject: concurrent: Add support for target function kwargs
..
Patch Set 2: Code-Review+2
This version is a rebase on current master without any code change. Copying
score.
Nir Soffer has posted comments on this change.
Change subject: virt: Use new concurrent.thread() utility
..
Patch Set 3:
This version splits the v2v changes to a separate patch per Francesco request.
--
To view, visit https:/
automat...@ovirt.org has posted comments on this change.
Change subject: v2v: Use new concurrent.thread() utility
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
automat...@ovirt.org has posted comments on this change.
Change subject: storage: Use new concurrent.thread() utility
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: virt: Use new concurrent.thread() utility
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
automat...@ovirt.org has posted comments on this change.
Change subject: network: Use new concurrent.thread() utility
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: concurrent: Add support for target function kwargs
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, mak
automat...@ovirt.org has posted comments on this change.
Change subject: infra: Use new concurrent.thread() utility
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
automat...@ovirt.org has posted comments on this change.
Change subject: lib: Use new concurrent.thread() utility
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
Nir Soffer has uploaded a new change for review.
Change subject: v2v: Use new concurrent.thread() utility
..
v2v: Use new concurrent.thread() utility
This patch updates v2v to use the new utility. No behavior change is
expected,
automat...@ovirt.org has posted comments on this change.
Change subject: virt: Use new concurrent.thread() utility
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
automat...@ovirt.org has posted comments on this change.
Change subject: v2v: Use new concurrent.thread() utility
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
Nir Soffer has posted comments on this change.
Change subject: jsonrpc: fd leak
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/45615/2/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:
Line 244:
Adam Litke has posted comments on this change.
Change subject: tests: Introduce schema parsing tests
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/45464
To unsubscribe, visit https://gerrit.ovirt.org/se
automat...@ovirt.org has posted comments on this change.
Change subject: jsonrpc: fd leak
..
Patch Set 2:
* Update tracker::#1256446::OK
* Check Bug-Url::OK
* Check Public Bug::#1256446::OK, public bug
* Check Product::#1256446
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: fd leak
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/45615/1//COMMIT_MSG
Commit Message:
Line 6:
Line 7: jsonrpc: fd leak
Line 8:
Lin
Nir Soffer has posted comments on this change.
Change subject: jsonrpc: fd leak
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/45615/1//COMMIT_MSG
Commit Message:
Line 6:
Line 7: jsonrpc: fd leak
Line 8:
Line 9: W
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: fd leak
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/45615/1//COMMIT_MSG
Commit Message:
Line 6:
Line 7: jsonrpc: fd leak
Line 8:
Lin
Nir Soffer has posted comments on this change.
Change subject: jsonrpc: fd leak
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/45615/1//COMMIT_MSG
Commit Message:
Line 6:
Line 7: jsonrpc: fd leak
Line 8:
Line 9: W
Nir Soffer has posted comments on this change.
Change subject: vm: Libvirt quering after disk detach operation addition.
..
Patch Set 18: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/45138/18/vdsm/virt/vm.py
File vds
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: fd leak
..
Patch Set 1: Verified+1
Verified by running jsonrpc based vdscli wrapped by functional network tests.
--
To view, visit https://gerrit.o
automat...@ovirt.org has posted comments on this change.
Change subject: jsonrpc: fd leak
..
Patch Set 1:
* Update tracker::#1256446::OK
* Check Bug-Url::OK
* Check Public Bug::#1256446::OK, public bug
* Check Product::#1256446
Piotr Kliczewski has uploaded a new change for review.
Change subject: jsonrpc: fd leak
..
jsonrpc: fd leak
We need to make sure that there is no reference to objects which holds
a socket because m2c closes socket when its objec
automat...@ovirt.org has posted comments on this change.
Change subject: spec: conflict with plain QEMU
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/45323
To unsubscrib
Francesco Romani has abandoned this change.
Change subject: spec: conflict with plain QEMU
..
Abandoned
two reasons to abandon
- don't fix outside RH-based distros
- breaks our CI
--
To view, visit https://gerrit.ovirt.org/45
automat...@ovirt.org has posted comments on this change.
Change subject: caps: more precise emulated machines selection
..
Patch Set 8:
* Update tracker::#1239258::OK
* Check Bug-Url::OK
* Check Public Bug::#1239258::OK, public
Yeela Kaplan has uploaded a new change for review.
Change subject: misc: remove cp parameter
..
misc: remove cp parameter
All usages of cp parameter have been extinguished.
Therefore, no longer needed.
Change-Id: I0906bfd7dfa12
automat...@ovirt.org has posted comments on this change.
Change subject: misc: remove cp parameter
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu
Yeela Kaplan has posted comments on this change.
Change subject: sudoers: remove unused iscsid policies
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/44504
To unsubscribe, visit https://gerrit.ovirt.org
Adam Litke has posted comments on this change.
Change subject: vm: Libvirt quering after disk detach operation addition.
..
Patch Set 18:
(1 comment)
https://gerrit.ovirt.org/#/c/45138/18/vdsm/virt/vm.py
File vdsm/virt/vm.py:
automat...@ovirt.org has posted comments on this change.
Change subject: json cli: use ssl when creating a socket
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
Yeela Kaplan has uploaded a new change for review.
Change subject: json cli: use ssl when creating a socket
..
json cli: use ssl when creating a socket
We want to be compatible with xmlrpc cli using regular ssl,
instead of curre
automat...@ovirt.org has posted comments on this change.
Change subject: ssl: configurable implementation
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
Nir Soffer has posted comments on this change.
Change subject: mount: Log info message when mounting or unmounting
..
Patch Set 4: Verified+1
Another trivial import change, copying verified.
--
To view, visit https://gerrit.o
Nir Soffer has posted comments on this change.
Change subject: mount: Perform mount and umount in supervdsm
..
Patch Set 5: Verified+1
Trivial import change, copying verified flag.
--
To view, visit https://gerrit.ovirt.org/4
Martin Polednik has posted comments on this change.
Change subject: caps: more precise emulated machines selection
..
Patch Set 7: Code-Review-1
(1 comment)
Small tweak would help the readability, it's not on the critical list
automat...@ovirt.org has posted comments on this change.
Change subject: mount: Perform mount and umount in supervdsm
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: mount: Remove unneeded return
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
automat...@ovirt.org has posted comments on this change.
Change subject: mount: Log info message when mounting or unmounting
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, ma
automat...@ovirt.org has posted comments on this change.
Change subject: blockVolume: Separate data formatting and writing
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Francesco Romani has posted comments on this change.
Change subject: caps: more precise emulated machines selection
..
Patch Set 4:
(3 comments)
https://gerrit.ovirt.org/#/c/45257/4/tests/caps_libvirt_multiqemu.out
File tests/
Piotr Kliczewski has posted comments on this change.
Change subject: tests: Introduce schema parsing tests
..
Patch Set 2: Code-Review+1
After talking to Adam we can have them as they are and refactor later if needed.
--
To v
Nir Soffer has posted comments on this change.
Change subject: lib: Use new concurrent.thread() utility
..
Patch Set 4:
Who wants to approve this?
--
To view, visit https://gerrit.ovirt.org/44895
To unsubscribe, visit https:/
Nir Soffer has posted comments on this change.
Change subject: concurrent: Add support for target function kwargs
..
Patch Set 1: Code-Review+2
Everyone seems happy, approving.
--
To view, visit https://gerrit.ovirt.org/45470
Adam Litke has posted comments on this change.
Change subject: Update v2v to use new jobs infrastructure
..
Patch Set 2:
Hi Shahar, I checked with Nisim and he does not have a VMWare environment. I
will not be able to verify
automat...@ovirt.org has posted comments on this change.
Change subject: volume: Unify metadata formatting and validation
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: volume: Support older engine or disks with long description
..
Patch Set 3:
* Update tracker::#1258097::OK
* Check Bug-Url::OK
* Check Public Bug::#125809
automat...@ovirt.org has posted comments on this change.
Change subject: blockVolume: Fail if metadata overflows
..
Patch Set 3:
* Update tracker::#1258097::OK
* Check Bug-Url::OK
* Check Public Bug::#1258097::OK, public bug
*
Nir Soffer has posted comments on this change.
Change subject: vm: Libvirt quering after disk detach operation addition.
..
Patch Set 18: Code-Review+1
(1 comment)
Waiting for Adam review.
https://gerrit.ovirt.org/#/c/45138/1
Yeela Kaplan has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 4: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/44689/4/lib/vdsm/config.py.in
File lib/vdsm/c
automat...@ovirt.org has posted comments on this change.
Change subject: spec: conflict with plain QEMU
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
automat...@ovirt.org has posted comments on this change.
Change subject: caps: more precise emulated machines selection
..
Patch Set 7:
* Update tracker::#1239258::OK
* Check Bug-Url::OK
* Check Public Bug::#1239258::OK, public
Amit Aviram has posted comments on this change.
Change subject: vm: Libvirt quering after disk detach operation addition.
..
Patch Set 18: Verified+1
--
To view, visit https://gerrit.ovirt.org/45138
To unsubscribe, visit https
Yeela Kaplan has posted comments on this change.
Change subject: ssl: configurable implementation
..
Patch Set 5: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/44494/5/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 1
Adam Litke has posted comments on this change.
Change subject: vm: Libvirt quering after disk detach operation addition.
..
Patch Set 18:
(1 comment)
https://gerrit.ovirt.org/#/c/45138/18/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Marcin Mirecki has posted comments on this change.
Change subject: network: add ifcfg write hook
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/44552
To unsubscribe, visit https://gerrit.ovirt.org/settin
Marcin Mirecki has posted comments on this change.
Change subject: network: add ifcfg write hook
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/44552/5/vdsm/network/configurators/ifcfg.py
File vdsm/network/configurat
Shahar Havivi has posted comments on this change.
Change subject: schema: add v2vJobs to HostStats
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/45593
To unsubscribe, visit https://gerrit.ovirt.org/sett
Shahar Havivi has posted comments on this change.
Change subject: v2v: add test for getOvaInfo verb
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/45594
To unsubscribe, visit https://gerrit.ovirt.org/set
Shahar Havivi has uploaded a new change for review.
Change subject: schema: add v2vJobs to HostStats
..
schema: add v2vJobs to HostStats
v2vJobs reports via HostStats and needs to be declared in schema
Change-Id: I20b5b44b2b74c
Shahar Havivi has uploaded a new change for review.
Change subject: v2v: add test for getOvaInfo verb
..
v2v: add test for getOvaInfo verb
Change-Id: I398943c356a87cf93a3e0557f4d78da0490814c5
Signed-off-by: Shahar Havivi
---
M
automat...@ovirt.org has posted comments on this change.
Change subject: v2v: add test for getOvaInfo verb
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
automat...@ovirt.org has posted comments on this change.
Change subject: schema: add v2vJobs to HostStats
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
automat...@ovirt.org has posted comments on this change.
Change subject: network: add ifcfg write hook
..
Patch Set 5:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#965929::ERROR, private bug
* Check Public Bug:
automat...@ovirt.org has posted comments on this change.
Change subject: vm: Libvirt quering after disk detach operation addition.
..
Patch Set 18:
* Update tracker::#1044466::OK
* Check Bug-Url::OK
* Check Public Bug::#1044466
Allon Mureinik has posted comments on this change.
Change subject: volume: fix failing metadata parsing
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45585
To unsubscribe, visit https://gerrit.ovirt.
Francesco Romani has posted comments on this change.
Change subject: vm: Libvirt quering after disk detach operation addition.
..
Patch Set 17: -Code-Review
I was too fast to approve :)
--
To view, visit https://gerrit.ovirt.
Nir Soffer has posted comments on this change.
Change subject: vm: Libvirt quering after disk detach operation addition.
..
Patch Set 17: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/45138/17/vdsm/virt/vm.py
File vd
Francesco Romani has posted comments on this change.
Change subject: vm: Libvirt quering after disk detach operation addition.
..
Patch Set 17: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/45138
To unsubscribe, vis
automat...@ovirt.org has posted comments on this change.
Change subject: vm: Libvirt quering after disk detach operation addition.
..
Patch Set 17:
* Update tracker::#1044466::OK
* Check Bug-Url::OK
* Check Public Bug::#1044466
Francesco Romani has posted comments on this change.
Change subject: vm.py: State saving in hotunplugDisk.
..
Patch Set 12: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/45077
To unsubscribe, visit https://gerrit.ov
automat...@ovirt.org has posted comments on this change.
Change subject: vm: Libvirt quering after disk detach operation addition.
..
Patch Set 16:
* Update tracker::#1044466::OK
* Check Bug-Url::OK
* Check Public Bug::#1044466
Amit Aviram has posted comments on this change.
Change subject: vm.py: State saving in hotunplugDisk.
..
Patch Set 12: Verified+1
--
To view, visit https://gerrit.ovirt.org/45077
To unsubscribe, visit https://gerrit.ovirt.org/
Nir Soffer has posted comments on this change.
Change subject: vm.py: State saving in hotunplugDisk.
..
Patch Set 12: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/45077
To unsubscribe, visit https://gerrit.ovirt.or
automat...@ovirt.org has posted comments on this change.
Change subject: vm.py: State saving in hotunplugDisk.
..
Patch Set 12:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
automat...@ovirt.org has posted comments on this change.
Change subject: volume: fix failing metadata parsing
..
Patch Set 2:
* Update tracker::#1258835::OK
* Check Bug-Url::OK
* Check Public Bug::#1258835::OK, public bug
* Che
Nir Soffer has posted comments on this change.
Change subject: volume: fix failing metadata parsing
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/45585
To unsubscribe, visit https://gerrit.ovirt.org/
Idan Shaby has posted comments on this change.
Change subject: volume: fix failing metadata parsing
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/45585
To unsubscribe, visit https://gerrit.ovirt.org/set
automat...@ovirt.org has posted comments on this change.
Change subject: volume: fix failing metadata parsing
..
Patch Set 1:
* Update tracker::#1258835::OK
* Check Bug-Url::OK
* Check Public Bug::#1258835::OK, public bug
* Che
Idan Shaby has uploaded a new change for review.
Change subject: volume: fix failing metadata parsing
..
volume: fix failing metadata parsing
The call to "split" in file and block volumes expects only one "=" per
line. This is n
Martin Polednik has posted comments on this change.
Change subject: hostdev: add udev rules for USB devices
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/44679/8/vdsm/supervdsmServer
File vdsm/supervdsmServer:
Line
Francesco Romani has posted comments on this change.
Change subject: vm: Libvirt quering after disk detach operation addition.
..
Patch Set 14:
(1 comment)
https://gerrit.ovirt.org/#/c/45138/14/vdsm/virt/vm.py
File vdsm/virt/v
automat...@ovirt.org has posted comments on this change.
Change subject: hostdev: add udev rules for USB devices
..
Patch Set 10:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
Francesco Romani has posted comments on this change.
Change subject: vm: Libvirt quering after disk detach operation addition.
..
Patch Set 14:
(1 comment)
https://gerrit.ovirt.org/#/c/45138/14/vdsm/virt/vm.py
File vdsm/virt/v
1 - 100 of 173 matches
Mail list logo
