Yeela Kaplan has posted comments on this change. Change subject: ssl: configurable implementation ......................................................................
Patch Set 5: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/44494/5/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 1260: if sslctx: Line 1261: if _m2cEnabled: Line 1262: sock = SSL.Connection(sslctx.context) Line 1263: else: Line 1264: sock = ssl.wrap_socket(sock, why not use sslctx.wrapSocket(sock) ? It already has all parameters, so its doing this call for you and you don't have to work hard here... Line 1265: keyfile=sslctx.key_file, Line 1266: certfile=sslctx.cert_file, Line 1267: server_side=False, Line 1268: cert_reqs=ssl.CERT_REQUIRED, -- To view, visit https://gerrit.ovirt.org/44494 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6501981bbd5276c49731b0d9eba4794286b0f823 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
